the_arc_rounded_after_the_back_edge_matches_both_together ran
one_then_the_other(BACK, arc_top()) as a test of its own. It is the same
check as every pair of a_round_ending_in_an_earlier_round_matches_both
_together (the round in sequence against both together, within the
display meshes' 5e-3), which had only the other order (arc_top(), BACK):
the pair joins that list and the separate test goes. Nothing is loosened.
Today the list fails before it reaches the pair: SMLib fails the arc's
round after the long front edge's (status 1001); the back-then-arc pair
failed the same way on its own.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.
The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
the blend at such a continuation, its refusal names the edge it runs into
and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
round an r2 round's end arc), the refusal says the chain was blended and
that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.
The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
curveblend.rs (rolling-ball rounds and chamfers of curved edges, their corners, the law
and chord variants), curvecorner.rs, loopblend.rs (blends round whole face loops) and
blend_vertex.rs (a sphere at three rounded edges) built blends on truck; SMLib's blend
makes all of these in its one call, with its own corners. curvecorner_tests.rs tests
fillet and chamfer through the public functions only, so it stays, mounted from blend.rs.
curveblend_tests.rs and curveblend_law_tests.rs go with the builder: they test its
internals (fit_sections, curve_blend_with_limit, ROLLS, its NURBS surfaces and contacts).
lib.rs needs `mod curveblend;`, `mod loopblend;` and `mod blend_vertex;` removed.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Body::mesh / mesh_plan / mesh_of and MeshTolerance (chord, display, display_of, export_of)
replace tessellate, tessellate_with, display_mesh*, display_plan*, reference_display_mesh_angular;
every caller in kernel, doc, engine, io, ui-egui, gpu and the CLI renamed mechanically; the
truck-mesher fallback, mesh_shells*, refined* removed; Body::new orients from the planner;
truck-meshalgo dropped from Cargo.toml with the tests of its hooks. Still to fix: trait imports
in tess/*, splitface/lumps/preview/step_in/boolean_record meshalgo uses, measure.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
* Fillets and chamfers meeting at corners on curved faces, on top of #935
What #935 and #926 leave of #851 and the matrix:
- Corner build for blends meeting on faces of any surface (curvecorner.rs):
the knife-edge tip's round with the arc's or the back edge's, edges
picked in any order, a round ending in an earlier round of its radius
(as a feature of its own), and chamfers meeting at the arc's corner.
Its end curves are fitted by chord length: a uniform parameter
through points clustered at the ends doubled back on itself there,
and the display planner refused the face.
- A straight edge ending at a curved face (the back edge into the
knife-edge tip): rolled, or cut by the face in the planar corner
build (blend_corner.rs).
- A rolling ball turning about a rounded corner of its own radius
(a pivot: a piece of sphere or cone).
- Seams that are an earlier blend's straight contact (fitted curves)
count as straight.
- No spline across a joint where the strip's curvature jumps (a line
into a small round): each strip ends on the joint's section.
- Sections at a chain's vertices on the faces of the edge from it
alone.
- Every new fillet path passes #949's check for openings.
Tests measure volumes through the display plan, as #935's do.
Action matrix: 51 more fillets and chamfers pass (sweep, tangent arc
chain, sheet-metal hem, bracket holes), none fewer. Robustness seed 33
recorded (its last fillet builds differently; display and measured
volumes now agree).
Co-Authored-By: bherbruck <brennen.herbruck@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015bV2ntwLfUHV4JnCMPSyRi
* Corner blend tests: scale, seed 33's volumes, tighter engine bounds
From the review of #854:
- seed_33_display_plan_and_measure_agree: seed 33's bodies measure
the same through the display plan and the measure (2e-5), which the
golden's re-record rests on.
- the_arc_rounded_after_the_back_edge_matches_both_together: the order
that still leaves 0.05 mm³ at the tip, as an ignored test.
- corner_blends_hold_at_any_scale: the cases this branch adds on the
#851 part, at 0.01x and 100x, take off what they take at full size
times k³ (within 5e-6, checked to 1e-4).
- The engine tests on the part as drawn measure through the display
plan; bounds are about twice what each reads (2e-4 to 3e-3), and the
front corner's sets are checked against the kernel's CSG grid.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015bV2ntwLfUHV4JnCMPSyRi
---------
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>