A To Object extrude to a curved face runs its tool through the target and
cuts the target out of it. The SMLib boolean carries no extrusion face
sources (they stood for the untrimmed profile), so sheet_tool_span, which
read the tool's depth and footprint only off its extrusion caps, gave up
and the intersect was refused as unrepresentable.
The tool's current geometry says what it is: the kernel's prism
certificate (prism_measure, the one component copies are compared by)
reads off the exact record whether a body is a uniform prism along a
direction, its two cap levels and its section of lines and arcs. It is
now public as certified_prism_section, and sheet_tool_span uses it when
the caps don't certify the tool: the levels are the depth, the section the
footprint the To Object cut is bounded by. A tool trimmed to something
that is not a prism (a curved roof over it) is still refused.
partial_depth_intersect_curved_to_object_preserves_current_trimmed_cap_footprint
passes: the tool is the square 20 ... 30 less the pin's circle (radius 2),
z 0 ... 1, 100 - 4π, as the test's own witness extrude measures it. A
kernel test reads that section off the trimmed lump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
end_at_wall takes the plate's end strip off a wall that stands on part of
an edge of the fixed face: the strip's two corners and its two edges go.
They were filtered at their places in the face's lists, counted from the
bend's edge, which pairs corner j with edge j only while the places do
not run across the lists' start. SMLib merges the plate's end strip and
both walls at x = 100 into one L-shaped face whose loop starts on the
strip, so the corners left were each followed by the next one's edge:
the bend's edge took the wall end's face and the wall end took the
plate's. The bend then ran the wall's full width and no relief cut it.
Both lists are now kept counted from the bend's edge.
a_wall_on_part_of_an_edge_meets_a_wall_at_a_relieved_corner_and_is_relieved_at_its_end
passes: bends [22, 92] (was [26, 96]). From the geometry: T 2, R 2, the
setback R + T = 4 on the plate from y = 0 and from x = 100; the round
corner relief 8 across is centred on the setbacks' corner (96, 4), so it
takes 4 off the end of each bend there: the long bend from x = 0 to
96 - 4 = 92, the short one from y = 4 + 4 = 8 to 30, 22 long.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
saved_curved_strip_projection_is_lost_after_exact_wall_coalescence built its "old" strip by
cutting the cavity raw (paint turning off the construction shortcut), where truck sewed the cut
slab by slab and split the outer round at the cavity's floor. SMLib cuts without slabs: the raw
cut's round is one face, so there was no piece to save a projection on, and the test stopped at
"must have a piece suffix". The link is now what such a build saved, written out: the face name
`F2:blend:F1:+x|F1:+y#1` (the lower piece, numbered up its spread) and the piece's projection on
YZ, the rectangle y 24..30, z 0..2 (the quarter round from (40, 24) to (34, 30), its arcs and
straight sides), 12 mm³ when extruded 1. The current wall is checked to be one face with that
stem and no planar authority.
The test still fails: the link is found on the whole wall ("was split; using the nearest
piece"), not lost, and the strip's material grows to 6 × 30 × 1 = 180 mm³. project.rs takes a
missing piece as removed only on a certified planar or coalesced face, which truck's shell
made and SMLib's does not. That is a persistent-name decision for the owner (see the PR).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's sheet name is the name 80% of its mesh triangles' centres agree on. SMLib's
mesher fans a 1 mm rim (30 mm tall) into four triangles about its middle; two of their
centres lie 1/6 mm from the panel's top or bottom face, inside the 0.2·t tolerance, and
took that face's name, so the rim got no name (rim.side0/side1/ext0/ext1 of the tray's
flanges: 6 faces unnamed). A flat face's name now needs its plane to face along the
triangle's normal (within 1e-3); otherwise the point is a rim's, a bend's or an ext rim's.
No face changes name: these faces had none.
sheet::face_names_tests::a_trays_faces_have_readable_sheet_names_that_follow_its_size now
passes its naming checks and fails later, on the point named_face_point gives for a rim
(the roomiest triangle's incentre, 0.497 mm from the rim's edge, not 0.5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A hole drawn on a flange's face and cut through ("direction": "negative") was refused as
"below the supported 0.000001 mm extrusion resolution": the flange panel's frame, turned
up by the cosine and sine of 90 degrees, puts the panel's origin at -1.9999999999999998
along the sketch normal, so the cut ends 2.2e-16 mm short of the sheet's far face and
reads as a layer 2.2e-16 thick. A depth within four units in the last place of the
numbers it is worked out from (the frame origins, the tool's span and the thickness) now
lands on the face. A real thin layer stays: a 1e-8 mm layer of a sheet 1e5 mm from the
origin (bound 9e-11 there) is still refused
(partial_depth_intersect_sub_extrusion_resolution_layers_refuse_atomically passes).
Fixes sheet::tests::a_sketch_on_a_sheet_face_follows_the_sheet_when_its_thickness_changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a circle in a profile is one closed arc (Loop2::circle). The sheet's
faces passed it to the sew as one arc edge from a point back to itself, which the sew
refuses ("sew: a degenerate edge"): a sewn edge runs between two vertices, and an arc
edge is the circle through its ends and middle. A disc's flange failed (first with the
4-face minimum, then with the degenerate edge). Each closed curve of a cell is now split
into its two exact halves (Seg2::split_half) where the cell's edges are prepared, as a
hole's wall already came out: a disc is two caps and two half walls.
sheet::tests::tiny_cut_inside_exact_circle_survives_unfold_refold_and_dxf now builds the
disc flange and fails later, on SMLib's extrude of the 50 nm tool (an SMLib tolerance
defect, reported separately).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the kernel's room pre-check went (bcbb99005), a fillet or chamfer refused as
too large stopped saying what would fit: only SMLib's NO_ROOM words were left. The
rig expects the refusal to name it (fillets/4782-fillet-two-end-verticals-past-a-full-round:
"the largest radius that fits is 7.5 mm", fillet_max for the exact fit).
A constant fillet with the exact fit, and an equal-distance chamfer, refused as too
large now add "; the largest radius (distance) that fits is X mm", found by the same
bisection fillet_max runs (up to 16 blends, three significant digits), now shared with
a new kernel::chamfer_max. Where the search itself fails (a candidate failing for
another reason), the refusal is left as it was. The reduce and taper fits and the
kernel's own searches call the kernel blends directly and do not pay for it.
Tests: the 14 x 6 x 10 post's R3.5 names 3 mm; a 4 mm rib's crossing chamfers and
rounds at 3 name 2 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The curves were held on a 1-2-5 ladder from the world origin, so count 3 on a 40 x 30 face gave 3
one way and 2 the other. They now follow the command's contract: the held parameter at
lo + k (hi - lo) / (count + 1), k = 1…count, over the face's extent. Faces of the body on the same
surface record are spaced together over their combined extent, so a face a boss splits still
shows the same lines straight across the split.
New case cov-isocurve-40-by-30-face-count-3: x = 10, 20, 30 and y = 7.5, 15, 22.5, to 1e-9 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both walked the picked curve's display polyline: a point a third along an R10 sketch arc was
0.87 µm off (8.6603, 5). They now evaluate the path's exact curves by arc length: lines and arcs
in closed form, a free-form span at the parameter its arc-length integral reaches (body edges by
their record curves, 3D sketch curves by their arc, spline, line or linked exact curves; only a
curve that exists as points alone, an intersection edge or a projected curve, runs along them).
The arc's point is now within 1e-12 mm of (10 cos 30°, 5, 0).
A t outside 0…1 was clamped silently, which the contract (`t: expr, 0…1 along it`) does not
say: it is refused ("t is 1.5: a point along a path is 0 (its start) to 1 (its end) of the way
along it"). The construction cases grade the arc and line to 1e-9 mm, past-the-end is refused,
and a new case takes the middle of a symmetric cubic spline, (20, 7.5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The single results form compares a whole number exactly (a count). The construction and inspect
cases gave positions and volumes as whole numbers, which the form they were written for compared
within tolerance; they are decimals now. The NPT groove fix makes ladder 06/023 pass: its golden
entry is the passing run (51 faces, 8226.4042 mm3).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The groove's section was cut square a fixed margin past the crest. The crest cone changes 1 in 32
along the axis across the section's own width, so for NPT (margin 0.015 mm against a 0.028 mm
rise) the section's deeper corner stopped under the cone and each tooth kept a sliver of its
flank: 0.94 mm3 too much on a 1/2-14 NPT. The section's edge now follows the cone at the same
margin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's parallel projection (CreateParallelProjectionCurves) gives every curve where the
projecting lines cross the face: a line projected down onto a ball came back as its top and its
bottom, each split at the pole, and the link's first wire was half the bottom. A projection onto
a surface is where those lines first hit it (owner's decision, as mainstream CAD does): a curve
is now kept only when the first hit on the body's mesh along the line through its middle is the
curve itself (within 4 chord tolerances), and the pieces that meet end to end are joined in
whatever order and direction they come, a piece run the other way exactly (its knots and
control points reversed; a line's, circle's or ellipse's parameter mirrored). The ball's top
is then one wire from x = -10 to 10.
three_d_sketch_curves now expects that exact curve: one wire, its ends at (±10, 0, √300), every
point of its exact curves on the sphere of radius 20 in y = 0 over the top, to the projection's
own tolerance (a millionth of the body's size), and sweeps_and_pipes_follow_3d_sketch_curves
pipes along the whole joined top. Both pass on the pinned SMLib (90aabff): the pieces lie 9.1e-6
off the sphere against a 4e-5 tolerance and meet at the pole within 4.7e-8 rad, since the fork's
8d95600 keeps the pole's exact tangent in StepBackFromSingularity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
path_points took any wire with three or more fit points as a fitted spline, and a 3D arc keeps
its start, through and end points as its fit: the pipe along a quarter arc of radius 20 ran
along the cubic through those three points and came out 388.06 mm³, not π·2²·10π = 394.78.
A wire with its exact arc (Wire::arc) now goes to the kernel as that circle, from its start
counter-clockwise about its normal through its sweep (kernel::curve_path of the record circle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Builds before format 14 named the pieces a cut splits a body into in truck's shell order, and
the later features of such a design name the piece they work on by that name. SMLib orders the
pieces otherwise, so split-body-pieces' fillet and chamfer landed on the wrong piece, its
reference "no longer exists" (design_corpus body_names_saved_before_exact_history_keep_their_pieces,
old_designs_open_and_evaluate_as_saved). For a feature saved so (`shell_piece_order`), each
name its pieces are known by goes to the piece the points the later features naming it picked
lie on; a name no later feature uses keeps SMLib's order, and so do all of them where the picks
do not tell the pieces apart. docs/compatibility.md says so.
That makes the feature's result depend on features after it, which neither its fingerprint nor
its cache key cover: a script replays the design one feature at a time, so the split was
evaluated before the fillet and chamfer existed, kept SMLib's order, and was reused once they
came (script_roundtrip corpus_designs_replay_from_their_scripts: 'Body1 (1)' 4765.663706234679
opened against 4765.663706134907 replayed). The state now keeps a digest of the picks it named
the pieces by (`ModelState::legacy_picks`), and every reuse (the last results, the cache, the
kept, rolled-back and primed results) takes a state for such a feature only while the design's
later features pick the same, so the replay names the pieces again as the file does when it
opens. A saved model's states carry no lineage and are taken as saved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The display mesh is the tessellation planner's (8b6bfc48c: the mesher plans a schema 4
record), which grids a planar face with no side longer than a fifth of the body's extent
(docs/capabilities.md, "Display meshes"); truck's mesher gave a box face two triangles. The
tests that counted truck's mesh now count the planner's, worked out by hand from that rule:
- a 10 x 20 x 30 box (37.4 mm diagonal): edges in 2, 3 and 5 pieces, faces of 2 x 3, 2 x 5
and 3 x 5 cells, 124 triangles; welded, the box lattice's 3 x 4 x 6 nodes less the
1 x 2 x 4 inside it, 64 positions (obj_export_is_welded_and_keeps_names);
- a 20 x 15 x 10 box: 4 x 3, 4 x 2 and 3 x 2 cells, 104 triangles (an_opacity_class_change...);
- a 20 x 20 x 10 box saved as a mesh: its edges in 4 and 2 pieces, 40 segments per box
(imported_mesh_edges_draw_in_each_style...);
- the cylinder's top cap is under a third of its triangles (select_other_over_a_dense_cluster...).
An imported mesh's outline was one line per crease side, so a box exported at that spacing
showed each edge in pieces: a click on a 10 mm edge measured 5 mm, or hit the node between
two pieces (measure_imported_stl_edges_and_vertices..., mesh_outline_hover_cache...). Outline
sides that run straight on through a vertex no other outline side meets are now one line, as
the CAD model's edge was.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's edges are projected exactly: lines, and arcs read off SMLib's NURBS within the
planar-edge tolerance (Body::planar_edges). An SMLib shell's offset corner is a NURBS whose
arc came out with its centre 2e-6 mm off and its ends up to 6e-7 mm from the lines they meet,
beyond the link's merge tolerance (1e-7): the inner loop of the sensor enclosure's case top
projected as sixteen loose curves, the offset of one found no chain to follow, and the Lid lip
extrude found no profile l13..a16 (the five acceptance scenarios, action_matrix
an_axis_through_a_corner_round_that_a_parameter_moves). Each edge's pieces now end on the
edge's vertices where they lie within the edge's and the reading's tolerance of them (the
vertex is the point both edges share), and an arc whose ends moved takes the centre nearest
its own that is equally far from both, so the sketch keeps both ends on its circle.
Body::planar_edges_tolerance names the reading tolerance planar_edges uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A chamfer picked at (10, 0, 20) on a cylinder's top rim lies on the vertex where SMLib's
cylinder has its seam. The blend takes the rim there (blend_smlib::resolve: a seam or a smooth
join loses a tie), but the name stored with the feature came from the nearest mesh edge, the
seam (`F2:side:c1`). Once the stem grew, the name found the seam and SMLib refused the chamfer
(join_extrude_from_a_chamfered_top_face). edge_names_for names the edge each pick takes as a
blend takes it (kernel::blend_edges), the nearest edge only where that finds none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The thread forms (b4549d270) parse designations in thread_forms, whose refusal for a plain
M28 said "give it: M28x1" and, for M0 or M1e9, still offered a pitch. The hint the hole
command gave (the two coarsest ISO fine pitches that suit the diameter: M28x2 or M28x1.5) is
now thread_forms::no_coarse_pitch, used by both; a diameter no metric thread has is an
unknown metric thread. The test's "unknown thread" follows the forms' wording ("unknown
metric thread").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#8676 added FeatureKind::Repair without a fixture, so
feature_walk_tests::the_record_covers_every_variant failed. The fixture sets
every field (body, gap, patch_holes); the records, written with
FEATURE_WALK_BLESS=1, show its one input (Gap, a length) and that copying with
bodies renamed rewrites its body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
the blend at such a continuation, its refusal names the edge it runs into
and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
round an r2 round's end arc), the refusal says the chain was blended and
that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.
The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The command worked the repair out itself for its reply and the feature worked it out again
when it evaluated. The evaluation now keeps the kernel's report on the feature's result (as
an import keeps its import report, cached with it), and the command's reply is built from
that: one repair per call, and a part with nothing to repair fails the evaluation, which
leaves the design unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new undoable feature (`repair`, one pending format file) and command with input and
output schemas. In order:
- A cylinder, cone, sphere or torus face SMLib refuses on its own is rebuilt on a NURBS
form of its surface laid on arcs from where the face starts
(`form::surface_on_own_arcs`), with SMLib's own trims: the import's quarter-grid form of
a face round most of a turn closes on itself, which SmTorus::IsNurbSurfaceTorus does not
recognise. Geometry unchanged.
- Free edges that pair up within `gap` are sewn by SMLib's stitch; GlueEdgesGeneral gives
each glued edge its own tolerance (at least twice its gap), the body's and the other
edges' stay. The result is checked against the input's own SMLib check, the
tolerance-bound tests (#5, #6, #59, #82) exempt.
- Loops of free edges left are holes: offered as surface.patch, and with patch_holes made
(flat only when the loop is planar and every face around it is a plane, else G1) and
sewn in.
The reply reports what changed face by face; nothing to do is refused with why.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three expectations encoded the old truck planar booleans' incidental output;
each is replaced by the exact answer:
- a_base_trimmed_for_a_flange_keeps_its_arcs: the flat outline has 10 edges,
not 12. The flange's bend zone and panel meet in line, and the union of
the two is one line along each side (a region's boundary has no vertex in
the middle of a straight run). Lengths and areas are unchanged and still
checked to 1e-9.
- a_base_trimmed_through_a_free_form_curve_follows_it_with_arcs, renamed
..._keeps_it_exact: the trim cuts the parabola exactly, so the base keeps
one conic and three lines instead of tangent arcs within 0.001 mm. The
strip (183.564 = ∫ y from 197 to 200, or 600) and the bend's length
(62.364) are now checked to 1e-6 and 1e-9 instead of 0.22 and 2e-3; the
chorded comparison stays.
- pockets_with_free_form_outlines_are_machined_beside_free_form_cut_outs:
the machining record holds the pocket's four exact conics in their order,
started at another of them; the check is for the same closed loop, not
the same first segment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two tests rebuilt the old kernel's raw strips (a shell's wall split along its
opening, a stepped tab's -x wall split by the Join and the Cut) with today's
kernel and took the saved piece's name and projection from them. SMLib leaves
those walls one face, so there is no strip to rebuild: the tests now say so (the
wall is one face) and give the saved link as what an older file holds, its piece
name and its rectangle (y 10..20 x z 0..20 on the -x wall, the same 4-line
projection the strip had), and keep every check of what the model does with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
expected.json may give `continuity: {order: g0…g4, edges?: "blend" | "corner"}`: the
seams of each round, chamfer face or corner patch with the faces either side of the edge it
replaced, and of each corner patch with its rounds, are measured as Continuity Analysis
measures them (seam_diagnostics at its default 33 stations and default tolerances), and the
case fails naming the worst seam, its faces, the order it reaches and the next order's worst
value. The seams come from the faces' persistent names (doc::naming::blend_seams). The older
`{near, within_mm, …}` form is kept.
Every fillet-area case with a body gets its order: constant rounds and rolling corners g1,
curvature rounds g2, chamfers g0, the corner: g2 patch g2 at its seams.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A torus face covering most of its tube off the tube's quarter lines (an
exhaust collector's bend: 326° of the tube from −113.8°) needed a fifth
quarter along the tube, which STEP counts from the outer equator: its form
ran past a full turn of the tube and SMLib refused the solid. #8496 turns
frames about the axis only, and the torus label had no tube reference.
The torus label gets a tube start (`tube_start`, radians; 0 and left out
of the record by default, so older records mean what they did): v counts
from there, in every evaluator, form, pcurve, iso curve, tessellation,
placement, SSI and SMLib transfer. A spilling torus face's tube start moves
to where its tube begins, or a turn before where it ends, whichever puts
its tube circles on the grid of a round face they are about the axis of
(a pipe's cylinder meeting the bend); circles round the tube are labelled
from the tube start (brep::form::on_tube), so their forms and pcurves lie
on the face's quarter grid exactly. The saved-format change is one file,
crates/doc/src/format/pending/torus-tube-start.rs.
Engine assembly: COLLECTOR_EXHAUST_VER_1 now comes in as a closed solid
(refused 3 -> 2); Poppy Humanoid unchanged (4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel's import warnings get a structure (ImportReport: the file's parts, how many came
in as solids, and each warning's kind, part, faces and count; the reads' notes are typed as
repairs or faces left out). The Import feature's result carries it (and the model cache keeps
it), and the timeline tooltip and the status line after an import word it from the catalogs:
"Imported 40 of 43 parts as solids. 1 part couldn't be made into a solid and is shown as a
mesh. 3 faces couldn't be repaired and are missing." with what may help. Entity numbers and
the kernel's wording stay in Copy Warning Message, which now lists every warning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An open body (a surface body, a mesh that does not close) has no inside: its faces counted
with the rest took the cap from the closed body it lay in or behind. The body's closedness,
which the kernel knows (`ModelBody::is_closed`: no shell left open, a mesh body every side of
which two triangles share), goes with it to the renderer (`SceneMesh`, `PlannedBody`,
`InstancedMesh`, a block's closed runs, the loose open triangles), and the count draws closed
bodies only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
The held parameter was spaced over each face's own trimmed (u, v) box, so the pieces of a
face split by a boss showed different lines that missed each other at the split. The lines
now sit on a ladder of the surface: a bounded parameter's range in count + 1 steps, a linear
one (a plane's, a cylinder's or cone's axis) at a round world spacing from the world origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel's Continuity moves out of bridge.rs into continuity_order.rs and gains G4. One
table holds each order's command word (g0-g4), its code (G0-G4, for tips and messages) and
the message ids of its label and hover text. Construction says which orders the patch,
bridge, network, match and sketch blend curve build today; Continuity::built_by is the one
refusal every command and kernel entry point uses. A design may now save g4 (format note).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The analysis sliced the display mesh with planes: faceted, approximate, and
broken at triangle seams and trims; the window drew it as a 2D overlay without
depth while the tool was active. Now one kernel routine (kernel::iso) clips a
surface's u = const or v = const line to a face's pcurve loops; the curve through
a point (sketch projection) and the analysis grid (count each way, evenly across
the face's extent) both use it. The loop polygon follows the loop's order (a
pcurve the loop runs against is walked backwards), which the inside test got
wrong before, and closes over vertex-loop poles.
ModelBody caches the lines per face, count and display quality. The session
keeps the picked faces as view state (inspect.isocurve add/clear, hostile counts
refused); the viewport, ui.render and snapshots draw them depth tested in the
accent colour. Curvature combs on faces follow the same exact lines.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New metric tapped holes drill the tap maker's drill (M8 6.8 mm). The Design preference "Metric
tapped holes drill the major diameter less the pitch" (`metric_tap_drill_major_less_pitch`, off
by default) gives them the drill every metric size took before (M8 6.75 mm): the Hole dialog
shows and sends it, and `solid.hole` given a thread and no `diameter` drills it, through the
session as `auto_project` is (kept when a design is opened or started, and across tabs). Unified,
pipe and taper sizes keep their tabulated drills; a given diameter is unchanged. Saved designs
keep the drill they stored either way.
Labels in en, ar, he, ja, zh, de and ko.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Every tapped hole now drills the tap maker's tabulated drill. ISO metric takes Yamawa YEU23's
drill size column for cutting taps (printed p.704, M coarse; pp.704 to 706, MF fine): M8 drills
6.8 mm and M12 10.3 mm, where the major less the pitch gave 6.75 and 10.25. A custom metric size
the table lacks keeps the major less the pitch. UNC/UNF (Guhring), G, Rp, Rc and NPT (Yamawa)
were tabulated already. The Thread command's suggested hole for a metric size follows.
The Hole dialog's Tap drill diameter is now a field, the tap maker's drill by default, and the
command's `diameter` with a thread is checked the same way: a drill is accepted from the
internal thread's standard minor diameter (or the tap maker's drill where that lies below it:
Rp, Rc, NPT) to 5% over the tap maker's drill. Outside that the command names the range and
why. The field's tooltip gives the drill, the minor diameter and the range. Presets keep a
chosen drill.
A saved design keeps the diameter it stored, so it builds as before, and editing such a hole
keeps its drill: no preference and no format change. Scripts that give a thread without a
diameter drill the new default; ladder 05/007, 11/003 and rig case threads/2115 follow
analytically, and their golden entries are re-measured from runs (tier 05 re-sorted by time).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The Rc and NPT drills were rounded to a drill series from a third-party reproduction of DIN 345
and a fractional/letter inch series cited from memory. They now come from the same tap maker's
catalogue the G and Rp drills do: Yamawa YEU23, printed p.709 (Rc, the maximum straight bored
hole with non-full threads, Rc 1/16 to 4) and p.710 (NPT, the maximum straight bored hole, 1/16
to 3). A size its tables lack (Rc 5 and 6, NPT 3 1/2 to 12) is refused as a tapped hole, naming
the range. The dialog's tooltip keeps the standard's minor diameter where the thread ends.
Rc 1/2 drills 17.6 mm (minor 17.807), 1/2 NPT 17.60 mm (minor 17.473).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
An Rc or NPT hole was drilled to the exact minor diameter where the thread ends, a size no shop
stocks. It now takes the largest stocked drill not larger than that: metric drills of the DIN 345
series for Rc (to 100 mm), letter and fractional inch drills by 64ths (to 1 1/2 in, ASME B94.11M)
for NPT; past the series it is bored to the exact value. The Hole dialog's drill shows the inch
size for NPT, and its tooltip the exact standard value. Rc 1/2: 17.807 mm, drilled 17.75 mm;
1/2 NPT: 17.473 mm, drilled 11/16 in (17.4625 mm).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The tapped-hole catalogue takes ISO 7-1's Rc and ASME B1.20.1's NPT internal taper threads,
every size of the tables a modelled thread cuts. Their drill is the internal minor diameter where
the thread ends (the reference plane's minor at the face less the 1 in 16 taper over the useful
or effective thread length), derived from the standards rather than a tap maker's table. An
external R is still no hole's.
A tapped hole's options mirror the thread's: `modeled` cuts its thread into the wall, from the
entry, by the same cut as `solid.thread` (now one function both call), and `ease_out` fades its
inner end out before the bottom (ISO 3508); without it the groove stops square at the thread
depth, clear of a blind hole's bottom. The Hole dialog's Tapped rows add Rc and NPT, Modeled
and the End choice (Square, Fade, Fade Length). The format notes in pending/thread-ends.rs and
pending/pipe-threads.rs record the new keys and sizes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The thread dialog offers the pipe threads: G (ISO 228-1), Rp (ISO 7-1), R and Rc (ISO 7-1) and
NPT (ASME B1.20.1). Their sizes are listed by designation without a pitch, one start and a hand
of right or left; a size picked for a hole the dialog sized Rc stays Rc.
Rp, ISO 7-1's parallel internal thread an R screws into, is a form of its own (`rp`): the
parallel profile (H = 0.960491 P) at ISO 7-1's gauge diameters, refused on a shaft. Its cut
meets the analytic material of its profile within 1e-5, as G does.
A taper thread takes a chamfered tip: each end's cone is measured from the major diameter the
taper has at that end. Pipe threads are not ISO metric, so they give chamfer_depth.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A thread's start runs off its free end, plain or chamfered; only its inner end fades out
(ease_out) or stops square. The `ease_in` field, the command parameter (refused now, naming
ease_out), the dialog's Ease In row and their docs are removed; `pending/thread-ends.rs`
drops a saved `ease_in` as the design opens. The runout test covers the short, standard and a
sub-turn fade at the inner end.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The free-end test looked for material 1 to 1.5 pitches past the face's end, beyond the first
pitch so that a chamfer the groove runs out through counts as free. A plate thinner than that
(a boss on a 1 mm plate under M10) had none there, so its top was taken for a free end and
the groove's one-pitch overrun cut into the plate (15 mm³ of a 1 mm plate).
An end is now closed when, over the overrun's whole reach, material lies outside the face's
cylinder (inside it, for a hole) at the radii the groove cuts beyond the face: a shoulder,
plate, head or blind bottom, however thin, steps out past the face, while a chamfer, neck,
countersink or counterbore steps the other way. The band test beyond the first pitch stays
for a cylinder that goes on past a split.
The regression test builds the boss as the app does (a rounded plate, a circle sketched on its
top face, extruded with Join) on 6 and 1 mm plates.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three forms: `bspp` (G, ISO 228-1, 55° parallel), `bspt` (R external, Rc internal, ISO 7-1,
55° taper 1 in 16) and `npt` (ASME B1.20.1, 60° taper 1 in 16). Their sizes are tabulated
from the public sources: ISO 7-1:1978 Table 1 (its gauge-plane diameters are the G sizes)
and NBS Handbook H28 (1957) Table VII.2; tests check every row against the standards' own
relations.
A taper thread starts at its free end with its standard diameter there (external: the gauge
diameter its gauge length in, internal: at the face). Its groove is the screw sweep with the
section moved 1/32 of the axial travel off the axis (the radial law the runouts use, added to
it), its section reaching just past the crest, and the material beyond the major cone (or
inside the minor cone) is cut with it, as a die or tap cuts the crests. An external one runs
its standard length by default.
The volumes are checked against the profile's material fraction integrated over the tapered
radii: G 1/2 to 2e-6, R 1/2, Rc 1/2 and 1/2-14 NPT within 0.2 % of the cut.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`tip` was none|chamfer, chamfer cutting every free end. It is now none|start|both: `start`
chamfers the end the thread starts from, refused when that end is not free (a shoulder, or a
stop inside the face), and `both` every free end as `chamfer` did. The dialog's Tip pick offers
None, Start and Both; `tip: chamfer` in a command names its replacements.
The thread's end options (runouts, tip, chamfer angle and depth) came without a format
change file; `pending/thread-ends.rs` records them and rewrites a saved `tip: chamfer` to
`both`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ISO 4753's chamfered end bounds the end's diameter by the minor diameter. The default took the
modelled root (the basic d1) for it, so the cone's small circle lay on the root cylinder and
the chamfer ring pinched to nothing wherever the groove reached the end. The default is now
the external minor diameter d3 = d - 1.226869 P of ISO 724, below d1: the cone crosses the
root, each end is a whole disk of d3 inside a whole conical ring. ISO 4753 is for ISO metric
threads; the other forms, whose root is already their design minor, give chamfer_depth.
Ladder 06/017's analytic volume follows (1945.354522563); its golden entry re-measured.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::Fillet with corner G2 is kernel::fillet_g2_corners, its setbacks
the corners' distances (the rest 1.5 r); setbacks now go with either corner.
The engine's corner test builds the G2 corner, default and set back 7, one
closed solid of 10 faces within 0.1% of the ball corner's volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Session::execute is a command span; Model::evaluate and each feature computed
(by its type) are spans; io's import, export and design read/write too; the
STEP reader's topology, pcurves and solid record.
- diagnostics.profile (contract + output schema): report, start/stop, reset,
Chrome trace file.
- A STEP/IGES import's reply carries its own profile while recording.
- Every app compiles the profiler in by default (feature `profile`);
SOLIDCRAFT_PROFILE=1 starts it.
- solidcraft-cli run/eval/bench-open --profile print the table on stderr,
--profile-out writes the trace; run --profile works on designs and STEP files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.24.0 (format 39) saved a left-hand Thread or tapped Hole as `handedness: "left"`; this
branch replaced main's handedness (#4414) with the thread's `hand`, and features don't refuse
unknown fields, so such a design opened right-handed without a word. The pending format change
thread-hand.rs renames `handedness` to `hand` on Hole and Thread features (a `right` is
dropped, anything else refused).
Tapped holes take `hand` again, right or left (never both, and only with `thread`): the Hole
feature saves it, its thread is cut and annotated that way, solid.hole takes `hand?`, the hole
dialog's tapped rows have the thread dialog's Hand choice (without Both), editing a hole keeps
it, and hole presets save it under v0.24.0's `thread_options.handedness` key, so presets saved
by v0.24.0 recall it.
Test: a format-39 design with a left-hand thread and tapped hole opens left-handed; a hole's
`hand` refuses both and needs a thread.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code main added since the last rebase reads the placed model, a camera or a scene
as values; on this branch they return Result. Picks and the edit dialogs read the
session's placed model through open_meshing::session_world, as the others do; the
revolve and circular-pattern axes, the model axis of a command and the warming of a
computed edit pass the error on; tests unwrap. A test meshing bodies uses
Body::mesh, the one mesher.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
The reworked thread has its own direction, `hand: right|left|both`, on SMLib's
exact screw sweep. Main's #4414 added a second one, `handedness: right|left`, on
Hole and Thread, for the faceted groove this branch replaces. It is taken out: the
field, its pending format change (never released), the hole dialog's direction row,
its hole-preset option, its strings and its tests, which measured the faceted
groove. A tapped hole is right-handed, as before #4414.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
A modelled thread never changes the size of the shaft it is on (#1018, #2853): a
shaft thicker than the thread is refused with the size to make it, as
tests/kernel-cases/threads/2705 expects ("this 14.6 mm shaft is too thick for a
modelled M14 thread; make the shaft 14 mm for M14"). This takes out the turn-down
of #4256: `thread_turn`, the fit that let a thicker shaft through, and its tests;
the 9 mm shaft refusing an M8 and the preview's M6 refusal on an 8 mm shaft are
back as they were before it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs