5c0e48ed2bc2e8d4ce0baa86cd52c4218f1b68fb
602
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
5c0e48ed2b |
feat(render): add bounded linear film accumulation (#1696) (#1697)
Extract the independent FilmAccumulator from owned donor
|
||
|
|
ce1c8db7fb |
feat(render): reconcile definition-local visual mapping (#1214) (#1223)
Retain the original mapping implementation, all eight analytic/hostile-input tests and mapping contract byte-for-byte from #1223. Reconcile only module registration and the current roadmap on render. Actual current render library 166/0; strict all-target render Clippy, wasm32 and repository gates pass. No persistence, sampler, new capability, kernel/vendor change or external code is added. Historical mixed-base full-CI failures are not relabelled. |
||
|
+30 |
d4ec5e6811 |
Sync pinned main into render (#5869)
* Viewport: show reference geometry through bodies (Preferences, off by default) (#2697) A new Graphics preference, "Show reference geometry through bodies", draws inactive sketch contours, origin and construction planes and their axes over shaded bodies. It is off by default, so the viewport looks as before: reference geometry is depth-tested and a section leaves it whole (#1229); Create Sketch and dialogs picking a plane still draw the planes through the model. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * ui-egui tests: offscreen GPU tests start their devices one at a time (#3989) (#3990) * claim: #3989 * ui-egui tests: offscreen GPU tests start their devices one at a time Every offscreen test started a wgpu instance of its own, and starting one makes the Vulkan loader scan its drivers. With several test threads two tests doing that at once crashed the test process with SIGSEGV inside the loader (loader_icd_scan). offscreen_device now holds a process-wide lock while it starts the instance, adapter and device; each test keeps its own device and the rendering still runs side by side. * DXF: write and read a Bézier at its own degree (#5269) (#5281) * claim: #5269 * DXF: write and read a Bézier at its own degree (#5269) The DXF writer and reader held a spline's degree to 7, the value MAX_BEZIER_DEGREE had before #1642 raised it to 9. A G4 blend (one Bézier of degree 9) was written as a degree-7 SPLINE over its first 8 control points, so a flat pattern's cut-out stopped 4.444 mm short in the file. - seg_shape takes its limit from MAX_BEZIER_DEGREE: a Bézier is written whole, at its own degree. - read_dxf reads SPLINE degrees 1 to MAX_BEZIER_DEGREE, the degrees a sketch spline takes. - Tests: every Bézier degree 4 to 9, a degree-9 round trip, the reader's degrees, hostile SPLINE degrees and too few control points, the G4 cut-out exported and read back with its areas, and a degree-9 SPLINE with 2 to 10 points inserted into a sketch. Fixes #5269 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Renaming a plane keeps its projections, canvases and hidden state (#4353) (#4354) * claim: #4353 * Renaming a plane keeps its projections, canvases and hidden state (#4353) timeline.rename only renamed the feature in other features' references. A sketch's projection of a construction plane, a canvas placed on it and the hidden list keep it by name too, so they lost it: the sketch warned that the plane no longer exists, the canvas left the view and a hidden plane showed again. Document::rename_feature_keys renames it in sketch links and canvases, as rename_body_keys does for bodies; the selection follows in the command, and the hidden list in Session::refresh_from, so a hidden plane stays hidden through undo and redo too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Browser: add Rename and Delete to feature menus (#3839, #4343) (#4342) * claim: #3839 * fix(ui): add Rename and Delete to browser feature menus * Browser: a second click on a Document Settings entry closes its window (#4150) (#4152) * claim: #4150 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Browser: a second click on a Document Settings entry closes its window (#4150) Each entry under Document Settings only opened its window. A second click on Units closed the menu on the press (the row is outside it) and opened it again on the release; Precision left Preferences open; Parameters and Design Properties came back as a fresh copy. Now a click on an entry whose window is open closes it the way the window's own x does: - Units: context_menu::toggle_for with the row as the opener, the fix #1522 made for the workspace button's menu. A right-click still opens it at the pointer. - Precision: prefs::close(app, true), the Cancel/x path that puts back what changed since the window opened (now pub(crate)). - Parameters and Design Properties: the window is dropped, as its x does. A Parameters value typed but not applied yet is dropped with it, as today's second click already drops it. Fixes #4150 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Preserve expression-positioned sketch fillet corners (#4097) (#4106) * claim: #4097 * Sketch fillet keeps a corner placed by an expression (#4097) Filleting a corner whose position comes from parameter expressions deleted the point and its expressions, so the sketch gained two degrees of freedom and later parameter changes distorted the outline. keep_corner now also keeps fixed or expression-positioned points as virtual sharp corners. * Fix feature editor picks after upstream sketch resizing (#4083) (#4084) * claim: #4083 * Feature editors refill named edges and faces where they are now (#4083) After an upstream sketch change, Fillet, Chamfer, Shell and Draft evaluated correctly, but their editors refilled the originally clicked points and could then fail with "no edge at ...". Resolve the stored names through the document's naming helpers first, keep the resolved index, and map the pick into the displayed body's frame; the point lookup stays as the fallback. * ui-egui tests: clear the texture deltas of the frames they run (#4039) Nine tests dropped an egui frame's output with its texture delta still unapplied (the expression completion editor's frames, the slot preview's three, the browser's feature rows). epaint asserts against that in debug builds, so they failed under the dev profile and passed only where debug assertions are off. They clear the delta as the other tests do; one more hover test that dropped its output the same way does too. * Frames: profile library, members along frame sketch lines, and the Frame Member dialog (#4003) (#4004) * claim: #4003 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the profile library (#4003) The first slice of frames and weldments: the cross-sections structural members will be made of, each SolidCraft's own parametric definition built in code (no vendor or standard size tables are shipped). - solidcraft_doc::frame: bar, round bar, rectangular and round tube, angle, channel, I-beam and a generic T-slot extrusion as exact line/arc regions, with defaults worked out from the profile's size, refusals that name the dimension that does not fit, anchors and placement, and exact section properties (area, centroid, Ixx/Iyy/Ixy by Green's theorem). - frame.profile.list, frame.profile.properties (with mass per metre for a density) and frame.profile.insert (draws a profile into a sketch, locked by default, at a point, anchor and angle). - Tests against hand-computed values (rectangles, circles, composite rectangles by the parallel-axis theorem, fillet spandrels), hostile input, extrusion volume, undo; catalog entries in every locale; docs/frames.md; ROADMAP M15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: drop the built-in T-slot profile (#4003) Aluminium extrusions and other vendor sections come from the user's own sketch (drawn or inserted from the vendor's DXF), so the library keeps the plain steel shapes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: members along frame sketch lines (#4003) frame.member lays one body per straight line of a frame sketch (2D lines or 3D sketch lines), its cross-section square to the line from end to end: - profile: a built-in profile, or profile_sketch, a sketch whose material (nested loops alternating, so two circles make a tube) is the section in its own x and y around its origin; profiles picks override it. - anchor (origin, centre, centroid or a bounding-box corner or edge middle), angle (an angle expression, so a parameter), mirror. - Orientation: the profile's y as near world up as the line allows, x square to both; a vertical member's x is world X (frame::member_axes). - Members follow sketch and parameter edits, undo as one step, save and reopen (format: pending/frame-members.rs), and are named after the profile (Rect Tube 40x40x3, (2)…), numbering on past names already taken. Tests against hand-computed volumes and bounding boxes (rectangle, 3D tower lines, parameter edit, sketch tube profile and picks, anchor/angle/ mirror), refusals, undo/redo and reopen; walk fixtures and goldens; docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: fixes from the adversarial review (#4003) - Default member lines are what was drawn: projected and other linked curves and 3D wires (a face sketch's edges) and lines of no length are left out. - A profile sketch's material starts from its drawn profiles, as solid.extrude's "all" does, so a section sketched on a face works; the even-odd test uses outlines and boxes worked out once, capped at 256. - Member names are pinned to their lines (`names`, by line id; `body_name` is the base): deleting or adding a line, or deleting another feature, no longer renames other members, and frame.member stores every name it gives. body.rename renames a member on its line (also for later member features); a copy whose body_names were set still names its members by position. - Built-in profile dimensions are expressions (ProfileSpec): they follow parameters, bare numbers take the design's units, and they are feature inputs. frame.profile.properties/insert read them the same way. - Default root/toe radii shrink to the room a thick section leaves; radii given are checked by name; a radius must be 0 or at least 0.01 mm; error messages report the wall or flange value given, not twice it. - A line within 1e-6 rad of vertical orients as vertical, so rounding never turns a post a quarter turn. - A 2D frame sketch in a differently placed component is mapped into the member's frame, and member features recompute when placements change. - Caps before lookups for a design's `lines`; a line listed twice is refused; a 3D wire that runs back on itself is not a line. Regression tests for each, from the review's scenarios. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the Frame Member dialog on the ribbon (#4003) - Frame Member (MODEL > Create) opens a dialog: the frame sketch's lines picked in the view (or All Lines), a built-in profile and its dimensions or a section picked in another sketch, anchor, angle, mirror and name, with a live preview. Edit Feature reopens it filled in. - Lines picked in the view keep their sketch (a SKETCH_LINES input picks ExternalSketchCurve): line ids are each sketch's own, so two 3D sketches both have a `w2`, and the members went on the newer sketch's lines. - timeline.redefine takes frame.member. Members keep their names through an edit unless it gives them a new body_name; frame.member takes `names`. - A member whose section is a whole profile sketch keeps it when edited (the dialog shows the sketch instead of picking every region, which would fill a tube's hole). - An original frame_member icon, open for review, on the ribbon, timeline and browser. - The angle profile is listed as L-Angle, and web and flange as Web/Flange thickness, so they translate apart from the existing Angle, Web and Flange; the dialog's labels are in en, ja and zh. en-GB no longer repeats the frame command labels it spells the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Rectangular and circular pattern: copies that miss the body are reported (#3042) (#3919) * claim: #3042 * Warn when cut pattern copies remove no material A rectangular or circular pattern whose copies miss the body succeeded silently and those copies did nothing. The pattern now reports how many of its cut copies removed no material, and keeps the copies that land. * Delete in a rolled-back history warns about the features after the marker (#3471) (#3698) * claim: #3471 * Delete in a rolled-back history warns about the features after the marker (#3471) With the timeline rolled back, the checks a delete runs first (the confirmation's "these features will fail", timeline.dependents and selection.delete's would_fail) compared models evaluated only up to the marker. Features after it, broken by the delete, were not listed, so their error marks turned up only once the timeline moved to the end. newly_broken_in_history evaluates both sides over the whole history when either has a marker (on copies; the model and document are unchanged) and is used by the delete's report and by timeline.dependents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * macOS: Fusion navigation preset does not support Shift + two-finger orbit (#3446) * Macos: keep touchpad/key modifiers true to fusion * fix: remove obsolete orbit snap reset from trackpad navigation Upstream removed ViewportState::orbit_snap. The new trackpad orbit path retained one reference, causing E0609 in the PR merge build. Validation: all seven trackpad tests pass; cargo check -p solidcraft-ui-egui --all-targets passes on the exact failing CI merge 66a2791b with this fix applied; rustfmt and diff checks pass. Co-Authored-By: GitHub Copilot <noreply@github.com> * fix: retain Fusion trackpad help in refactored preferences Preserve upstream's new preferences pages and apply the translated Fusion trackpad tooltip in prefs/navigation.rs. Validation: cargo build -p solidcraft passed. Tests and full CI were not run, as requested. Co-Authored-By: GitHub Copilot <noreply@github.com> * style: format Fusion trackpad preferences tooltip Apply rustfmt's required wrapping for the relocated tooltip. No behavior changes. Validation: cargo fmt --all -- --check and git diff --check passed. Co-Authored-By: GitHub Copilot <noreply@github.com> --------- Co-authored-by: GitHub Copilot <noreply@github.com> * 2-point circle takes a typed diameter (#3278) (#3335) * claim: #3278 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 2-point circle takes a typed diameter (#3278) After its first point the 2-point circle tool showed no value box, so the circle could only be sized with the cursor. It now shows a Diameter box, like the centre circle: the typed value puts the second point that far along the cursor's direction, and Enter draws the circle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Reorder design tabs by dragging them (#3187) (#3188) * claim: #3187 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reorder design tabs by dragging them (#3187) A tab dragged along the strip follows the pointer while the others make room, and lands where it is released; Escape, or releasing down the window, leaves the order as it was. With the custom title bar a drag that starts mostly up or down (or on the only tab) still moves the window. The control channel's ui.documents gains a move action (from, to). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Renaming a body keeps the evaluated timeline, off the window thread (#2467) (#2468) * Renaming a body that later features change evaluates nothing (#2467) Model::rename_body now keeps the results when later features change the body (a pattern, a chamfer, a join). It still evaluates when a body of that name comes and goes or isn't the same body throughout, when a later body's name is worked out from it (X (2)), or when a message quotes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rename box: rename off the window thread, and locked bodies follow a rename (#2467) The rename box commits body.rename through run_heavy, so a rename that still evaluates later features (one names the body in its targets) computes beside the window instead of freezing it. Locked bodies now follow a body.rename from anywhere (the rename box, the control channel, scripts), not only the rename box. --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Toolbar: a constraint dragged out of the small box becomes a full button (#5254) (#5456) * claim: #5254 * Toolbar: a constraint dragged out of the small box becomes a full button (#5254) The Constrain panel's small box of constraint icons was a fixed list, so dragging one onto the full-size buttons saved a new order but it was still drawn in the box. The toolbar settings now remember, per tab, which box commands were moved out; those are drawn as full buttons, the box closes up, and dropping one back on a box icon returns it. Reset Toolbar restores the default box, and settings saved before this load unchanged. * Sketch offset keeps its source lines free to turn (#4464) (#4466) * claim: #4464 * Sketch offset keeps its source lines free to turn (#4464) An offset adds a Parallel between each source line and its offset line. Since offsets became associative, the offset's points are held during a solve, so each Parallel pinned its source line to the offset line's current direction: a closed chain lost its turning freedom (8 degrees of freedom became 6), and Horizontal or an angle edit on a source line was refused as conflicting. The solver and the constructive reading now leave out a Parallel that ties an offset line to the source it follows while the association lives; the association already keeps them parallel. After Break the stored Parallel drives again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Flat Pattern view draws perforations (#4440) (#4441) * claim: #4440 * Flat Pattern view: draw perforation holes (#4440) The flat view drew the outline, cut-outs, pockets and bend lines but not perforation fields, though the flat-pattern data and the DXF export list their holes. The view now reads the hole centres from the sheet through SheetBody::perforation_holes, caches them per model state and body, and draws them as circles in the cut-out style. Holes outside the viewport or smaller than one pixel are skipped, and the cache is capped at one million holes. * "Don't Save" looks like a button in the Save changes prompt (#4380) (#4400) * claim: #4380 * "Don't Save" looks like a button in the Save changes prompt (#4380) The prompt's third action used the kit's low-emphasis text style, so it didn't read as clickable and people thought Cancel was the only way out. Add an opt-in secondary_left style to the confirm footer (a framed secondary button from the theme tokens) and use it for Don't Save. * Save prompt test: clear each frame's texture delta once it is applied egui 0.36 panics when a TexturesDelta with unapplied deltas is dropped; the test kept only the last frame's output and dropped the earlier ones. * 3D mouse test: clear the frame's texture changes, so it passes in debug builds (#4382) each_frame_hands_the_view_its_motion_through_the_drivers_mapping dropped the output of a frame it ran (`let _ = ctx.run_ui(...)`). epaint panics in debug builds when a TexturesDelta is dropped with deltas left ("Dropped TexturesDelta with 1 unapplied deltas"), so the test failed under a plain `cargo test` on every platform while the ci profile passed. It now clears them, as the other UI tests do since #60. Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Spanish (es-ES): catch up with en.json (#4292) Co-authored-by: carlymx <24634598+carlymx@users.noreply.github.com> * Esc ends the navigation bar's Pan, Orbit and Zoom modes (#4226) (#4233) * claim: #4226 * Esc ends the navigation bar's Pan, Orbit and Zoom modes (#4226) The nav bar toggled a mode on, but nothing cleared it on Esc, so a left drag kept panning, orbiting or zooming. Esc now ends an active nav mode first; the next Esc reaches the tool or dialog as before. * Keep long Select Other labels inside the popup (#4209) (#4225) * claim: #4209 * fix(ui): bound Select Other labels and expose full names (#4209) * Deleting an inserted file removes its components, placements and joints (#4100) (#4113) * claim: #4100 * Deleting an inserted file removes its components, placements and joints (#4100) A STEP or mesh file inserted into a design makes a component tree. Deleting its feature left that tree behind: the components, their occurrences, the rigid joints that hold them and the bodies' component assignments. A later body that took an imported body's name was then placed in the stale component. Document::remove_component_tree removes a component subtree and everything that refers to it: the features made inside it, its occurrences, the joints on them with their motion links, joint origins, contact set members, motion study keys and exploded moves, body component and offset entries, standard part and link records, and configuration columns. Deleting an inserted file's feature and component.delete both use it; component.delete now also removes joints left pointing at a deleted occurrence. The body transfer refusal moves with it, unchanged. * Only an inserted file's feature takes its component tree when deleted Mark the feature a STEP, IGES or mesh insert makes (`inserted`), and remove the component tree on delete only for those and for a linked design's feature. Deleting a copied component's independent base deletes just that feature, as before. Older designs get the mark as they open (pending format change), except copied components' independent bases. * Rigid joint saved with the wrong occurrence when two occurrences share a component (#3857) (#3939) * claim: #3857 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Joint dialog: a body of a further instance picks that occurrence, not the component's first (#3857) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Cancel Sketch: leave a sketch without keeping its changes (#3838) (#3938) * claim: #3838 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 * Cancel Sketch: leave a sketch without keeping its changes (#3838) sketch.cancel (Cancel Sketch, ribbon Exit group and the sketch's right-click menu) puts the design back as it was when the open sketch was created or opened for editing: a new sketch is removed with its dimension parameters, an edited one returns to how it was. It is one undo step, so Undo goes back into the sketch. The session remembers the design and the undo history at the point a sketch is entered. Cancel uses that only while the history still runs through it (the same steps before, every step since taken in this sketch); otherwise it refuses and points to Undo, so a stale entry can never throw away later work. The icon is the approved close glyph in the sketch accent (alias sketch_cancel); ja and zh carry the new label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * 3MF import: name a Bambu Studio project's bodies after its objects (#3858) (#3859) * claim: #3858 (3MF import: names from a Bambu Studio project) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3MF import: name a Bambu Studio project's bodies after its objects (#3858) Bambu Studio leaves the name off the root model's objects and keeps it in Metadata/model_settings.config (<config><object id="N"><metadata key="name">), so every object of a project came in as Mesh1, Mesh2, ... A build item whose root object has no name of its own now takes the object's name from those settings. A name in the model still comes first, and part names, other settings and objects of other model parts are left alone. The settings are read only when a body needs a name, within what the model parts left of the 1 GB budget. Settings that can't be read (malformed, nested too deeply, too large) never fail the import: the bodies keep the generic names, with a warning saying why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Viewport: right-click keeps a multi-selection of faces and edges (#3733) (#3788) * claim: #3733 * Viewport: right-click keeps a multi-selection of faces and edges (#3733) --------- Co-authored-by: AhmetV <344941595+ahmetv10@users.noreply.github.com> * Parameter import and image pickers offer their own file types (#3216) (#3314) * claim: #3216 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameter import and canvas image pickers offer their file types (#3216) Both opened the picker with no file type of their own, so it listed only designs, CAD files and meshes (and All files). macOS lets you pick only the types a filter names: CSV parameters, and PNG or JPEG images for a canvas, were greyed out. They now ask for csv/json and png/jpg/jpeg, which the picker lists first (#1801). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Return to the originating tab after finishing a sketch (#3250) (#3264) * claim: #3250 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Return to the originating toolbar tab after finishing a sketch (#3250) A sketch started from SHEET METAL or PLASTIC always ended on the SOLID tab. Remember the tab that was active when the sketch began (UiState::sketch_return_tab, not saved) and go back to it when the sketch ends. Falls back to SOLID when that is not one of the normal toolbar tabs. A sketch started from SOLID behaves as before. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Test: no one-element loop in the return-tab test (clippy single_element_loop) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * STEP import: let a cancelled import release the import slot (#3171) (#3189) * claim: #3171 * Release cancelled file import slots (#3171) * Dragging a part along its joint no longer highlights what's under the pointer (#5137) (#5140) * claim: #5137 * Dragging a part along its joint no longer highlights what's under the pointer (#5137) The viewport's hover pick was skipped during a box selection and camera moves, but not while a jointed part was dragged, so faces and edges under the pointer lit up on every frame of the drag. The pick now waits until the joint drag ends. * Browser: a body picked in the viewport is opened to and scrolled to (#3005) (#3081) * claim: #3005 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Browser: a body picked in the viewport is shown in the Browser (#3005) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Merge main; viewport::select takes a toggle flag now Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Line tool snaps a diameter through the circle centre (#4326) (#4327) A line drawn across a circle only snapped its end onto the curve, so a diameter could miss the centre at any angle. Near the centre the line now locks onto the radial line: on the rim it stays on the circle and the centre is kept on the line, and on the centre point the end lands there. * Flatpak: find the host's fonts for CJK text and the font list (#5124) (#5127) * claim: #5124 * Flatpak: find the host's fonts for CJK text and the font list (#5124) Inside the Flatpak sandbox the host's fonts are mounted at /run/host/fonts and /run/host/user-fonts, which no font search looked at. Japanese and Chinese text fell back to boxes, and the font list missed the host's families. - Search both folders for the CJK and Chinese fallbacks and for the installed-font list. - The CJK fallback reads SOLIDCRAFT_FONT_DIRS (a path list, as the font list already does), with CRAFT_FONTS_DIR kept as a fallback. * Crash reports: keep component.activate in the journal (#5079) (#5121) * claim: #5079 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Crash journal keeps component.activate (#5079) Activating a component changes only the session's active component and occurrence path, not the design, so the journal dropped the command and a crash report's replay built later parts under the previously active component. The journal now also keeps a command that changes either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Control channel and MCP on by default, with a setting to turn it off (#5561) The app opens its localhost control channel on port 27878 (or the next free one) unless Preferences > Assistant turns it off; --control and SOLIDCRAFT_CONTROL_PORT still win. A current.port discovery file lets solidcraft-cli mcp find the running app with no arguments. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Tests: moving an occurrence recomputes only the cuts and joins it touches (#4965) (#4982) * claim: #4965 * Joins and cuts follow only the placements they depend on (#4965) Tests that turning a joint between parts cuts no hole again, and that a tool cutting another part cuts again when that part moves relative to it, while an unrelated part moving keeps the result. Booleans and Combine now hash only the placements of the bodies they take as inputs, relative to the frame that evaluates them (#3397), so these pin that behaviour for joins and cuts with named targets across parts. * fix(ui): preview shortcut chords and wait for complete modifier input (#1810) Keep physical modifier events out of the ordinary-key slot, preview held keys immediately, and confirm after release and a one-second settling interval. Preserve legacy control-channel modifier behavior while allowing explicit physical Control/Command input. Add regression coverage, a UI scenario, localized guidance and documentation. Fixes #1809. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Move: scope box selection to the active component (#4459) (#4527) * claim: #4459 * fix: scope Move box selection to active component (#4459) * Delete removes a selected construction axis (#4692) (#4695) * claim: #4692 * Delete removes a selected construction axis (#4692) Delete on a construction axis skipped it with "the origin axes can't be deleted". It now deletes the construction axis feature, like construction planes; the origin axes X, Y and Z are still refused. * Agent chat: end the agent's process group where `kill` is busybox' (#4587) (#4588) * claim: #4587 * Agent chat: end the agent's process group with the system call (#4587) The group was signalled with a `kill` program: `kill -s TERM -- -<pgid>`. That works with procps' `kill` and with BSD's, but busybox' `kill` takes no `--`: it prints its usage, exits 1 and signals nothing. The agent's helpers (the CLI an adapter wraps, the MCP servers it starts) then stay alive after the agent is ended. The group is signalled with the system call instead, so no `kill` program and no shell are needed and the behaviour is the same everywhere. `nix` (MIT) is already in the tree through zip, and only on Unix: the browser build does not take it. The two tests that cover this now pass where they failed before: `agent_chat::process::tests::dropping_the_process_ends_its_group` and `agent_chat::process::tests::stopping_the_agent_leaves_no_helpers_running`. * Extrude: picking a face, vertex or parallel plane off the profile switches the extent to To Object (#2855) * Extrude: picking a face, vertex or parallel plane off the profile turns the extent to To Object With profiles picked, a face off their plane (or curved), a vertex off it, or a construction plane parallel to it is taken as the To Object target instead of another profile: the extent switches without the Extent Type choice, and the distance shows how far the target is. Coplanar faces still join the profiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Extrude: automatic To Object is a Preferences setting, off by default Preferences > Design > "Extrude to a picked target" (`extrude_auto_to_object`, default false) turns the automatic To Object on. Off, picks in the Extrude dialog only add profiles and the distance is not synced to a target, as before this change. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * FreeCAD/Rhino import: decode caps with room for detailed parts (#1783) (#3209) * claim: #1783 * FreeCAD/Rhino import: decode caps with room for detailed parts (#1783) cadmpeg decoded FreeCAD and Rhino files under its service profile, whose million collection items and 2.56e8 work units a detailed part (a sprocket, a threaded rod, a part with a few hundred faces) runs past: the import was refused with "resource limit on CollectionItems: BudgetExceeded". Allow 8 million items and 2e9 work units, half of cadmpeg's desktop profile; the input-size cap stays SolidCraft's STEP limit and every other cap stays at the service profile's. decoding_is_capped checks the two raised caps (and that they stay below the desktop profile's) and that every other cap is still the service one. Fixes #1783 * A spherical shell revolves into a solid with a void, and cuts and joins with hollow tools work (#451) (#4182) * Assembly: ground the first part; drag free joint chains (#2804) (#2805) * assembly(feat): ground first parts and drag free joint chains Ground the first top-level part when it is created and let face dragging reposition free occurrences or any member of a floating joint chain in one undo step. Preserve exact repeated-placement frames, joint values, modifier selection and Escape cancellation. Keep the accumulated fixture, viewport layout and documentation integration fixes from the existing PR. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(fix): update movable fixtures for first-part grounding Accept the documented grounded override in component creation, explicitly free movement fixtures, and keep linked clipboard pastes movable even in an empty document. Cover first and reused linked pastes, default insertion grounding, and single-step undo in the existing link tests. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): keep the motion-cost crank free Unground the first component in the document-level joint-face measurement fixture so its motion samples can rotate after first-part grounding. Preserve the rotation and shared-measurement assertions that caught the Linux CI failure. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): free the frame placement fixture Create the frame-member placement fixture ungrounded before moving it above its root sketch. Keep its world-space member assertions while respecting first-part grounding in the frame tests added on main. Signed-off-by: Karl Von Richter<karl@embeint.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> * UI: integrate theme radii, borders, palettes and viewport refresh (#5045) (#5046) * claim: #4922 * UI: let themes own corner radii * UI: use four-point panel and window radii in SolidCraft 95 * UI: align the 95 radius assertion with four-point panels * claim: #4953 * UI: let themes own structural and control borders * UI: single Blueprint outlines and dotted secondary rules * UI: separate container outlines and add theme-owned 95 bevels * claim: #5007 * UI: apply theme palettes to icons, workspace tabs and Gruvbox settings * claim: #5045 * Viewport: invalidate cached geometry colours when the theme palette changes * UI: preserve legacy theme logo colours with the borderless mark * Section Analysis: OK with no plane picked turns the section off (#2410) (#2411) While a section is on, Section Analysis opened with no plane picked now says "No plane picked: OK turns the section off." and OK runs inspect.section {"clear": true}. With no section on, OK with no plane still asks for a plane. Fixes #2410. * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * Close Change Parameters with Escape (#3372) (#3399) * claim: #3372 * Fix Escape cancellation in Change Parameters Consume Escape before parameter editors can commit pending text on focus loss, while preserving autocomplete and shortcut capture priority. Add 11 UI regressions covering draft cancellation, preview cleanup, document and history preservation, and reopening saved values. * Preserve construction references when axes and points are renamed (#4419) (#4449) * claim: #4419 * fix: preserve renamed construction references (#4419) * Browser: route body picks into open command dialogs (#2560) (#4371) * claim: #2560 * fix(ui): route Browser body picks into active dialogs * Fix midpoint picks in sketch dimensions (#4872) Retain MID snaps across both picks and materialize reusable midpoint constraints for point-to-line and point-to-point dimensions. Let midpoint pairs choose horizontal or vertical spans with pointer placement before entering a value. Cover projected model edges, overlapping geometry, helper reuse, undo/cancel/reopen, and existing angular and line-circle workflows. * Sketch slots: provide typed dimension inputs for every variant (#2423) (#4318) * claim: #2423 * fix(sketch): add typed dimensions to every slot tool (#2423) * Version 0.21.0 on main (released from rc.2's code) (#5774) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * docs(mcp): Windows setup for Claude Desktop (#3794) * docs(mcp): Windows setup for Claude Desktop (paths, two servers, Store config file) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(mcp): say the Store build can keep the config elsewhere, not that the other path fails Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * MCP: wait out long requests, honest batch outcomes, batch tool aliases (#2901) Rebased onto main as one commit (was 120d26f7, df488f9a, db9d1073 plus merges of main). - A request the app reports as still running (#1618) is waited for on the same connection through `control.pending`; past the wait the error says it was not cancelled and will still apply (or only write its file), later calls are not sent behind it, and the new read-only `pending` tool returns its result once it lands. - A failed batch says what really happened: `rolled_back` only when the design is back where the batch started (as #3288 / #3242 on main: the app's `rolled_back` is believed; for an older app, every completed step undone; only a rollback asked for is reported as one), plus `applied`, `not_run` and `failed.still_running`. - A batch step may name a tool (set_parameter, list_commands, describe_command, execute, measure, inspect_design, undo, redo, export, save, open, new_design, crash_reports); screenshot, body_topology, batch and pending are refused before anything is sent. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: driver choice, guided calibration, button mapping and a picture of the device (#1463) (#3825) * Add a small test boat to steer around with the 3D mouse A little hull in its own camera, drawn by the UI itself and not the CAD viewport, so a 3D mouse can be tried out without opening a design. It brings the model (generated by assets/models/make_test_boat.py) and the tests for how the camera moves it. Nothing uses it yet; Preferences picks it up with the rest of the 3D mouse work. * UI kit: keep a choice row from flipping with the scrollbar A choice row picks segments or a dropdown by whether its labels fit. A page scrollbar that comes and goes narrows the row by its own width, so the row could flip back and forth between the two on a page that sits right at the edge. It is now judged on the whole row and through a small helper, fits_steadily, that only changes its answer once the miss is wider than the scrollbar. Also tests for that, for typed numbers in a slider's value box, and a test hook to put up the issue-report input barrier by hand. * 3D mouse: device model, guided calibration, buttons and a picture The 3D mouse becomes a device we know something about instead of six raw numbers. The reader picks between spacenavd and the direct hidraw driver, falls back from one to the other, and says so when it can't open the device. Guided calibration asks whether the device is a spring cap or a trackball, adds a touch step, and uses a settle filter so a ball let go of stops reading as motion. Buttons get jobs (keys, held modifiers, commands), saved per device, with defaults for the SpaceMouse Pro. Preferences gets a picture of the device that moves as it does, next to the test boat, and the same picture can sit in the 3D view at Left Viewport, Right Viewport or Left Window, above the floating History card like the legend and readouts. These ride together because the crate's calibration types, the Preferences page, the Linux reader and the button hook all use each other. * 3D mouse: offer to calibrate an uncalibrated device When a 3D mouse shows up that has not been calibrated, a card in the 3D view offers to calibrate it, to swap drivers when the other one would work better, to close, or to never ask again. It is made once per device, goes away after 30 seconds in view, and gives way to a status or computing toast instead of stacking on it. The card is the shared toast, which now takes buttons: they group by purpose, wrap inside the card at narrow widths, and do nothing while an issue report holds CAD input. The picture of the device in the 3D view keeps clear of the card. * 3D mouse: translations and attribution The 3D mouse strings (ui.3d_mouse_*, the calibration steps and the offer card) in every shipped language, the Japanese catalog note, and the credit for the test boat model in ATTRIBUTION.md. This is last because the code before it only looks keys up: it builds and runs without these, falling back to English until they land. * 3D mouse: draw its preferences with the settings kit like the rest of Navigation The 3D mouse section was a folded header with its own layout. It now uses the same kit as the sections above it: a settings_section card, settings_form rows with the shared label column, dividers between the device, axes, picture and buttons groups, Text::Hint for the helper lines, and settings_control_width for the dropdowns. The section is open like every other one (the header still folds it), so the device badge on the folded header is gone; the calibration row already names the device. Every setting, string and key is unchanged. Tests that unfolded the section no longer click it, and the hint lines are looked up as hints instead of notes. * 3D mouse: show each axis's live tilt in Preferences, like main's axis rows Each view axis row is main's axis row again: a meter that follows the tilt of the motion driving it, with the dead zone marked, next to Invert, Speed and the "driven by" menu. The meter reads the calibrated travel when the device has a calibration and the raw reading over full scale when it does not, and asks for a frame whenever the reading changes. The helpers are back as they are on main, and the calibration state is a badge by the enable toggle. * 3D mouse: line its preferences up with the rest of Navigation - The two checkboxes sit side by side in the same two-column grid as Wheel and trackpad. - Row labels stop repeating "3D mouse" and use sentence case: Calibration, Driver, Restore defaults, Reset view, Left viewport, Right viewport, Left window. - Hints line up under the control column instead of the left edge. - The six view axes are named Pan X, Pan Y, Zoom, Orbit X, Orbit Y and Roll so they fit the name column. - Buttons are a divider and rows in a form like the other groups, without the bold sub-heading. - The driver, dead zone, axes, picture and buttons sit behind a collapsed Advanced section, since most people never touch them. * 3D mouse: tidy the Advanced test for clippy * Timeline: suppressing a feature keeps later features' body names (#4302) (#4311) * claim: #4302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: suppressing a feature keeps later features' body names (#4302) Bodies numbered by the counter (`BodyN`) take the next free number on every recompute, so suppressing a feature that made one moved every later counted body down one (`Body2` became `Body1`) and broke what named it, such as a Move of `Body2`. timeline.suppress now stores the current names of later features' counted bodies in their `body_names` first, as body.rename already does for a renamed counted body (#1109). Engine only: no evaluation or design-format change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: a body made while a feature is suppressed keeps its name (#4302) Suppressing a feature freed its counted name (`Body1`), so a body made meanwhile took it and became `Body3` once the feature was back. Suppress now also stores the suppressed feature's own counted names, and the evaluator adds the names stored on earlier suppressed features to the state's `reserved_body_names` (the names a rename freed, #4957), which the `BodyN` counter passes by. They are taken from the design before each feature is computed and are part of the state digest, so a cached result is only reused when they match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * cadmpeg 0.6.3: FreeCAD and Rhino import in the browser too (#4482) cadmpeg 0.6.3 is pure Rust (ruzstd instead of the zstd C library, zip 9), so solidcraft-io depends on it on every target and the wasm build reads .FCStd and .3dm files like the desktop app. The browser's file pickers offer them. 0.6.3 replaces DecodeOptions::container_only with a decode depth; ask for Geometry, what its STEP writer reads. zip 8 leaves the tree, and with it the three cargo-deny advisory exceptions kept for it. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Pattern dialogs: Quantity fields get up/down step arrows (#4260) (#4264) A new kit control, `ui_kit::count_field` / `count_row`, is an expression field for a whole-number count with stacked step arrows at its right edge. An arrow steps the evaluated count by one within the field's limits: a plain number is replaced, an expression keeps its parameters and gains or adjusts a trailing `+ n`. The text changes as typing changes it, so the live preview follows. Used by the Quantity rows of the sketch Rectangular (1-500, both directions together at most 500) and Circular (2-500) patterns, and the solid Rectangular, Circular and Path patterns (1-1000). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * Join: say so when the joined piece doesn't touch the body (#4434) (#4436) * claim: #4434 * Join: say so when the joined piece doesn't touch the body (#4434) A Join (extrude, revolve, sweep, loft, pipe, coil, primitives, thicken, boundary fill, surface network) whose material meets none of its targets still joins it to the first target as a separate piece. The result stays as it was; the feature now warns: "the joined piece doesn't touch `Body1`, so `Body1` is now in 2 separate pieces (New Body makes it a body of its own)". History marks it and the command reply carries it. The check compares pieces (outer shells, not voids) of the bodies the feature changed or absorbed before and after it, so it holds for the batched multi-profile path too, stays quiet for a join that bridges pieces or closes a cavity, and leaves Combine (which joins the bodies it is given) alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Hole: snap to face and round-edge centres, drag placed holes, section in the dialog (#2171) (#2912) Placing a Single hole put it exactly where the click landed, with nothing to line it up by and no way to move it but taking it out and picking again; the dialog was a list of size fields. - Preferences › Design › Create Hole has two settings, both off by default, so a new installation places holes as before: - Snap to face and edge centres (`hole_snaps`): the planar face under the cursor offers its middle and the centres of its round edges (a boss, a rounded corner, a hole already there) as marks; a pick near one, or on or beside such an edge, takes that centre and the mark is named. Sketch points on the face still come first; Alt or Ctrl held places it where clicked. - Move holes by clicking or dragging (`hole_moves`): each placed hole has a handle that drags it (snapping when snaps are on) and takes it out when clicked, and a pick elsewhere on its face moves it there. Edit Feature shows the handle too, so a hole can be moved later (#1047). - The Hole dialog draws a section of the hole as its options make it, with each size in a field beside the dimension it sets; a hovered or focused field lights its dimension. The layout is a new kit element, `ui_kit::figure_rows` (a caller-painted figure beside captioned fields). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Hole: place a Single hole by distances from reference edges (#37) (#2931) A Single hole can take up to two straight edges of its face as references, each with the distance of the hole's centre from that edge's line, measured in the face's plane. `solid.hole` takes them as `references: [{edge, distance}]`; the edges are found again by their persistent names, else their points, so the hole follows them when the part changes, and each distance is a parameter. A bad reference (no edge there, a curved edge, one square to the face, parallel edges, a negative distance, a centre off the face) is refused. In the Hole dialog, Reference 1 and 2 follow the face, each with its Distance row; the canvas shows each distance as a dimension from its edge to the hole, with a box just past the edge to type it in. Picking an edge measures its distance (and its box takes the keyboard), typing one moves the hole, and moving the hole measures them again. Edit Feature picks the edges again with their distances. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> Co-authored-by: Frank <58932224+plexi32@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: raykholo <raykholo@users.noreply.github.com> Co-authored-by: CamWight <91156642+CamWight@users.noreply.github.com> Co-authored-by: SS-EN <84559909+SS-EN@users.noreply.github.com> Co-authored-by: Colin Faulkingham <colin.faulkingham@gmail.com> Co-authored-by: Karl Von Richter <karl@von-richter.net> Co-authored-by: HiroKenEz <59478073+HiroKenEz@users.noreply.github.com> Co-authored-by: Peppe Bergqvist <p@bergqvi.st> Co-authored-by: GitHub Copilot <noreply@github.com> Co-authored-by: phanoob <lesur.Stephane@wanadoo.fr> Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Kai Evans <nemshilov@gmail.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Tyler Chiriboga <tylerchiriboga.apps@gmail.com> Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: CaRLymx <carlymx@gmail.com> Co-authored-by: carlymx <24634598+carlymx@users.noreply.github.com> Co-authored-by: Loohi <78334654+Loohi@users.noreply.github.com> Co-authored-by: leValdemar19 <valdemarnord@hotmail.com> Co-authored-by: AhmetV <mihendiz10@gmail.com> Co-authored-by: AhmetV <344941595+ahmetv10@users.noreply.github.com> Co-authored-by: rlartot <94693724+rlartot@users.noreply.github.com> Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Thodoris Tsagkogeorgas <thodoristsagko@gmail.com> Co-authored-by: ahmetalpcelik <80778880+ahmetalpcelik@users.noreply.github.com> Co-authored-by: ealitt <ealitt@gmail.com> Co-authored-by: Homero Thompson <vdirienzo@gmail.com> Co-authored-by: Diogo Soares Rodrigues <dsrodrigues20@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Artem Sushchev <Suschev.Artem+github@gmail.com> Co-authored-by: Nathan Dane <nathandane.dev@gmail.com> Co-authored-by: Kai Evans <hi@kaievans.co> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cronos <crono2250@users.noreply.github.com> Co-authored-by: rbousigues88 <rbousigues@gmail.com> Co-authored-by: The Nomad <nomad@positron3d.com> Co-authored-by: Jackson Oursland <jacob.oursland@gmail.com> Co-authored-by: Jacques <59315319+Jacquesvdberg92@users.noreply.github.com> |
||
|
|
24c9d14663 |
GPU: adapt dispatches and retire lost devices (#5754) (#5755)
* claim: #5754 * fix(gpu): adapt dispatch size and retire lost path devices (#5754) Start with a 64-item quantum and adapt bounded work toward 20 ms from observed completion, including denoiser tiles. Never exceed 16384 work items; hardware-specific shader cost means this is not a universal TDR guarantee. Publish device loss/uncaptured failure/poll failure through live executor availability without reinitializing automatically. Source-pinned required-Vulkan GPU suite: 105 passed, zero failed, three existing ignores, including actual device.destroy retirement and session availability. Strict GPU/engine all-target Clippy passes. Broader engine and repository/WASM continuation remains separately recorded. No geometry baseline, CI rule or published format history change. |
||
|
|
934d4ddae2 |
Render: defer path-host startup until first use (#5742) (#5743)
* claim: #5742 * fix(render): defer GPU path initialization until first use (#5742) Retain the selected adapter factory during Design/safe-mode startup; instantiate once on first Render entry, including late viewport installation. Preserve the deferred/preparing/ready/failed state across document changes and retain selected fallback adapter policy. Exact tree passes 32 render-workspace and 1966 full UI tests (0 failures; 7 existing ignored), strict native all-target Clippy, wasm check and repository gates. Three wasm warnings remain in untouched upstream files. Fresh native desktop acceptance is separate and in progress; no whole-renderer/main sign-off implied. |
||
|
|
7a81a7fc15 |
library: transport PBR and engineering cards without lossy copies (#1086)
* wip(library): reconcile exact rich-catalog replacement semantics (#1062) Source-only scoped extraction from original 0f801962 / #1086 on the refreshed #1060 card prerequisite. Preserve current asynchronous picker guards and source-ID handles. Scalar v1 and rich-v2-without-PBR clear existing PBR; supplied rich PBR is retained. No new saved concept or duplicate card descriptor. Formatting and source review completed; compile/native acceptance is still pending. * test(library): preserve explicit downgrade and fallible UI regressions (#1062) Request scalar v1 explicitly in the card downgrade refusal regression; rich v2 remains the default lossless writer. Propagate fallible harness actions with ? in the shared clicked-catalog helper, preserving all assertions. No production code, limits or ignore changes. Fresh grouped IO/engine/UI tests, scoped strict Clippy and WASM pass on this exact tree. |
||
|
|
47a1459060 |
Sync current main into render, preserving release and viewport changes (#5705)
* Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * Viewport: whole-body highlights reuse the model's own triangles (#4554) (#5109) Hovering or selecting whole bodies -- a browser row, a History group, a body under the pointer in body-pick mode -- built a CPU copy of every body's triangles into the highlight scene. On a 40-body 4.3 MB STEP assembly that was 147 bodies, 70 MB of triangle copies and a 519 ms frame. The model already has the same geometry on the GPU. The highlight now names it and the renderer draws it again in the highlight colour: - bodies drawn from a display plan: the model's evaluated plan chunks, with a hover/selection tint uniform (the chunks stay resident in the model scene); - bodies drawn as placements of shared triangles: the same placements of the model's shared triangles, coloured per instance; - bodies the model builds on the CPU: their vertex range in the model scene's block. See-through and faded bodies keep the CPU feedback, which colours them; faces and edges highlighted on their own are unchanged. The highlight looks the same (verified side by side). On the assembly the highlight build drops from 519 ms to 9 ms and no longer copies any triangles; selecting the whole assembly takes 9-20 ms. Co-authored-by: Claude Code <noreply@anthropic.com> * Offer to stand up SolidWorks files instead of turning them silently; add Turn Up Axis to the component menu (#5655) Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Sketch on a picked origin plane uses the plane shown after standing an import up (#5659) * Sketch on a picked origin plane uses the plane shown, also in a moved component After a STEP file opens its component stays the active one, and standing it up turns that component a quarter about X. Starting a sketch on XY picked in the viewport then sent `{"plane": "XY"}`, which names the active component's own XY: upright after the stand-up. The sketch landed on the world XZ, Look At turned to face Y and the extrude went along Y. The viewport and browser only show the design's origin planes, so a picked origin plane now goes to sketch.create written out as that world plane while the active component is moved; sketch.create maps it into the component's frame once. The flip toward the viewer uses the same plane. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Stand-up axes tests: stand the file up through the offer when one is waiting #5655 offers to stand up SolidWorks files instead of turning them silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * gpu tests: give the two test frames the new hover and selection tints (#5698) #5109 added Frame::hover_tint and selection_tint; two test frames that landed alongside it didn't set them, so solidcraft-gpu's tests stopped compiling on main. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Release 0.21.0-rc.2 (#5691) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jackson Oursland <jacob.oursland@gmail.com> Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
ee5ca2430b |
feat(render): expose independent anisotropic GGX core (#1694) (#1699)
Extract the original numerical source and analytic tests from published #1698 at
|
||
|
|
e3d7cbe830 |
Merge pinned main into the shared render integration
Synchronize official main |
||
|
|
e3c9f22ead |
GPU path tracing: use compatible Vulkan adapters (#3306)
Land the final Vulkan-only path-executor policy after #2191 under the #5493 constituent route. Fixes #3217. Fresh quick run 40012565783 passed. Preserve adapter/software policy and CPU fallback; no DXC dependency or workflow changes. Full native/hardware acceptance and final jyviko sign-off remain separate. Co-Authored-By: Christian Svensson <blue@cmd.nu> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
c6cbde3706 |
Render: studio lighting, clear coat and glass on GPU (#2191)
Integrate the original studio renderer after the GPU executor and async UI foundations, under #5493. Fresh render-target quick run 40011408339 passes. Preserve attribution, bounded resource admission and documented glass/denoising limits. Historical native benchmarks retain their source pins. Full renderer-to-main CI and jyviko sign-off remain separate. Co-Authored-By: Christian Svensson <blue@cmd.nu> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com> |
||
|
|
30449418ac |
Render: progressive GPU path-tracing executor (#2067)
Land the unchanged contributor GPU foundation into render under the maintainer policy in #5493. Fresh quick gate 39993339605 passed. Original author and co-author attribution retained; no workflow file changes. Final render-to-main CI and jyviko sign-off remain separate. Co-Authored-By: Christian Svensson <blue@cmd.nu> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
95a56ca00e |
Persist validated engineering cards independently of mass and optics (#1060)
Render constituent under #5493. Fixes #1048. One pending material-engineering-cards descriptor, immutable released migrations, independent assigned density and source conditions. Nine persistence and ten physical-card regressions plus the fresh quick gate pass. Additional native follow-up is reported separately; no full-stack acceptance is implied. |
||
|
|
4b42ef50c7 |
Mesh leftovers from the ribbon redesign (#133) (#4471)
* claim: #133 * mesh: Save As Mesh declares the panel that shows it (#133) The ribbon redesign (#2176) removed the MESH tab, but three things still pointed at it: - `file.save_mesh` declared `.at("MESH", "MODIFY")`. The command inventory prints the placement a spec declares, so `docs/features.md` advertised a `MESH > MODIFY` location no ribbon has. Its real home is already INSERT / FILES (`SECTIONS` lists it), so the declaration now agrees with the ribbon; `destination()` resolved it there before and after, so nothing moves on screen. - The user guide sent people to "the Mesh tab under Modify" for Save as mesh. - A test now refuses any command that declares a tab the ribbon removed, and pins where Save As Mesh lives. `PLACEMENTS` keeps its MESH entries: those migrate toolbars users saved under the old panels, which is a different question from what a spec declares. --------- Co-authored-by: Geraldrunion <geraldrunion@users.noreply.github.com> |
||
|
|
3ed1829cc7 | fix: retain circular sketch pattern Quantity expressions (#4435) (#4607) | ||
|
|
e33c371e99 |
Model cache: thin the checkpoints of a design too big for its file instead of leaving the cache out (#3220) (#4882)
* claim: #3220 * Model cache: keep fewer states of a design too big for its file instead of none (#3220) A model cache over the container's budget keeps the final state, then the slowest features' states while the bodies they add fit (a body several states hold counts once), and is left out only when not even the final state fits. Opening evaluates just the features whose state the file left out, each from the state before it, so the model is whole afterwards. * Model cache: keep each encoded body apart, copy only what a cache stores Encoding a model too big for its file no longer copies every distinct body into one buffer before thinning: the payload is copied from the encodings once its size fits, so saving holds no more than before. * Model cache tests: canonical runs in the timeline fixture; rustfmt * Model cache: count the records a thinned cache keeps; always try the final state Thinning counted only the bodies, so a model of many copies of one part (records, not bodies, filling the room) shrank its budget to nothing and saved no cache although its final state fitted. The choice now counts the records of what it keeps, always keeps the final state, and says what it counted, so each retry keeps less and the final state alone is always tried. * docs: a thinned model cache counts its records and always tries the final state * Model cache test: the slowest feature's state holds bodies 16 to 23 * Model cache: thinned opens with fingerprints that read the state before a feature Since #3397 a feature's fingerprint reads where the bodies before it lie. After a state the file left out, adopt takes the saved fingerprint and the evaluation that works the state out checks it. A result evaluated ahead is never taken as one the file left out. The thinned round trips include the placed components' design, whose cut reads those placements. --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
dad28abecf |
solidcraft-cli bench-assistant: the standard Assistant model test (#4851) (#4930)
* claim: #4851 * solidcraft-cli bench-assistant: the standard Assistant model test Runs the eleven v1 tasks of #4851 against a desktop app that is already running with a control port. Each task starts a new design and a new chat with All permissions, runs only the prescribed setup, sends the prompt once and waits for the turn. The result is checked on the design (document.inspect with measurements): body count, volume within 1% (0.3% for the fillet), bounding-box size in any orientation, the lowest corner, the body name, live feature kinds, and changed or unchanged content; the volume question is checked on the reply. Failures get the issue's categories from the conversation's items. Prints a table, and writes the issue's comment template (--markdown) and the raw results with each conversation (--json). |
||
|
|
36a354e3a7 |
Agent chat: serve the bundled skills' reference through an MCP tool (#4966) (#4970)
* claim: #4966 * Agent chat: serve the bundled skills' reference through an MCP tool (#4966) The bundled skills start with "read reference.md", but SolidCraft's own chat turns the agent's file tools off, so its agent could not follow them. The MCP server gains a read-only `skill_reference` tool that returns a skill's documents from copies built into the binary. It takes a skill name and a file name from a fixed list, never a path, and refuses an unknown skill or file with the available ones. The skills point to it, and docs/mcp.md and skills/README.md describe it. |
||
|
|
80fd2fbbf1 |
Assistant: add Anthropic-compatible API agents (#5015) (#5017)
* claim: #5015 Co-Authored-By: Claude Code <noreply@anthropic.com> * Assistant: add Anthropic-compatible API agents (#5015) The Add agent wizard now offers Anthropic-compatible endpoints beside OpenAI-compatible ones. The API backend speaks the Anthropic Messages protocol with the same MCP bridge, tool gate, limits, undo and keychain rules: x-api-key and anthropic-version, a top-level system note, input_schema tools, content-block answers and one user tool_result message per round. Test sends a short message because compatible endpoints (Qwen's) need not list models. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com> |
||
|
|
9852a2e758 | Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] | ||
|
|
2dc31a30d4 |
Extract to File: move a component into its own linked design (#5113)
The component's sketches, features, bodies, subcomponents, the joints among them and the parameters they use move to a new .solidcraft design, keeping their ids and names, and the component becomes linked to it as Insert Design makes it. The new design must build the same bodies and the assembly must look the same afterwards, else nothing changes and no file is written. Joint faces on the component are found again on the linked bodies, and components that build the same bodies can become placements of the link. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ae3b36ac88 |
Agent cursor follows the agent's own pointer input (ui.move, ui.click, ui.drag, ui.scroll) (#5162)
The agent cursor only acted out engine commands: pointer input sent over the control channel reached the app as synthetic events without moving it, so an agent's clicks, right-clicks and drags were invisible to a person watching. While the cursor is shown, each synthetic pointer event now moves it to where the input lands, a press leaves a ripple, and a drag is followed step by step. A request being acted out keeps the pointer; with the cursor hidden nothing changes. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b6a45b8278 | Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] | ||
|
|
63d81cc096 |
Motion Trace: regenerate kept curves only when inputs change (#5248) (#5270)
* claim: #5248 * feat(motion): regenerate kept traces when source inputs change * feat(motion): add a parametric Chebyshev trace demo * perf(joints): reuse face measurements across motion samples Face-centred joint origins called Body::faces on every solve, bypassing the reference-mesh reuse used for rigid placements. Share face measurements with unchanged model geometry at the existing tolerance, while guarding replaced bodies and applying offsets after the cached measurements. Cover repeated named/nearest-face solves, shape edits, retained snapshots and direct replacement with deterministic work counts. The 145-point Chebyshev dimension and range updates retain identical sampled and interpolated curves. * perf(naming): skip preparation for cached face names Both face lookup paths spawned fresh workers over every body even when their name cells were ready. Prepare only cold cells, with direct handling of zero or one cold body. Preserve the existing parallel naming path and all face selection semantics. Deterministic regressions cover repeated picked and unique-name lookups, misses, partial warmup, renames, snapshots and moved copies. Release Chebyshev medians fall from 859 to 50 ms for a dimension edit and 871 to 34 ms for a sweep edit; all 145 samples and interpolated points remain identical. Full cargo xtask ci passes with RUST_TEST_THREADS=4 and the existing local Windows validation overlays. |
||
|
|
94279fe059 |
Web: Ctrl+Tab and Ctrl+Shift+Tab switch browser tabs again (#5227) (#5350)
* claim: #5227 * Web: leave Ctrl+Tab and Ctrl+Shift+Tab to the browser (#5227) eframe cancels the default action of every Tab keydown on its canvas (egui moves focus with Tab), so browsers that let a page cancel their shortcuts, such as Vivaldi, could not switch tabs while SolidCraft had the keyboard. A capture listener on the window now stops Ctrl+Tab and Ctrl+Shift+Tab before they reach the canvas, without cancelling them, so the browser acts on them as usual. Plain Tab and Shift+Tab still move between the app's fields. Desktop builds are unchanged. web-api-test checks it in headless Chrome: Ctrl+Tab and Ctrl+Shift+Tab keydowns are not cancelled, Tab still is. --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
867df396ea |
Agent chat in the Flatpak says why no agent is found and how to allow one (#4765) (#4769)
* claim: #4765 * Agent chat: explain the Flatpak sandbox when no agent is found (#4765) In the Flatpak the sandbox has no home-folder or network access, so agents installed through nvm or ~/.local/bin are never discovered and the chat only said that no agent was found. With FLATPAK_ID set and nothing discovered, the picker and Preferences > AI now say why and offer the exact `flatpak override --user ai.storyteller.solidcraft ...` command with a Copy button. The message is in every catalog, and docs/agent-chat.md gains a Flatpak section listing what each permission is for. The manifest is unchanged. |
||
|
|
edf57cec29 |
Stand up Y-up STEP and IGES files from SolidWorks automatically (#5191)
* claim: #5150 * Stand it up: don't offer it for SolidCraft's own STEP files (#5150) STEP replies from file.insert_step and doc.open now carry the file's originating system, and the window skips the stand-up offer when it is exactly SolidCraft, as SolidCraft's STEP export writes it. * Stand up Y-up STEP and IGES files from SolidWorks automatically The STEP header (originating system, preprocessor version, FILE_DESCRIPTION) and the IGES global section's native system ID say which program wrote a file. A SolidWorks header means Y up: the import's component is stood up as it opens, as one undo step, and the message offers Undo. SolidCraft's own files are left alone; an unknown exporter keeps the offer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Ray <raykholo@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
0c72ad56d2 |
An idle window draws nothing with the frame-rate readout on (#5165)
The viewport's frame-rate readout asked for a new frame every frame, so with it on an untouched window redrew as fast as the display allowed and kept the GPU busy: 77% GPU at 60 fps on an M1 with a 5K display showing the sample, against 0% with the readout off. It now asks for no frames of its own and shows how often the view really draws; one frame a little over a second after the frames stop shows the view idle at 0 FPS. The preference's note no longer says the view redraws continuously. The status toast also asked for a frame every half second for the six seconds it shows; it now asks for one frame, when it is due to go. |
||
|
|
92d3a2fde5 |
GPU: a lost device stops drawing instead of crashing (#4172) (#4229)
* claim: #4172 * GPU: a lost device stops drawing instead of crashing (#4172) After the driver resets the GPU (Windows TDR), the first queue write to meet the lost device panicked inside wgpu-core (PendingWrites::activate unwrapping DeviceError::Lost). Nothing watched the device for its loss. - egui-wgpu: RenderState::device_lost (DeviceLost) is set by the device's lost callback. The painter draws nothing on a lost device, and before a frame's uploads it submits nothing (DeviceLost::probe), so a loss the driver reports is found by that submission instead of the first write. - Pictures (thumbnails of saves, ui.render) watch the same flag: on a lost device the capturer refuses with GpuError::DeviceLost without touching it, and the picture comes from the CPU rasterizer. Headless capturers watch their own devices. - The app, seeing the loss, closes keeping unsaved changes for recovery (as a forced quit does) and starts again; the new start says what happened. A second loss within ten minutes starts on the software renderer. The loss is noted in the crash journal. |
||
|
|
971b28c982 | claim: preferences redesign (#4608) | ||
|
|
f79cbc216c |
Redesign the home page as the File view (#2027) (#3822)
* claim: #2027 * Redesign the home page as the File view (#2027) * Match the File view with the accepted component design (#2027) * Restore the Start subtitle and simplify the recovery icon (#2027) * Integrate File view with main's shared UI containers |
||
|
|
4b23bb3a03 |
Implement compact workspace layout (#2029) (#4533)
* Vertical history strip: left of the browser, compact rows, hollow-circle marker, collapsed rail hover * Vertical history strip: seam handle to expand and collapse names, drag to resize with snap * Vertical history strip: no empty gap below the transport * Show the history seam arrow only on hover (#2028) * claim: #2021 * Redesign the Assistant chat panel with shared UI components * Show Assistant in the shared floating panel shell * Extend floating Assistant to viewport height and shift navigation * Dock Assistant before history and match docking preview bounds * Align Assistant top margin with floating shell cards * Extract a shared panel drag grip * Rebuild responsive history sizing and three-way docking * Share browser and History collapse hover styling * Show the History title as soon as its text fits * Animate stacked browser and History expansion and collapse * Make panel folding responsive and independent of frame delays * Let folding panel contents shrink continuously to header height * Use four explicit History transport actions in every layout * Resize the shared Browser and History column from either card * claim: shared compact-mode containers (#2029) * Centralize layout-aware UI containers and enforce their use * Keep docked Assistant at the outer edge beside tool sheets * Use shared surface policy for Assistant tool space * Let tool sheets drag over shell panels while avoiding Assistant * Update Parameters drag bounds assertion for shell overlap * Keep dragged tool sheets below ribbon and workspace selector * Enforce universal UI containers in mandatory repository checks * Remove legacy report windows and require shared window composition * Remove retired UI styling and require shared controls * claim: compact layout preference (#2029) --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
920398ac53 |
Bring back the view-change glide; orbit, pan and zoom stay instant (#4596)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
b49557c294 | Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] | ||
|
|
dfd58293a6 |
Navigation: opt-in free orbit and shared Normal to Selection (#1912)
* Navigation: opt-in free orbit and shared Normal to Selection Preserve the complete reviewed feature, shared camera setting propagation, rigid pivot behavior and focus/drag regressions from PR #1912. Consolidate the prior main-integration commits before rebasing, so their merge-resolution fixes remain in the linear feature history. * docs: move free orbit help beside viewport controls * Merge main into fix/solidworks-free-orbit Camera animation is gone on main, and with it the orbit snap spring: the Shift snap keeps its unsnapped orbit in orbit_free, which the free-orbit checks now read. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
ba4f7864ff |
Export Current View as DXF includes shown sketches (#3708) (#3780)
* claim: #3708 * Export Current View as DXF includes shown sketches (#3708) The view export refused a design with only a sketch and left shown sketches out when bodies were present. It now draws the sketches the viewport shows (profile curves only: no construction geometry, points, dimensions or constraints) on a SKETCH layer, one entity per curve. Finished sketches are hidden behind bodies through the body-edge occlusion; the active sketch is drawn on top, as in the viewport. Sketch points use the same projection, budgets and cancellation. The export is refused only when there is neither a visible body nor a shown sketch curve; the dialog and the command share that check (cmd::view_dxf_exportable). --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
b289dc2421 |
Sketch Dimension: name = value defines a user parameter (#2916) (#3638)
* Sketch Dimension: `name = value` defines a user parameter (#2916) In a dimension's value (the D tool's box, and `sketch.dimension`'s `value` from scripts, the CLI, MCP and the control channel), `name = expression` adds the user parameter `name` with that expression and dimensions with `name`: typing `width = 40` on a line gives a 40 mm user parameter `width` and a dimension whose expression is `width`. A bare number is read in the design's unit, as a bare dimension value is; an angle's parameter is in degrees. The expression may be anything the parameter editor takes. It is one command: one undo removes the parameter and the dimension together, and a dimension the sketch refuses leaves no parameter behind. A taken name is refused with a hint (type the name to use it, or change it in Parameters), a reserved name with the parameter editor's message, and a left side that is not a name (`2 = 3`) still fails to parse as before. A driven dimension defines nothing. The reply carries `defined`, and the status line names the parameter. The splitter lives in the doc crate (`expr::definition`) so other value inputs can take the same form later; editing an existing dimension, the inline shape boxes and feature dialogs are follow-ups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension: say why a name is refused, in the command's own words (#2916) The dimension editor showed a refused definition raw, in the box and the status line: "invalid parameters for `sketch.dimension`: value: `mm` is a unit, constant or function name". It now reads "Sketch Dimension: `mm` is a unit name, so it cannot be a parameter name": the editor passes the command's errors through `friendly_error` like every other command, and drops the `value:` field tag, since the box is the value. The taken-name hint reads the same way: "Sketch Dimension: there is already a parameter `w`: type `w` to use it, or change it in Parameters". A reserved name says what kind of word it is and what that means (`param_name_problem`, shared with the Parameters dialog): a unit name, a function name, or a constant, "so it cannot be a parameter name"; `expr::reserved_kind` tells them apart. `friendly_error` translates the command label with the interface language (the engine's sentence stays English), so the prefix reads "Wymiar szkicu:" in Polish. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension test: keep the third line off the ribbon (#2916) On current `main` the ribbon floats over the top of the canvas, and the test's third line at sketch y = 50 projected under it: the click opened Parameters instead of picking the line. The line now goes below the first one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
84ec512d7a | fix: midpoint tool rejects two lines (#3836) | ||
|
|
17ece2edc0 | Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] | ||
|
|
63f210b49f |
Restyle the vertical history sidebar (#2028) (#3953)
* Vertical history strip: left of the browser, compact rows, hollow-circle marker, collapsed rail hover * Vertical history strip: seam handle to expand and collapse names, drag to resize with snap * Vertical history strip: no empty gap below the transport * Show the history seam arrow only on hover (#2028) * Extract a shared panel drag grip * Rebuild responsive history sizing and three-way docking * Share browser and History collapse hover styling * Show the History title as soon as its text fits * Animate stacked browser and History expansion and collapse * Make panel folding responsive and independent of frame delays * Let folding panel contents shrink continuously to header height * Use four explicit History transport actions in every layout * Resize the shared Browser and History column from either card |
||
|
|
5e05d925e0 |
Tapped Hole: keep Custom selection and edit nominal diameter (#2440) (#2441)
* claim: #2440 * feat: choose ISO metric tapped-hole sizes and derive the drill diameter * fix: label the tap drill and hide the unused diameter editor * test: cover tapped hole catalogue and drill sizing * fix: omit coarse metric pitch from generated designations * Keep custom tapped-hole nominal diameter and pitch editable Preserve Custom as dialog state, derive the existing metric designation from numeric inputs, and refuse invalid drafts without applying the last valid size. Retain manual text editing, physical tap-drill geometry and saved-design compatibility. * fix(i18n): register custom tapped hole labels in source catalogs * Adapt tapped-hole Custom fields to the current form kit * fix: preserve tapped designation focus with dynamic custom rows |
||
|
|
cb3cabeda1 |
Remove camera animation: every view change and orbit applies at once (#4296)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
93a2922c5e |
Display plans and the model cache for large STEP assemblies (#2814) (#4021)
* STEP import: mesh band faces that wrap around a closed surface correctly Fixes two related bugs that caused SolidCraft to fail to mesh a face wrapping all the way around a closed, non-periodic surface (a revolved ridge band, or a tube-shaped B-spline surface): a missing face, a folded/self-overlapping triangulation, or a hole in the rendered body. 1. Ring edges that run slightly off their surface. STEP files write a surface and the curves bounding it to the file's own declared uncertainty, so a ring edge can legitimately sit a few micrometres off the surface it bounds. The code finding where a ring edge crosses the planned split line compared against the edge's raw (off-surface) point using a hardcoded tolerance far stricter than the file's own precision, rejecting a valid cut. Now matches against the point on the surface directly below the ring crossing, respecting the file's declared tolerance. 2. Closed B-spline surfaces, their slits and their slivers. truck only treats the rotation of a revolved surface as periodic; a face on a B-spline surface whose control net closes on itself (a tube) wasn't recognized as wrapping around at all. This produced a folded face, a hole (a boundary loop landing a full period away from where it should cut), and one near-zero-width sliver face costing the entire body its tessellation plan. Adds periodicity detection for closed B-spline surfaces, period- aware hole-loop alignment, dropping of zero-width slit boundaries, and isolating a too-thin-to-triangulate face so it no longer takes the rest of the body down with it. The GPU shader's periodic wrap mirrors the CPU math so the two don't drift apart. Regression tests: band_faces_split_when_ring_edges_run_off_their_surface, band_face_with_a_zero_width_slit_is_still_meshed, a_sliver_face_too_thin_to_triangulate_does_not_cost_the_body_its_plan. Ablation-tested: disabling either mechanism in (2) reproduces its target test's original failure message while leaving the other test unaffected. * STEP import: mesh the band's split faces, not just split them jyviko asked whether a band wall missing from the interactive app's render was a shading issue or a genuinely missing face. It was missing: the ring- edge split fix made the band's topology correct, but plan_face still produced zero triangles for the two new sub-faces. Two causes, both in plan_face (crates/kernel/src/tess/mod.rs): 1. The tolerance for how far an imported boundary may lie off its surface was tied to the requested mesh's chord tolerance instead of to the body's own size. A finer display tolerance could then reject a boundary a coarser one had just accepted, so the face would drop out exactly when zooming in on it. 2. Near a sharp corner of this flat-panelled band, several boundary points that are legitimately a few micrometres apart (within the STEP file's own declared precision) all projected onto the same surface point. The boundary loop then repeated a point in (u, v), which a triangulator can't follow, so the face's plan failed outright. One face without a plan costs the whole body its plan, and the fallback mesher can't handle a closed B-spline surface either, leaving both halves of the split band with no triangles at all: present in the topology, invisible in every renderer, and absent from the body's volume. Fix: scale the off-surface tolerance to the body's own extent (new Rules::extent), and collapse a run of boundary nodes that land on the same surface point to one (drop_collapsed) before triangulating. Regression test additions to band_faces_split_when_ring_edges_run_off_their_surface: the body's volume now matches the analytic pentagon prism (was a third of it - only the top cap - before this fix); display_plan leaves no face without triangles from coarse to fine tolerance; and the actual tolerance and facet angle the viewport draws with gives the split band its full lateral area on both halves. Confirmed on review_band_big.step, the fixture behind the review screenshots: volume's relative error against the analytic pentagon prism drops from 1.4e-4 to 4.1e-6, and the band wall now occludes the floor grid behind it in a snapshot the same way the top and bottom caps always did. Full kernel suite: 739 tests, 0 failed. * STEP import: hold an imported boundary to the file's own tolerance, not the part's size jyviko: the off-surface acceptance added in the last commit (rules.extent * OFF_SURFACE) scaled with the part, so a 2 m part silently accepted a boundary 2 mm off its surface while a 20 mm copy of the same part accepted only 0.02 mm. A STEP file's own declared uncertainty does not grow with the part, so the bound shouldn't either. Body gains boundary_tol: Option<f64>, Some(file's declared tolerance) for a body read from STEP (crate::step_in::Units::tol, already used by the ring-split fix in split.rs), None for anything this kernel built. It's set before the import's own unmeshed-face check runs, and carried over by the two face-split operations that re-cut an imported surface (splitface.rs, outline.rs), since the file's uncertainty still describes those boundaries afterward. plan_face's accept now reads: the file's own tolerance when the body declares one, or the old chord-tolerance/extent bound otherwise. The old bound's tol * 10.0 term had to go too, not just the extent term: at a 2 m part's typical display tolerance that term alone is ~20 mm, nearly ten times the extent bound jyviko objected to, so keeping it would have left the exact 2 m/2 mm example still silently accepted. Two new tests in step_in/tests.rs: - band_faces_split_when_a_scaled_copy_runs_off_its_surface: the same band fixture at a realistic 2 m scale with the same absolute slop and declared uncertainty as the small one, meshes the same way at every chord tolerance from coarse to fine. - off_surface_budget_follows_the_file_not_the_part_size: the actual regression. The same off-surface error is accepted or refused the same way whether the part is 20 mm or 2 m; a 2 mm error against a 1 µm declared uncertainty is refused at both sizes now (accepted at 2 m under the old bound, refused at 20 mm - that asymmetry was the bug). Checked at both a coarse and a fine display tolerance. Known gap, not fixed here: a STEP-imported body saved into a .solidcraft design and reopened loses boundary_tol (native.rs's decoder has no field to read it from) and falls back to the old extent-based bound on reload. Today's design format has no concept of this value at all; persisting it is a real format change, out of scope for this fix. Full kernel suite: 776 tests, 0 failed. clippy -D warnings clean. * Display plans for STEP threads and pointed ends (#3847) Three faces cost a threaded or pointed STEP part its whole display plan, so it was drawn from the reference mesh: cracked, faceted, and never refined up close. - A loop through a pole (a cone's apex on the boundary) seemed to wind around the surface: the jump at the apex, unwrapped to the nearest copy, was arbitrary. The loop is turned to end where it leaves the pole, so the step that closes it is an ordinary one (`seam::close_through_pole`). - Projection onto a spline with hundreds of spans (a helical flank) restarted from a 16 x 16 grid and settled on another turn; it now starts from two points per span, capped. - Sag refinement no longer inserts a point exactly on a boundary side, which split the side and failed the face. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * tess: a refused face's edges are divided finer and it is planned again (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * tess: sliver faces plan empty; a face no method plans is filled flat from its nodes (#2814) A face whose boundary runs out and back along itself (two edges between the same vertices, a rounding apart, as STEP files write slivers) encloses nothing and is planned with no triangles. A face still refused after its edges are divided finer (a cusp, a sliver whose sides sag across each other, a small cap at a pole) is filled flat from its shared boundary nodes, so the rest of the body keeps its display plan instead of falling back to the reference mesh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * display mesh tests: a rim the chord tolerance leaves a line is divided again (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * portable B-rep: up to 8192 control points along a spline direction (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * solidcraft-cli: --debug logs what the engine reports to stderr Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * STEP import: a spline written over a tiny parameter range is read over one (#2814) Some writers parameterize splines over a few millionths (a humanoid robot's edges span 5.4e-6). The kernel tells parameters apart only to 1e-6, so over such a range it evaluated the curve's end wrongly, and trimming an edge to its vertices dropped a control point: the bodies could not be stored exactly and the whole model cache was left out of the design. The knots are now stretched to span one; the curve is the same and edges are trimmed by their vertices, so nothing read from the file refers to the old parameters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * model cache: a body keeps its file's declared accuracy (#2814) A body restored from the cache dropped the accuracy the file it was read from declares, so the planner held its boundaries to the kernel's own bound and a reopened design drew differently from the import. It is stored with the body's runtime values, and only when there is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * tess: a boundary within a hundredth of its body lies on its surface, at every quality (#2814) #1721 held a body read from a file to the accuracy the file declares. A writer declares what it aims for, not a bound its edges keep: a 251-body robot assembly declaring 0.01 µm has boundaries 10 to 30 µm off their surfaces, and 95 of its bodies lost their display plans. The bound is a hundredth of the body again, what Normal quality always allowed, and now the same at every quality, so zooming in still never drops a face (#1721's point). A file declaring more raises it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * STEP import: keep faces whose edge vertices sit slightly off their curves Some exporters write an edge's vertex beside the end of its curve, further off than the accuracy the file declares (a surface export declares 0.01 mm and puts a vertex 0.19 mm off two spline ends). The reader refused such edges and left the face, and with single-face bodies the body, out. A vertex may now sit up to the file's tolerance or 1/1000 of the model's size (the diagonal around its VERTEX_POINTs), whichever is larger, never more than the existing 1 mm ceiling. Spline and open-conic edges have the end control point moved onto the vertex, so every such edge meets its vertices exactly. The file's declared accuracy still governs closed-curve, seam and circle checks. * tess, io: review clean-ups (#2814) - A sliver face is one whose loops are all slit: drop_slits finds it in the retry after a failed plan, so the pre-check on every face (folded) is gone. - The flat fill uses cdt::triangulate (a lenient fill that leaves out sides crossing one already kept) and its flood-fill inside test, and the plane from geom::Plane. - Refinement only builds its indexes when a face was refused, takes the faces to plan again from edge_faces, and re-samples edges on the pool; Rules::finer for the finer rules. - One PackageWriter::fits for the model cache, the preview and the thumbnail. - The band split's ring tolerance lives in split.rs; comments say what the off-surface bound is now. - The CLI logger prints Level::as_str(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM --------- Co-authored-by: David Lackovic <lackovicdavid1234@gmail.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Ray <raykholo@users.noreply.github.com> |
||
|
|
776541b081 |
Agent commands compute off the window thread, so the window stays live (opt-in) (#1989) (#3340)
An agent's design changes over the control channel (engine.execute, engine.batch) are evaluated ahead on a copy of the session on an `agent` worker, then run on the window thread reusing every feature computed there (doc::KeptResults, whatever the bounded evaluation cache dropped); the worker also makes the display meshes of the bodies they end with. Exports run on a copy. While a change computes, or the agent cursor acts one out, ui.*, inspection and screenshots answer; later design changes wait their turn. A chip names the command with Stop. A person's edit meanwhile goes first; a replaced design refuses the request. Preference: Preferences > AI, agent_off_thread, off by default. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
fdec948abc |
Control channel: control.running lists what the app is running, across connections (#3654) (#3689)
* claim: #3654 * Control channel: control.running lists what the app is running, across connections (#3654) control.pending answers only for the connection that asks, so a second client, the MCP bridge after a reconnect or a script saw {"pending": null} while the app was busy. control.running answers for the whole app, the same on every connection and at once (the connection's own thread answers it, also while it is busy with a timed-out request): every request the app has been sent and not answered yet, oldest first, with its connection, id, method, command id (or a batch's step count), seconds since it arrived and whether it still waits its turn. A timed-out request stays listed until the app answers it, also after its connection closed. Parameters are never shown. The window marks a request started when it takes it (ControlRequest.started), which tells queued from running. The MCP server gets a read-only `running` tool. --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
164554edba |
3MF import: production extension review follow-ups (#2089) (#3628)
* claim: #2089 (3MF production extension: review follow-ups) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3MF import: production extension review follow-ups (#2089) Follow-ups from the review of #2127: - Only the root model's build is read; other parts' build sections are ignored as the spec asks (a slicer's child build pointing at a thumbnail no longer matters). - A model part that can't be read fails only the placements that need it; the package-wide caps (part names, 1 GB of model XML) still refuse the package. The root XML is dropped once parsed and each part is read against the remaining budget. - Loops are reported apart from depth, keyed by (part, object). - Messages name parts as written; objects are kept in id order so parts are read in the same order every run; %XX escapes in part names are decoded; the model unit is a local of the parser. - Tests: a component without p:path stays in its part (T1), the same id in two parts is no loop (T2), a slicer-shaped project (T3), the placement budget across parts (T4), a loop through three parts and a chain past the depth cap (T5), broken parts and child builds (T6), escaped names; the hostile-parts test asserts its messages; the mutation test also mutates the parts' XML and zips it again. - Guide: what slicer-only data is not read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d9d6af51c6 |
Sheet metal: mirrored and copied sheet bodies stay sheet metal (#3353) (#3354)
* claim: #3353 * Sheet metal: mirrored and copied sheet bodies stay sheet metal Mirroring a sheet metal body into a new body gave a plain solid: the opposite-hand bracket had no flat pattern, DXF or bend table ("`Body1 (2)` is not a sheet metal body"). Copies from a body pattern or Move with copy lost their sheet model the same way. A copy now takes the sheet model with it (SheetBody::copied). A rigid copy moves the flat frame. A mirror moves the frame with its x axis turned round, so the thickness side stays, and mirrors everything in flat coordinates (x -> -x): base, flange bend lines (run from their far end, with their end extensions, slopes and tears swapped), panel shapes, cut-outs, pockets, bores, letters and base sketch lines. Arcs stay exact and loops keep their sense. A perforation field of a mirrored copy runs its grid from the right, so its holes are the mirror image too. The flat length, bends and K-factor are unchanged, and the copy takes further sheet metal features of its own. Mirror with combine is unchanged: the joined body has no single sheet model yet. Mirroring or patterning flange features is still refused. Sheet models are derived from the timeline, so no design format change. * Format: note the saved from_right of a mirrored sheet's perforation field The new `from_right` flag is saved in the design, so it gets a pending format note. No migration: a field without it runs from the left as before. |
||
|
|
2eacbc37f4 | Keep sketches out of the Browser Features folder (#3584) | ||
|
|
bd65a561c8 |
Ribbon: New Sketch on the Surface tab (#3964)
Sketches drive surface extrudes, revolves, sweeps and lofts, so the Surface tab gets the same Sketch panel as Model and Sheet Metal. A sketch started there keeps the tab until it opens. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ac362945cc |
English (UK) as a language: a plain catalogue of the 25 messages UK English spells differently (#2501) (#2502)
* claim: #2501 * English (UK) as a language: a plain catalogue of the 25 messages UK English spells differently (#2501) assets/locales/en-GB.json holds only the English messages whose spelling differs in UK English (Centre, Customise, Organisation, Licence, colours, towards, ...), in UK spelling; every other message falls back to English. One registration in i18n.rs (English first, then by id), a test that shows UK spelling and English for the rest, a row in ATTRIBUTION.md, and the docs/localization.md note. The translation-coverage checks skip a regional English catalogue, which has no gaps to report. Fixes #2501 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |