5c0e48ed2bc2e8d4ce0baa86cd52c4218f1b68fb
835
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
+30 |
d4ec5e6811 |
Sync pinned main into render (#5869)
* Viewport: show reference geometry through bodies (Preferences, off by default) (#2697) A new Graphics preference, "Show reference geometry through bodies", draws inactive sketch contours, origin and construction planes and their axes over shaded bodies. It is off by default, so the viewport looks as before: reference geometry is depth-tested and a section leaves it whole (#1229); Create Sketch and dialogs picking a plane still draw the planes through the model. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * ui-egui tests: offscreen GPU tests start their devices one at a time (#3989) (#3990) * claim: #3989 * ui-egui tests: offscreen GPU tests start their devices one at a time Every offscreen test started a wgpu instance of its own, and starting one makes the Vulkan loader scan its drivers. With several test threads two tests doing that at once crashed the test process with SIGSEGV inside the loader (loader_icd_scan). offscreen_device now holds a process-wide lock while it starts the instance, adapter and device; each test keeps its own device and the rendering still runs side by side. * DXF: write and read a Bézier at its own degree (#5269) (#5281) * claim: #5269 * DXF: write and read a Bézier at its own degree (#5269) The DXF writer and reader held a spline's degree to 7, the value MAX_BEZIER_DEGREE had before #1642 raised it to 9. A G4 blend (one Bézier of degree 9) was written as a degree-7 SPLINE over its first 8 control points, so a flat pattern's cut-out stopped 4.444 mm short in the file. - seg_shape takes its limit from MAX_BEZIER_DEGREE: a Bézier is written whole, at its own degree. - read_dxf reads SPLINE degrees 1 to MAX_BEZIER_DEGREE, the degrees a sketch spline takes. - Tests: every Bézier degree 4 to 9, a degree-9 round trip, the reader's degrees, hostile SPLINE degrees and too few control points, the G4 cut-out exported and read back with its areas, and a degree-9 SPLINE with 2 to 10 points inserted into a sketch. Fixes #5269 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Renaming a plane keeps its projections, canvases and hidden state (#4353) (#4354) * claim: #4353 * Renaming a plane keeps its projections, canvases and hidden state (#4353) timeline.rename only renamed the feature in other features' references. A sketch's projection of a construction plane, a canvas placed on it and the hidden list keep it by name too, so they lost it: the sketch warned that the plane no longer exists, the canvas left the view and a hidden plane showed again. Document::rename_feature_keys renames it in sketch links and canvases, as rename_body_keys does for bodies; the selection follows in the command, and the hidden list in Session::refresh_from, so a hidden plane stays hidden through undo and redo too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Browser: add Rename and Delete to feature menus (#3839, #4343) (#4342) * claim: #3839 * fix(ui): add Rename and Delete to browser feature menus * Browser: a second click on a Document Settings entry closes its window (#4150) (#4152) * claim: #4150 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Browser: a second click on a Document Settings entry closes its window (#4150) Each entry under Document Settings only opened its window. A second click on Units closed the menu on the press (the row is outside it) and opened it again on the release; Precision left Preferences open; Parameters and Design Properties came back as a fresh copy. Now a click on an entry whose window is open closes it the way the window's own x does: - Units: context_menu::toggle_for with the row as the opener, the fix #1522 made for the workspace button's menu. A right-click still opens it at the pointer. - Precision: prefs::close(app, true), the Cancel/x path that puts back what changed since the window opened (now pub(crate)). - Parameters and Design Properties: the window is dropped, as its x does. A Parameters value typed but not applied yet is dropped with it, as today's second click already drops it. Fixes #4150 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Preserve expression-positioned sketch fillet corners (#4097) (#4106) * claim: #4097 * Sketch fillet keeps a corner placed by an expression (#4097) Filleting a corner whose position comes from parameter expressions deleted the point and its expressions, so the sketch gained two degrees of freedom and later parameter changes distorted the outline. keep_corner now also keeps fixed or expression-positioned points as virtual sharp corners. * Fix feature editor picks after upstream sketch resizing (#4083) (#4084) * claim: #4083 * Feature editors refill named edges and faces where they are now (#4083) After an upstream sketch change, Fillet, Chamfer, Shell and Draft evaluated correctly, but their editors refilled the originally clicked points and could then fail with "no edge at ...". Resolve the stored names through the document's naming helpers first, keep the resolved index, and map the pick into the displayed body's frame; the point lookup stays as the fallback. * ui-egui tests: clear the texture deltas of the frames they run (#4039) Nine tests dropped an egui frame's output with its texture delta still unapplied (the expression completion editor's frames, the slot preview's three, the browser's feature rows). epaint asserts against that in debug builds, so they failed under the dev profile and passed only where debug assertions are off. They clear the delta as the other tests do; one more hover test that dropped its output the same way does too. * Frames: profile library, members along frame sketch lines, and the Frame Member dialog (#4003) (#4004) * claim: #4003 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the profile library (#4003) The first slice of frames and weldments: the cross-sections structural members will be made of, each SolidCraft's own parametric definition built in code (no vendor or standard size tables are shipped). - solidcraft_doc::frame: bar, round bar, rectangular and round tube, angle, channel, I-beam and a generic T-slot extrusion as exact line/arc regions, with defaults worked out from the profile's size, refusals that name the dimension that does not fit, anchors and placement, and exact section properties (area, centroid, Ixx/Iyy/Ixy by Green's theorem). - frame.profile.list, frame.profile.properties (with mass per metre for a density) and frame.profile.insert (draws a profile into a sketch, locked by default, at a point, anchor and angle). - Tests against hand-computed values (rectangles, circles, composite rectangles by the parallel-axis theorem, fillet spandrels), hostile input, extrusion volume, undo; catalog entries in every locale; docs/frames.md; ROADMAP M15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: drop the built-in T-slot profile (#4003) Aluminium extrusions and other vendor sections come from the user's own sketch (drawn or inserted from the vendor's DXF), so the library keeps the plain steel shapes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: members along frame sketch lines (#4003) frame.member lays one body per straight line of a frame sketch (2D lines or 3D sketch lines), its cross-section square to the line from end to end: - profile: a built-in profile, or profile_sketch, a sketch whose material (nested loops alternating, so two circles make a tube) is the section in its own x and y around its origin; profiles picks override it. - anchor (origin, centre, centroid or a bounding-box corner or edge middle), angle (an angle expression, so a parameter), mirror. - Orientation: the profile's y as near world up as the line allows, x square to both; a vertical member's x is world X (frame::member_axes). - Members follow sketch and parameter edits, undo as one step, save and reopen (format: pending/frame-members.rs), and are named after the profile (Rect Tube 40x40x3, (2)…), numbering on past names already taken. Tests against hand-computed volumes and bounding boxes (rectangle, 3D tower lines, parameter edit, sketch tube profile and picks, anchor/angle/ mirror), refusals, undo/redo and reopen; walk fixtures and goldens; docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: fixes from the adversarial review (#4003) - Default member lines are what was drawn: projected and other linked curves and 3D wires (a face sketch's edges) and lines of no length are left out. - A profile sketch's material starts from its drawn profiles, as solid.extrude's "all" does, so a section sketched on a face works; the even-odd test uses outlines and boxes worked out once, capped at 256. - Member names are pinned to their lines (`names`, by line id; `body_name` is the base): deleting or adding a line, or deleting another feature, no longer renames other members, and frame.member stores every name it gives. body.rename renames a member on its line (also for later member features); a copy whose body_names were set still names its members by position. - Built-in profile dimensions are expressions (ProfileSpec): they follow parameters, bare numbers take the design's units, and they are feature inputs. frame.profile.properties/insert read them the same way. - Default root/toe radii shrink to the room a thick section leaves; radii given are checked by name; a radius must be 0 or at least 0.01 mm; error messages report the wall or flange value given, not twice it. - A line within 1e-6 rad of vertical orients as vertical, so rounding never turns a post a quarter turn. - A 2D frame sketch in a differently placed component is mapped into the member's frame, and member features recompute when placements change. - Caps before lookups for a design's `lines`; a line listed twice is refused; a 3D wire that runs back on itself is not a line. Regression tests for each, from the review's scenarios. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the Frame Member dialog on the ribbon (#4003) - Frame Member (MODEL > Create) opens a dialog: the frame sketch's lines picked in the view (or All Lines), a built-in profile and its dimensions or a section picked in another sketch, anchor, angle, mirror and name, with a live preview. Edit Feature reopens it filled in. - Lines picked in the view keep their sketch (a SKETCH_LINES input picks ExternalSketchCurve): line ids are each sketch's own, so two 3D sketches both have a `w2`, and the members went on the newer sketch's lines. - timeline.redefine takes frame.member. Members keep their names through an edit unless it gives them a new body_name; frame.member takes `names`. - A member whose section is a whole profile sketch keeps it when edited (the dialog shows the sketch instead of picking every region, which would fill a tube's hole). - An original frame_member icon, open for review, on the ribbon, timeline and browser. - The angle profile is listed as L-Angle, and web and flange as Web/Flange thickness, so they translate apart from the existing Angle, Web and Flange; the dialog's labels are in en, ja and zh. en-GB no longer repeats the frame command labels it spells the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Rectangular and circular pattern: copies that miss the body are reported (#3042) (#3919) * claim: #3042 * Warn when cut pattern copies remove no material A rectangular or circular pattern whose copies miss the body succeeded silently and those copies did nothing. The pattern now reports how many of its cut copies removed no material, and keeps the copies that land. * Delete in a rolled-back history warns about the features after the marker (#3471) (#3698) * claim: #3471 * Delete in a rolled-back history warns about the features after the marker (#3471) With the timeline rolled back, the checks a delete runs first (the confirmation's "these features will fail", timeline.dependents and selection.delete's would_fail) compared models evaluated only up to the marker. Features after it, broken by the delete, were not listed, so their error marks turned up only once the timeline moved to the end. newly_broken_in_history evaluates both sides over the whole history when either has a marker (on copies; the model and document are unchanged) and is used by the delete's report and by timeline.dependents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * macOS: Fusion navigation preset does not support Shift + two-finger orbit (#3446) * Macos: keep touchpad/key modifiers true to fusion * fix: remove obsolete orbit snap reset from trackpad navigation Upstream removed ViewportState::orbit_snap. The new trackpad orbit path retained one reference, causing E0609 in the PR merge build. Validation: all seven trackpad tests pass; cargo check -p solidcraft-ui-egui --all-targets passes on the exact failing CI merge 66a2791b with this fix applied; rustfmt and diff checks pass. Co-Authored-By: GitHub Copilot <noreply@github.com> * fix: retain Fusion trackpad help in refactored preferences Preserve upstream's new preferences pages and apply the translated Fusion trackpad tooltip in prefs/navigation.rs. Validation: cargo build -p solidcraft passed. Tests and full CI were not run, as requested. Co-Authored-By: GitHub Copilot <noreply@github.com> * style: format Fusion trackpad preferences tooltip Apply rustfmt's required wrapping for the relocated tooltip. No behavior changes. Validation: cargo fmt --all -- --check and git diff --check passed. Co-Authored-By: GitHub Copilot <noreply@github.com> --------- Co-authored-by: GitHub Copilot <noreply@github.com> * 2-point circle takes a typed diameter (#3278) (#3335) * claim: #3278 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 2-point circle takes a typed diameter (#3278) After its first point the 2-point circle tool showed no value box, so the circle could only be sized with the cursor. It now shows a Diameter box, like the centre circle: the typed value puts the second point that far along the cursor's direction, and Enter draws the circle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Reorder design tabs by dragging them (#3187) (#3188) * claim: #3187 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reorder design tabs by dragging them (#3187) A tab dragged along the strip follows the pointer while the others make room, and lands where it is released; Escape, or releasing down the window, leaves the order as it was. With the custom title bar a drag that starts mostly up or down (or on the only tab) still moves the window. The control channel's ui.documents gains a move action (from, to). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Renaming a body keeps the evaluated timeline, off the window thread (#2467) (#2468) * Renaming a body that later features change evaluates nothing (#2467) Model::rename_body now keeps the results when later features change the body (a pattern, a chamfer, a join). It still evaluates when a body of that name comes and goes or isn't the same body throughout, when a later body's name is worked out from it (X (2)), or when a message quotes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rename box: rename off the window thread, and locked bodies follow a rename (#2467) The rename box commits body.rename through run_heavy, so a rename that still evaluates later features (one names the body in its targets) computes beside the window instead of freezing it. Locked bodies now follow a body.rename from anywhere (the rename box, the control channel, scripts), not only the rename box. --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Toolbar: a constraint dragged out of the small box becomes a full button (#5254) (#5456) * claim: #5254 * Toolbar: a constraint dragged out of the small box becomes a full button (#5254) The Constrain panel's small box of constraint icons was a fixed list, so dragging one onto the full-size buttons saved a new order but it was still drawn in the box. The toolbar settings now remember, per tab, which box commands were moved out; those are drawn as full buttons, the box closes up, and dropping one back on a box icon returns it. Reset Toolbar restores the default box, and settings saved before this load unchanged. * Sketch offset keeps its source lines free to turn (#4464) (#4466) * claim: #4464 * Sketch offset keeps its source lines free to turn (#4464) An offset adds a Parallel between each source line and its offset line. Since offsets became associative, the offset's points are held during a solve, so each Parallel pinned its source line to the offset line's current direction: a closed chain lost its turning freedom (8 degrees of freedom became 6), and Horizontal or an angle edit on a source line was refused as conflicting. The solver and the constructive reading now leave out a Parallel that ties an offset line to the source it follows while the association lives; the association already keeps them parallel. After Break the stored Parallel drives again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Flat Pattern view draws perforations (#4440) (#4441) * claim: #4440 * Flat Pattern view: draw perforation holes (#4440) The flat view drew the outline, cut-outs, pockets and bend lines but not perforation fields, though the flat-pattern data and the DXF export list their holes. The view now reads the hole centres from the sheet through SheetBody::perforation_holes, caches them per model state and body, and draws them as circles in the cut-out style. Holes outside the viewport or smaller than one pixel are skipped, and the cache is capped at one million holes. * "Don't Save" looks like a button in the Save changes prompt (#4380) (#4400) * claim: #4380 * "Don't Save" looks like a button in the Save changes prompt (#4380) The prompt's third action used the kit's low-emphasis text style, so it didn't read as clickable and people thought Cancel was the only way out. Add an opt-in secondary_left style to the confirm footer (a framed secondary button from the theme tokens) and use it for Don't Save. * Save prompt test: clear each frame's texture delta once it is applied egui 0.36 panics when a TexturesDelta with unapplied deltas is dropped; the test kept only the last frame's output and dropped the earlier ones. * 3D mouse test: clear the frame's texture changes, so it passes in debug builds (#4382) each_frame_hands_the_view_its_motion_through_the_drivers_mapping dropped the output of a frame it ran (`let _ = ctx.run_ui(...)`). epaint panics in debug builds when a TexturesDelta is dropped with deltas left ("Dropped TexturesDelta with 1 unapplied deltas"), so the test failed under a plain `cargo test` on every platform while the ci profile passed. It now clears them, as the other UI tests do since #60. Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Spanish (es-ES): catch up with en.json (#4292) Co-authored-by: carlymx <24634598+carlymx@users.noreply.github.com> * Esc ends the navigation bar's Pan, Orbit and Zoom modes (#4226) (#4233) * claim: #4226 * Esc ends the navigation bar's Pan, Orbit and Zoom modes (#4226) The nav bar toggled a mode on, but nothing cleared it on Esc, so a left drag kept panning, orbiting or zooming. Esc now ends an active nav mode first; the next Esc reaches the tool or dialog as before. * Keep long Select Other labels inside the popup (#4209) (#4225) * claim: #4209 * fix(ui): bound Select Other labels and expose full names (#4209) * Deleting an inserted file removes its components, placements and joints (#4100) (#4113) * claim: #4100 * Deleting an inserted file removes its components, placements and joints (#4100) A STEP or mesh file inserted into a design makes a component tree. Deleting its feature left that tree behind: the components, their occurrences, the rigid joints that hold them and the bodies' component assignments. A later body that took an imported body's name was then placed in the stale component. Document::remove_component_tree removes a component subtree and everything that refers to it: the features made inside it, its occurrences, the joints on them with their motion links, joint origins, contact set members, motion study keys and exploded moves, body component and offset entries, standard part and link records, and configuration columns. Deleting an inserted file's feature and component.delete both use it; component.delete now also removes joints left pointing at a deleted occurrence. The body transfer refusal moves with it, unchanged. * Only an inserted file's feature takes its component tree when deleted Mark the feature a STEP, IGES or mesh insert makes (`inserted`), and remove the component tree on delete only for those and for a linked design's feature. Deleting a copied component's independent base deletes just that feature, as before. Older designs get the mark as they open (pending format change), except copied components' independent bases. * Rigid joint saved with the wrong occurrence when two occurrences share a component (#3857) (#3939) * claim: #3857 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Joint dialog: a body of a further instance picks that occurrence, not the component's first (#3857) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Cancel Sketch: leave a sketch without keeping its changes (#3838) (#3938) * claim: #3838 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 * Cancel Sketch: leave a sketch without keeping its changes (#3838) sketch.cancel (Cancel Sketch, ribbon Exit group and the sketch's right-click menu) puts the design back as it was when the open sketch was created or opened for editing: a new sketch is removed with its dimension parameters, an edited one returns to how it was. It is one undo step, so Undo goes back into the sketch. The session remembers the design and the undo history at the point a sketch is entered. Cancel uses that only while the history still runs through it (the same steps before, every step since taken in this sketch); otherwise it refuses and points to Undo, so a stale entry can never throw away later work. The icon is the approved close glyph in the sketch accent (alias sketch_cancel); ja and zh carry the new label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * 3MF import: name a Bambu Studio project's bodies after its objects (#3858) (#3859) * claim: #3858 (3MF import: names from a Bambu Studio project) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3MF import: name a Bambu Studio project's bodies after its objects (#3858) Bambu Studio leaves the name off the root model's objects and keeps it in Metadata/model_settings.config (<config><object id="N"><metadata key="name">), so every object of a project came in as Mesh1, Mesh2, ... A build item whose root object has no name of its own now takes the object's name from those settings. A name in the model still comes first, and part names, other settings and objects of other model parts are left alone. The settings are read only when a body needs a name, within what the model parts left of the 1 GB budget. Settings that can't be read (malformed, nested too deeply, too large) never fail the import: the bodies keep the generic names, with a warning saying why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Viewport: right-click keeps a multi-selection of faces and edges (#3733) (#3788) * claim: #3733 * Viewport: right-click keeps a multi-selection of faces and edges (#3733) --------- Co-authored-by: AhmetV <344941595+ahmetv10@users.noreply.github.com> * Parameter import and image pickers offer their own file types (#3216) (#3314) * claim: #3216 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameter import and canvas image pickers offer their file types (#3216) Both opened the picker with no file type of their own, so it listed only designs, CAD files and meshes (and All files). macOS lets you pick only the types a filter names: CSV parameters, and PNG or JPEG images for a canvas, were greyed out. They now ask for csv/json and png/jpg/jpeg, which the picker lists first (#1801). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Return to the originating tab after finishing a sketch (#3250) (#3264) * claim: #3250 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Return to the originating toolbar tab after finishing a sketch (#3250) A sketch started from SHEET METAL or PLASTIC always ended on the SOLID tab. Remember the tab that was active when the sketch began (UiState::sketch_return_tab, not saved) and go back to it when the sketch ends. Falls back to SOLID when that is not one of the normal toolbar tabs. A sketch started from SOLID behaves as before. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Test: no one-element loop in the return-tab test (clippy single_element_loop) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * STEP import: let a cancelled import release the import slot (#3171) (#3189) * claim: #3171 * Release cancelled file import slots (#3171) * Dragging a part along its joint no longer highlights what's under the pointer (#5137) (#5140) * claim: #5137 * Dragging a part along its joint no longer highlights what's under the pointer (#5137) The viewport's hover pick was skipped during a box selection and camera moves, but not while a jointed part was dragged, so faces and edges under the pointer lit up on every frame of the drag. The pick now waits until the joint drag ends. * Browser: a body picked in the viewport is opened to and scrolled to (#3005) (#3081) * claim: #3005 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Browser: a body picked in the viewport is shown in the Browser (#3005) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Merge main; viewport::select takes a toggle flag now Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Line tool snaps a diameter through the circle centre (#4326) (#4327) A line drawn across a circle only snapped its end onto the curve, so a diameter could miss the centre at any angle. Near the centre the line now locks onto the radial line: on the rim it stays on the circle and the centre is kept on the line, and on the centre point the end lands there. * Flatpak: find the host's fonts for CJK text and the font list (#5124) (#5127) * claim: #5124 * Flatpak: find the host's fonts for CJK text and the font list (#5124) Inside the Flatpak sandbox the host's fonts are mounted at /run/host/fonts and /run/host/user-fonts, which no font search looked at. Japanese and Chinese text fell back to boxes, and the font list missed the host's families. - Search both folders for the CJK and Chinese fallbacks and for the installed-font list. - The CJK fallback reads SOLIDCRAFT_FONT_DIRS (a path list, as the font list already does), with CRAFT_FONTS_DIR kept as a fallback. * Crash reports: keep component.activate in the journal (#5079) (#5121) * claim: #5079 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Crash journal keeps component.activate (#5079) Activating a component changes only the session's active component and occurrence path, not the design, so the journal dropped the command and a crash report's replay built later parts under the previously active component. The journal now also keeps a command that changes either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Control channel and MCP on by default, with a setting to turn it off (#5561) The app opens its localhost control channel on port 27878 (or the next free one) unless Preferences > Assistant turns it off; --control and SOLIDCRAFT_CONTROL_PORT still win. A current.port discovery file lets solidcraft-cli mcp find the running app with no arguments. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Tests: moving an occurrence recomputes only the cuts and joins it touches (#4965) (#4982) * claim: #4965 * Joins and cuts follow only the placements they depend on (#4965) Tests that turning a joint between parts cuts no hole again, and that a tool cutting another part cuts again when that part moves relative to it, while an unrelated part moving keeps the result. Booleans and Combine now hash only the placements of the bodies they take as inputs, relative to the frame that evaluates them (#3397), so these pin that behaviour for joins and cuts with named targets across parts. * fix(ui): preview shortcut chords and wait for complete modifier input (#1810) Keep physical modifier events out of the ordinary-key slot, preview held keys immediately, and confirm after release and a one-second settling interval. Preserve legacy control-channel modifier behavior while allowing explicit physical Control/Command input. Add regression coverage, a UI scenario, localized guidance and documentation. Fixes #1809. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * Move: scope box selection to the active component (#4459) (#4527) * claim: #4459 * fix: scope Move box selection to active component (#4459) * Delete removes a selected construction axis (#4692) (#4695) * claim: #4692 * Delete removes a selected construction axis (#4692) Delete on a construction axis skipped it with "the origin axes can't be deleted". It now deletes the construction axis feature, like construction planes; the origin axes X, Y and Z are still refused. * Agent chat: end the agent's process group where `kill` is busybox' (#4587) (#4588) * claim: #4587 * Agent chat: end the agent's process group with the system call (#4587) The group was signalled with a `kill` program: `kill -s TERM -- -<pgid>`. That works with procps' `kill` and with BSD's, but busybox' `kill` takes no `--`: it prints its usage, exits 1 and signals nothing. The agent's helpers (the CLI an adapter wraps, the MCP servers it starts) then stay alive after the agent is ended. The group is signalled with the system call instead, so no `kill` program and no shell are needed and the behaviour is the same everywhere. `nix` (MIT) is already in the tree through zip, and only on Unix: the browser build does not take it. The two tests that cover this now pass where they failed before: `agent_chat::process::tests::dropping_the_process_ends_its_group` and `agent_chat::process::tests::stopping_the_agent_leaves_no_helpers_running`. * Extrude: picking a face, vertex or parallel plane off the profile switches the extent to To Object (#2855) * Extrude: picking a face, vertex or parallel plane off the profile turns the extent to To Object With profiles picked, a face off their plane (or curved), a vertex off it, or a construction plane parallel to it is taken as the To Object target instead of another profile: the extent switches without the Extent Type choice, and the distance shows how far the target is. Coplanar faces still join the profiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Extrude: automatic To Object is a Preferences setting, off by default Preferences > Design > "Extrude to a picked target" (`extrude_auto_to_object`, default false) turns the automatic To Object on. Off, picks in the Extrude dialog only add profiles and the distance is not synced to a target, as before this change. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * FreeCAD/Rhino import: decode caps with room for detailed parts (#1783) (#3209) * claim: #1783 * FreeCAD/Rhino import: decode caps with room for detailed parts (#1783) cadmpeg decoded FreeCAD and Rhino files under its service profile, whose million collection items and 2.56e8 work units a detailed part (a sprocket, a threaded rod, a part with a few hundred faces) runs past: the import was refused with "resource limit on CollectionItems: BudgetExceeded". Allow 8 million items and 2e9 work units, half of cadmpeg's desktop profile; the input-size cap stays SolidCraft's STEP limit and every other cap stays at the service profile's. decoding_is_capped checks the two raised caps (and that they stay below the desktop profile's) and that every other cap is still the service one. Fixes #1783 * A spherical shell revolves into a solid with a void, and cuts and joins with hollow tools work (#451) (#4182) * Assembly: ground the first part; drag free joint chains (#2804) (#2805) * assembly(feat): ground first parts and drag free joint chains Ground the first top-level part when it is created and let face dragging reposition free occurrences or any member of a floating joint chain in one undo step. Preserve exact repeated-placement frames, joint values, modifier selection and Escape cancellation. Keep the accumulated fixture, viewport layout and documentation integration fixes from the existing PR. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(fix): update movable fixtures for first-part grounding Accept the documented grounded override in component creation, explicitly free movement fixtures, and keep linked clipboard pastes movable even in an empty document. Cover first and reused linked pastes, default insertion grounding, and single-step undo in the existing link tests. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): keep the motion-cost crank free Unground the first component in the document-level joint-face measurement fixture so its motion samples can rotate after first-part grounding. Preserve the rotation and shared-measurement assertions that caught the Linux CI failure. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): free the frame placement fixture Create the frame-member placement fixture ungrounded before moving it above its root sketch. Keep its world-space member assertions while respecting first-part grounding in the frame tests added on main. Signed-off-by: Karl Von Richter<karl@embeint.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> * UI: integrate theme radii, borders, palettes and viewport refresh (#5045) (#5046) * claim: #4922 * UI: let themes own corner radii * UI: use four-point panel and window radii in SolidCraft 95 * UI: align the 95 radius assertion with four-point panels * claim: #4953 * UI: let themes own structural and control borders * UI: single Blueprint outlines and dotted secondary rules * UI: separate container outlines and add theme-owned 95 bevels * claim: #5007 * UI: apply theme palettes to icons, workspace tabs and Gruvbox settings * claim: #5045 * Viewport: invalidate cached geometry colours when the theme palette changes * UI: preserve legacy theme logo colours with the borderless mark * Section Analysis: OK with no plane picked turns the section off (#2410) (#2411) While a section is on, Section Analysis opened with no plane picked now says "No plane picked: OK turns the section off." and OK runs inspect.section {"clear": true}. With no section on, OK with no plane still asks for a plane. Fixes #2410. * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * Close Change Parameters with Escape (#3372) (#3399) * claim: #3372 * Fix Escape cancellation in Change Parameters Consume Escape before parameter editors can commit pending text on focus loss, while preserving autocomplete and shortcut capture priority. Add 11 UI regressions covering draft cancellation, preview cleanup, document and history preservation, and reopening saved values. * Preserve construction references when axes and points are renamed (#4419) (#4449) * claim: #4419 * fix: preserve renamed construction references (#4419) * Browser: route body picks into open command dialogs (#2560) (#4371) * claim: #2560 * fix(ui): route Browser body picks into active dialogs * Fix midpoint picks in sketch dimensions (#4872) Retain MID snaps across both picks and materialize reusable midpoint constraints for point-to-line and point-to-point dimensions. Let midpoint pairs choose horizontal or vertical spans with pointer placement before entering a value. Cover projected model edges, overlapping geometry, helper reuse, undo/cancel/reopen, and existing angular and line-circle workflows. * Sketch slots: provide typed dimension inputs for every variant (#2423) (#4318) * claim: #2423 * fix(sketch): add typed dimensions to every slot tool (#2423) * Version 0.21.0 on main (released from rc.2's code) (#5774) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * docs(mcp): Windows setup for Claude Desktop (#3794) * docs(mcp): Windows setup for Claude Desktop (paths, two servers, Store config file) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(mcp): say the Store build can keep the config elsewhere, not that the other path fails Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * MCP: wait out long requests, honest batch outcomes, batch tool aliases (#2901) Rebased onto main as one commit (was 120d26f7, df488f9a, db9d1073 plus merges of main). - A request the app reports as still running (#1618) is waited for on the same connection through `control.pending`; past the wait the error says it was not cancelled and will still apply (or only write its file), later calls are not sent behind it, and the new read-only `pending` tool returns its result once it lands. - A failed batch says what really happened: `rolled_back` only when the design is back where the batch started (as #3288 / #3242 on main: the app's `rolled_back` is believed; for an older app, every completed step undone; only a rollback asked for is reported as one), plus `applied`, `not_run` and `failed.still_running`. - A batch step may name a tool (set_parameter, list_commands, describe_command, execute, measure, inspect_design, undo, redo, export, save, open, new_design, crash_reports); screenshot, body_topology, batch and pending are refused before anything is sent. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: driver choice, guided calibration, button mapping and a picture of the device (#1463) (#3825) * Add a small test boat to steer around with the 3D mouse A little hull in its own camera, drawn by the UI itself and not the CAD viewport, so a 3D mouse can be tried out without opening a design. It brings the model (generated by assets/models/make_test_boat.py) and the tests for how the camera moves it. Nothing uses it yet; Preferences picks it up with the rest of the 3D mouse work. * UI kit: keep a choice row from flipping with the scrollbar A choice row picks segments or a dropdown by whether its labels fit. A page scrollbar that comes and goes narrows the row by its own width, so the row could flip back and forth between the two on a page that sits right at the edge. It is now judged on the whole row and through a small helper, fits_steadily, that only changes its answer once the miss is wider than the scrollbar. Also tests for that, for typed numbers in a slider's value box, and a test hook to put up the issue-report input barrier by hand. * 3D mouse: device model, guided calibration, buttons and a picture The 3D mouse becomes a device we know something about instead of six raw numbers. The reader picks between spacenavd and the direct hidraw driver, falls back from one to the other, and says so when it can't open the device. Guided calibration asks whether the device is a spring cap or a trackball, adds a touch step, and uses a settle filter so a ball let go of stops reading as motion. Buttons get jobs (keys, held modifiers, commands), saved per device, with defaults for the SpaceMouse Pro. Preferences gets a picture of the device that moves as it does, next to the test boat, and the same picture can sit in the 3D view at Left Viewport, Right Viewport or Left Window, above the floating History card like the legend and readouts. These ride together because the crate's calibration types, the Preferences page, the Linux reader and the button hook all use each other. * 3D mouse: offer to calibrate an uncalibrated device When a 3D mouse shows up that has not been calibrated, a card in the 3D view offers to calibrate it, to swap drivers when the other one would work better, to close, or to never ask again. It is made once per device, goes away after 30 seconds in view, and gives way to a status or computing toast instead of stacking on it. The card is the shared toast, which now takes buttons: they group by purpose, wrap inside the card at narrow widths, and do nothing while an issue report holds CAD input. The picture of the device in the 3D view keeps clear of the card. * 3D mouse: translations and attribution The 3D mouse strings (ui.3d_mouse_*, the calibration steps and the offer card) in every shipped language, the Japanese catalog note, and the credit for the test boat model in ATTRIBUTION.md. This is last because the code before it only looks keys up: it builds and runs without these, falling back to English until they land. * 3D mouse: draw its preferences with the settings kit like the rest of Navigation The 3D mouse section was a folded header with its own layout. It now uses the same kit as the sections above it: a settings_section card, settings_form rows with the shared label column, dividers between the device, axes, picture and buttons groups, Text::Hint for the helper lines, and settings_control_width for the dropdowns. The section is open like every other one (the header still folds it), so the device badge on the folded header is gone; the calibration row already names the device. Every setting, string and key is unchanged. Tests that unfolded the section no longer click it, and the hint lines are looked up as hints instead of notes. * 3D mouse: show each axis's live tilt in Preferences, like main's axis rows Each view axis row is main's axis row again: a meter that follows the tilt of the motion driving it, with the dead zone marked, next to Invert, Speed and the "driven by" menu. The meter reads the calibrated travel when the device has a calibration and the raw reading over full scale when it does not, and asks for a frame whenever the reading changes. The helpers are back as they are on main, and the calibration state is a badge by the enable toggle. * 3D mouse: line its preferences up with the rest of Navigation - The two checkboxes sit side by side in the same two-column grid as Wheel and trackpad. - Row labels stop repeating "3D mouse" and use sentence case: Calibration, Driver, Restore defaults, Reset view, Left viewport, Right viewport, Left window. - Hints line up under the control column instead of the left edge. - The six view axes are named Pan X, Pan Y, Zoom, Orbit X, Orbit Y and Roll so they fit the name column. - Buttons are a divider and rows in a form like the other groups, without the bold sub-heading. - The driver, dead zone, axes, picture and buttons sit behind a collapsed Advanced section, since most people never touch them. * 3D mouse: tidy the Advanced test for clippy * Timeline: suppressing a feature keeps later features' body names (#4302) (#4311) * claim: #4302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: suppressing a feature keeps later features' body names (#4302) Bodies numbered by the counter (`BodyN`) take the next free number on every recompute, so suppressing a feature that made one moved every later counted body down one (`Body2` became `Body1`) and broke what named it, such as a Move of `Body2`. timeline.suppress now stores the current names of later features' counted bodies in their `body_names` first, as body.rename already does for a renamed counted body (#1109). Engine only: no evaluation or design-format change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: a body made while a feature is suppressed keeps its name (#4302) Suppressing a feature freed its counted name (`Body1`), so a body made meanwhile took it and became `Body3` once the feature was back. Suppress now also stores the suppressed feature's own counted names, and the evaluator adds the names stored on earlier suppressed features to the state's `reserved_body_names` (the names a rename freed, #4957), which the `BodyN` counter passes by. They are taken from the design before each feature is computed and are part of the state digest, so a cached result is only reused when they match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * cadmpeg 0.6.3: FreeCAD and Rhino import in the browser too (#4482) cadmpeg 0.6.3 is pure Rust (ruzstd instead of the zstd C library, zip 9), so solidcraft-io depends on it on every target and the wasm build reads .FCStd and .3dm files like the desktop app. The browser's file pickers offer them. 0.6.3 replaces DecodeOptions::container_only with a decode depth; ask for Geometry, what its STEP writer reads. zip 8 leaves the tree, and with it the three cargo-deny advisory exceptions kept for it. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Pattern dialogs: Quantity fields get up/down step arrows (#4260) (#4264) A new kit control, `ui_kit::count_field` / `count_row`, is an expression field for a whole-number count with stacked step arrows at its right edge. An arrow steps the evaluated count by one within the field's limits: a plain number is replaced, an expression keeps its parameters and gains or adjusts a trailing `+ n`. The text changes as typing changes it, so the live preview follows. Used by the Quantity rows of the sketch Rectangular (1-500, both directions together at most 500) and Circular (2-500) patterns, and the solid Rectangular, Circular and Path patterns (1-1000). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Regenerate THIRD-PARTY-LICENSES.txt and docs/features.md [skip ci] * Join: say so when the joined piece doesn't touch the body (#4434) (#4436) * claim: #4434 * Join: say so when the joined piece doesn't touch the body (#4434) A Join (extrude, revolve, sweep, loft, pipe, coil, primitives, thicken, boundary fill, surface network) whose material meets none of its targets still joins it to the first target as a separate piece. The result stays as it was; the feature now warns: "the joined piece doesn't touch `Body1`, so `Body1` is now in 2 separate pieces (New Body makes it a body of its own)". History marks it and the command reply carries it. The check compares pieces (outer shells, not voids) of the bodies the feature changed or absorbed before and after it, so it holds for the batched multi-profile path too, stays quiet for a join that bridges pieces or closes a cavity, and leaves Combine (which joins the bodies it is given) alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Hole: snap to face and round-edge centres, drag placed holes, section in the dialog (#2171) (#2912) Placing a Single hole put it exactly where the click landed, with nothing to line it up by and no way to move it but taking it out and picking again; the dialog was a list of size fields. - Preferences › Design › Create Hole has two settings, both off by default, so a new installation places holes as before: - Snap to face and edge centres (`hole_snaps`): the planar face under the cursor offers its middle and the centres of its round edges (a boss, a rounded corner, a hole already there) as marks; a pick near one, or on or beside such an edge, takes that centre and the mark is named. Sketch points on the face still come first; Alt or Ctrl held places it where clicked. - Move holes by clicking or dragging (`hole_moves`): each placed hole has a handle that drags it (snapping when snaps are on) and takes it out when clicked, and a pick elsewhere on its face moves it there. Edit Feature shows the handle too, so a hole can be moved later (#1047). - The Hole dialog draws a section of the hole as its options make it, with each size in a field beside the dimension it sets; a hovered or focused field lights its dimension. The layout is a new kit element, `ui_kit::figure_rows` (a caller-painted figure beside captioned fields). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Hole: place a Single hole by distances from reference edges (#37) (#2931) A Single hole can take up to two straight edges of its face as references, each with the distance of the hole's centre from that edge's line, measured in the face's plane. `solid.hole` takes them as `references: [{edge, distance}]`; the edges are found again by their persistent names, else their points, so the hole follows them when the part changes, and each distance is a parameter. A bad reference (no edge there, a curved edge, one square to the face, parallel edges, a negative distance, a centre off the face) is refused. In the Hole dialog, Reference 1 and 2 follow the face, each with its Distance row; the canvas shows each distance as a dimension from its edge to the hole, with a box just past the edge to type it in. Picking an edge measures its distance (and its box takes the keyboard), typing one moves the hole, and moving the hole measures them again. Edit Feature picks the edges again with their distances. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> Co-authored-by: Frank <58932224+plexi32@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: raykholo <raykholo@users.noreply.github.com> Co-authored-by: CamWight <91156642+CamWight@users.noreply.github.com> Co-authored-by: SS-EN <84559909+SS-EN@users.noreply.github.com> Co-authored-by: Colin Faulkingham <colin.faulkingham@gmail.com> Co-authored-by: Karl Von Richter <karl@von-richter.net> Co-authored-by: HiroKenEz <59478073+HiroKenEz@users.noreply.github.com> Co-authored-by: Peppe Bergqvist <p@bergqvi.st> Co-authored-by: GitHub Copilot <noreply@github.com> Co-authored-by: phanoob <lesur.Stephane@wanadoo.fr> Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Kai Evans <nemshilov@gmail.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Tyler Chiriboga <tylerchiriboga.apps@gmail.com> Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: CaRLymx <carlymx@gmail.com> Co-authored-by: carlymx <24634598+carlymx@users.noreply.github.com> Co-authored-by: Loohi <78334654+Loohi@users.noreply.github.com> Co-authored-by: leValdemar19 <valdemarnord@hotmail.com> Co-authored-by: AhmetV <mihendiz10@gmail.com> Co-authored-by: AhmetV <344941595+ahmetv10@users.noreply.github.com> Co-authored-by: rlartot <94693724+rlartot@users.noreply.github.com> Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Thodoris Tsagkogeorgas <thodoristsagko@gmail.com> Co-authored-by: ahmetalpcelik <80778880+ahmetalpcelik@users.noreply.github.com> Co-authored-by: ealitt <ealitt@gmail.com> Co-authored-by: Homero Thompson <vdirienzo@gmail.com> Co-authored-by: Diogo Soares Rodrigues <dsrodrigues20@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Artem Sushchev <Suschev.Artem+github@gmail.com> Co-authored-by: Nathan Dane <nathandane.dev@gmail.com> Co-authored-by: Kai Evans <hi@kaievans.co> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cronos <crono2250@users.noreply.github.com> Co-authored-by: rbousigues88 <rbousigues@gmail.com> Co-authored-by: The Nomad <nomad@positron3d.com> Co-authored-by: Jackson Oursland <jacob.oursland@gmail.com> Co-authored-by: Jacques <59315319+Jacquesvdberg92@users.noreply.github.com> |
||
|
|
24c9d14663 |
GPU: adapt dispatches and retire lost devices (#5754) (#5755)
* claim: #5754 * fix(gpu): adapt dispatch size and retire lost path devices (#5754) Start with a 64-item quantum and adapt bounded work toward 20 ms from observed completion, including denoiser tiles. Never exceed 16384 work items; hardware-specific shader cost means this is not a universal TDR guarantee. Publish device loss/uncaptured failure/poll failure through live executor availability without reinitializing automatically. Source-pinned required-Vulkan GPU suite: 105 passed, zero failed, three existing ignores, including actual device.destroy retirement and session availability. Strict GPU/engine all-target Clippy passes. Broader engine and repository/WASM continuation remains separately recorded. No geometry baseline, CI rule or published format history change. |
||
|
|
7a81a7fc15 |
library: transport PBR and engineering cards without lossy copies (#1086)
* wip(library): reconcile exact rich-catalog replacement semantics (#1062) Source-only scoped extraction from original 0f801962 / #1086 on the refreshed #1060 card prerequisite. Preserve current asynchronous picker guards and source-ID handles. Scalar v1 and rich-v2-without-PBR clear existing PBR; supplied rich PBR is retained. No new saved concept or duplicate card descriptor. Formatting and source review completed; compile/native acceptance is still pending. * test(library): preserve explicit downgrade and fallible UI regressions (#1062) Request scalar v1 explicitly in the card downgrade refusal regression; rich v2 remains the default lossless writer. Propagate fallible harness actions with ? in the shared clicked-catalog helper, preserving all assertions. No production code, limits or ignore changes. Fresh grouped IO/engine/UI tests, scoped strict Clippy and WASM pass on this exact tree. |
||
|
|
e3d7cbe830 |
Merge pinned main into the shared render integration
Synchronize official main |
||
|
|
c6cbde3706 |
Render: studio lighting, clear coat and glass on GPU (#2191)
Integrate the original studio renderer after the GPU executor and async UI foundations, under #5493. Fresh render-target quick run 40011408339 passes. Preserve attribution, bounded resource admission and documented glass/denoising limits. Historical native benchmarks retain their source pins. Full renderer-to-main CI and jyviko sign-off remain separate. Co-Authored-By: Christian Svensson <blue@cmd.nu> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com> |
||
|
|
30449418ac |
Render: progressive GPU path-tracing executor (#2067)
Land the unchanged contributor GPU foundation into render under the maintainer policy in #5493. Fresh quick gate 39993339605 passed. Original author and co-author attribution retained; no workflow file changes. Final render-to-main CI and jyviko sign-off remain separate. Co-Authored-By: Christian Svensson <blue@cmd.nu> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
95a56ca00e |
Persist validated engineering cards independently of mass and optics (#1060)
Render constituent under #5493. Fixes #1048. One pending material-engineering-cards descriptor, immutable released migrations, independent assigned density and source conditions. Nine persistence and ten physical-card regressions plus the fresh quick gate pass. Additional native follow-up is reported separately; no full-stack acceptance is implied. |
||
|
|
17bac141c8 |
An intersect that would leave nothing is refused instead of deleting the body (#5295) (#5303)
* claim: #5295 * An empty intersect is refused instead of deleting the body (#5295) An intersect whose boolean came out empty removed the target body and reported success. The shared evaluator now refuses it when nothing of a named target would remain, when nothing of any target would remain, or when the tools meet a target and the result is still empty. An unnamed target the tools miss altogether is still removed, as an intersect with every body does (#5160). Sheet metal flat machining follows the same rule. * Sheet metal: an intersect with already removed material is refused (#5295) |
||
|
|
4b42ef50c7 |
Mesh leftovers from the ribbon redesign (#133) (#4471)
* claim: #133 * mesh: Save As Mesh declares the panel that shows it (#133) The ribbon redesign (#2176) removed the MESH tab, but three things still pointed at it: - `file.save_mesh` declared `.at("MESH", "MODIFY")`. The command inventory prints the placement a spec declares, so `docs/features.md` advertised a `MESH > MODIFY` location no ribbon has. Its real home is already INSERT / FILES (`SECTIONS` lists it), so the declaration now agrees with the ribbon; `destination()` resolved it there before and after, so nothing moves on screen. - The user guide sent people to "the Mesh tab under Modify" for Save as mesh. - A test now refuses any command that declares a tab the ribbon removed, and pins where Save As Mesh lives. `PLACEMENTS` keeps its MESH entries: those migrate toolbars users saved under the old panels, which is a different question from what a spec declares. --------- Co-authored-by: Geraldrunion <geraldrunion@users.noreply.github.com> |
||
|
|
769dfff1a5 |
Section Analysis: a Hatch option (#4563) (#4565)
* claim: #4563 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Section Analysis: a Hatch option, off for a plain cut in the body's colour (#4563) The Section Analysis dialog gets a Hatch check box beside Flip, and inspect.section a hatch?: bool (default true), so scripts, the CLI and the control channel reach it too. Hatched, a cut is its body's colour tinted toward the cap colour with 45 degree stripes, as before; off, it is the body's own solid colour. The viewport (cap alpha in the uniform), the CPU rasterizer and ui.render follow it, and the section keeps it when hidden and shown again or edited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3ed1829cc7 | fix: retain circular sketch pattern Quantity expressions (#4435) (#4607) | ||
|
|
b982ccd8c4 |
Mesh Convert works without activating the mesh's component first (#4609) (#4613)
* claim: #4609 * Mesh Convert works without activating the component first (#4609) Inserting a mesh puts it in a new component while the parent stays active, so Convert Mesh always refused the first time. Convert now resolves the mesh body's owning component and adds the conversion there when the active component is that component or an ancestor, leaving the active component unchanged. From another branch it still refuses, and the error names the component to activate. |
||
|
|
a5f9ff45dd |
Sketch Symmetry: a dimensioned shape slides onto the axis (#4030) (#4626)
* claim: #4030 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch Symmetry: a dimensioned shape slides onto the axis (#4030) With a rectangle's width dimensioned, Symmetry of its two sides about an axis was refused: the second side can't move on its own, the axis never moves, and the ordinary solve that slides the whole rectangle only ran when every first-picked entity could move. One movable first entity is now enough. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
61360c3b0d |
Convert to Sheet Metal: a bend picked on its tangent edge connects, on rotated parts too (#4328) (#4630)
* claim: #4328 * Fix sheet conversion picks on tangent bend edges (#4328) Resolve cylindrical bends through the nearest edge's incident faces when a pick on a tangent boundary resolves to its planar panel. This keeps valid remote bends connected, including picks on the other skin of a shell. Keep conversion geometry and picks in the body's local frame, and format conversion diagnostics through its world placement. Cover rotated bend picks and disconnected-pick coordinates with synthetic regressions. |
||
|
|
eec6da060f |
Measure: report obtuse angles at a shared corner (#4625) (#4634)
* claim: #4625 * fix: measure obtuse corners independently of edge direction (#4625) |
||
|
|
96ce31153c |
Pattern and mirror: a rib as the source (#4593) (#4667)
* claim: #4593 * Pattern and mirror: a rib as the source (#4593) A pattern or mirror of features refused a rib as a source ("Rib1 cannot be patterned or mirrored yet"). A rib's walls run until they meet the body, so each copy is built again where it is: the rib's sketch is moved by the copy's transform and the walls are run against the bodies there, as a hole is drilled again at each copy. The copies join the body, as the rib does. The rib's own tool building moves into rib_tools, which the rib feature calls unmoved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a9c3c8bb8a |
Accept a leading = in expressions, so a fillet radius can be =d3 (#4681) (#4686)
* Sketch fillet radius: accept a leading = in an expression (#4681) * A second = after a name is still not a definition |
||
|
|
a147a7c083 |
Sketch Point: a point put on a midpoint or a curve snap is held there (#4691) (#4745)
* Sketch Point: a point put on a midpoint or a curve snap is held there (#4691) The Point tool sent only a snapped point's coordinates and sketch.point took only [x, y], so a point clicked on a line's midpoint (or on a curve, or a model vertex) was free to move off it. sketch.point now takes the snap forms the other draw commands take ("mid:<line>", "on:<curve>:x,y", {vertex}, {on_edge}); the snap makes the point with its constraint. The tool passes those snaps as themselves; a snap to an existing point still goes as coordinates, where `connect` joins them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch Point: refuse a snap it can't read instead of answering as if it made a point sketch_project::snap_points leaves a snap it can't parse ("on:c1:abc", "on:c1", "on:c1:1,2,3") as it was given, and sketch.point then read that string back as the point it had made: no error, no point, and an id a script would go on to dimension. It now takes the snap only when it names a point of the sketch, and otherwise refuses, listing the snap forms (found by the test agent on #4745). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
84cad43154 |
Timeline marker: refuse a negative position, and name the command asked for (#4712) (#4749)
timeline.rollback / timeline.roll_to read a negative position as 0, so an agent passing -1 for "one step back" rolled the whole timeline back and every body disappeared, with no error. A negative position is now refused. The two commands shared one function that refused in roll_to's name; each now refuses in its own. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9559ad398a |
Physical material: one rule for a body's material and its density (#4783) (#4785)
* claim: #4783 * Physical material: one rule for a body's material and its density (#4783) inspect.measure, component.properties, occurrence.properties and the Properties window took a body's material name from the raw assignment, but its density from Document::density, which falls back to the default material when the assigned one is unknown or has an unusable density. So a damaged or hand-edited design read one material and weighed another: a design material "Broken" at -3 g/cm³ read "Broken" at 1.29 g/cm³. One rule, in one place: - DEFAULT_MATERIAL (new, beside DEFAULT_DENSITY in the material library) is the default material's name. The library's first row uses it. - Document::body_material (new, beside Document::density) is the material a body's mass is computed with, as the library or the design spells it: the assigned one when it is known and has a usable density, else DEFAULT_MATERIAL. Document::density is that material's density, with the same value as before for every input. inspect.measure and the physical properties name body_material. inspect.measure now names every body's material, measured or not, since naming it takes no measuring; the density stays with the mass, on the bodies measured. So the Properties window shows the engine's name without a fallback of its own. The places that keep the assignment as stored (configuration cells, material.assign, material.edit, material.delete and the dialogs) only use the constant, so a configuration still keeps a damaged assignment as it is. The visible change: a body whose material is unknown, or has an unusable density, reads "Default", the material it weighs, and a miscased name reads as the library or the design spells it. A body inspect.measure can't measure now has its material too. Masses and densities don't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a0fd39a7be |
Flange on a plain solid says how to start sheet metal (#2987) (#4789)
* claim: #2987 * Flange on a plain solid says how to start sheet metal (#2987) Flange, Flat Pattern, and Export DXF on a design with no sheet metal body now say how to make one: Flange > Base, or Convert to Sheet Metal on a plate's large flat face. An edge flange checks for a sheet metal body before it adds a feature. The message is in the catalogs, and engine messages that match a catalog entry are shown in the interface language. * Dialogs show a refusal without the engine's parameter prefix (#2987) The Flange dialog showed "invalid parameters for `sheet.flange`: " in front of the new guidance. The dialog already names its command, so the red refusal text leaves that prefix out and follows the interface language when the message is in the catalogs. Create Issue still gets the full text. |
||
|
|
e104e241a3 |
Rename a body: keep the names of siblings a later feature removed (#4880) (#4904)
* claim: #4880 * Rename a body: keep the names of siblings a later feature removed (#4880) Renaming a body sets the stored names of all bodies its feature made, so the siblings are not renumbered. Those names were read from the final model, where a body that a later feature removed no longer exists: its stored name was lost, it came back as `Ext (3)`, and the later Remove failed with "no body `Body3`". Read the siblings from the feature's own result instead, as the later features already are. * Test: renaming one half of a split leaves the other Renaming one half keeps the other half's name, also once a later feature joins that other half away, after both an incremental and a full evaluation. |
||
|
|
d1f5d6e223 |
History: drag features across the marker in one step, clearer drop feedback (#4938)
Dropping a feature just behind the history marker now rolls it back, and dropping it just before the marker makes it active again, in both the bottom strip and the left panel. timeline.reorder and timeline.move_many take an optional `active` param that sets the marker in the same command, so the move is one undo step and one recompute. A position on the wrong side of the marker for the requested `active` is refused. Drop feedback: - bottom strip: the drop line sits centred between two features (it used to touch the previous one) and shows at the first position (it used to be drawn outside the strip there) - left panel: a drop slot below the marker when it is at the end - no drop line when the marker is dragged back to where it is - a dragged feature is outlined in the drop line's green - grab cursor on the marker, grabbing cursor while dragging the marker or a feature Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
60efbe39e3 |
Sketch drag: a linkage with redundant parallelogram constraints still moves (#4585) (#4983)
* claim: #4585 * Sketch drag: a linkage held by redundant parallelograms still moves (#4585) Cursor motion looks for the sketch's freedom in the null space of the constraint Jacobian. Redundant constraints (a parallelogram held both parallel and equal on each pair of sides) are dependent only at an exact solution; after a correction to the solver's tolerance their rows differ by about 1e-9, which the 1e-9 pivot tolerance counted as rank, so the null space came out empty and a one-DoF linkage stayed locked. Use the rank analysis' 1e-7, so the drag sees the freedom the sketch reports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
567bc50723 |
Snap fit: refuse sizes too small to build (#5022) (#5027)
* claim: #5022 * Plastic features: refuse sizes under 0.01 mm (#5022) A snap fit with a near-zero thickness (1e-9 mm) got past the size checks, which only asked for a positive number, and panicked in the kernel's intersection code. The boss, lip, groove and rest had the same gap. Every length of a plastic feature that becomes geometry (snap fit length, thickness, width, catch_depth and catch_length; boss diameter, height, hole_diameter, hole_depth and rib sizes; lip and groove width and height; rest width, length, height and thickness) must now be at least 0.01 mm. The check sits where the feature is evaluated, so a parameter changed later is refused the same way, and the message names the parameter. |
||
|
|
1a5fcd05d6 |
Extrude and loft: refuse duplicate profile indexes (#5023) (#5028)
* claim: #5023 * Extrude and loft: refuse repeated profile indexes (#5023) `profiles: [0, 0, ...]` with 10 000 copies built 10 000 identical bodies in about 35 s, and a loft section listing one profile 10 000 times took 25 s before it was refused. A list of profile indexes now refuses a repeated index while it is parsed ("profile 0 is listed twice"), as offset association ids already were. Before the profiles are resolved, a selection naming more profiles than its sketch has, an index the sketch doesn't have, or two points in the same profile is refused too. A design file that repeats an index still opens, using the profile once. |
||
|
|
da46c660df |
Coincident on two circles lays the second on the first (#5038)
Coincident with two circles (or arcs) picked was refused: "two curves must both be straight lines; otherwise choose a point and a curve". It now lays the second pick on the first: Concentric and Equal together, in one step, with the first staying put. A pair already concentric or equal gets only the other half; one already lying on the other is refused as nothing to add. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
92d1331978 |
A renamed body keeps its number: the next body does not take the freed name (#4957) (#5053)
* A renamed body keeps its number (#4957) The design's body counter starts over at every evaluation, so a body renamed after a join (the join changed it, so the rename cannot be followed without evaluating the design again) gave its number back: the next body took the name the rename freed, and a script that names a body found another one. The design now saves the names a rename freed, and the counter skips them. * A renamed body keeps its number (#4957) The design's body counter starts over at every evaluation, so a body renamed after a join (the join changed it, so the rename cannot be followed without evaluating the design again) gave its number back: the next body took the name the rename freed, and a script that names a body found another one. The design now saves the names a rename freed, and the counter skips them. * Format |
||
|
|
dbbad6d4ee |
view.apply: keep the camera's roll, and refuse an up axis (#5087) (#5094)
* claim: #5087 * view.apply: keep the camera's roll, and refuse an up axis (#5087) An explicit camera was read as a named view, which has no roll or up, so roll was silently reset to 0 and up was ignored. Read roll as a finite number in radians, clamped to ±π, and refuse up with a message saying the up axis comes from the design settings. |
||
|
|
2dc31a30d4 |
Extract to File: move a component into its own linked design (#5113)
The component's sketches, features, bodies, subcomponents, the joints among them and the parameters they use move to a new .solidcraft design, keeping their ids and names, and the component becomes linked to it as Insert Design makes it. The new design must build the same bodies and the assembly must look the same afterwards, else nothing changes and no file is written. Joint faces on the component are found again on the linked bodies, and components that build the same bodies can become placements of the link. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8b68eb7eac |
fix(extrude): a sketch on an inserted part joins and cuts it, through all too (#5115)
A STEP file inserted into a new design sits in its own component under the empty root, and a sketch on its face must join that part going out and cut it going in rather than make a separate body beside it. With a distance, main already resolves this; Through All with no distance gave `auto` no reach to probe, so it fell back to New Body and cut nothing. Through All now reaches past every body in its direction, and `auto` reads it as a cut (#1234). Co-authored-by: Steven <steven2021067613@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5367ef4367 |
Extrude without a profile selection keeps holes in nested loops (#5172) (#5176)
* claim: #5172 * Extrude without profiles keeps nested loops as holes (#5172) With no `profiles`, solid.extrude took every region of the sketch, so circles drawn inside a plate outline were extruded as well and filled the plate's holes. The default now applies even-odd nesting to the drawn profiles: a loop inside an outline is its hole, a loop inside that hole is material again, and separate outlines all extrude. Sketches without nesting keep the `all` selection, and explicit `profiles` (including "all") are unchanged. Saved designs store their selection, so they recompute as before. |
||
|
|
caa1e6e196 |
component.create refuses parameters it does not take (#5174) (#5178)
* claim: #5174 * component.create refuses parameters it does not take (#5174) A call with `bodies` (or a misspelled key) used to succeed and make an empty component. Unknown keys are now refused before anything changes, the error lists the accepted parameters, and `bodies` points to component.move_bodies and component.from_bodies. |
||
|
|
8bd17cea42 |
Joints: a joint origin's name given as a face says to pass it as the origin (#5175) (#5179)
* claim: #5175 * Joints: a joint origin's name given as a face says to pass it as the origin (#5175) When the name in `face` or `circle` matches no face but is a joint origin, the error now says so instead of "no face is named". |
||
|
|
4256775274 |
Joint: avoid redundant analysis and residual placement work (#5185) (#5186)
* claim: #5185 * Joint: reuse residual placements and skip discarded mobility reports (#5185) |
||
|
|
17f0d6bc68 |
Format registry: one table of formats, extensions and options (#5215) (#5217)
* Add the format registry: one table of formats, extensions and options in crates/io. The hosts' Open-dialog filters and the web accept list derive from it, and registry tests pin it to the path predicates and the command docs. * Fix format-registry tests that compared FormatSpec without Eq. assert_eq on Option<&FormatSpec> does not compile; the none cases only need is_none, matching the other rows that compare ids. |
||
|
|
63d81cc096 |
Motion Trace: regenerate kept curves only when inputs change (#5248) (#5270)
* claim: #5248 * feat(motion): regenerate kept traces when source inputs change * feat(motion): add a parametric Chebyshev trace demo * perf(joints): reuse face measurements across motion samples Face-centred joint origins called Body::faces on every solve, bypassing the reference-mesh reuse used for rigid placements. Share face measurements with unchanged model geometry at the existing tolerance, while guarding replaced bodies and applying offsets after the cached measurements. Cover repeated named/nearest-face solves, shape edits, retained snapshots and direct replacement with deterministic work counts. The 145-point Chebyshev dimension and range updates retain identical sampled and interpolated curves. * perf(naming): skip preparation for cached face names Both face lookup paths spawned fresh workers over every body even when their name cells were ready. Prepare only cold cells, with direct handling of zero or one cold body. Preserve the existing parallel naming path and all face selection semantics. Deterministic regressions cover repeated picked and unique-name lookups, misses, partial warmup, renames, snapshots and moved copies. Release Chebyshev medians fall from 859 to 50 ms for a dimension edit and 871 to 34 ms for a sweep edit; all 145 samples and interpolated points remain identical. Full cargo xtask ci passes with RUST_TEST_THREADS=4 and the existing local Windows validation overlays. |
||
|
|
858e5995d6 |
Plane at Angle: a planar face is a base plane (#1939) (#1956)
Co-authored-by: jeremymiribung-blip <jeremymiribung-blip@users.noreply.github.com> |
||
|
|
edf57cec29 |
Stand up Y-up STEP and IGES files from SolidWorks automatically (#5191)
* claim: #5150 * Stand it up: don't offer it for SolidCraft's own STEP files (#5150) STEP replies from file.insert_step and doc.open now carry the file's originating system, and the window skips the stand-up offer when it is exactly SolidCraft, as SolidCraft's STEP export writes it. * Stand up Y-up STEP and IGES files from SolidWorks automatically The STEP header (originating system, preprocessor version, FILE_DESCRIPTION) and the IGES global section's native system ID say which program wrote a file. A SolidWorks header means Y up: the import's component is stood up as it opens, as one undo step, and the message offers Undo. SolidCraft's own files are left alone; an unknown exporter keeps the offer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Ray <raykholo@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
3b982ca371 |
Prevent deleted item IDs from being reused (#1016) (#3641)
* claim: #1016 * Prevent deleted design item IDs from being reused |
||
|
|
aaa110218b |
Edit Offset Plane: keep a face base, refuse a plane on itself (#3567) (#3889)
* claim: #3567 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Yz6dHZiXcgTgrxjVNC6hx * Edit Offset Plane: keep a face base, refuse a plane on itself (#3567) Reopening an Offset Plane built on a face looked the face up at the plane's origin, which can lie off the face, so the Plane input came up empty. Look it up at the point picked on the face. A redefine that builds a feature on itself is refused with a plain message instead of failing with "plane offsets nested too deeply". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Yz6dHZiXcgTgrxjVNC6hx --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
46f80b769f |
Sketch fillet and chamfer refuse an offset's corners instead of leaving circles (#2874) (#3860)
* claim: #2874 * Sketch fillet and chamfer refuse an offset's corners (#2874) An analytic offset's output ends are recomputed from its source curves on every solve and held fixed there. Filleting an output corner moved those ends to the tangent points, the next refresh pulled them back to the sharp corner, and the new arcs closed into full circles with the sketch left unsolved. Fillet and chamfer now refuse a corner on an offset output before anything changes (a batch fillet applies all of its corners or none) and say how to get the rounded result: round the source corners before offsetting, or break the offset association first, after which the same corners round normally. |
||
|
|
26ca82735b |
Circular Pattern and Revolve: a construction axis can be the axis (#2885, #4506) (#3796)
* claim: #2885 * Circular Pattern and Revolve: a construction axis can be the axis (#2885) The dialogs send a picked axis by its name, but solid.pattern.circular only knew X, Y and Z, and solid.revolve / surface.revolve read any other name as a sketch line id. Picking a construction axis therefore failed. - solid.pattern.circular takes a construction axis name, saves it as `axis_feature` and turns about the axis as evaluated, so the copies follow it when it is edited. - AxisRef::Construction { name } for revolve and surface revolve, resolved at evaluation and checked to lie in the sketch plane. - construct.plane.at_angle accepts a construction axis name (its fixed axis line is taken from the axis as it is now). - Reopening these features shows the construction axis as the pick. - Design format: pending/construction-axis-refs.rs. * Construction axis references follow the axis in the feature's component frame (#4506) - Revolve, Surface Revolve and Circular Pattern resolve a construction axis where it is evaluated, mapped into the feature's component frame. - A line of the revolved sketch with the same id as a construction axis still wins, so existing scripts keep their meaning. - Tests: the revolve keeps the reference through save and reopen and follows an edited axis (60π to 80π mm³); perpendicular, offset and profile-crossing axes are refused without changing the design. |
||
|
|
408d30ea56 |
Joint drive moves parts without evaluating them (#3391) (#3397)
* Joint drive moves parts without evaluating them A joint drive (also the Drive dialog and motion steps) changes only occurrence transforms, yet it re-evaluated nearly the whole timeline: every feature that might read another component's geometry (a sketch with any link, even to its own axis) hashed every occurrence's transform into its fingerprint, so any motion invalidated it and everything after it, and no new pose was ever in the cache. - Placement digest: a feature now hashes only where the geometry it actually reads lies relative to its own frame (link sources, anchors, profiles and paths from other components, mirror placements; To Object and face/edge-picked planes read every component, relatively). Moving parts that keep those relative placements leaves every result in place: nothing is evaluated or re-meshed. In-context features whose referenced part really moved still rebuild. - Evaluated ahead, applied once: `Ahead::evaluate` returns what it evaluated and `Session::prime` lets the window-thread pass take it (history commands and dialog OK), so an off-thread command no longer costs twice on designs past the cache's budget. - Contact meshes are kept per body geometry across drives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Joint drive: booleans read only their input bodies' placements A join, cut or intersect with named targets, and a Combine, read every placement, so a joined part transferred to a component re-ran its boolean at each new joint pose. Each now hashes only the placements of the bodies it actually takes as inputs, resolved in its timeline input state (before any later BodyTransfer), relative to the frame that evaluates it; Combine reads its tools relative to its target. Unresolved and legacy component or path reads keep the conservative dependency. 24 new joint_pose_ tests cover new angles, transfers, targets, save/reopen, undo and real relative motion (900 -> 800 mm3). Supplement offered on #3397 by takuto-NA. Co-Authored-By: takuto-NA <183465875+takuto-NA@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Creating a component recomputes nothing A new, empty component changes nothing a feature reads, yet it changed the placement fingerprint of every targeted boolean, Combine and To Object feature, so `component.create` evaluated the timeline again: - the first component of a design: `placement_digest` returned 0 while the design had no placements and a nonzero value once it had one; - To / From Object and legacy face- or edge-picked planes hashed every component, not just those holding the bodies, sketches and construction geometry the feature can reach. Co-Authored-By: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Test: creating a component after a legacy face sketch recomputes nothing A face extruded after its construction certificate is gone (a patterned cut, a pad joined flush with it, then one more cut) is sketched on a legacy face plane, which reads every placed body. A new, empty component must not change what it reads either (reported by Tyler Chiriboga). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: takuto-NA <183465875+takuto-NA@users.noreply.github.com> Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> |
||
|
|
4dc1828138 |
Imported meshes: share their triangles between document copies (#4673) (#4675)
Every edit clones the document for undo, and `MeshData`'s positions and triangles (plain `Vec`s) were copied with it: ~165 MB a command for a 2 M- triangle STL. They are now `Arc<[f64]>` and `Arc<[u32]>`, shared by clones; the few places that rewrite them build new arrays. Saved designs are unchanged (an `Arc<[T]>` serializes as the array). Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
3d3dd27439 |
Viewport: leave out placements of an instanced mesh that are out of view (#4646) (#4647)
* claim: #4616 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Viewport: draw a part placed many times from one copy of its triangles (#4616) A part placed by many occurrences was drawn, framed and picked from a moved copy of its mesh per placement: on the CPU (the moved mesh and its scene bytes) and on the GPU (its vertices uploaded once per placement). - The model scene draws bodies that share a mesh as GPU instances: the shared triangles once, a rigid move and colour per placement (`InstancedMesh`, `vs_tri_inst`), in the solid, section and AO passes. `GpuScene::merged` expands them, so scene tests see world triangles. - `ModelBody::mesh_in_place`, `plan_mesh_in_place_at`, `mesh_bounds` and `display_identity` give the shared mesh, its placement, the exact box and an identity without making the moved copy. - Display refinement's body ids, Fit/Home bounds, the viewport's body boxes, the background mesher and picking use them (picking moves the ray into the part's frame and shares one pick index). 25 placements of a 2 M-triangle STL on an M2 Max: orbit 45 -> 37 ms a frame, footprint 41 -> 16 GB, 24 copies 39 -> 18 s. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Viewport: draw large meshes from shared, indexed vertices (#4637) An instanced mesh's vertices are shared between its triangles and drawn indexed (`SharedTris`). A flat-faceted mesh (an STL's facets) shares them by position alone and lights each fragment with its triangle's own plane (`vs_tri_inst_flat`, `fs_*_flat`), taken from the fragment's position relative to the eye so it stays exact at any zoom; its vertex outputs are kept few, since a tiled GPU stores every vertex's outputs. A body alone is drawn this way from 50 k triangles. A mesh too large for one buffer falls back to unshared vertices. `instanced_scene_gpu_benchmark` (manual, ignored): 25 placements of a 2 M- triangle STL at 3600 x 2190 px, 4x MSAA, M2 Max: 21.3 ms a frame for the placements' own triangles, 16.1 ms shared and indexed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Viewport: leave out placements of an instanced mesh that are out of view (#4646) Each frame `Batches::cull` keeps the placements whose box may be seen (`placed_box_in_view`: all eight corners past one side of the view in clip space, so it holds behind the eye too) and writes them again only when that set changes. The manual benchmark gains `SOLIDCRAFT_BENCH_CLOSE=1`: close up on the middle of 25 placements of a 2 M-triangle STL (13 in view), 3600 x 2190 px, 4x MSAA, M2 Max: 28.2 ms a frame for the placements' own triangles, 17.2 ms instanced and culled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
4b23bb3a03 |
Implement compact workspace layout (#2029) (#4533)
* Vertical history strip: left of the browser, compact rows, hollow-circle marker, collapsed rail hover * Vertical history strip: seam handle to expand and collapse names, drag to resize with snap * Vertical history strip: no empty gap below the transport * Show the history seam arrow only on hover (#2028) * claim: #2021 * Redesign the Assistant chat panel with shared UI components * Show Assistant in the shared floating panel shell * Extend floating Assistant to viewport height and shift navigation * Dock Assistant before history and match docking preview bounds * Align Assistant top margin with floating shell cards * Extract a shared panel drag grip * Rebuild responsive history sizing and three-way docking * Share browser and History collapse hover styling * Show the History title as soon as its text fits * Animate stacked browser and History expansion and collapse * Make panel folding responsive and independent of frame delays * Let folding panel contents shrink continuously to header height * Use four explicit History transport actions in every layout * Resize the shared Browser and History column from either card * claim: shared compact-mode containers (#2029) * Centralize layout-aware UI containers and enforce their use * Keep docked Assistant at the outer edge beside tool sheets * Use shared surface policy for Assistant tool space * Let tool sheets drag over shell panels while avoiding Assistant * Update Parameters drag bounds assertion for shell overlap * Keep dragged tool sheets below ribbon and workspace selector * Enforce universal UI containers in mandatory repository checks * Remove legacy report windows and require shared window composition * Remove retired UI styling and require shared controls * claim: compact layout preference (#2029) --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
dfd58293a6 |
Navigation: opt-in free orbit and shared Normal to Selection (#1912)
* Navigation: opt-in free orbit and shared Normal to Selection Preserve the complete reviewed feature, shared camera setting propagation, rigid pivot behavior and focus/drag regressions from PR #1912. Consolidate the prior main-integration commits before rebasing, so their merge-resolution fixes remain in the linear feature history. * docs: move free orbit help beside viewport controls * Merge main into fix/solidworks-free-orbit Camera animation is gone on main, and with it the orbit snap spring: the Shift snap keeps its unsnapped orbit in orbit_free, which the free-orbit checks now read. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
ba4f7864ff |
Export Current View as DXF includes shown sketches (#3708) (#3780)
* claim: #3708 * Export Current View as DXF includes shown sketches (#3708) The view export refused a design with only a sketch and left shown sketches out when bodies were present. It now draws the sketches the viewport shows (profile curves only: no construction geometry, points, dimensions or constraints) on a SKETCH layer, one entity per curve. Finished sketches are hidden behind bodies through the body-edge occlusion; the active sketch is drawn on top, as in the viewport. Sketch points use the same projection, budgets and cancellation. The export is refused only when there is neither a visible body nor a shown sketch curve; the dialog and the command share that check (cmd::view_dxf_exportable). --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
b289dc2421 |
Sketch Dimension: name = value defines a user parameter (#2916) (#3638)
* Sketch Dimension: `name = value` defines a user parameter (#2916) In a dimension's value (the D tool's box, and `sketch.dimension`'s `value` from scripts, the CLI, MCP and the control channel), `name = expression` adds the user parameter `name` with that expression and dimensions with `name`: typing `width = 40` on a line gives a 40 mm user parameter `width` and a dimension whose expression is `width`. A bare number is read in the design's unit, as a bare dimension value is; an angle's parameter is in degrees. The expression may be anything the parameter editor takes. It is one command: one undo removes the parameter and the dimension together, and a dimension the sketch refuses leaves no parameter behind. A taken name is refused with a hint (type the name to use it, or change it in Parameters), a reserved name with the parameter editor's message, and a left side that is not a name (`2 = 3`) still fails to parse as before. A driven dimension defines nothing. The reply carries `defined`, and the status line names the parameter. The splitter lives in the doc crate (`expr::definition`) so other value inputs can take the same form later; editing an existing dimension, the inline shape boxes and feature dialogs are follow-ups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension: say why a name is refused, in the command's own words (#2916) The dimension editor showed a refused definition raw, in the box and the status line: "invalid parameters for `sketch.dimension`: value: `mm` is a unit, constant or function name". It now reads "Sketch Dimension: `mm` is a unit name, so it cannot be a parameter name": the editor passes the command's errors through `friendly_error` like every other command, and drops the `value:` field tag, since the box is the value. The taken-name hint reads the same way: "Sketch Dimension: there is already a parameter `w`: type `w` to use it, or change it in Parameters". A reserved name says what kind of word it is and what that means (`param_name_problem`, shared with the Parameters dialog): a unit name, a function name, or a constant, "so it cannot be a parameter name"; `expr::reserved_kind` tells them apart. `friendly_error` translates the command label with the interface language (the engine's sentence stays English), so the prefix reads "Wymiar szkicu:" in Polish. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension test: keep the third line off the ribbon (#2916) On current `main` the ribbon floats over the top of the canvas, and the test's third line at sketch y = 50 projected under it: the click opened Parameters instead of picking the line. The line now goes below the first one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |