Commit Graph
988 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 25175d68ca Merge #8526 (brett19/solidcore e30cfd2ac): solidcore as the default kernel, C++ SMLib behind --features smlib
Three conflicts:
- crates/smlib flat.rs and export.rs: #8526's export copies the C++
  arrays by id range; the ranges now run to the ball-patch arrays
  (FACE_DEFINITION_REAL_COUNT, FACE_DEFINITION_REALS), with
  WIRE_EDGE_NURBS_FORM (35) and FACE_DEFINITION_REAL_COUNT (36) both kept.
- tests/KNOWN_FAILING_TESTS: solidcore's lines and develop's, each test
  once; tests/KNOWN_FAILING_TESTS.smlib takes develop's SMLib a18bbe5 lines
  too. The first full run trims both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 16:42:23 -05:00
jyviko 3cbcf0315a Merge remote-tracking branch 'upstream/develop' into merge-main-develop
# Conflicts:
#	tests/kernel-cases/fillets/KNOWN_FAILING
2026-11-02 15:45:18 -05:00
jyvikoandClaude Opus 5.5 653c16e6f5 Native B-rep: a ball patch is its own surface kind, read from and written to SMLib's flat kind 6
SMLib's flat arrays now carry the corner of three equal rounds as `SURFACE_BALL_PATCH` (kind 6): its net as a NURBS face's block, with its sphere's centre and radius as its definition (ids 36 and 166). The record reads it as `ball_patch {center, radius}`, a label like the analytic kinds, with the net as its `nurbs`. A plain sphere with a form won't do: the net is not a piece of SMLib's sphere NURBS, so SMLib's `IsNurbSurfaceSphere` would refuse it.

Written back, a ball patch is kind 6 with the same definition, which SMLib takes once its net is certified on that sphere. Elsewhere:
- Offsets classify it as its sphere, so its offsets stay exact and collapse at the centre.
- Face kinds count it as a sphere: fillet_three_edges_at_a_corner's corner is now `sphere`, no longer `other`.
- STEP, which has no ball-patch entity, gets the net as the face's B-spline surface, pcurves included.
- Iso curves and SSI of the label are refused; the face's form is what evaluates.

Test: a_rounded_cubes_ball_patches_go_round_with_their_spheres. The cube's eight corners are ball patches about the corners pulled in by r. Points of each patch lie on its sphere to 1e-12. The patches are kind 6 again after import, with the same definitions bit for bit, and the closed-form volume holds.

Format: pending/ball-patch-faces.rs. Docs: docs/native-brep.md and the rig README's `surface_types` (`ball_patch`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 15:44:41 -05:00
brett19andClaude Opus 5.5 e30cfd2acf Tests and the rig for a default build without the C++ kernel
- step_in's a_solid_smlib_refuses_with_its_faces_is_refused_not_meshed assumed
  a build without SMLib has no kernel; on solidcore the cube imports, so it
  now runs only under SOLIDCRAFT_KERNEL=smlib and says it skipped otherwise.
- rounds_on_the_871_part and mitred_rounds_follow_a_moved_top compare with
  the C++ kernel (listed in tests/KNOWN_FAILING_TESTS) when it is built; their
  solidcore half runs as *_on_solidcore on a build without it, so each list
  entry is graded only where its comparison runs.
- kernel-cases without --cli builds the CLI once (with --features smlib when
  a run asks for the C++ kernel) before the cases, so the first cases don't
  spend their timeout compiling it.
- rustfmt for diagnostics.kernel's message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 12:30:22 -07:00
brett19andClaude Opus 5.5 5a93e6c4d2 Make the C++ SMLib kernel opt-in at build time (feature smlib, off by default)
solidcore, the pure-Rust kernel, is always built and stays the default. The
`smlib` feature (apps, engine, kernel; solidcraft-smlib's `native`) now has
to be asked for to compile and link SMLib: the app, the CLI and the web app
drop it from `default`, and solidcraft-gpu's dev-dependency no longer forces
it on. Without it no C++ toolchain, fetch-smlib.sh, prebuilt or build.rs work
is needed.

On a build without it, asking for the C++ kernel (SOLIDCRAFT_KERNEL=smlib,
diagnostics.kernel, the rig) is refused with Error::NotBuilt, which now says
"this build doesn't include the C++ SMLib kernel; build with --features
smlib", and SOLIDCRAFT_KERNEL=smlib logs that once. `cargo xtask
kernel-cases` builds the CLI with --features smlib only when --kernel smlib
or both asks for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 10:56:02 -07:00
brett19andClaude Opus 5.5 d7ef9771bc Merge fork/smlib be78372b2 (twisted sweep circles as exact cylinders, solidcore#2184) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-02 04:23:22 -07:00
brett19andClaude Opus 5.5 be78372b2e Twisted sweep: circles about a straight path are exact cylinders (solidcore#2184)
A twist about a straight path maps a profile circle centred on the path's
line onto itself, so its swept wall is exactly the cylinder. The skin
through the stations stayed within 3.9e-9 of it (6.6e-9 on the outer wall),
and a boolean with another body on that cylinder failed with status 1001
(solidcore#2184; the kernel's handling of a B-spline face lying on a
cylinder stays open there).

sweep_controlled now builds those walls exactly when the path is lines
along the profile's normal and there is no end scale or rails: a profile
whose every loop is such a circle is swept untwisted, and such holes in
another outer loop are cut as exact cylinders from the skinned sweep of
the rest. Other loops, and an axis-centred arc inside a loop of other
curves, are skinned as before; a failed cut falls back to skinning all.

Regression test in smlib_sweeps_tests.rs: #2184's tubes joined at 10, 16,
18, 20 and 30 degrees give one closed body of 11.5625 pi with cylinder
walls; a twisted hexagon with the bore keeps a cylinder bore.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 04:19:04 -07:00
brett19 c043e0b873 Merge ws/sync-4 (smlib with develop f916a8d and main 0.30) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	crates/kernel/src/blend_smlib.rs
#	tests/KNOWN_FAILING_TESTS
2026-11-02 03:03:21 -07:00
brett19andClaude Opus 5.5 083b525adf Merge origin/main into smlib
Conflicts kept both sides:
- eval.rs: main's thread-search change (#10227) moved into develop's eval_thread.rs; construction axis/point source bodies with the branch's fallible construction_state; main's identity shortcut in the branch's fallible placed().
- eval_more.rs: main's box helpers and beyond_cylinder_reach kept (main's cut and tap-marking code uses them), body_box meshing through Body::mesh.
- project3d/project.rs: SMLib meeting_edges kept; a face pick now takes its whole surface patch (#9009) through meeting_edges over a set of faces.
- frames.rs: main's split_move (#9660) with the branch's fallible to_local.
- ao.rs: main's draw_opaque with the branch's open-body triangles.
- dialogs.rs, move_preview.rs, viewport.rs: both sides.
- Generated files from main. Tests calling world_state() unwrap its Result.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-02 01:33:06 -07:00
brett19 a8202960b9 Merge origin/develop into smlib (SMLib pin f916a8d)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	.github/workflows/ci.yml
2026-11-02 01:22:44 -07:00
jyvikoandClaude Opus 5.5 597b23ba8e Sheet metal: cuts and holes pass over sheets and bends by their exact boxes, never a mesh's
A primitive cut skips the sheets kernel::apart (exact bounds grown by the record tolerance)
finds clear of its tool; the bend check leaves the clear case to kernel::boolean, which answers
it from the same exact boxes with no intersection work. The mesh-box helpers are gone, and their
four lines leave xtask/mesh-decisions.txt (172 sites left).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 02:58:29 -05:00
jyvikoandClaude Opus 5.5 5d168a5e26 Kernel tests: SMLib's own corner between curvature rounds is curvature continuous, as the G2 patch is
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 22:57:24 -05:00
jyvikoandClaude Opus 5.5 e6db7be0af Kernel tests: three rounds of different radii at a corner meet in SMLib's setback corner
Each round runs whole to its section square to its edge at its setback (the owner's rule, at
least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the
setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1.
Outside the box the sections span the body is the three strips', so its volume is theirs within
that box's. A later r3 round at the mitred corner makes the body all three at once make
(7928.142563938, 15 faces), as the engine and the model-cache tests have it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 22:57:24 -05:00
jyvikoandClaude Opus 5.5 5136898b9d Fillet: a setback too short for its corner is refused naming the least that builds (smlib_blend_fit_size)
SMLib's setback corner takes a G1 fill only once certified convex, and refuses a setback too
short for that as SMLIB_ERR_NO_ROOM with SMLIB_FIT_SETBACK_AT_LEAST, the smallest setback that
builds. The kernel reads it (solidcraft-smlib binds smlib_blend_fit_size) and names it; the
Fillet dialog says it in plain words. Other room refusals keep their words. The r5 box corner
set back 5.5 is refused naming 5.962, which builds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 22:57:24 -05:00
brett19andClaude Opus 5.5 e1ca2fd883 Merge smlib into solidcore
smlib b7e83cd7c: origin/develop (SMLib pin 5e8c9c1) and origin/main.

Conflicts, both sides kept:
- Cargo.toml: solidcore's pinned solidcore dependency beside main's solidcraft-testkit.
- tests/KNOWN_FAILING_TESTS: solidcore's default-kernel list kept (refreshed from this
  merge's run in a following commit); smlib's list for SMLib 5e8c9c1 becomes
  tests/KNOWN_FAILING_TESTS.smlib.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 20:45:19 -07:00
brett19andClaude Opus 5.5 dd00ff989f Native wire fixture: a box edge round's cylinder keeps its own frame
With swap_uv_keeps_analytic_definition (#2281) on, the fillet's cylinder in
box_and_fillet_have_stable_wire_records keeps the frame it was made with:
its origin moves along the axis from x = 0 to x = -20 (the edge runs x 0 to
40), with the same axis, radius 2 and trims; the last bits of the axis and
radius move with it. The same surface; turning that flag alone off gives
the old record back. Re-blessed with NATIVE_BREP_BLESS=1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 20:39:18 -07:00
brett19andClaude Opus 5.5 4c1eed9603 Tabbed plate: the rim and one corner arc round together (solidcore#2223)
solidcore#2223 (closed by #2302, under fillet_section_end_trim_at_creases):
the R25 rim and the x > 0 R2 corner arc rounded together at r 0.5 on the
plate 2 high take off 8.117810114 (the rim's 7.958674274526857 and the
corner arc's Pappus 0.15913583972191622) within 1e-7, 12 faces, valid. A
new test beside the tabbed-plate test, which shares its outline.

The tabbed-plate test gets past that pair and now stops at the two R2
corner arcs picked together: 1001 in trim_at_creases (cliff_overflow with
the crease trims off), though each builds alone (solidcore#2314). Its
known-failing line says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 19:33:33 -07:00
brett19andClaude Opus 5.5 81c02315c5 Merge smlib 876203621 into solidcore: the STEP torn-ball fix and four review test fixes
The four tests fixed on smlib (lid ring sketch, curve-id seam, timeline chip, viewport culling)
leave both known-failing lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 18:38:04 -07:00
brett19andClaude Opus 5.5 9ed5b2c50c Merge origin/develop into smlib
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 18:37:15 -07:00
brett19andClaude Opus 5.5 3b4adeb73b solidcore: a variable round is built again, as the union of its balls
With #2262 and fillet_gn_section_generator on, solidcore builds a
variable round as the union of its balls, so fillet_variable's
refusal from sync-2 (9f64cce54, solidcore#2250) comes off. Laws with a
corner stay refused (solidcore#430); a law whose balls fold is refused
by solidcore (NoRoomReason::BallsFold) and arrives as Error::NoRoom.

Against closed forms, solidcore and SMLib d01d7b0 agreeing to 1e-11:
- 1 to 3 along 30 mm removes 27.858907 against the balls' union's
  27.857434 (great circles 27.898239); a law of one radius 2 removes
  25.753574 against (1 - π/4) 4 · 30 = 25.752220: both 5.3e-5 over,
  the solver's surface fit, as on the C++ kernel.
- the rig's 1 to 5 cone: 11956.21991 against 11956.22243 (2.1e-7).
- kernel tests: a_linear_radius_runs_from_the_start_end (18.5378),
  variable_radius_on_a_box_edge, down_to_zero (22.5949),
  taper_follows_the_room (the wedge 5245.68 against the balls'
  union) pass.

The refused test becomes a_variable_round_is_the_union_of_its_balls
(the two closed forms, either direction, a folding law refused, a pick
miss named first). the_wedge_round_keeps_its_volume held 5223.0386,
measured before the fork's balls' union; it now takes its closed form
from removed_by_balls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 18:32:30 -07:00
jyvikoandClaude Opus 5.5 72109054c1 Kernel tests: the box-and-fillet wire fixture records the round's cylinder frame as SMLib now keeps it
The round's cylinder keeps the frame it was made on when it is turned (SMLib's SwapUV no longer
re-derives it): its origin sits at x = −20 on the same axis line, (x, 2, 8) along x, radius 2.
Same cylinder; one number in the record moves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 19:01:31 -05:00
jyvikoandClaude Opus 5.5 38385ab5d3 Kernel tests: three rounds at a box corner end on one rational patch on the ball's sphere, not an analytic sphere
SMLib's Ball corner is always the rational patch exactly on the sphere (owner ruling, blend
design §23), so the corner counts as an 'other' face beside the three cylinders and six planes.
The removed volume still checks the corner against r³ − πr³/6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 19:01:31 -05:00
jyvikoandClaude Opus 5.5 bf51e62f7b Kernel tests: a law's dip shows its corner ball's sphere, a peak's two rounds cross (the reasons had them swapped)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 19:01:31 -05:00
brett19 5fbece0acc STEP import: a ball's halves whose seams are off each other's quarter lines each form within one turn
A sphere split into two halves along a circle about its axis, each half covering a pole with no
seam, gets a seam per half from the first vertex of its loop to the pole. The circles between the
halves group their frames so they turn together, and when the two seams are not a whole number of
quarters apart no one turn fits both: the group kept its frames, a half's form ran past one turn,
SMLib's trim (SMLib and solidcore alike) across the form's end crossed the face, and the mesh
folded over the ball (a rotor's ball showed torn; its half had 196 times its area in triangles).

When no one turn fits the group, each spilling face is now turned on its own to start on a quarter
line. On the rotor file this also clears three other faces that were filled leniently and a
0.076 mm edge gap; regression test in step_in/tests.rs with the area and volume of each half.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
(cherry picked from commit b3188e005d427043b918267449c2336a1777e54f)
2026-11-01 16:34:04 -07:00
brett19andClaude Opus 5.5 e9ac0e606e solidcore: a curvature fillet is refused until solidcore has the equal-area Gⁿ section
SMLib d01d7b0's capi builds the curvature section as the Gⁿ generator's order 2 at the
equal-area thumbweight (fork 6148773), taking off (1 - π/4) r² at a square corner. Our capi
port still built solidcore's blend-curve quintic (113/756 r²): a body every check passes,
off the closed form (862's box edge 7892.38 against 7845.49). solidcore has no Gⁿ generator
yet (solidcore#2250, port in progress as #2260), so Blend::Curvature now gives
Error::Unported, "not supported yet" with the issue, rather than another section. The
refusal comes off when the pin carries #2260 and 6148773 with fillet_gn_section_generator on.

The C++ closed-form case takes the equal-area volume; its solidcore twins are ignored until then.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 11:47:31 -07:00
brett19 ff894bfb67 Merge smlib 4afadeed5 (develop 6ba069d06, main 176c22aca) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	crates/smlib/src/ops_tests.rs
#	tests/KNOWN_FAILING_TESTS
2026-11-01 11:16:50 -07:00
brett19 c8318cd3b9 Merge develop 6ba069d06 into smlib
KNOWN_FAILING_TESTS: kept both sides' lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	tests/KNOWN_FAILING_TESTS
2026-11-01 11:15:21 -07:00
jyvikoandClaude Opus 5.5 0b1cc8a8c2 Kernel tests: a spline radius whose balls fold over one another at its peak is refused
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:00:02 -05:00
jyvikoandClaude Opus 5.5 7bba3092c6 Kernel tests: variable rounds graded by the union of their balls, the removed volume to 1e-4 of itself
removed_by_balls integrates, in each plane square to a right-angled edge, the corner the union
of the balls leaves (by rays from the edge, the least entry over the balls), cut to the body's
section. The law with a corner through a middle point is its own test, listed as failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:00:02 -05:00
jyvikoandClaude Opus 5.5 4df3adc5a7 Curvature fillets: the section's default thumbweight is equal area, so the round's volumes are the circle's
On the round's rails the order-2 section takes off what the ball's circle does: (1 - pi/4) s^2 at a
square corner, first moment 0.0474559669443 s^3 (w = -0.5252123889). The kernel and engine tests
and the curvature rig cases take their volumes from it by their own methods; the pipe on the plate
from its own wedge (70.52878 degrees, w = -0.8544103493). The G2 corner patch's seam test is listed
until the corner step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 11:00:02 -05:00
brett19andClaude Opus 5.5 0aff357051 Merge fix: solidcore reads planar sheets without SMLib, so their edge reader is always built
smlib's 4627402e4 built prism_curve::projected only with the smlib feature, where its one caller
lived; on solidcore that caller (prism.rs sheets) is built without it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 07:33:59 -07:00
brett19andClaude Opus 5.5 486bdf7e66 Merge fork/smlib into solidcore
smlib 4627402e4 brings origin/main be425c610.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 07:14:59 -07:00
brett19andClaude Opus 5.5 4627402e40 Clippy without SMLib: the planar-sheet edge reader is built only with it
Its one caller is in the smlib-only sheets module, so without the feature it was dead code and
clippy -D warnings refused the kernel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 06:41:27 -07:00
brett19andClaude Opus 5.5 d076a69e75 Merge smlib (main + develop) into solidcore
The hole and placement sections stay on main's Tools page and network locations on its General page; the geometry kernel section stays on the Design page. prepare_preferences refuses a kernel choice before main's checks. tests/KNOWN_FAILING_TESTS keeps solidcore's lines until rebuilt from a run on this tree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 23:26:14 -07:00
brett19andClaude Opus 5.5 afb55d806b One kernel flag: solidcore, the default, or smlib; routed is gone
The process runs on one kernel, so `Choice` and the routing table (`Op`, `Overrides`,
SOLIDCRAFT_KERNEL_ROUTES) go, and every call asks `route::backend()`. SOLIDCRAFT_KERNEL takes smlib or
solidcore as before.

- The preference offers solidcore and SMLib. A saved `routed` loads as solidcore without an error;
  asked for now, by ui.prefs or diagnostics.kernel, it is refused. Another unknown saved value stays
  as saved and runs on the default, as it did.
- diagnostics.kernel answers {choice, environment}. `smlib` on a build without the C++ kernel, wasm
  included, is refused as not available, never answered by the other kernel; a saved `smlib` there
  says so on the status line and the preference page.
- The conversion between kernels stays: a body computed before the choice changed still needs it, and
  so do the parity tests.

The notes' translations in 6 languages and the new message's are machine-written, not reviewed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 21:48:18 -07:00
brett19andClaude Opus 5.5 48fcb7aac1 Merge fixes from the ui test pass and the gates
Main's thread.direction keys go with develop's thread hand, which replaced them. Vietnamese for the
messages develop added while main made vi a complete catalog. CGA and 1-bit themes set develop's
comb and section hatch colours. A ribbon button with a persistent effect is pressed only while its
tool runs, so persistent_ribbon_pressed alone decides how its effect is shown; other analyses stay
pressed while on. Two of main's ui tests listed as failing on SMLib, with why.
Gates: fixed thread tables become slices, one collapsed if, rustfmt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 19:38:55 -07:00
brett19 51d7ad09e2 A blend's pick measures close edges on their curves, not their polylines
A polyline can be a chord off its edge, more than two edges are apart near a
tangent point. A pick exactly on a ball's rim took the straight edge the rim is
tangent to, and solidcore built a chamfer of that edge with a clean check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
(cherry picked from commit c786db6bf4)
2026-10-31 17:48:35 -07:00
brett19andClaude Opus 5.5 c786db6bf4 A blend's pick measures close edges on their curves, not their polylines
A polyline can be a chord off its edge, more than two edges are apart near a
tangent point. A pick exactly on a ball's rim took the straight edge the rim is
tangent to, and solidcore built a chamfer of that edge with a clean check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 17:46:08 -07:00
brett19andClaude Opus 5.5 b3ef6ae52e Hidden lines: kernel bodies through the production prepare against closed forms
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 17:27:37 -07:00
brett19 4b2d226be2 Merge the hidden-line port to develop's record model 2026-10-31 17:25:16 -07:00
brett19andClaude Opus 5.5 e4977721fe Hidden lines: a traced intersection is drawn only where its spline lies on both surfaces
A leader off either surface is refused like a curve with no spline to follow. Tests: a traced rim
drawn on the circle and plane within tolerance, the same leader 1 mm off refused, and kernel bodies
with arcs through the production prepare against closed forms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 17:25:16 -07:00
brett19andClaude Opus 5.5 1b17dd7f54 Merge fixes: every crate and test target compiles on the merged tree, but for crates/geom's hlr
world_state, view::bounds, home_camera and scene return Result on develop; new
main code takes that with ? or session_world. New fixtures carry the spline's
nurbs. ForeignCopy::of returns Result. occurrence_placement_with walks the path
with its moves, since the placement index holds pending_moves only.

The hlr port is separate and still to come: this commit does not compile as it
stands in crates/geom/src/hlr.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 17:01:30 -07:00
brett19andClaude Opus 5.5 5a161e542b Merge main into smlib (develop): 76 conflicting files resolved
main beb35029a (Release 0.29.0), develop 05f5e8601. Committed as resolved and
not yet compiling; fixes follow by layer.

Where the two sides could not both stay as written:
- Section caps: develop's stencil crossing count (with hatch by part) kept;
  main's WINDING/NOT_CAP marking and its fs_solid_touch removed. main's #9407
  test is kept and has to hold on the count.
- crates/kernel/src/prism.rs: develop's, which has no 3D prism boolean; main's
  #6904 route has nothing to change there. Its test still has to be ported.
- Continuity legend: main's details card, with develop's G3/G4 classes.
- inspect.analysis one at a time: while main's "several analyses" preference is
  set, turning one on leaves the others on.
- Model cache: FORMAT 8, since neither side's reader reads the other's records.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 16:40:37 -07:00
brett19andClaude Opus 5.5 25d376f0f5 Merge ws/pin-9 into ws/default-solidcore
Keeps the failure dumps on solidcore's brep_copy; KNOWN_FAILING_TESTS stays
solidcore's, KNOWN_FAILING_TESTS.smlib takes develop's C++ list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 14:59:38 -07:00
brett19andClaude Opus 5.5 7f1bf7cde6 Merge origin/develop 88e00486b
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 09:34:28 -07:00
brett19andClaude Opus 5.5 c5e4a42f4f Format
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 08:20:36 -07:00
brett19andClaude Opus 5.5 99ba9dfb1a Tests known to fail, one list per kernel; untrim carries history tags; fix two tests
KNOWN_FAILING_TESTS is now solidcore's, the default; KNOWN_FAILING_TESTS.smlib keeps
the C++ kernel's. A face copied out for untrimming now carries its tags on solidcore.
The profile test accepts either kernel's spans; ssi_corpus skips a kernel the
environment overrides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 07:42:22 -07:00
jyvikoandClaude Opus 5.5 88e00486bb STEP import: a face bounded by a slit alone is the whole of its closed surface
A loop that runs out along a chain of edges and straight back (a meridian from a sphere's pole
stopping short of the other, out and back) encloses no (u, v) area, yet on a closed surface it
bounds all of it less a cut of none. The reader only read such a face when the slit already ran
pole to pole (and moved the sphere's frame onto it only then), so the 2 mm ball whose meridian
stops at 2.5 rad was refused for its empty loop.

The slit is now made the face's seams, so its loop bounds the surface's whole domain: on a
sphere, a revolution whose profile ends on its axis, or a spline closed round u that collapses
at both ends, the slit's meridian is run on to both poles, out and back (a sphere's frame put
on the slit first, whichever two points it joins); on a torus, the circle the slit lies along is
closed and the other circle through its start is the second seam. The seams on a sphere are its
own meridians (angle 0 on the equator), so their pcurves are exact lines on its form.

Tests: non_antipodal_seam_sphere_imports_as_a_whole_ball passes (its known-failing line goes);
seam_only_torus_imports_as_a_whole_ring adds a torus bounded by a slit along its tube.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 10:05:22 -04:00
jyvikoandClaude Opus 5.5 77f127c61e STEP import: a face bounded by seams alone runs its loop the other way, never turns over
A loop that uses each of its edges once each way (a whole torus within its tube and ring seams)
is the same set of uses run backwards, so it says nothing of the face's side. One written
clockwise in (u, v) turned the face over, against its same_sense: the torus came in inside out
with a warning. Such a loop is now reversed and the face keeps its side.

Test: seam_only_torus_imports_as_a_whole_ring, both orders of the two seams, volume 2π²Rr².

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 10:05:22 -04:00
brett19andClaude Opus 5.5 c26f9760de Merge develop b0d1ba345 into solidcore
SMLib moves to 26cc451 with develop. Merged cleanly; the kernel test
changes are develop's, moved or tightened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 06:48:37 -07:00