Commit Graph
153 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 25175d68ca Merge #8526 (brett19/solidcore e30cfd2ac): solidcore as the default kernel, C++ SMLib behind --features smlib
Three conflicts:
- crates/smlib flat.rs and export.rs: #8526's export copies the C++
  arrays by id range; the ranges now run to the ball-patch arrays
  (FACE_DEFINITION_REAL_COUNT, FACE_DEFINITION_REALS), with
  WIRE_EDGE_NURBS_FORM (35) and FACE_DEFINITION_REAL_COUNT (36) both kept.
- tests/KNOWN_FAILING_TESTS: solidcore's lines and develop's, each test
  once; tests/KNOWN_FAILING_TESTS.smlib takes develop's SMLib a18bbe5 lines
  too. The first full run trims both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 16:42:23 -05:00
jyviko 3cbcf0315a Merge remote-tracking branch 'upstream/develop' into merge-main-develop
# Conflicts:
#	tests/kernel-cases/fillets/KNOWN_FAILING
2026-11-02 15:45:18 -05:00
jyvikoandClaude Opus 5.5 653c16e6f5 Native B-rep: a ball patch is its own surface kind, read from and written to SMLib's flat kind 6
SMLib's flat arrays now carry the corner of three equal rounds as `SURFACE_BALL_PATCH` (kind 6): its net as a NURBS face's block, with its sphere's centre and radius as its definition (ids 36 and 166). The record reads it as `ball_patch {center, radius}`, a label like the analytic kinds, with the net as its `nurbs`. A plain sphere with a form won't do: the net is not a piece of SMLib's sphere NURBS, so SMLib's `IsNurbSurfaceSphere` would refuse it.

Written back, a ball patch is kind 6 with the same definition, which SMLib takes once its net is certified on that sphere. Elsewhere:
- Offsets classify it as its sphere, so its offsets stay exact and collapse at the centre.
- Face kinds count it as a sphere: fillet_three_edges_at_a_corner's corner is now `sphere`, no longer `other`.
- STEP, which has no ball-patch entity, gets the net as the face's B-spline surface, pcurves included.
- Iso curves and SSI of the label are refused; the face's form is what evaluates.

Test: a_rounded_cubes_ball_patches_go_round_with_their_spheres. The cube's eight corners are ball patches about the corners pulled in by r. Points of each patch lie on its sphere to 1e-12. The patches are kind 6 again after import, with the same definitions bit for bit, and the closed-form volume holds.

Format: pending/ball-patch-faces.rs. Docs: docs/native-brep.md and the rig README's `surface_types` (`ball_patch`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 15:44:41 -05:00
brett19andClaude Opus 5.5 5a93e6c4d2 Make the C++ SMLib kernel opt-in at build time (feature smlib, off by default)
solidcore, the pure-Rust kernel, is always built and stays the default. The
`smlib` feature (apps, engine, kernel; solidcraft-smlib's `native`) now has
to be asked for to compile and link SMLib: the app, the CLI and the web app
drop it from `default`, and solidcraft-gpu's dev-dependency no longer forces
it on. Without it no C++ toolchain, fetch-smlib.sh, prebuilt or build.rs work
is needed.

On a build without it, asking for the C++ kernel (SOLIDCRAFT_KERNEL=smlib,
diagnostics.kernel, the rig) is refused with Error::NotBuilt, which now says
"this build doesn't include the C++ SMLib kernel; build with --features
smlib", and SOLIDCRAFT_KERNEL=smlib logs that once. `cargo xtask
kernel-cases` builds the CLI with --features smlib only when --kernel smlib
or both asks for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU
2026-11-02 10:56:02 -07:00
jyvikoandClaude Opus 5.5 a840c9cd31 Merge main (01b592e0c): its 20 commits since brett's sync 5
Conflicts:
- doc/eval.rs: ours. Main's #6452 adds a `copy` flag so a pattern's or mirror's copy skips the join-end trimming. This branch has no join-end trimming, so the flag has nothing to switch, and its parameter is removed rather than kept unused. #10698's exact cone and torus normals merged cleanly.
- doc/sheet.rs, engine/cmd/sheet_tests.rs, gpu/tests.rs: both sides added beside each other; both kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-02 10:14:29 -05:00
Colin Faulkingham c4808e4715 MCP: clean up empty scratch folders on shutdown (#7836) (#7929)
* claim: #7836

* fix(mcp): remove empty scratch directories on command exit
2026-11-02 13:57:48 +00:00
brett19 c043e0b873 Merge ws/sync-4 (smlib with develop f916a8d and main 0.30) into solidcore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	crates/kernel/src/blend_smlib.rs
#	tests/KNOWN_FAILING_TESTS
2026-11-02 03:03:21 -07:00
brett19 a8202960b9 Merge origin/develop into smlib (SMLib pin f916a8d)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz

# Conflicts:
#	.github/workflows/ci.yml
2026-11-02 01:22:44 -07:00
jyviko ce3ad4d96d Merge remote-tracking branch 'upstream/develop' into merge-main-develop 2026-11-02 01:52:57 -05:00
jyvikoandClaude Opus 5.5 e6db7be0af Kernel tests: three rounds of different radii at a corner meet in SMLib's setback corner
Each round runs whole to its section square to its edge at its setback (the owner's rule, at
least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the
setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1.
Outside the box the sections span the body is the three strips', so its volume is theirs within
that box's. A later r3 round at the mitred corner makes the body all three at once make
(7928.142563938, 15 faces), as the engine and the model-cache tests have it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 22:57:24 -05:00
brett19andClaude Opus 5.5 e1ca2fd883 Merge smlib into solidcore
smlib b7e83cd7c: origin/develop (SMLib pin 5e8c9c1) and origin/main.

Conflicts, both sides kept:
- Cargo.toml: solidcore's pinned solidcore dependency beside main's solidcraft-testkit.
- tests/KNOWN_FAILING_TESTS: solidcore's default-kernel list kept (refreshed from this
  merge's run in a following commit); smlib's list for SMLib 5e8c9c1 becomes
  tests/KNOWN_FAILING_TESTS.smlib.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 20:45:19 -07:00
brett19andClaude Opus 5.5 9ed5b2c50c Merge origin/develop into smlib
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 18:37:15 -07:00
jyvikoandClaude Opus 5.5 970446dec0 Kernel rig: a case's continuity can ask for an order per seam (seams: [{order, edges, exact}])
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
2026-11-01 20:03:30 -05:00
brett19andClaude Opus 5.5 6de10a7fbd Model cache test: say why it reaches the C++ kernel
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 01:46:24 -07:00
brett19andClaude Opus 5.5 4a98a1f8a4 Model cache: a saved model is its kernel's
The cache key did not name the kernel, so a design saved on solidcore opened under SOLIDCRAFT_KERNEL=smlib showed solidcore's bodies, and the other way round. Case fillets/report-fillet-concave-arc-and-front-top-edge-together-r7-solver-residues: saved on solidcore and opened on C++ gave volume 9446.261 (C++ evaluates 9453.338); saved on C++ and opened on solidcore gave 9453.338 (solidcore evaluates 9446.261). The manifest now records the kernel and a cache of another kernel, or of none, is a miss: the design is evaluated on the kernel in force.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz
2026-11-01 00:42:31 -07:00
brett19andClaude Opus 5.5 d076a69e75 Merge smlib (main + develop) into solidcore
The hole and placement sections stay on main's Tools page and network locations on its General page; the geometry kernel section stays on the Design page. prepare_preferences refuses a kernel choice before main's checks. tests/KNOWN_FAILING_TESTS keeps solidcore's lines until rebuilt from a run on this tree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 23:26:14 -07:00
brett19andClaude Opus 5.5 afb55d806b One kernel flag: solidcore, the default, or smlib; routed is gone
The process runs on one kernel, so `Choice` and the routing table (`Op`, `Overrides`,
SOLIDCRAFT_KERNEL_ROUTES) go, and every call asks `route::backend()`. SOLIDCRAFT_KERNEL takes smlib or
solidcore as before.

- The preference offers solidcore and SMLib. A saved `routed` loads as solidcore without an error;
  asked for now, by ui.prefs or diagnostics.kernel, it is refused. Another unknown saved value stays
  as saved and runs on the default, as it did.
- diagnostics.kernel answers {choice, environment}. `smlib` on a build without the C++ kernel, wasm
  included, is refused as not available, never answered by the other kernel; a saved `smlib` there
  says so on the status line and the preference page.
- The conversion between kernels stays: a body computed before the choice changed still needs it, and
  so do the parity tests.

The notes' translations in 6 languages and the new message's are machine-written, not reviewed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 21:48:18 -07:00
brett19andClaude Opus 5.5 1b17dd7f54 Merge fixes: every crate and test target compiles on the merged tree, but for crates/geom's hlr
world_state, view::bounds, home_camera and scene return Result on develop; new
main code takes that with ? or session_world. New fixtures carry the spline's
nurbs. ForeignCopy::of returns Result. occurrence_placement_with walks the path
with its moves, since the placement index holds pending_moves only.

The hlr port is separate and still to come: this commit does not compile as it
stands in crates/geom/src/hlr.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 17:01:30 -07:00
brett19andClaude Opus 5.5 5a161e542b Merge main into smlib (develop): 76 conflicting files resolved
main beb35029a (Release 0.29.0), develop 05f5e8601. Committed as resolved and
not yet compiling; fixes follow by layer.

Where the two sides could not both stay as written:
- Section caps: develop's stencil crossing count (with hatch by part) kept;
  main's WINDING/NOT_CAP marking and its fs_solid_touch removed. main's #9407
  test is kept and has to hold on the count.
- crates/kernel/src/prism.rs: develop's, which has no 3D prism boolean; main's
  #6904 route has nothing to change there. Its test still has to be ported.
- Continuity legend: main's details card, with develop's G3/G4 classes.
- inspect.analysis one at a time: while main's "several analyses" preference is
  set, turning one on leaves the others on.
- Model cache: FORMAT 8, since neither side's reader reads the other's records.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 16:40:37 -07:00
brett19andClaude Opus 5.5 25d376f0f5 Merge ws/pin-9 into ws/default-solidcore
Keeps the failure dumps on solidcore's brep_copy; KNOWN_FAILING_TESTS stays
solidcore's, KNOWN_FAILING_TESTS.smlib takes develop's C++ list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 14:59:38 -07:00
Colin Faulkingham bba2fc1400 Report omitted print-face selections in command-script exports (#10230) (#10235)
* claim: #10230

* fix: report omitted print-face assignments in script exports
2026-10-31 19:58:48 +00:00
jyvikoandClaude Opus 5.5 780a0652d9 Kernel rig: a volume or area can be graded as a hand-derived range where analysis only bounds it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 09:33:29 -04:00
Dahak BuildsandDahak Builds 34c378c063 Save As: rename the design to the new file's name (#4907) (#10036)
* claim: #4907

* Save As: rename the design to the new file's name when its name was borrowed (#4907)

---------

Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
2026-10-31 13:22:10 +00:00
brett19andClaude Opus 5.5 ee078b97c4 smlib: no unrouted C++ path on solidcore; .smb files move too
Native files run on solidcore through its public api_files (each kernel reads the other's, in both
forms). face_points routes with Split, pcurves with Convert, and an ssi::Surface no longer needs the
C API: its arguments are checked here as the C API checks them, and the C side is made only when a
family on the C++ kernel asks. intersect, domain and evaluate have no solidcore path and refuse with
Error::NotOnSolidcore. Planar region booleans and the rig CLI no longer need the smlib feature.

Tests that exercise the C++ kernel opt in per thread (route::on_cpp), so parity tests keep comparing
two kernels instead of solidcore with itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
2026-10-31 02:35:43 -07:00
jyvikoandClaude Opus 5.5 f3cf0c4f37 Model cache: a body made by rounds keeps them, so a later round blends them the same after opening
A design gave another body when opened from its model cache: the rounds a body was made of
lived only in memory, so a later round at their mitre was built sequentially (or refused, as
too large) after opening and blended with them when evaluated anew. The saved model now
records, per kernel body made by rounds, the body they were made on (a place in the bodies,
stored once though no state holds it) and the edges with their radii; reading it attaches
them back down each chain, and a thinned model keeps those bodies with the bodies made from
them. Model cache format 7.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 19:19:30 -04:00
jyvikoandClaude Opus 5.5 709765fcae Model cache: a saved model records its body check mode and is adopted under it
Since the body check mode became part of the evaluation context (9acbcf924),
evaluate digests the context with the mode, but Model::adopt still took the
context without it and the default mode: the first evaluation after opening a
design from its saved model saw another context and recomputed every feature
(undoing_an_edit_after_opening_reuses_the_saved_results,
rolling_the_marker_back_keeps_results_after_cache_eviction). The saved model
now records the mode it was evaluated under (thinned ones too), adopt takes
it and digests the context as evaluate does, and a session opening a design
under another mode evaluates it again rather than showing that mode's results.
Model cache format 6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 15:19:33 -04:00
jyvikoandClaude Opus 5.5 d3766865a0 Tests: old designs open and evaluate; what they rebuild to is today's
Tests that asserted an older design rebuilds as the build that saved it made it
now assert what still holds: it opens, is upgraded, evaluates, round trips and
names alike every time, and a feature that lost a reference asks for it again.

- naming corpus: two builds still name every face and edge alike and find the
  same faces with their stored names; a stored name that finds nothing must
  leave its feature failed (it asks to reselect), never a feature that builds.
  A sketch's face is found by its name as the sketch finds it.
- design corpus: the volumes, areas and bounds the saving builds recorded are
  no longer compared; a corpus design may fail only by a request to reselect,
  and undo leaves the features that failed on opening failed.
- fixed robustness seeds: no panic, valid bodies and volumes moving the right
  way; a step the kernel refuses is not a bug.
- a format 28 design's pieces and a format 13 design's extra bodies: marked as
  they open and named alike, without promising the numbers or names saved.
- action matrix baseline: the two corpus designs whose fillets, chamfer and
  offset face held names saved before format 14 re-recorded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 14:31:23 -04:00
jyvikoandClaude Opus 5.5 ef37bd4459 doc: names saved before format 14 find nothing; their features ask to reselect
Face and edge names stored before format 14 were worked out from geometry and
open marked `?`. They were found among the names geometry gives today, as the
builds that saved them found them, pieces by the one nearest the pick. They
find nothing now: the feature holding one fails, asking for its reference to be
picked again, which stores its exact name. The legacy face and edge names a
body worked out for them are gone.

The tests that found such names as saved now assert the request to reselect:
a saved strip projection, a version 9 emboss on an annulus, a format 10 face
sketch and the corpus design named with numbered pieces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 14:31:23 -04:00
jyvikoandClaude Opus 5.5 cfa6f38d6e doc, engine: a stored name finds its very face or edge, or its feature asks to reselect it
A face or edge name a feature stored finds only the face or edge it names: the
very name (or a synonym of that face), or the named piece told apart by the
faces around it. A face split into several pieces, merged into another face,
or left only as a face of the same stem is not the face that was picked, and a
name found on several bodies is told apart only by the body the reference's
point lies on. The fallbacks are gone: no piece nearest the pick, no merged
face, no edge at the picked point, no lost link that keeps its last geometry.
A feature whose stored reference finds nothing fails with DocError::Reselect:
blends, face points, sketch planes, sketch projection links, construction
references, hole reference edges, sheet bend edges and cylinder emboss.

The tests that asserted a fallback now assert the request to reselect: split
and removed fillet edges, a merged or rejoined face, a projected edge that was
split or is gone, a projection whose body went, saved strip projections after
wall coalescence, a fillet saved on a piece of a tapered side that is whole
now, a cut that starts from a piece that is no longer that piece, and a fillet
named on the lower of two stacked boxes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 14:31:23 -04:00
jyviko 1a93a39770 CLI: run and kernel-cases take the validation mode
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

solidcraft-cli run --validation MODE, kernel-cases --validation=MODE and
cargo xtask kernel-cases --validation MODE (with --ladder too), so the rig
runs under each mode.
2026-10-30 13:52:54 -04:00
jyvikoandClaude Opus 5.5 172c64cef8 Tests: the naming corpus checks that references resolve and builds agree
corpus_designs_rebuild_with_the_same_names_and_references compared every
corpus design with a text record of each body's face and edge counts and its
full name list, last written from truck's output (a55196e7a); 110 designs
differed only because SMLib keeps whole faces truck split in pieces. Those
counts and names are the kernel's, not an outcome.

The test, renamed corpus_designs_keep_their_references_and_name_alike_every_build,
now asserts invariants only, with no record:
- every design loads; one that does not is a failure naming the design and
  the step (oracle/83-boundary-loop-thicken: surface.thicken, SMLib status
  1001), not a record line;
- every name a design stores (fillet and chamfer edges, faces a feature
  picks, a sketch's face, sheet metal edges) finds a face or edge: none
  `gone`, no sketch face `lost`;
- two builds give the same name -> face map: each named face's area and
  centre and each named edge's length and middle (to 1e-6 of their size), and
  the same face or edge found for every stored name.
The design already exempt for unstable piece order
(regressions/closed_sweep_torus_cut) is still only printed for the second.

On develop it fails on two designs: oracle/83 above, and
regressions/cut_up_to_face_leaves_skin, whose Extrude13 face
`F47:top#[...]` finds nothing (the truck-era record had it `gone` too). All
159 designs name alike in both builds. The records in tests/naming/ are no
longer read; CONTRIBUTING no longer asks to re-record them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 07:12:24 -04:00
jyvikoandClaude Opus 5.5 74001e5325 Tests: check what each operation is for, not how many faces it makes
The kernel switch broke these tests only through their counts, which record how a kernel splits
faces rather than whether the result is right. Each now checks its intent:
- a fitted circle is the exact circle (centre, radius, a full turn), not "one segment";
- the tight bend sweeps a valid solid of Pappus' volume, πr²(40 + 5π/2), not a count of faces,
  edges and vertices;
- the Pi case keeps each outer side one face, stays valid after every feature and rebuilds the
  same topology at 32 whether built there or edited there, without a hard-coded table of totals;
- a certified paint stays on the wall's radius and covers as many faces after an edit, a copy
  and reopening as when it was painted;
- the offset sleeve and the extended strip are checked by their exact areas only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 04:32:50 -04:00
jyvikoandClaude Opus 5.5 db757efc7c Tests: the pi case and the hole wall read as on green-truck-era-tests, so both branches agree
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 23:17:59 -04:00
jyvikoandClaude Opus 5.5 2debdd87ae Pi case test: each standoff is four faces, its walls one face each
The README demo's Raspberry Pi case stands four standoffs on its floor: Extrude2's ring of
radius 3 round a 1.25 hole, patterned by RectangularPattern1. Each is its outer wall, its inner
wall, its top and the floor inside it: four faces. The recorded counts were truck's, which made
each cylindrical wall two halves (six faces a standoff): 25 after feature 6, 43 after the
pattern, and 8 more than now at every step after it. On SMLib each wall is one face closed on
its seam, and the counts are 23, 35, 35, 47, 47, 51, 51, 55, 71 from feature 6 on (the feature
names show it: F6:side:c1, F6:side:c2, F6:top and the floor piece bounded by F6:side:c2 per
standoff). The outer sides stay one face each, and (b) and (c) still agree step by step.

Fixes cli rebuild_topology::pi_case_faces_per_step_at_both_heights.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 23:17:59 -04:00
jyvikoandClaude Opus 5.5 5c45570c91 Kernel rig: rustfmt; measured values in results are decimals, within tolerance; the ladder records 06/023 passing
The single results form compares a whole number exactly (a count). The construction and inspect
cases gave positions and volumes as whole numbers, which the form they were written for compared
within tolerance; they are decimals now. The NPT groove fix makes ladder 06/023 pass: its golden
entry is the passing run (51 faces, 8226.4042 mm3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 014a9eced5 Kernel rig: a flat_pattern field grades a sheet metal case's flat pattern
From the script's last sheet.flat_pattern result: the outline's size, its area less the
cut-outs', and the bend lines, each matched to its own one of the result's either way round.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 70f695c6ba Kernel rig: grade construction geometry and the numbers a command replies with
A case's construction field names construction points, axes and planes with the point, line or
plane each must be, and results reads values out of the commands' own replies by JSON pointer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 bc3c9185cd Kernel rig: grade the kinds of a result's surfaces, its B-spline degrees and spans, and its free edges
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 235645db50 Kernel rig: the ellipse length's Simpson weights as a named step
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
jyvikoandClaude Opus 5.5 45c9553262 Kernel rig: a case can check the files it writes and the commands' answers
A case's expected.json may name files written to $OUT (json, csv rows, or a DXF's
entity counts and curve lengths per layer) and a command's answer by step, each
matched as a part of what was made.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:08:31 -04:00
Rick MorgansandClaude Opus 5.5 4a781b8cd8 MCP: --param-check checks calls to the running app (#9072) (#9073)
* claim: #9072

* MCP: --param-check checks calls to the running app (#9072)

`mcp --connect` (and `mcp` once it bridges to an app) took
`--param-check` and forwarded every call unchecked, while the app's own
session is always off. `Remote` now checks each `engine.execute` and
`engine.batch` against this server's command contracts before sending:
`strict` refuses a call, or a batch with such a step, without sending
anything, and `warn` adds `param_warnings` to the app's reply (each
step's result in a batch). A command with no contract here goes to the
app unchecked. `Auto` carries the headless session's level over when it
bridges to a late app. `batch_preflight::contracts` is the contract half
of the existing preflight, for a runner in another process.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 00:33:42 +00:00
Rick MorgansandClaude Opus 5.5 2356a63aea CLI: run takes --param-check (#6921) (#6924)
* claim: #6921

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* CLI: run refuses unknown options and takes --param-check (#6921)

`solidcraft-cli run` now checks its options through `known_args`, so a
mistyped option fails instead of being ignored, and takes
`--param-check off|warn|strict` with the MCP server's words and default
`off`. `warn` prints each unknown key with a suggestion on stderr and
runs the step; `strict` stops at that step and writes nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* CLI: run's option check takes --param-check; warn on timed runs as steps complete

`run` keeps #6919's (#6918) unknown-option check, with `--param-check`
among the options that take a value. `Session::run_script_timed` now
takes the same per-step callback as `run_script_each`, so `run --timings`
or `--profile` at the warn level reports a step's warnings even when a
later step fails, instead of after the script (and not at all on a
failure).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 21:40:30 +00:00
kaltenbrunnermarkusandMarkus Kaltenbrunner 5f11d92458 Opening a design pins its body names, so the first undo evaluates nothing (#8939)
Problem: a design saved before body names were pinned (#6403) is pinned by its first command
that changes it, as part of that command. Undoing that command went back to the unpinned design,
whose fingerprints no evaluated result matched any more, so the first undo after opening
evaluated the whole timeline again: 63-72 s in the SELENE rover (5,484 features) when opened
from the command line or headless (`Session::opened_at`), 0.08 s with this change. `doc.open`
pinned at the end of the command instead, which kept undo fast but left the design with unsaved
changes on opening.

Solution: `Session::opened_at` pins the names as it opens the design, with the names the file's
bodies have (no result changes, so nothing is evaluated), and takes the pinned design as the
saved one: opening is no change.

Claude-Session: https://claude.ai/code/session_013WUFq6QFBqmZjxwaKy2J1M

Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
2026-10-29 18:15:47 +00:00
Andrzej Błasik cb05e1e0f7 GPU path tracer: run on Metal on macOS (#7183) (#7185)
* claim: #7183

* GPU path tracer runs on Metal on macOS, not only Vulkan (#3217)
2026-10-29 13:58:49 +00:00
jyvikoandClaude Opus 5.5 e0c7867b9b run_strict: the box's volume to 1e-9, as SMLib integrates it
allow_errors_writes_anyway_and_a_saved_design_keeps_failing compared the box's volume
with 4000.0 to the bit, which the old kernel's closed-form planar volume gave. SMLib
integrates mass properties numerically (relative accuracy 1e-4 asked for) and gives
the 20 x 20 x 10 box within a unit or two in the last place (3999.999999999999), the
correct answer to the precision the measure has. The test now checks 4000 mm³ to a
relative 1e-9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 22:13:01 -04:00
jyvikoandClaude Opus 5.5 39bf63b16a Kernel rig: designed continuity cases, G0 to G4, that prove the measurement
A new `continuity` area: seams whose order is certain by construction, each graded
`exact` (reads its order and not the next) at picked edges with Continuity Analysis's
default stations and tolerances: a box's crease (g0), a chamfer in place of a round (g0),
an r5 round on planes (g1), and a profile closed by a g1, g2, g3 or g4 blend curve between
lines, extruded (g1 … g4). `continuity.edges` may now be a list of points, picked as
`inspect.continuity` picks them, and `continuity.exact` asks for the order and no more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:17 -04:00
jyvikoandClaude Opus 5.5 c37b0d2f02 Kernel rig: a case's expected continuity order at its blend seams
expected.json may give `continuity: {order: g0…g4, edges?: "blend" | "corner"}`: the
seams of each round, chamfer face or corner patch with the faces either side of the edge it
replaced, and of each corner patch with its rounds, are measured as Continuity Analysis
measures them (seam_diagnostics at its default 33 stations and default tolerances), and the
case fails naming the worst seam, its faces, the order it reaches and the next order's worst
value. The seams come from the faces' persistent names (doc::naming::blend_seams). The older
`{near, within_mm, …}` form is kept.

Every fillet-area case with a body gets its order: constant rounds and rolling corners g1,
curvature rounds g2, chamfers g0, the corner: g2 patch g2 at its seams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 21:22:17 -04:00
e6dc105134 Point clouds: insert PLY, XYZ and PTS scans as a modelling reference (#5151) (#5381)
* Point clouds: insert PLY, XYZ and PTS scans as a modelling reference (#5151)

A point cloud is kept in the design as a reference, drawn as depth-tested
dots and never a body.

- io: a PLY reader (ASCII, binary little/big endian; x, y, z of any numeric
  type, optional colours, other elements skipped; counts checked against the
  file) and XYZ/PTS text, thinned evenly past max_points. PLY meshes with
  faces can also come in through file.insert_mesh.
- doc: Document.point_clouds (shared f32 points relative to an f64 origin,
  colours, units, rigid placement, size and colour), stored as a binary
  container part; format change in pending/point-clouds.rs.
- engine: pointcloud.insert / edit / delete / list; doc.open opens a cloud as
  a new design; selection.delete takes point_clouds; view bounds include them.
- gpu: an instanced point-sprite pipeline (16 bytes a point).
- ui: Browser Point Clouds folder with eyes, menu and an Edit Point Cloud
  card; drop, Open, Insert and file dialogs take .ply/.xyz/.pts; a CPU
  viewport fallback; messages in en, en-GB, ja, zh, de and ko.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Point clouds: colour by the file, one colour or height, from the UI (#5151)

The Edit Point Cloud card gets Color By (File Colors, Single Color,
Height). Height is a blue-to-red ramp over design Z, between the cloud's
own two heights or, by default, a range worked out from the points (all
but the lowest and highest 2 %, from an even sample). pointcloud.insert
and pointcloud.edit take color_by and height_range; pointcloud.list
reports them. The colour of each point is worked out in one place
(PointCloud::shade) for the GPU and CPU viewports.

Also: the card's dropdowns compare the picked index (a dropdown's
response doesn't report the pick, so File Units did not change either).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Point clouds: integrate format registration and viewport caches (#5151)

* Point clouds: satisfy current UI audits and document comparisons (#5151)

Route model RGB data through the theme conversion boundary, provide a compact ribbon label, and include point clouds in the new document comparison. Gate the Unix-only CLI-link helper and test so Windows all-target checks remain buildable after the rebase.

* Point clouds: isolate translations for current main (#5151)

Move the existing 74 messages unchanged into one pending locale file and attribute it through a pending row, following the current repository workflow. Repository checks, 50 tooling tests, final workspace Clippy, wasm and generated-catalog equality checks passed after the rebase.

* Point clouds: fit the rebased code to main's GpuTarget and Frame

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Compare point clouds when reusing placement-independent results

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Point clouds: complete command help and required translations (#5151)

* Point clouds: size the save cap from the raised limit after the rebase

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
2026-10-28 21:17:02 +00:00
jyvikoandClaude Opus 5.5 97721ad05f Fillet setbacks not past where the rounds meet are refused naming the least; the rig grades a refusal by its reason
A corner setback must reach past where the corner's rounds' contact lines
meet without one (smlib_blend_setback); short of it SMLib failed with its
own status (1001). The kernel now refuses it before SMLib runs, for the
rolling-ball corner (fillet_setback) and the curvature corner
(fillet_g2_corners) alike, naming the least: on each face at a corner of
planar faces and straight edges the two rails, r tan(psi/2) from their
edges, cross (d2 + d1 cos alpha) / sin alpha along an edge (r on faces
square to each other). Other corners stay SMLib's to refuse.

The rig's `refused` cases now name the reason (`refusal`, a part of the
message, required), so a failure for another reason no longer passes; a
`solid_or_refused` case may name one. Fillets: the setback cases and
783, 3435 pass; 1390, 896, 4782 past-a-full-round and the no-tangent-chain
case are refused for an unclear reason and fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 15:13:23 -04:00
raykholo dd2e44bb12 Raise the largest file SolidCraft opens with a setting or launch flag (#4086) (#7565)
* claim: #4086

* Raise the largest file SolidCraft opens with a setting or launch flag (#4086)

* Translate the file size limit strings

* Size limits: design files are .sc now, .solidcraft still read
2026-10-28 16:52:29 +00:00