On a B-spline face the export now takes each edgeuse's UV trim exactly as
SMLib holds it (EDGEUSE_NURBS_*): the face's parameters are SMLib's, so the
trim is the pcurve, reversed exactly (knots t -> a + b - t) where the
edgeuse runs against its edge, its knots mapped onto the edge record's
parameter where that is an affine image of SMLib's (identity for spline
edges, as_line's map for NURBS lines, the C side's map for lines), and its
end knots set to the edge interval where they differ by rounding (within
the schema's 1e-9 slack, else an error). Changed: export.rs `curves`
(per-edge TrimMap), new `trims`, `mapped`, `Face::given`,
`Edge::trim_map`, the face loop in `native_ordered`, `pcurves`,
`outer_area`.
Analytic faces and circle/ellipse edges keep brep::pcurve: SMLib keeps an
analytic face's trims on its internal rational B-spline (SmCylinder.h:
"the map from one to the other is not linear") and a circle's on its NURBS
parameter, neither an exact B-spline in the record's angle parameters.
brep::pcurve::EdgeUse gains `given`, a producer's exact pcurve taken as it
is (structure and interval checked, moved by whole periods with its loop,
never refitted). Existing construction sites (STEP reader, tests, truck
adapter) pass `given: None`; the existing tests change only for the new
field.
Built, clippy-clean and tested on 4b2c0eaf before the rebase onto
kernel-smlib/no-truck (not built: base in progress).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A face on a B-spline surface whose first and last control columns are the
same (closed around u), bounded by loops that go once around without a seam
edge, was refused ("a loop across a closed spline surface's seam"). It now
gets a seam as cylinders and cones do, along the surface's own boundary
column (u at the start of its knots, an exact iso-curve of the net), each
loop split where it crosses that column when it has no vertex on it; the
period is the knots' width. At a pole a loop may jump across u, where the
seam's two uses meet a period apart.
The step-conformance NURBS cylinder, dome and torus ring now read. With
SOLIDCRAFT_KERNEL=smlib all 17 parts import into SMLib with their exact
volumes and face counts. A spline closed in v only, or both ways, is still
refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Solid::face_origin lists the ADVANCED_FACE or FACE_SURFACE entity of each
of the record's faces, in the record's face order, so a body made from the
record (in another kernel) can trace its faces to the file, as the truck
import's face_origin does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SolidCraft's own record of a body SMLib made (the rig's record check, the saved body, the next
SMLib import) re-fitted every pcurve at the kernel's working tolerance, 1e-5 mm. SMLib's fillet
and chamfer surfaces lie some 2e-5 to 2e-4 mm off their faces, so 15 fillet and chamfer cases
failed that check although SMLib's own passed. And SMLib reported one tolerance for a whole body,
the largest any part of it needed, so one loose edge (a pocket cut left one at 0.23 mm) made the
whole body loose on its way back into SMLib.
Now the tolerances go per edge and per vertex, both ways:
- solidcraft-smlib reads and writes the fork's new SMLIB_FLAT_EDGE_TOLERANCE and
VERTEX_TOLERANCE arrays. Export gives each edge and vertex record its own (never below the
floor, which becomes the body's). Where those understate what an approximated edge needs on
its face (SMLib holds a blend's end curve 2.3e-5 mm off its plane at 2e-5), the export falls
back to SMLib's largest everywhere, as before. Import writes each record edge's and vertex's
tolerance.
- `geom::brep::pcurve::EdgeUse` carries its edge record's tolerance, and a pcurve is fitted to
it where it is larger than the face's.
- The kernel's decoded body keeps its record's edge and vertex tolerances
(`Body::tolerances`, in its edge and vertex order) after an SMLib operation and a saved body's
decode, and keeps them through a rigid placement. Its record writes them again; anything that
builds a new solid drops them.
SMLIB_REV moves to the fork commit that adds the arrays (smlib-blends-abi2 4a67471, ABI 2).
Rig and ladder fillet and chamfer cases on SMLib: 43 pass before, 60 now, none lost. Tests: a
pcurve fitted to its use's own tolerance, and the ladder's 08/006 cylinder rim chamfer whose
record, saved body and placed copy all stay valid and SMLib's check takes back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
SURFACE_OF_REVOLUTION reads as a placed revolution (u the angle, v the profile's parameter,
STEP's normal); SURFACE_OF_LINEAR_EXTRUSION as an exact spline surface, the profile as a
(rational) B-spline times degree 1 along the vector; a circle extruded along its axis or
revolved in a plane through the axis as the cylinder or ring torus it is. Line, conic and
open-conic profiles are bounded by the face (a closed conic's seam outside it, a revolved
profile stopped at the axis). OFFSET_SURFACE of the analytic kinds reads as the moved
surface, checked at each level. Hyperbola and parabola edges read as exact rational
quadratic pieces and a Bezier on STEP's parameter. Faces winding around a revolution get
seams along its profile. Every mapping is checked point by point and normal by normal
against STEP's own surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face winding around a closed (non-periodic) spline surface without a seam edge has loops
that jump across the surface's domain; it is refused for now instead of making a record whose
loops do not close. The step-conformance parts are read in a test, and the kernel's ignored
corpus comparison builds each record back into a truck solid to compare volumes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face on a cylinder, cone or sphere bounded by loops that go round the axis (a band
between two circles, a dome on its equator, a cone on its base and apex) gets a seam:
a ruling or meridian from one loop to the other (split where it has no vertex at that
angle) or to the pole it covers, so every loop closes in (u, v) as schema 4 requires.
Pcurves may be fitted up to 1 mm off for edges that lie off their surfaces. The kernel
gets an ignored corpus test comparing truck's face and edge counts with schema 4's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
read_solids walks MANIFOLD_SOLID_BREP, BREP_WITH_VOIDS and SHELL_BASED_SURFACE_MODEL
into solidcraft_geom::brep records: lines, conics, B-splines and polylines; planes, the
analytic surfaces and B-spline surfaces; edge intervals from the vertices' parameters;
loops relative to the surface's natural normal; outer loops, regions, voids and sheets;
pcurves from the 3D edges; the canonical order. Unsupported geometry refuses its solid
with a reason and the rest of the file is still read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new crate, solidcraft-step (L1, no modelling backend), holds the Part 21
parser (moved from the kernel, which now reads through it) and STEP geometry
as plain data: lines, conics, B-splines (rational and implied knots),
polylines, trimmed curves, surface curves with their pcurves, 3D offset
curves; planes, cylinders, cones, spheres, tori (degenerate too), B-spline
surfaces, revolutions, linear extrusions, offset and rectangular trimmed
surfaces. Each keeps STEP's own definition and parameterisation, in mm and
radians, with pcurves scaled by their surface's parameter units. Shared
entities stay shared. A writer emits the same entities back, deduplicated.
Tests per entity check values against analytic points, units, round trips
and hostile input; an ignored test reads and round-trips every edge curve
and face surface of the tangency-labs/models STEP files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>