A cylinder, cone, sphere or torus face of less than one turn that does not
start on a quarter line of its frame, with more than three quarters left to
it, spilled into a fifth quarter of the quarter grid: its NURBS form ran past
one turn and SMLib refused the solid ("an edge lies 12-16 mm off the face's
surface"), which came in as surfaces.
Before its edges are labelled on it, such a face's frame is turned about its
own axis (brep::form::turned: the same surface, its angle parameter measured
from further on) so it starts on a quarter line and its form spans four
quarters. Round faces a circle edge about both their axes joins share one
quarter grid, so they turn together by one angle, chosen so every one of them
fits in four quarters; a group with a face that cannot be turned keeps the
file's frames. Each face's box on its label is measured once and reused.
Engine assembly: PULLEY_WATER_PUMP and MOUNT_SCAVENGE_PUMP_01 now come in as
solids (refused 5 -> 3); Poppy Humanoid unchanged (4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A body showing another's display (a later instance of a part an assembly
places several times) took that part's mesh, placed, but was planned for
the GPU viewport on its own: Poppy Humanoid's display planned all 247
bodies where its meshes came from 94 parts. Body::mesh_plan now plans the
original once (kept with the shared display, as its meshes are) and moves
the plan, so the copy's display is the part's triangulation, as its mesh
is. Body::unmeshed_faces needs no case of its own for a copy any more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The STEP import's mesh check made a coarse mesh of every part (planned,
evaluated, its seams and smooth edges flagged) only to see which faces had
triangles, and threw it away. A face has triangles in the evaluated mesh
exactly where its plan has a triangle on its own nodes, so the count is now
read off the plan (TessPlan::faces_with_triangles, the condition evaluate
keeps a triangle by).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A window of planned solids ended at the second instance of a part not yet
read, so an assembly that places a part several times in a row converted
in windows of one or two solids, each waiting for its slowest read before
the next began (Poppy Humanoid: 14 windows of 1 to 30 reads on 8 workers).
The window now always takes MAX_WINDOW solids; an instance of a part an
earlier job of the window reads is placed after that job, from the
orientation it found, as the next window would have placed it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's import says only that it refuses a body, so the kernel now keeps a structured
refusal with the body's SMLib cache (Body::smlib_refusal / smlib_refused: the first face SMLib
refuses on its own, found by sending each face alone, and its surface kind). A STEP import sends
each part's first instance as an operation would, notes the parts that need repair in the
import report, and the browser marks them ("VALVE_COVER_01: needs repair").
A feature dialog whose operation fails on such a part says, instead of the kernel's words and
an issue report: "Couldn't join to VALVE_COVER_01. One of its rounded faces can't be used for
modelling.", with Repair part (body.repair, declared as planned, also in the part's menu) and
Show face (selects and frames the face).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel's import warnings get a structure (ImportReport: the file's parts, how many came
in as solids, and each warning's kind, part, faces and count; the reads' notes are typed as
repairs or faces left out). The Import feature's result carries it (and the model cache keeps
it), and the timeline tooltip and the status line after an import word it from the catalogs:
"Imported 40 of 43 parts as solids. 1 part couldn't be made into a solid and is shown as a
mesh. 3 faces couldn't be repaired and are missing." with what may help. Entity numbers and
the kernel's wording stay in Copy Warning Message, which now lists every warning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Setback field reached the command and the kernel used it: on a box corner
with r 2 rounds a 3 mm setback built, while 1.5 and 2 mm failed inside SMLib
(status 1001), shown as "could not be built" with nothing saying why. A setback
must reach past where the rounds meet without one (the radius on square faces).
The kernel now refuses such a setback before SMLib runs, naming the least
(the pre-check of aa2b09bc2 on fillet-kernel-cases), and exposes that least
(fillet_least_setback). The field shows the default, 1.5 x the radius, as an
editable length that follows the radius until the user types one, and outlines
a value at or below the least in the warning colour with "More than 2 mm"
under it (ui_kit::checked_row, warning_caption). Its hover text says what a
setback does, the default and the least.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A SHELL_BASED_SURFACE_MODEL with both closed and open shells (Poppy Humanoid's
thighs: the part and a two-face sheet on it) came in as one body, open for the
sheet's edges. Each closed shell is now read as an item of its own, a solid in
the model's colour, and the model's open shells as a surface body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A face's form covers the quarters of its box, and the box is the extent of its
boundary's points, which run past a quarter's end by as much as the edges lie
off the surface (nanometres in a file of 1e-11 mm digits). A half tube's form
then took the quarter past each end and went round the whole tube, which SMLib
does not take for a torus: 16 parts of an alternator came in as meshes. An end
within the tolerance of a quarter's end (the angle on the face's widest circle
there) is now on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A corner setback must reach past where the corner's rounds' contact lines
meet without one (smlib_blend_setback); short of it SMLib failed with its
own status (1001). The kernel now refuses it before SMLib runs, for the
rolling-ball corner (fillet_setback) and the curvature corner
(fillet_g2_corners) alike, naming the least: on each face at a corner of
planar faces and straight edges the two rails, r tan(psi/2) from their
edges, cross (d2 + d1 cos alpha) / sin alpha along an edge (r on faces
square to each other). Other corners stay SMLib's to refuse.
The rig's `refused` cases now name the reason (`refusal`, a part of the
message, required), so a failure for another reason no longer passes; a
`solid_or_refused` case may name one. Fillets: the setback cases and
783, 3435 pass; 1390, 896, 4782 past-a-full-round and the no-tangent-chain
case are refused for an unclear reason and fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The held parameter was spaced over each face's own trimmed (u, v) box, so the pieces of a
face split by a boss showed different lines that missed each other at the split. The lines
now sit on a ladder of the surface: a bounded parameter's range in count + 1 steps, a linear
one (a plane's, a cylinder's or cone's axis) at a round world spacing from the world origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib holds both sides of a sheet's faces and gives each back on its surface's
natural side, so a sheet whose file uses faces the other way came back
renumbered. The reader no longer turns them (that lost the file's side);
instead SMLib is given the sheet with those faces turned over exactly on the
record, and they are turned back on SMLib's body, each face mapped through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A solid the reader or SMLib refuses was shown as a mesh of its faces (#8223):
exactness lost, cracks between faces, and no modelling. It now comes in as an
open surface body of the faces that read, sharing their edges as the file has
them; each face left out is named.
- The reader reads a solid with a set of faces left out (read_solid_without):
a sheet whose faces face their surfaces' natural normals, as SMLib gives a
sheet's faces back, so SMLib's body numbers the faces as the record does.
- Tier 1: the faces that cannot be read alone and the face each refusal names
(named_face) are left out, up to 8 reads. Tier 2, when a refusal names no
face of the solid: the one-face bodies stitched by SMLib. Tier 3, when SMLib
cannot stitch them: the mesh of them, as before.
- Report: "imported as surfaces: <why>" and "left out: face #..."; the
ImportedBody field shown_as_mesh is now refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's boundary node on a patch side collapsed to within the tolerance of
the vertex there (capped at the chord tolerance), not to a point, is a pole:
its parameter along the collapsed direction is free, as the record check and
the STEP loop check take it (`uv::collapsed`, shared with
`SurfaceEval::pole_within`). A loop through such a corner no longer winds
round the surface as projected, and plans strictly (Poppy Humanoid's
connector, face 43: a quarter of a sphere cap on a closed rational spline).
A face the strict plan and the lenient fill both refuse no longer fails the
whole body's mesh: it is left out with no triangles, named in
PlanStats::unmeshed (logged by the display plan, counted by
Body::unmeshed_faces), and the rest of the body is meshed; a body none of
whose faces plan is still the first face's error. Body::volume_at gives no
volume for a mesh with a face left out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the reader or SMLib refuses a solid, each of its faces is read on its
own as a one-face surface body (solidcraft_step::topology::read_faces_with)
and meshed by the planner; the triangles together are a mesh body (the
existing kind STL/3MF imports make), marked ImportedBody::shown_as_mesh with
the refusal. The report says 'shown as a mesh: <reason>' and names each face
left out. Modelling operations refuse it as any mesh body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check that a loop does not jump across a spline surface's parameters took a
pole only within the face's tolerance. A corner patch written with one side
shrunk to a few µm (Poppy Humanoid's connectors: 5 µm in a 1e-5 mm file) was
refused, though the record check takes the same junction as a pole at the
tolerance of the vertex the uses meet at. The import check now uses that
vertex's tolerance; the loop runs along the collapsed side, its boundary iso
line. A jump that is still refused says whether the surface closes there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each seam now also reports the jump of the curvature's arc-length derivative across it (G3)
and of its second derivative (G4), both from the faces' exact partials, and its order: the
highest one every station meets within the tolerances (two new tolerances, defaults in the
kernel). The verdict keeps its meaning (smooth is G2 or better). inspect.continuity replies
with the new metrics, each seam's order and a count per order; the viewport widens G3 and G4
seams, the legend and the marker labels name every order in words. The Patch, Blend and
Boundary rows offer the orders the kernel's Construction table says they build. G4's words
in en, ar, de, he, ja, ko and zh.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel's Continuity moves out of bridge.rs into continuity_order.rs and gains G4. One
table holds each order's command word (g0-g4), its code (G0-G4, for tips and messages) and
the message ids of its label and hover text. Construction says which orders the patch,
bridge, network, match and sketch blend curve build today; Continuity::built_by is the one
refusal every command and kernel entry point uses. A design may now save g4 (format note).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The analysis sliced the display mesh with planes: faceted, approximate, and
broken at triangle seams and trims; the window drew it as a 2D overlay without
depth while the tool was active. Now one kernel routine (kernel::iso) clips a
surface's u = const or v = const line to a face's pcurve loops; the curve through
a point (sketch projection) and the analysis grid (count each way, evenly across
the face's extent) both use it. The loop polygon follows the loop's order (a
pcurve the loop runs against is walked backwards), which the inside test got
wrong before, and closes over vertex-loop poles.
ModelBody caches the lines per face, count and display quality. The session
keeps the picked faces as view state (inspect.isocurve add/clear, hostile counts
refused); the viewport, ui.render and snapshots draw them depth tested in the
accent colour. Curvature combs on faces follow the same exact lines.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two edges leaving a vertex almost tangentially (a cusp, as a round runs out on Poppy
Humanoid's creative_commons_license) separate by about Δκ·s²/2 at distance s while a chord of
length L sags by κL²/8: halving the chords never stops them crossing. untangle returned that
face's error for the whole plan, and the body's 1834 faces were not shown. It now returns the
faces still crossing, each with why, and plan_or_fill fills each leniently straight away and
names it in the stats (the rule of #7755): the other faces are planned as usual.
Test: a face named as still tangled is filled leniently and named with that reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A corner ball's edge may run from its equator over the sphere's pole to a vertex just past
it (Poppy Humanoid's creative_commons_license: 1.8° past, 0.016 mm off the pole). On the
sphere's parameters the pole is a line, and the edge's pcurve would have to jump half a turn
along it: "pcurve starts 2 from the end of the use before it, on another period". Each
edge that passes through a pole of a face it bounds (a sphere's, a revolved face's on its
axis) inside its interval is now split at the nearest point to the pole (golden-section
search from 16 samples), the new vertex placed on the pole; the loop's half turn is then at
a vertex on the pole, where a loop may run along it. Each solid's notes say how many edges
were split. The geometry check takes a vertex at a pole to within the vertex's tolerance, as
the reader already does (SurfaceEval::pole_within).
Without the split the edge's jump read as a 0.024 mm gap and was covered by a tolerance:
the measured gap now only covers what the file's geometry really has.
Test: a spherical triangle (radius 0.5) with an edge over the pole to 1.8° past it reads
with its spherical-excess area and its edge split.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A closed-form pcurve (a B-spline edge's control points projected onto its plane) is
accepted within half its edge's tolerance, and the edge carried the file's: Poppy
Humanoid has planes whose B-spline edges stand 9 µm off them in a file that states
10 µm. The closed form was refused, and a plane has no parameter box for SMLib to make
pcurves in: "a face on an unbounded surface without closed-form pcurves" on 11 of its
solids. On a plane, cylinder, cone, sphere or torus (nearest points in closed form)
each edge's distance from the surface is now measured along it first, and its
tolerance covers three times that; a spline face's gaps stay measured on its kernel's
pcurves, with the 1.5 × margin of a vertex's. The pcurve code reads each use's own
tolerance.
Poppy: 194 → 195 bodies, the unbounded-surface refusals 11 → 3 (the solids they let
through now stop at later steps); the corpus survey and the kernel tests are as before.
Test: a plane face whose B-spline edges stand 0.8e-6 mm above it in a file stating
1e-6 mm imports with its closed forms; without the measure it fails as Poppy's did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A TOROIDAL_SURFACE whose tube reaches its axis (major radius at most the minor, or
written with a negative major radius) and a DEGENERATE_TOROIDAL_SURFACE were refused.
They are read as what they are: the tube's meridian circle (centre C + R·X, its angle
from X towards Z) revolved about the axis, the same points and normal as ISO 10303-42's
formula, a negative R putting the tube's centre across the axis.
A revolved circle or ellipse that meets its axis is now its whole arc on the face's
side, pole to pole, in closed form (where s0 + M cos(t - phi) = 0), and its NURBS form
is cut there exactly (Boehm knot insertion, bspline::segment): the parameter stays the
quarter grid's, so the edges' forms and straight pcurves are unchanged, and the surface
ends at the poles instead of running on to whole quarters past the axis (which folded
the surface over itself, and left a face with one bound around the axis without its
pole). The face's boundary picks the apple or the lemon.
On Poppy Humanoid 22 solids were refused for these tori; with the SMLib fixes before
this none of their torus faces fails: Poppy 42 -> 27 solids not imported, 194 -> 215
bodies.
Tests (hand-written files, analytic answers): a horn torus round of radius 1 on a pin
(V = 8 pi + pi(5/3 + pi/2)); a spindle torus pin end (major 1, minor 2, its apex in a
dimple at z = sqrt 3, V = 3 sqrt3 pi + 8 pi^2/3 on the cylinder) as TOROIDAL and
DEGENERATE_TOROIDAL, with a seam to the pole and with one bound; a nearly round end
(0.005 / 0.345) in two halves with SolidWorks's apex vertex; the lemon of a spindle torus
as one seam-bounded face with major radius -1 and as a degenerate torus with its lemon
selected (V = pi(6 sqrt3 - 8 pi/3)). Volumes and areas within 1e-3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Each edge is sampled on its own, and a short one within the chord tolerance is one
segment. A face bounded by two such edges (a lens of short arcs, a sliver strip of a
cylinder between two rulings) had two chords on one line: "degenerate boundary", and
the whole body's display mesh failed with it (one of Poppy Humanoid's bodies lost all
336 faces to one sliver). Such a loop's segments are now halved until it has three; the
new nodes are on the edges' curves and shared by every face that runs them.
Test: a lens of two radius-1000 arcs beside a 2 m face meshes; without the split it
fails with the same error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
An edge's curve as a file writes it may lie off a face's surface by more than the
file's stated uncertainty: Poppy Humanoid's intersection curves lie up to 9 µm off
surfaces in a file that states 0.01 µm, and 24 of its solids were refused by the
record check ("pcurve … lifts off its edge's curve"). Each use's gap, between its
pcurve on the surface and its edge's curve, is now measured along the edge at 17
points as the record check measures it, and the edge's tolerance covers it (1.5 ×
the gap, as a vertex's covers its gap; more than 1 mm is refused). The pcurves are as
made, and each solid's notes say how many edges were raised and how far.
The pcurve fit's tenfold retries went in 6cc0401fa; this measures instead of
retrying. On the corpus (the repository's STEP/IGES files, the models repository,
Poppy): 50 → 53 of 56 files import; Poppy 132 → 194 bodies.
Test: a hand-written domed patch whose edges are written 0.2 µm above it (SMLib makes
its pcurves) imports with them covered; 1.5 mm off is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A face whose boundary crosses itself in (u, v) (a cusp, a sliver whose sides
sag across each other) was an error, and the body had no display plan. It is
now planned once more with a lenient constrained Delaunay in (u, v): sides
crossing one already kept are left out, the rest is seeded and refined as any
face, and its points lie on the surface, where the GPU evaluates them. The
display has no hole, but the face is still a defect upstream, in its pcurves
or seams: PlanStats::lenient names it with the strict plan's refusal, and the
display plan logs a warning for each such face, so it is never silent.
The face boundaries keep coming from the exact pcurves (d61efb306); cdt::Fill
gets its `lenient` field back (dropped in 3f2585569). The old flat fill (#4021,
tess/fallback.rs) stays gone: develop removed it in 9138e8704. A face the
lenient fill refuses too (loops that do not close in (u, v), or wind round a
seam or pole) stays an error naming the face. Closes#4453's intent on develop.
(cherry picked from commit 84de5aa071)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
SMLib's out_failed_corner reaches Rust as Error::CornerRefused { corner }, and the
kernel names the corner by its point: a G2 fillet at a corner of mixed convexity
says where it is and that SMLib sets back only corners whose rounds are all
convex or all concave. Engine test checks the message through solid.fillet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The inner corner of a notch, three concave r5 rounds, takes the set-back G2
patch as a convex corner does: one valid solid with the ball corner's 13
faces, seam jump 6.3e-4 per mm clear of the hole's corners against the
ball's 0.2. A corner of two convex rounds and a concave one is refused as not
supported: SMLib sets back only corners of one convexity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A corner where three or more rounded edges meet, every edge there rounded, is
set back (1.5 r unless a setback names it) and left open by SMLib
(blend_smlib::fillet_setback_open: the sheet and each corner's hole, in the
sheet's orders); each hole is filled by fill::matched_patch, the height field
over its plane fitted to the position, tangent plane and normal curvature
across the boundary of every face beside it (exact second derivatives), rounds
and planes alike, each edge's pcurve its exact projection; SMLib sews the
sheet and the patches into one solid, which must close. The history is the
sewing's carried through the sheet's, each patch face made from the rounded
edges its neighbours come from.
corner_g2 is that construction now. The polar patch over three sections it
held (never sewn in) could not be: its boundary is a closed cubic through
stations, which rounds off a corner of the loop, and the setback hole has six.
The 60 x 40 x 20 box corner of r5 rounds (07/015): 10 faces, a valid closed
solid (record and SMLib's check), curvature jump across the patch's seams
6.3e-4 per mm clear of the hole's corners against the ball's 0.2; set back 8
between the hull and prism bounds; set back 11 to 15 inside the box but by
under 7e-4; all eight corners of a box filled; refusals named.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SeamReport.stations: each station's edge fraction, gap, normal angle and
curvature jump, alongside its point, so a seam's profile (where a jump holds,
where it fades) can be read and plotted, not only its worst value.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Booleans, blends, sweeps, lofts, shell/draft/offset, healing and sewing,
SMLib conversions, meshing and measuring; the import as parse, index,
per-solid read, placement and mesh check, convert batches and finish.
The existing per-step boolean/tessellate capture names its spans too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge is left out of the shaded view only where its two faces meet
with one tangent plane (normals within 0.5 degrees) and one curvature
across the edge: at each station the faces' normal curvatures square to
the edge agree within 0.5 degrees' worth, |k1 - k2| <= 0.0087 x
max(|k|, 1/L), L the edge's length, so the continued faces turn apart
by no more than that over a radius of curvature or the edge's length.
Fillet boundaries (0 to 1/r), corner-patch joins and a plane tangent to
a cylinder are drawn again, straight ones included. A modelled thread's
flank pieces (one sweep) differ by at most 0.0046 and stay hidden.
Second derivatives of a spline surface now exist at a boundary point a
pcurve carries a rounding step past the knot range, as its point and
first derivatives already did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Smoothness (normals within 0.5 degrees) and a crease are separate
verdicts. A crease is certified where the normals differ by more than
the evaluation can account for: each pcurve point's measured distance
off the edge's own curve times the faces' larger principal curvatures.
So a real crease too small to see is not drawn in the shading but stays
a pickable edge in the wireframe, overriding a coarse same-surface seam
fit, as before; exact tangent joins (fillets, seams, a thread's flank
pieces) are no crease.
The viewport's smooth-wall test expects the wireframe to draw
`edge_visible` edges: the offset ellipse's pieces meet at real creases
of 1e-4 rad that the old checker could not certify.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge is left out of the shaded view when its two faces' outward
normals, evaluated on their exact surfaces at each use's own pcurve,
agree within half a degree at eight stations along it (a seam one face
meets itself across is the same test with its two pcurves); it is a
protected crease when they differ by more. Replaces the special cases
for ruled clamped Bezier patches, planes, cylinders and cones. Fillet
tangent joins and corner-patch joins are hidden too; they stay
pickable and in the wireframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A collapsible if (assemble.rs), two manual assign operations (sew.rs), a range loop indexing
the placement inverse's translation row (step_in), and two needless borrows (engine features),
which failed CI's clippy -D warnings. No behaviour change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main's reader (#1609, #3845, #3928) and the branch's met in the rebase, and the
tree kept main's gap closing: it moved a trim piece's end vertex onto the mean
of the gap's ends without changing its curve, and widened the STEP file's
stated accuracy to cover the move. SMLib checks each edge against its vertex at
the body's tolerance and refused the box (SmTrimmingTools Edge/Edge Gap 0.005 >
0.00425, rig 3845); the first piece of a trim curve with no start point was
also turned against the second (rig 3913, "edge loop is not connected").
The reader keeps main's structure (groups and subfigure instances as products,
names, placements, separate lumps as separate solids, the originating system)
and sews each group's surfaces the branch's way: each meeting point of two
pieces is one vertex, where most piece ends there agree, and a line or clamped
B-spline that misses it is rebuilt to end there exactly. Main's limits on which
gaps are one corner written loosely (0.1 mm, 5% of the shorter piece) decide
which meeting points are joined; the stated accuracy stays the file's. A trim
curve's first piece starts at its end away from the second when no start point
is given.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The IGES reader (#1609) writes each group and subfigure instance's placement as a
CARTESIAN_TRANSFORMATION_OPERATOR_3D_NON_UNIFORM. The branch's STEP reader took
only the uniform operator, and only its origin: every IGES assembly placement
was refused ("placement location: expected a reference") and put at the origin.
An operator, uniform or not, is now read as main reads it: its axes (the global
ones where omitted), its scales (1, and the first for the second and third) and
its origin, refused when singular. A placement may then scale, so the inverse
that maps one placement onto another inverts the linear part by its adjugate
instead of transposing it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The branch's placement change (placing the model returns its error) made
world_state, home_camera, bounds, open_sketch_plane, the scene builders,
to_local and auto_operation return a Result. Main added callers of them
since the branch left it; they now take the error as the branch's own
callers do:
- engine: commands pass it on (`?`); helpers answering yes/no or "found"
(snap points, a face's normal, the DXF export check) answer no for a
model that cannot be placed. Frames keep the session for main's lazy body
frames (#6356) beside the placed model the picks are on; a library apply
maps its targets on that placed model. Before an extract or a link is
replaced, the placed model is taken or the command fails.
- ui: panels, picks, dialogs and previews read the placed model through
open_meshing::session_world (none when it cannot be placed: the viewport
says why); Home and Fit frame nothing then.
- cli: the usage table is main's, with kernel-cases in it (a resolution of
the rig's commit had kept the branch's whole file).
- tests read the Results with unwrap, and main's tests of Body::tessellate
mesh through Body::mesh. Main's test of saved boolean retries goes (the
branch saves none), as does the thread half of its dialog rendering test
(the branch's thread dialog has its own); the tapped hole half stays.
- What no caller uses after the merge goes: a mesh body's span, the metric
thread refusal text, and the revolve's targets-as-shown model (main used
it for the coplanar run-on the branch removed). Main's SolidWorks Y-up
test reads the exporting system's name (the branch's STEP header has no
preprocessor or description fields).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The branch rebased onto main keeps each of its commits; where both sides
changed the same code, these are the pieces neither side's commit had.
- Cargo: one [features] table in the CLI's manifest (two met in the merge).
- geom: a NURBS surface's `closed` set once in a placed copy (both sides
added it).
- kernel: the whole-face extrude tools (#2040) work around truck's boolean
on truck types, which left the workspace with the SMLib kernel; the
module, its tests and the doc crate's tool and tests go. The display
planner's flat fill (tess/fallback.rs) has no caller with the schema 4
mesher, and the tessellator's seam and uv modules are the branch's. A
body's boundary tolerance from a STEP file belongs to the truck body the
schema 4 record replaced: `with_boundary_tol` goes. `unmeshed_faces`
counts the coarse mesh as the branch does. A loft's section re-split
passes the lead's perimeter shares to main's `resample` (a circle breaks
there when the matched corners do not go round in order). Main's tests of
the mesh-based measure (the SMLib kernel measures exactly) and of the
IGES preprocessor name (no such field on the branch's import record) go.
- doc: a feature result carries no boolean diagnostics on the branch, so
the model cache neither writes nor reads them, and a pattern copy's miss
test runs the intersect as it is. A placed body's worker result is a
Result: a body taken from the previous placement is Ok. A thread's
clipboard remap takes main's arguments, the tapped catalogue names a
metric size by ThreadForm::Metric, and main's tests unwrap the placing
calls that return their error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each (point, distance) sets back the corner at the body's nearest vertex: its
patch starts that far along every edge there. Tested on the 60 x 40 x 20 box
corner with r5 rounds set back 8 (volume between the convex hull and the
rounds' prisms bounds, 15/36/23 topology, the box's bbox) and on refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ladder 06/009 had no way to ask for one: "solid.thread has no runout (vanishing thread)
length". With SMLib's smlib_screw_sweep_radial (replay e7acea1):
- smlib: the FFI binding and Brep::screw_sweep_radial, the profile moved off the axis by a
piecewise linear law of the turn; crate test: a tooth moved out 1 mm over three turns has
A 2π (c turns + ∫ offset dt).
- kernel: sweep_helix_radial, sharing sweep_helix's checks (helix_profile).
- doc: `ease_in`, `ease_out` (a length, or ISO 3508's standard 2.5 P or short 1.25 P) fade the
groove over that length, its section moving out of the material as it turns (outward for a
shaft, inward for a nut). ease_in is at the end the thread starts from. The runout lies past
the full-form length: beyond a square stop, before a shoulder up to its clearance; at a free
end inside the face. Runouts longer than the thread are refused. No end gets one by default,
so saved threads keep their geometry.
The cut is the integral over the turn of the clipped section's 2π∫ r dA: engine test (2.5 P
and 1.25 P between two collars) within the sweep's wall tolerance times the runouts' wall area
(0.029 against a 0.036 mm³ bound), ladder 06/009 (004's shaft, a 2 P runout before the
shoulder) graded in closed form (measured 1.7e-6 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A thread of some length ran from "the end of the face nearest the pick", a coin toss for a
pick in the middle (rig 602's 4 mm thread meant for the free bottom end ran at the head end,
cutting 1.17 mm into the hex), and every thread end at a face end got a one-pitch overrun,
which at a shoulder gouged the material past it (ladder 06/004 cut 0.9% of its volume out of
the collar).
- kernel: material_in_ring, the exact intersection of a body with a ring about a cylinder
face's axis, by an SMLib boolean.
- doc: a face end is free when no material lies past it, over the span the groove's one-pitch
overrun reaches beyond its first pitch, within the radii the groove cuts (a cap, a chamfer
the groove runs out through, a counterbore). At a free end the groove runs out as before; at
a closed one (a shoulder, a head, a blind hole's bottom) it stops with its widest part clear
of it; inside the face it stops square.
- doc: a thread of some length starts at the end nearest `from`, else at the face's only free
end, else at the end the pick lies within a third of the face of; a pick in the middle of a
face whose ends are alike is refused, naming `from`. A length as long as the face runs the
whole face. `up_to` a plane or a point's place along the axis. New fields `from`, `up_to`
default to none, so saved threads keep their meaning where it was not a coin toss.
- engine: solid.thread takes extent (full|length|up_to), from and up_to.
- ladder 06/003 (now with `from`), 004 and 007 are graded by volume and centre of mass in
closed form (a square stop inside material removes exactly length/P turns, the section being
symmetric); rig 602's method says why the thread is at the bottom, tolerance 0.02%.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's boundary nodes are its edges', shared with the neighbouring face.
On a nearly straight stretch (the base of a thread flank's corner, clipped by
a hex head's flats, on an iso-line of the helix) refinement met slivers
between consecutive boundary nodes: their centroid, or the middle of their
inner edge, lies on the boundary chord to rounding. Inserting it split the
boundary constraint, and the face was refused ("boundary crosses itself";
rig threads/602, refused while the body was meshed to pick the fillet's
edges). A sliver whose centroid lies on the boundary is now split at its
inner edges' middles, and a refinement point that lands on the boundary is
not inserted.
The 602 engine test assumed the old kernel's faceted thread (over 1000
faces); with SMLib the thread is exact, and the test now checks that the
fillet finishes and removes a little material.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>