112e0a3d9c8ff9fac3cce0fd8b0fe7077e0e3bb3
16
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
d01de87552 |
Merge main into drawings (Oct 30)
Brings the 1,270 commits on main since the drawings branch last met it,
including the first drawings landing (#8249), into drawings.
Merged with the drawings snapshot that #8249 landed (
|
||
|
|
6a2bdbf144 |
Bill of materials: virtual components and a typed quantity (#3874, P6) (#9226)
`bom_quantity` is a part property of any component: what one placement of it means, an expression evaluated with the design's parameters (pieces without a unit, else a length). A row's `quantity` is what its placements add up to, with `quantity_unit`; pieces beside a length, or a quantity that no longer evaluates, give none and say why. A quantity is a parameter user: a rename follows it, and a parameter it uses can't be deleted. The CSV gains a `quantity` column at the end. `virtual` marks a component with no geometry (grease, paint, a label): listed with its quantity, weighing nothing. It can't be the active component, and one check after each undoable outermost command refuses any change that puts a body, a sketch or a placed component into one, whichever command made it. A file a damaged virtual component already fills opens, and other changes go on. Mass, volume and area quantities wait for the expression units of #4811. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
413c145c56 |
Bill of materials: stable item numbers, saved with the design (#3874) (#7779)
* Bill of materials types on one occurrence (#3874) An occurrence can count in the bill of materials as another type than its component, for that occurrence only: `bom_type` on the occurrence, set with occurrence.bom_type (one undo step; it changes no geometry, so nothing is evaluated). An occurrence without it counts as its component, so older designs need no step; the format change is one pending file (occurrence-bom-type.rs). assembly.bom counts each placement by its own type: a purchased placement of a kit part is one row without the kit's contents, a phantom placement lists what it holds where it sits, and one component placed as two types gives a row for each. Paste New keeps the types; Paste Instance counts as the component. The compact list and the locales (en, de, ja, ko, zh) carry it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials rows: material, and mass when asked (#3874) Every row of assembly.bom (and every part folded into a row) names the physical materials of its definitions' own bodies, each once, with "; " between several. An unassigned body's is Default. A subassembly or an empty component has none of its own. With mass: true each row also carries mass_g, what one of its parts weighs as the row stands for it, so the rows of any list add up to the assembly once: - at the top level, all it holds; - in parts only, its own bodies, because what it holds is listed beside it; but a folded part's row is the kit (all it holds), a purchased part is all it holds, and an inseparable one all but its purchased parts; - a reference placement adds nothing, nor does anything inside it. It is null when nothing in the part has a body, a body can't be measured or measures a negative volume (inside out, such as an open mesh facing the origin), or the definitions sharing the row's part number weigh differently. Measuring runs the kernel, so it is asked for: the Bill of Materials window re-runs assembly.bom after every change and doesn't ask (0.2 ms without mass, 135 ms with it on a bolted bracket). Placements are rigid, so each definition is weighed once however often it is placed, and each body is measured once with measure_mass (the same volume as measure, without the topology counts' tessellation). A body's material and its density now follow one rule: Document::body_material (new, beside Document::density) is the material its mass is worked out with, named as the library or the design spells it: the assigned one when it is known and has a usable density, else DEFAULT_MATERIAL (new, beside DEFAULT_DENSITY). Document::density is that material's density, with the same values as before. So a damaged file's unknown or broken material reads as Default, as it weighs, and a hand-edited "steel" reads as Steel. The bill of materials uses both; the other places that read a body's material or spell "Default" (component.properties, inspect and others) move to them in a separate cleanup PR for #4783, which brings the same two functions to main. Document::body_owners returns each body's owner in order, so the rows find their bodies in one pass. It no longer repeats the owner rule: model_body_component, legacy_body_component and body_owners go through the rule written once, given how to find a feature's component (the timeline for one body; body_owners still builds its map once). The CSV columns are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Physical properties: a reference placement adds nothing (#3874) component.properties and occurrence.properties now leave out a placement that counts as a reference in the bill of materials (its occurrence's bom_type, else its component's: a fixture shown for context), and everything inside it: no body entry, mass, volume, area, centre of mass or bounding box, and it isn't in placement_count. That is the bill of materials' rule, so a reference part is in neither the parts list nor the assembly's mass, and every bill of materials list still adds up to the assembly's Properties. The placement asked for counts whatever its type: a reference fixture's own Properties still measure it and what it holds, as a component's own bill of materials lists what it holds. Only the totals change. The placements walk that face picking, sketches on placed faces and the occurrence path lookup use stays complete, so a reference fixture's faces can still be picked. The type an occurrence counts as is now written once: Document::occurrence_bom_types (new, beside BomType) gives each occurrence's type in their order, looking each component up once. The bill of materials, occurrence.bom_type's reply and the physical properties use it, in place of the two copies in the bill of materials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: one module of typed rows in doc (#3874) The bill of materials now lives in solidcraft_doc::bom as the typed rows of a bill of materials view. assembly.bom's JSON and CSV and the Bill of Materials window present those rows; parts lists, item numbers and balloons are to read them too. - list(tree, request) walks the placements below the assembly once. One rule (classify) decides for each placement whether it is counted in a row, how what it holds is walked and what its row stands for when weighed, from the type it counts as, the view and the component's shape. "An inseparable part's purchased parts are listed beside it" is written there once, and the mass walk reads it. - A row carries its identity (RowKey: the rows it is listed under and its lowest member, a component and the type it counts as), its item, count, each, the placements it counts by occurrence path, what it stands for (Holds), its part properties, materials, mass and children. - Mass is a Mass: not asked, grams, or unknown with the reason (nothing to weigh, unmeasurable, the definitions differ). Each definition is weighed once for each kind of row and kept in the Tree. The assembly's total is weighed from the design the same way, not added up from rows, so it is known even when a row's definitions weigh differently. - Bom::row_of(tree, path) finds the row a placement is counted in (a nut inside a purchased bolt is in the bolt's), or says why there is none: no such placement, a reference, or no row of its own. - rows_deep() lists each row followed by its children (1, 1.1, 1.2, 2); Request::default() is assembly.bom {}; View and Group carry the commands' words. What changes, beside that the output is otherwise the same: - One placement budget (100,000) and one depth limit (64 levels) cover the whole list. A folded part's contents used to be walked under a budget of their own, so a design past the limit was listed with group_children; it is refused now, as it already was without it. - Kits are compared by what they hold (part, type and count), not as text: a part without a part number whose id is 12 no longer reads as a part numbered "#12", nor a part numbered "P×1\nQ" as a P and a Q. Kits holding the same parts through different definitions (two bolt definitions, each with its own nut definition of one part number) are one row, and its children count every bolt's placements, where they showed the first bolt's definitions only. - A folded part's row always stands for all it holds. It used to stand for its own bodies when nothing inside it was listed, which differs only for a phantom with bodies of its own inside it. - An inseparable part's row in parts only names the material of what it stands for (its steel blocks read Steel) where it was blank, and a subassembly whose parts share one material names it at the top level. - A damaged file's component placed inside itself is refused at the first level too, since naming a row's material walks inside it, as weighing it already did. - A row's body count saturates, so a compact assembly with more placed bodies than a count holds (a block placed 2^64 times) is weighed instead of overflowing. Materials follow Cameron's rule for a row that stands for an assembly (C3, 2026-10-23): a part's row lists its own bodies' materials, as before; a row that weighs what is placed inside it (a subassembly at the top level, a purchased or inseparable part with parts inside it, a folded part) names a material only when everything it stands for shares it, else none. A frame of steel and aluminium parts reads blank, and a bought bearing of steel parts reads steel. One walk (adding) decides what is placed inside a row's part for both its mass and its materials, and each definition's materials are read once. Components are looked up by id once per list; they were searched for each row and each kit. The window reads the rows directly instead of running assembly.bom after every change, so it no longer adds an entry to the crash journal each time it refreshes. The engine keeps the command, its parameters and the files. Tests check rows. The module's own: an empty assembly, one part, a row named by its lowest member through part-number edits, one part number of two types, a phantom in a phantom, a reference at the root and its own list, the 64-level limit, the budget hit exactly with and without folding, kits told apart by what they hold and the types they hold it as, a folded part's contents not folded again, row_of for every type, every placement in one row or none, a damaged file's missing component and cycle, the mass agreement rule (moved from the engine with row_mass) and what adds to a row. In the engine: the material rule for every kind of row, the JSON against the rows for every option, why a mass is unknown, the total against component.properties in every view, what a row stands for and its placements, and the overflow. The assembly.bom tests from #1888 on pass unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: structured, all levels (#3874) P4: `assembly.bom {levels: "all"}` lists the assembly's direct contents, each subassembly a row with its own rows listed under it, to any depth (items 1, 1.1, 1.1.1), each child counted `each` per one of its parent and `count` in all. - `doc::bom::View::AllLevels` goes through the one rule (`classify`) the other views use: a normal subassembly is a row holding what it holds, listed under it as all levels again; a phantom has no row and what it holds joins the level it sits in, merged with the same parts there; a purchased part is a row with nothing under it unless `show_purchased_contents` (Request::purchased_contents) asks for its contents; an inseparable part is a row with nothing under it; a reference counts nowhere. - The rows under a row are the folded-part rows already built (kits), so subassemblies with one part number and different contents are different rows, and no second nested builder is written. All levels gathers every level as it gathers the first; a folded part's contents are still gathered by part number in the other views. - The JSON and CSV already nest to any depth; `show_purchased_contents` is echoed with the other options. Each row's mass still adds up to the assembly at the top. Tests, worked by hand: four bolts and a two-bolt subassembly placed twice (8 bolts in parts only; in all levels the subassembly twice with 2 bolts each, 4 in all, beside the top's 4); three levels deep (2 x 3 x 2: counts 2, 6, 12, items 1, 1.1, 1.1.1, the CSV in that order); each type (a phantom's bolt merged into its subassembly's, purchased with and without its contents, inseparable, reference); two subassemblies of one part number with different contents as two rows; `levels: "deep"`, a flag that isn't one, and an assembly over 100,000 placements refused. D's test that a folded part's contents are listed as parts only lists them now names the two views it holds for, and checks all levels' nested rows (the subassembly inside the folded part a row with its own rows). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: parts with one part number are one row only when they hold the same to any depth (#3874) The kit compare looked one level down: two parts with one part number whose contents differed two levels below merged into one row, and the children that only one of them held came out at each 0. Each placement now has a kit, a number interned from what it holds (each child's part, type and own kit), built in one pass from the last entry back: an entry's children come after it in the walk, so their kits are known first. Rows are told apart by that number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: a phantom's own bodies are a row of their own (#3874) A phantom had no row, and its own bodies were weighed in the assembly's total but in no row, so the rows didn't add up. Its own bodies, when it has any, are now a row of the phantom's type that stands for them alone, as a subassembly's own bodies are in parts only; what it holds still counts where it is placed. Inside an inseparable part in parts only, nothing changes: the part's row weighs them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: the assembly's total mass in assembly.bom (#3874) `list` weighed the assembly as a whole (from the design, not added up from rows) and the command dropped it. `assembly.bom` now gives it as `total_mass_g`, and so does a JSON file it writes, only when `mass: true` (null when it isn't known). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: all levels as JSON lists its rows one after another (#3874) All levels nested each level's rows in the row above it: two JSON containers a level, so the 64 levels a list may hold came to 129, past the 128 that serde_json (and so the MCP server and the control channel) reads. In all levels `assembly.bom` now gives the rows one after another, each followed by the rows under it (items 1, 1.1, 1.1.1), as its CSV does; a row listed under another still reads its item as text and gives `each`. A folded part's contents, one level, stay inside its row as `children`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: a row whose definitions weigh something and nothing differs (#3874) A row gathering a definition with bodies and one with none (one part number on a steel block and on an empty assembly) said there was nothing to weigh. Their masses differ, so it says so; only a row where none of them has a body has nothing to weigh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: definitions agree on a mass within the measurement accuracy (#3874) A row's definitions had to weigh the same to 1e-9, but the kernel measures a volume from tessellations, and one part modelled another way is tessellated differently: a pin made as a cylinder and as a revolved rectangle measured 1.05e-5 apart, so it read as two masses. The bill of materials now has its own `bom::MEASURE_ACCURACY` (1e-4: ten times that gap, with its doc on what it follows: the kernel's `measure` gives one solid's volume to about that, relative, however the solid was modelled), and a row's definitions agree within it. A pin 0.1% wider (0.2% heavier) still differs. The kernel is unchanged: its work is paused while it is being replaced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials guide: all levels, purchased contents and this round's changes (#3874) The guide had no `levels: "all"` or `show_purchased_contents`. It now has both, with how all levels tells subassemblies apart and lists its rows as JSON, a phantom's own bodies as a row, the assembly's `total_mass_g`, and definitions that agree on a mass within the measurement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: materials are bodies', as the code says (#3874) The rule stays as built (a row that stands for an assembly names a material only when everything in it shares one), but its comment and the guide said a material set on a component is set on all its bodies. `material.assign` takes bodies only: a component has no material of its own yet. The module notes now say so, and where component materials will join the rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: a body's volume measured once with the evaluated model (#3874) `assembly.bom` measured each definition's bodies anew for every list, and `component.properties` measured each placed body again. A body's measure depends on nothing but the body, so the evaluated model keeps its volume (`ModelBody::volume`, shared by clones, as its outline box is), and both commands weigh that one measurement: the same grams to the bit. A body offset scales it by the size of its determinant (`mat_volume_scale`) instead of copying the B-rep to measure it. The physical properties still measure the placed body for its area, centre, box and counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: row keys, what rows stand for, members and row_of stay in doc (#3874) Nothing outside `doc` reads them yet: `RowKey`, `Unlisted`, `Holds`, a row's `key`, `stands_for` and `members`, and `Bom::row_of` are crate-private until item numbers and balloons need them, so they can still change without breaking another crate. The engine test that read them is covered by doc's own (`row_of_finds_the_row_a_placement_is_counted_in`, `every_placement_is_in_one_row_or_none`). `Unknown` stays public: `Mass::Unknown` carries it, and a public enum can't carry a private type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Assemblies: one fallible placement walk for totals that cover the whole assembly (#3874) The physical properties walked the placements twice in their own code, with the 64 levels and 100,000 placements written as literals, and the bill of materials gave the same refusal in words of its own. `Document::placements_below` is that walk once, from any placement, refusing what is past `MAX_PLACEMENT_DEPTH` or `MAX_PLACEMENTS` (never walking it in part), and both use its refusal: "the assembly is deeper than 64 levels or has more than 100000 placements". The physical properties now allow 100,000 placements below the start, as the bill of materials does (they stopped at 99,999). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: the same rows for less work (#3874) - Part numbers are borrowed from their definitions (`Part<'a>::Number(&'a str)`) instead of copied for every placement grouped and every kit. - A row's members, the placements' paths, are built only when the list is asked for them (`list_with`, for item numbers, balloons and `row_of`): the walk then keeps paths and moves each into its one row instead of copying it. A list made for its rows alone builds no paths at all. - `row_of` reads an index of member paths, built once with the list, instead of scanning every row's members for each placement asked about. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * occurrence.bom_type: input and output schemas (#3874, #4035) `OccurrenceBomTypeParams` takes the occurrence (an id or a name), its path when given and the type (one of the five, `same_as_component` or null), each read by the handler's own reader: the path through `cmd::path_ids`, split out of `occurrence_path`, the type through `cmd::occurrence_bom_type`, split out of the handler. The handler builds its reply from `OccurrenceBomTypeResult` ({occurrence, bom_type, effective, changed}). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials tests: all levels presented at every depth, and its caps (#3874) - `assembly_bom_presents_the_typed_rows` now covers all levels (with mass, purchased contents and by definition) and the total mass, on a three-level design with a purchased gearbox holding a gear, comparing every field of every row down to 1.1.1.1. - All levels lists 100,000 placements and 64 levels, and refuses 100,001 and 65. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: static materials, typed in for a component (#3874) A value the bill of materials works out can now be typed in by hand for a component (a static value, Cameron's choice of word). Material comes first: `component.metadata.set {component, material}` takes any text up to MAX_TEXT_BYTES, and `component.metadata` reads it back as `material`. It is shown wherever the component is listed, at every level and in every view, over the materials worked out from its own bodies or an assembly's blank, and the row carries `static: ["material"]`. Clearing it (empty text or null) brings the worked-out material back. It is kept the way `bom_type` is: a part property in the component's metadata (`material`), so there is no format change and older releases keep it. `PART_ONLY` names both keys in one place: Design Properties doesn't list them and `document.metadata.set` refuses them. Another tool's non-text value is kept and reads as no static material. The bill of materials says one thing about the part everywhere: a static material also stands for the part in the one material an assembly around it shares (two parts typed in as S355 make their frame read S355; S355 beside plain steel reads blank). A phantom's row is its own bodies, so its static material names those only, and what it holds keeps its own. A row gathering several definitions takes the first one's that has a static material, as its description does. It only names: mass still comes from the bodies. The CSV gets a `material` column at the end, so the other columns keep their places: what the row shows, the static material or the worked-out ones joined with "; ". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: stable item numbers, saved with the design (#3874, P5a) A numbered parts list keeps each row's item number under the row's key in `assembly.item_numbers`, so a row keeps its number when others are added, removed or reordered. New rows take the next number after the highest at their level; Renumber restarts a view in list or item order and leaves locked rows alone; duplicates are marked; numbers change no geometry and are part properties in the undo history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f3ee34d372 |
English: American spelling throughout the base catalog, British only in English (UK), and "1 body" (#9085) (#9194)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
cb34eef6aa |
Settings profiles: save, switch, export and import input and interface settings (#6237) (#6254)
* claim: #6237 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Settings profiles: save, switch, export and import input and interface settings (#6237) A profile keeps the Interface, Navigation and Sketch preferences (mouse mode, radial menu and gestures with every studio's lists, theme, scale, font, ...), the language, the keyboard shortcuts, the toolbar, the S box favourites and the imported theme it uses under a name. Machine-specific settings stay out (3D mouse, graphics, units, AI, recent files). - Preferences > General > Settings profiles: choose the active profile to apply it, Save, Rename, Delete, Export... and Import...; a note shows when the settings differ from the saved profile; Cancel takes a switch back. - settings.profile.{list,save,apply,rename,delete,export,import} commands for the control channel, palette and scripts; the engine checks the parameters, the app does the rest. - One `solidcraft-profile/1` file; import checks the format and name, drops unknown keys and unreadable values, caps sizes, never switches, and never panics. Each preference is applied through prefs::set, so a value this computer refuses keeps its current one and is reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Glossary: settings profile, and "profile" among the words with more than one meaning (#6237) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Settings profiles: new strings in a pending locale file, not the catalogs (#6237) New UI strings now go to assets/locales/pending/ (CONTRIBUTING.md), so this pull request no longer edits the shared catalogs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Preferences snapshot: compare the toolbar, favourites and profile too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Settings profiles: keep a command's several keys (#6237) Since a command can have several keys (#6288), the keymap saves a list where it has more than one. A profile's checks only took a single key, so saving or importing a profile dropped such a command's shortcuts. They now read the keys as the keymap does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Settings profiles: Arabic, Hebrew and Vietnamese strings (complete catalogs) (#6237) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Tripper <tripper@localhost> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
a7048f41ab |
Sketch: equation-driven curve, a curve from x(t) and y(t) formulas (#8352) (#8353)
* claim: #8352 * Sketch: equation-driven curve, a fit point spline from x(t) and y(t) formulas (#8352) sketch.equation_curve draws a curve from formulas in the expression language and the design's parameters: x(t) and y(t) over a range of t, or y = f(x) over a range of x. The curve is a cubic fit spline through fixed points sampled from the formulas, as many as keep it within a tolerance (0.01 mm by default, at most 500 points); a curve that ends where it starts closes smoothly. The sketch keeps the formulas (one new design-format file), places the points again before every solve so they follow the parameters, and sketch.equation_curve.edit changes them, keeping the joined end points. Both commands have input and output schemas. * Sketch: Equation Curve window, its Edit menu item, labels and guide (#8352) The ribbon's Equation Curve opens a window for the form (parametric or explicit), the formulas, the range and the tolerance; OK runs sketch.equation_curve. Right-clicking an equation curve offers Edit Equation Curve, which reopens the window on its formulas and runs sketch.equation_curve.edit. New labels and help in a pending locale file (with ar, de, he, ja, ko, vi and zh), the icon, the glossary term and the sketching guide. * Equation curve: one if for closing the sampled points (clippy collapsible_if) |
||
|
|
5e0e168ae9 |
Properties: moment of inertia, principal axes and first moments of a part or assembly (#8095) (#8103)
* claim: #8095 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Properties: moment of inertia, principal axes and first moments of a part or assembly (#8095) component.properties and occurrence.properties report each closed body's inertia tensor about its centre of mass, and in total the tensor about the total centre of mass (world axes, g·mm²), its principal moments and axes, the first moments, and with `about: [x, y, z]` the tensor about any point. The tensor comes from each body's welded export mesh, tessellated once per body, scaled to the measured mass and turned by each placement; bodies add by parallel axes. The maths is a new crates/geom inertia module. The Properties window shows the first moments, the tensor, the principal moments and axes, and the view marks the centre of mass with the principal axes while it is open. Inspect → Measure → Properties now opens that window (it ran the command and showed nothing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Properties: Copy matrix, and the whole design's card titled just Properties (#8095) Copy matrix, under the tensor, puts it on the clipboard as three lines of tab-separated values at full precision, in the units shown. The card for the whole design is titled Properties; one opened on a component, placement or bodies keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Properties: measure beside the window, so a large assembly doesn't freeze it (#8095) Properties ran on the window thread: 18 s on a 144-body design, with the window answering nothing meanwhile (#5203). In the desktop app the card now measures on a copy of the session on a worker, the way #4614 made agents' measures work, says "Measuring…" until the reply is in, and Close drops it. A quick measure still shows at once; headless, tests and the web measure in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
4fa051c9fc |
View angles: an optional readout under the orientation gizmo and a command to set them (#6032) (#6249)
* claim: #6032 * View angles: an optional readout under the orientation gizmo and a command to set them (#6032) View > View angles (also Preferences > Graphics, or view.angle_readout) shows the view's pitch, yaw and roll in degrees and Ortho/Persp under the axis view or cube, updated live; off by default. Clicking the readout opens a small card to type exact angles, which runs view.apply. The angles are the camera's own (Camera::view_angles / with_view_angles), about the up axis: yaw is the heading of the line of sight (Front 0, Left 90, Right -90, Back 180), pitch the eye's elevation (Top 90, Bottom -90), and a positive roll turns the model clockwise. view.apply documents this convention and now refuses a pitch past +/-pi/2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9bcb2ffe68 |
Drawings: first landing from the drawings branch (#8249)
* Drawing sheets: sizes, the ISO 5457 border and its marks (#3875) (#5108) * Drawing sheets: sizes and the ISO 5457 border (#3875) A sheet is a paper size and an orientation: ISO A0 to A5, Letter, Legal, ANSI A to F, architectural A to E1, or a custom size (finite, above 0 and at most 5,000 mm a side), landscape by default and either way for every size. A border profile is the rule for its border, and layout() works it out for a sheet: the frame inside the margins, and the reference fields with their labels. The ISO profile has a 20 mm filing margin on the left and 10 mm elsewhere, a 0.7 mm frame, fields of 50 mm out from the centre lines with the corner fields taking what's left, rows lettered from the top without I and O (AA, AB and on past Z), columns numbered from the left, and an A4 sheet labelled on its top and right only. A profile can divide the frame equally instead, or have no grid. The records sit in geom, next to the section records, so saving, rendering and export can all use them. Nothing is saved or drawn yet: there is no command and no format change. Margins that leave no drawing space, values that aren't finite, fields outside 1 to 1000 mm, more than 200 equal fields and unknown JSON fields are refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: ISO 5457's centring and trimming marks (#3875) A drawing border profile now also holds the grid reference border and the centring and trimming marks, either of which can be left out. The ISO profile follows ISO 5457:1999 (read in its identical adoption, IS 10711:2001): - the grid reference border 5 mm outside the drawing border on every side, with the field labels between the two; - four centring marks on the sheet's centre lines, from the grid reference border to 10 mm inside the drawing border; - at each corner a trimming mark of two overlapping 10 x 5 mm rectangles, in the margin outside the grid reference border. The labelled sides are now a rule worked out for each sheet: ISO 5457's (the top and right of A4, all four sides of the others) or fixed sides. So one profile labels every size correctly. validate() checks what doesn't depend on the sheet, for when a profile is read; layout() calls it, then checks the rest against the sheet. Refused: - a grid reference border that isn't finite, is negative or is wider than a margin; - a centring mark that isn't above 0, would reach past the sheet's centre lines, or is on a drawing border those lines miss; - a trimming mark that isn't above 0, is wider than it is long, is wider than the margin left outside the grid reference border, or is longer than half the sheet's shorter side. The grid rule's JSON is now externally tagged ("none", {"from_centre": {"field_mm": 50}}), as the sheet size is, so an unknown field is refused in every form; the internally tagged "none" ignored one. Nothing is saved yet, so the shape change costs nothing. The names follow the glossary, and ISO 5457's "drawing sheets": the module is drawing_sheet (was sheet, which means sheet metal elsewhere here), DrawingBorderProfile and SheetLayout (were BorderProfile and BorderLayout), sheet_border and drawing_border (were paper and frame), and Sheet::size_mm (was paper_mm). The first part of S1 is still a draft, so the renames are made here rather than in a commit of their own. The extra centring marks ISO 5457 asks for on sheets larger than A0 aren't here yet. Still nothing is saved or drawn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: a lighter built-in border, the filing margin a choice (#3875) Cameron's decisions after seeing the sheet in the app, 2026-10-23: - No trimming marks in the built-in profile: the filled corner blocks take a lot of ink. trimming_mark_mm stays, so a profile can still ask for them. - Centring marks stop at the drawing border: from the grid reference border to the drawing border, never into the drawing area (on A4 they crossed the tables). centring_mark_mm keeps its meaning, how far a mark reaches inside the drawing border, and now takes 0, the built-in value, as grid_border_mm already takes 0 for "on the drawing border". A mark of no length (a reach of 0 with no grid reference border) is refused. - Margins of 10 mm all round. ISO 5457's 20 mm filing margin on the left, for drawings that get bound, is a named choice: filing_margin, off when not given. On, it stands in for margins.left_mm, which is kept, and still checked, for when it's off again. The 20 mm is FILING_MARGIN_MM, and validate() and layout() both take the margins from one helper, laid_out_margins(). A3 landscape is now 400 x 277 at (10, 10), with eight 50 mm columns. With the filing margin it is 390 x 277 at (20, 10) again, the same as a 20 mm left margin set by hand. A profile with all three choices on (ISO 5457's full border) lays out exactly as the built-in profile did before, and the tests keep the old hand values for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W23a workshop plate oracle fixtures (#4950) (#4962) * test(oracle): reviewer-aligned parameterized workshop plate fixtures (#4950) Independent analytic W23 expected values and seven verified models, including four R10 corners and the 2 mm tangent top chamfer. Document accepted Drawing states and commit regenerated docs/oracle.md from successful workflow run #29 (90/90 pass). * fix(oracle): correct W23 chamfer centroid and clarify drawing session ownership * Paper scene: plain records of what is drawn on a sheet (#4890 A1) (#5513) geom::paper holds what a sheet shows as plain data: groups of strokes and fills, each group tagged with the object that drew it (an opaque id) and its kind, with one validation pass over a bounded record count. Seg2's checks and the coordinate rule move into profile.rs so section and paper share them, and drawing_sheet takes its side and line limits from paper, so each limit is written once. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: centring marks across the whole margin (#3875) (#5554) The built-in sheet's centring marks now run from the trimmed sheet's edge to the drawing border. From the grid reference border, as before, a mark was the same length as a grid field mark, and on A3 it sat on one (the sheet's centre falls on a field edge), so it no longer read as a mark once the grid reference border's outline is left out (Cameron, after the prototype on #3875). - DrawingBorderProfile.centring_mark_start: sheet_edge (the built-in's, and when not given) or grid_border (ISO 5457's figure 5); ISO's full border in the tests asks for grid_border. - A mark still needs a length: one that stops on the drawing border needs room outside it on the side it starts from, every margin for sheet_edge, the grid reference border for grid_border. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: no centring or trimming mark longer than the largest sheet's side (#3875) (#6410) A border profile capped every length at 5000 mm (the largest sheet's side) but two: a centring mark's reach inside the drawing border and a trimming mark's length. A file could give either a huge whole number, such as 18446744073709551615. The read's number check passes whole numbers, so the profile took it as 1.8e19 mm, and saving wrote it as a decimal the next read refused: a drawing that saved but didn't open again. K2's fuzz test of drawing files (#3890) found it. Both now take the cap the margins have, `MAX_SIDE_MM`, in `validate`, so the file is refused when it's read. Layout's own checks against the sheet are unchanged, so a 5000 mm mark still validates and is refused only on a sheet too small for it. Tests: the hostile-profile test refuses 5000.000001 mm and 1.8e19 mm for each mark, and takes 5000 mm on its own; 4 planted faults (each cap removed or made one short) are all caught. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials types: phantom, reference, purchased and inseparable (#3874) (#5107) * Bill of materials types: phantom, reference, purchased and inseparable (#3874) A component's bill of materials type is a part property (`bom_type` in its metadata, set with component.metadata.set and read by component.metadata, as part_number is), so older releases keep it and no format change is needed. It isn't a design property: the Design Properties dialog doesn't list it and document.metadata.set refuses it. A word this build doesn't know reads as normal and is kept. assembly.bom counts by type: a phantom has no row and what it holds counts where it is placed, in the same rows as the same parts there; a reference counts nowhere, and nothing inside it does; purchased and inseparable components are one row, and in parts only an inseparable component's purchased parts are listed too. Rows of one part number but different types are different rows. Rows and children carry bom_type. With no types set the rows are as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Glossary: bill of materials and bill of materials type (#3874) The bill of materials types are a new idea, so the glossary gets their term, with the five types, and "normal" gets its fourth meaning in the table of words with more than one meaning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials types: a plain line for each (#3874) The guide's table and the glossary entry say what each type is for in plain words: something you make, something just to group, something to use as a reference, something you buy, something made as one piece. The names stay the five standard ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: kits fold together only when their contents' types match (#3874) With group_children, two kits with one part number share a row when what they hold reads the same. That reading (kit_key) compared each child by part number and count, but not by its bill of materials type, though rows themselves are told apart by type. So a kit holding a made bolt and a kit holding a bought one, both KIT, folded into one KIT x2 row listing the first kit's bolt twice: the other type was lost, and which one depended on creation order. 0xlillith found it in review of #5107. kit_key now includes each child's type. Equal part number, type and contents still fold. Test: two KIT kits each holding a BOLT fold into one row of two; once one bolt is purchased they are two rows, each listing its own bolt. Planted fault (the type left out of the key): caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing files: a drawing saved as a container or as plain JSON, never read as a design (#3890) (#7098) * File format families: drawings share the design format's versioning (#3890) The format code works for a family of files: its own tag, its own numbers and its own folder of change files, with one reading of a file's format, one refusal of a file a newer build saved and one upgrade for every family. Designs (solidcraft/N) are one family and keep everything they had: FORMAT and FORMATS are as they were, and pending_names, format_string, version_of and read mean what they did. Drawings (solidcraft-drawing/N) are the other, with format 1 as their first record and each later change one file in crates/doc/src/drawing/format/pending/, as design changes are. Nothing saved changes. A design tag never reads as a drawing's or the other way round, and a file that names no format is a design from before format strings, never a drawing. Every refusal names its family; a design's read word for word as before. A design listing a pending change this build doesn't have is now refused as a newer build's before its content is checked, as a newer number already was, so a newer build's fields never read as damage. The list reader is take_names(v, key, noun), the shape #4811 uses for its own list. For the maintainer, the release step changes: scripts/fold-format-pending.sh now folds every family that crates/doc/build.rs lists (FAMILIES), each into its own next number: designs into crates/doc/src/format/v<N>/ as before, drawings into crates/doc/src/drawing/format/v<N>/ from 2. With nothing pending in a family it says so and moves nothing. Its test folds a drawing change into v2 beside the design changes. docs/releasing.md, CONTRIBUTING.md and AGENTS.md say so. build.rs lists each family's changes from its own folder, each folder's versions contiguous from its own base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing record: format 1 of the drawing family (#3890) A drawing is now a record of its own (crates/doc/src/drawing.rs): its name, the designs it draws (sources: an id and the design file's path, relative to the drawing's folder as a linked design's is), its properties under the design metadata's rules, its units (each design's own, or one length unit of the expression unit table), its content language (a BCP 47 tag) and its sheets. A sheet holds its paper, a copy of its drawing border's profile, the resolution its pictures are rendered at (300 dpi unless it says, 25 to 2400), the component it documents and whether it is left out of the sheet count or of printing. This is format 1 of the drawing family; each later kind of record adds one file in crates/doc/src/drawing/format/pending/. The rules: one id counter for every object, raised above the largest id when a file is read and never rewound; every reference is an id that must resolve, or the file is damaged and refused, never patched; 1 to 1,000 sheets, at most 64 sources, names of 1 to 256 bytes, paths of 1 to 4,096 bytes without NUL. The same drawing always saves as the same bytes. Drawing::from_json reads at most 16 MiB of text, then runs the family's format check, the number check, the upgrade, the typed record (unknown fields refused everywhere) and Drawing::validate. The number check is now one function every family calls, Family::check_numbers, told which field holds other tools' data; a design's refusals read as before. Nothing saves or opens a drawing yet: the container is the next step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing ids: random and collision-free from format 1 (#3890) A drawing's objects now take random ids, the form jyviko chose on #3890 from #1017: no counter, so objects added on two branches never share an id and never edit one line. The allocator is one module for drawings now and designs later (#626 Phase 3), crates/doc/src/ids.rs: an IdSource gives nonzero u64s by splitmix64 from a seed, each checked against the ids in use and drawn again when it is one, or when it is 0. A run never draws a number twice, so at most one draw per id in use comes before a free one, and a seeded run over a file the same seed made still gets a new id. IdSource::seeded gives the same ids for tests and replays; IdSource::from_entropy seeds a session from the standard library's hash keys, the time and a count, with no new dependency. In a file an id is 13 characters of Crockford base32, lowercase (0000000000001 to fzzzzzzzzzzzz): ids::encode writes it and ids::decode reads only that spelling, case-sensitive, so an id has one form to search for. Anything else, 0 included, makes the drawing damaged. The drawing loses next_id (a file that holds one is refused), and Drawing::new and allocate_id take the IdSource. Messages name ids as the file writes them. The component a sheet documents stays its design's own number until designs move over. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing record: a drawing too large to reopen isn't saved (#3890) from_json reads at most MAX_DRAWING_BYTES (16 MiB), but to_json had no limit. Other tools' properties are kept as they came, and indenting them can grow a drawing read in at about 4 MB past 16 MiB (two million zeros in one array), so the next read refused what the save had just written. 0xlillith found it in review of #3891. to_json now returns a Result and refuses JSON longer than a read takes ("drawing too large to save (at most 16 MiB)"), so every drawing saved opens again. Nothing writes drawing files yet, so the error reaches the future file writer before it publishes anything. Test: that case is refused, and a smaller compact drawing saves and reopens unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing files: a drawing saved as a container or as plain JSON, never read as a design (#3890) K3 of the drawing storage plan (W11.2): the file a drawing is saved in. Nothing writes one from a command yet; opening and saving come with K5. - A drawing container is a design container holding `drawing.json` (Deflate, as `document.json`) in place of `document.json`, and `container.json` says so: {"content": "drawing", "format": "solidcraft-container/1"}. A design's `container.json` is as it was, with no `content`. The plain JSON form is the drawing's own text. Both give the same bytes every save, so a drawing can live in version control as text. - `io::file_kind` tells a design from a drawing by `container.json` or by the JSON's format. The design reader refuses a drawing ("this file is a SolidCraft drawing, not a design: open it as a drawing") and the drawing reader a design; plain JSON only asks when it isn't a design, so reading a design costs nothing more. A container's content this build doesn't know, or a drawing container that also holds a design's `document.json`, is refused. - `read_drawing` (bytes, either form), `read_drawing_file` (one seekable handle, the design reader's checks) and `write_drawing_container`; `DRAWING_EXT` (`scdwg`) and `is_drawing_path` beside the design's. - The container writer's set-up and finish, the file opening and the container sniffing move into one function each, which designs and drawings both use. The container's own checks (budgets, entries, the ZIP directory) are the design container's, word for word. Tests: a drawing round-trips through both forms byte for byte, and the container holds exactly `container.json` and `drawing.json`; `file_kind` on both forms of both kinds; each reader refuses the other's file; unknown content, a stray `document.json`, a missing drawing, an unknown container version and a damaged drawing refused; both forms from disk, and a directory refused; mutation fuzz of both forms (an error or a drawing, never a panic). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Paper scene: SVG of a sheet, its lines, arcs, cubics and fills (#4890 A3a) (#7032) The first export of a paper scene, as SVG first (jyviko and 0xlillith on #4890), from the research in the plan's §16. A3b adds ellipses, hyperbolas and Béziers above degree 3, which this refuses as "not supported yet". - `geom::paper::Prepared`: writers read a scene through `Scene::prepare`, which checks it first, so none reads one unchecked. Clipping goes there too, once (A8). - `geom::paper::arc_pieces`: an arc's ends in pieces of at most a quarter turn, the last its own end. A half turn drawn from its ends is ill-conditioned: rounded to the nanometre (six decimals of a millimetre) its centre moves up to 1e-2 mm, where a quarter turn's stays under 1e-6 mm. - `io::paper::paper_svg`: one user unit a millimetre, the size in mm on the root; y flipped by writing the height less y, so the file's numbers are page coordinates and an anticlockwise arc has sweep flag 0; lines `L`, arcs `A` (never large-arc), cubics `C`, parabolas `Q`; fills black and even-odd; one path per item; groups as `data-object` and `data-kind` (object ids can't be XML ids). No background, so cutters see only the marks. - Numbers are whole nanometres (six decimals of a millimetre): no exponent, no "-0", the same bytes every time. They are the writer's own state too, so a joint is written once and a closed path ends exactly on its first point. Numbers are written straight onto the document, with no text made per number. A width under half a nanometre is written as one, and a piece too short for the grid is merged into the next, both counted in the report; a path's last piece has no next, so it is kept however short (unless it has no length). Output over 64 MiB is refused. Tests: the A3 drawing border's whole document; quarter, 270°, clockwise and whole-turn arcs, and a circle of two halves giving the same four quarters; the quarter-turn boundary both sides; cubics and parabolas, and the conics refused; the number format; a closed path whose start and end round apart; a sliver merged; an open path's short last line and arc kept, and one of no length dropped; read back through our own SVG reader (lines exactly, the arc as an arc); the scene's JSON mutated into the writer (never a panic). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W17a: view definitions as data (#4816) (#4817) * claim: #4816 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing views as data: named views, scales and the map onto paper (#4816, W17a P1) What a drawing view is, before anything draws it (geom::drawing_view): - NamedView: the six principal views and the isometric views from the four upper corners, each an exact basis (a Plane whose normal points back at the viewer), never taken from a camera, whose pitch clamp would tilt a top view, with no -0 to write out; `iso` reads as the front-right one. - basis_looking: any other view from its direction, an up and an origin (paper x = direction x up, paper y = x x direction), refusing a zero direction, an up along it, or an origin that isn't finite or within 1e12 mm. W07's {direction, up, origin} view reads through it. - Scale: paper : model as two positive numbers, read and written as "1:2", from 1:100000 to 1000:1; Scale::fit picks the largest ISO 5455 preset (50:1 to 1:10000) at which a view fits a space (W07's "fits the page" default), compared as size x paper <= room x model so an exact fit at a reduction isn't lost to rounding. - ViewFrame: a view's basis, scale and place on paper, the point of its plane at `centre` landing at `position_mm`. Its paper map moves the view's curves and their accuracy onto paper (paper error = scale x model error); `boundary` maps a box of its plane onto paper from its four corners. In geom, where Seg2 lives: - Similarity2 and Seg2::similar (new): scale, turn and shift a segment exactly, an arc staying an arc. Similarity2::new refuses a scale that isn't above 0 and works the turn out once, not per point; - Seg2::map_controls: a segment's control points mapped by any function. It was doc's sheet::map_controls; its four callers in doc use the method now, unchanged. CurveAccuracy::scaled gives a curve's accuracy at another scale. Tests: each named view's basis and viewer side, and the same bases from a direction and up; a 50 mm cube in every principal view at 1:1 and 1:2, and in isometric (edges 50 x sqrt(2/3), outline 50 x sqrt(2)); the view's centre on its position (W07's 100 x 20 front view on A3 at 2:1); scales read, written and refused; the fitted scale, an exact fit at 1:5 and ISO's smallest; no -0 in any named view's axes; an origin refused by its own message; hostile bases, centres and positions; every segment kind moved by a similarity, and the similarities refused; scaled accuracy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing views: the bottom view pinned, square near parallel, bounded scales and boxes (#4816) From DevonHope's review of #4817: - The tests pin all six principal views exactly. The direction-and-up test uses literal ups, so a bottom view turned half round now fails it. - basis_looking squares x to the direction before normalising. Near the 1e-9 threshold the normal was up to 8.8e-9 rad off; now it is about 1e-16. - Scale::fit fits nothing for a size or room that is negative or not finite. A size of 0 still sets no limit that way. - Each side of a scale is 1e-6 to 1e6, so a scale writes at most 49 characters. - ViewFrame::boundary returns a Result. It refuses a box that is inside out or not finite on paper, instead of dropping a corner. - paper_map, boundary and seg_to_paper say which coordinates they take. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W18 S2: title blocks as data (#3875) (#3877) * Title blocks: what a cell shows and where its text goes (#3875) geom::cell holds a title-block cell's content: parts of text and fields (component, drawing, sheet, revision or prompt, by key, with an optional unit and decimals kept as written for the resolver to check), at most 64 parts and 4096 bytes of text, with no control character but a line break. Beside it are a resolved value (live, overridden and drifted, or missing, with "-" for each part that couldn't be read and why), an override with the value it replaced, and the projection a drawing's views use (first or third angle), which the title block's symbol will read. A fit warns and never cuts: a count of characters, not bytes, with its own count for text in Chinese, Japanese, Korean or Yi characters. The cell text rule places a label and a value: the label's baseline 1 mm plus its cap height below the cell's top, the value box under it inset by 1 mm, one line centred in the box, and wrapped or several lines down from its top at the font's pitch, with a warning when the last falls below the box. Wrapping by width, width warnings and glyphs a font lacks need the text measured, so they wait for the paper scene's text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Title blocks: definitions and their place on a sheet (#3875) geom::title_block holds a title block's definition: its size (1 to 1000 mm a side), its outline and cell line widths, and up to 64 cells. Each cell has a snake-case name of its own, a rectangle measured from the block's lower-right corner, an optional one-line label with its cap height, and a value: text from cell content, with its cap height, alignment and fit, or the projection symbol, which reads the drawing's projection and is never fixed in the block. validate() checks a definition on its own, as when one is read: cells inside the block and not overlapping (touching is fine), label and value cap heights that fit, and the content's own limits. layout() puts the block on the drawing border's lower-right corner of a sheet, refusing one that doesn't fit, and gives each cell's rectangle, its label's place and its value box by the cell text rule. On A3 landscape a 180 x 54 mm block runs from (230, 10) to (410, 64); it fits A5 landscape and every larger sheet, but not A5 upright. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cell text: a value box lies within the paper's coordinates (#3875) place_lines took any finite, ordered value box, but centring one far out (min x 1e308, max x 1.1e308) overflows: the anchor came back infinite, with no warning. 0xlillith found it in review of #3877. The paper scene already bounds every coordinate it holds by MAX_COORDINATE_MM (twenty times the longest sheet side). That limit is now public, and place_lines keeps its box inside it, so its anchor is always finite: one rule for what a paper coordinate may be. Tests: the hostile-box test refuses both overflow cases from the review and a box just past the limit on each side, and places lines in a box the size of the whole paper limit. The fuzz test's numbers now include values past the limit (1.1e5, ±1e308). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Title blocks: padding from the lines' inner edges, one label rule, nothing unread (#3875) A cell's text is padded from the inner edge of its lines: each side of a cell moves in by half the line drawn on it (the outline's on the block's edges, a cell line's inside), so a wide outline never covers the text. Before, the padding ran from the line's centre. The label's one-line rule lives with the cell text rules (`cell::check_label`), where parts lists will find it. The cell types nothing read yet (`Override`, `Resolved`, `State`, `Problem`, `Reason` and `MISSING`) wait for the resolver that will read them. The tests check the exact thresholds inside the lines (a label that leaves no room, a value that just fits), pick each of the lines, alignment and wrapping on their own so every combination comes up, and lay fuzzed blocks out on every standard sheet, either way, with and without the filing margin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Title blocks: the drawing border's line, descenders, room where the block sits (#3875) From DevonHope's review of #3877: - Each cell's lines are clamped to the inner edge of the drawing border's line. That line runs along the block's right and bottom edges, and along any other edge it reaches, as when the block fills the border. Aabb2::intersection, the 2D twin of Aabb3's, does the clamping. - layout checks each cell's room again where the block sits (place_cells, which validate runs at the origin), so rounding at the real corner can't turn a cell inside out. - The cell text rule counts descenders, at 3/10 of the cap height (ISO 3098's lettering B). They may reach into the padding under a value box, never past it to a line. place_lines warns Height when they would, and validate asks it whether one line fits. - The module doc no longer links to a private function. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W06a: exact orthographic hidden lines for the analytic subset (#2455) (#2457) * Drawing W06a: exact orthographic hidden lines for the analytic subset (#2455) crates/geom/src/hlr (L0): prepare once per body, then hidden_lines for a scene of placed bodies. Edges and face silhouettes are projected from their exact curves, split where projections cross, and each piece is classified by rays toward the viewer against the trimmed faces: visible, hidden or explicitly uncertain, never guessed. Planes, cylinders, cones, spheres and tori are supported whether stored as analytic records, revolutions or spline patches; freeform faces are reported and make what they could hide uncertain. Screen geometry is Seg2 with the W01a accuracy vocabulary: exact lines and conic arcs where the projection is exact, bounded chords otherwise. docs/drawing-hlr.md holds the contract and its limits. * geom/hlr: handle the brep records main gained in #3093 Main's exact model storage (#3093) added Curve::SurfaceIntersection, Surface::PlaneThrough and Surface::PlacedRevolution, and the HLR matches on the records no longer compiled. A plane through three points is a plane: it is trimmed and intersected as one, and a box stored that way draws the same bits as one with axis-stored planes. The procedural intersection curve and the placed revolution (whose affine placement may scale it unevenly) are refused by prepare as not supported yet, until the kernel adapter handles them. The records' positions move with the body's centre like the others. * geom/hlr: pad plane faces' boxes, so a plane record off by rounding still hides Plane faces took the box of their boundary chords unpadded, flat along the normal. When the plane record and its edges disagree by rounding (a unit cube's top plane one ulp above its edges, a 100 mm cube's 1e-11), the ray toward the viewer reached the plane just outside that box, the slab test culled the hit, and the back edges came out Visible with no doubt. Every face's box is now padded by 1e-6 of its size, as curved faces' boxes already were. Reported by DevonHope on #2457. * geom/hlr: limits from review: trim samples, scene extent, crossing pairs, surface groups From DevonHope's review of #2457: - Options::trim_samples must be 1 to MAX_TRIM_SAMPLES (4096). - Placed bodies must stay within MAX_COORDINATE (1e12 mm, as section and brep bound stored numbers). Placements 1e200 apart made the scene's size infinite and every tolerance taken from it with it, so everything came out Visible. - The crossing search counts its candidate pairs before it starts and meets each pair only in the first grid cell the two segments share, instead of keeping a set of the pairs met, which could outgrow wasm's 4 GB before the 500 million pair budget tripped. The same pairs in the same order. - prepare groups faces on one quadric or torus by comparing each face with the faces of its kind whose size agrees to the tolerance (sorted), not with every face; at most 50 million comparisons. prepare_cancellable polls a cancel callback between edges, faces and comparisons. * geom/hlr: boundary chords on a grid, and no fine pass over coincident curved chords The cost items of DevonHope's review of #2457: - Every ray hit asked how far it lies from its face's boundary by scanning all of the face's chords (4096 per circle; a plate's face with 256 holes has about a million). The chords are now bucketed on a uniform grid over the boundary's box, cells at least as long as the longest chord, and the test looks only at the cells around the point. It finds exactly the chords the scan finds. - Chords of two curved curves that lie on each other end to end (aligned holes seen along their axes) were cut into 16 by 16 pieces and intersected, to find crossings that are only noise within the curves' tolerance. They are now skipped; visibility changes where a coincident run starts or ends, and chords that only partly overlap still find those. - Fixtures: a plate with holes, coaxial cylinders seen along their axis, and 300 placements. * geom/hlr: pad boxes by the body's coordinates too; coincident chords only to rounding Review of the previous commits found two holes: - The padding grew with the face's size, but rounding grows with where the body was modelled: a 0.001 mm cube 1e7 mm out, its top plane one step (1.9e-9 mm) above its edges, still had its hit culled. The pad now adds 1e-12 of the body's offset. - Two chords were taken for coincident when their ends lay within each other's sag, which in a coarse scene can hide real crossings: an arc can bulge across a line 1 mm off its chord twice. Only chords that coincide to rounding are skipped now; identical projections, the costly case, still are. * geom/hlr: coincident curves meeting at shared sample points do not cross Timing the review's scenes showed that skipping coincident chords was not enough: chords of two coincident curves also touch end to end at every sample point they share, and each touch was a crossing to refine and split at. 64 coaxial cylinders seen along their axis gave 8.3 million crossings (19 s), 64 cylinders one behind another along the line of sight 4.2 million (214 s; before these commits the crossing budget refused it). A touch at a shared sample point is now dropped when the two curves also coincide, to rounding, on both sides of it. Where a coincident run starts or ends one side differs, and the touch is kept. * geom/hlr: the own-face margin allows for rounding where a body was modelled The far 0.001 mm cube of the previous commit showed a second effect of records rounded at large coordinates: its top plane, one ulp (1.9e-9 mm) above its edges, hid the top edges themselves, because a ray leaving an edge met its own face 3.2e-9 mm along, past the own-face margin of 1e-6 of the face (1.4e-9). The margin now also covers 1e-14 of the body's offset (about 45 ulps of its coordinates), which only matters for parts far smaller than their distance from the origin. * geom/hlr: no parity test for a hit on the boundary, where it is uncertain anyway * docs/drawing-hlr: the fixtures of the review's second round --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> --------- Co-authored-by: CamWight <91156642+CamWight@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Benny1496 <163034806+Benny1496@users.noreply.github.com> Co-authored-by: Mateusz Sych <151755914+SychPL@users.noreply.github.com> Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
03b8f4138b |
New designs save as .sc; .solidcraft files still open (#7325)
* claim: new designs save as .sc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * New designs save as .sc; .solidcraft files still open and keep their name on Save DESIGN_EXT is now "sc"; DESIGN_EXTS lists sc, solidcraft and solvecraft and every open path (dialogs, drag-drop, recent files, CLI, MCP, links, the web picker) accepts all three. Save of an opened .solidcraft file writes that file; Save As, autosave, recovery and crash reports use .sc. Windows, macOS and Linux register .sc alongside the older extensions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Update UI tests for the .sc default extension Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
98abb249c4 |
Cylinder: place by distances from reference edges, like Hole (#6380) (#6381)
* claim: #6380 * Cylinder: place by distances from reference edges, like Hole (#6380) A Cylinder standing on a flat face can take up to two straight edges of that face as references, each with the distance of its base centre from the edge's line, measured in the face's plane, as a Single hole does (#37). `solid.cylinder` takes them as `references: [{edge, distance}]` with a numeric `base`; the edges are found again by their persistent names, else their points, so the cylinder follows them when the part changes, and each distance is a parameter (an input of Inspect Feature). A cylinder without references stays at its base, as before. In the Cylinder window, started on a picked face, Reference 1 and 2 take the edges, each with its Distance measured from the pick, so it works with the mouse alone; the canvas shows each distance with a box to type it in, and Edit Feature picks the edges again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder: Edit Feature shows each reference edge input once (#6380) A face selected when Edit Feature opened the window had already added the reference inputs; the edit added them a second time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder references: the measured-once cost test's cylinder has none (#6380) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder: pick the face it stands on in its window, then the edges (#6380) The Cylinder window took its place only from a face selected before it opened, so started first it stood at the origin and offered no reference edges. It now has a Face input before Reference 1 and 2, as the Hole window does: start Cylinder, click the face, click the edges, OK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Glossary: reference edge, and "Reference" among the words with more than one meaning (#6380) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder edge references: the Cone dialog (#6250) gets the references field too The Cone primitive landed on main after this branch began; its dialog initialisers lacked the `refs` field the Primitive kind gained here. The dense form check for Cylinder fills only its fields: its face and reference edges place it, which the reference tests cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder: declare references in its contract; reference-placed cylinders are not placement-independent Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
04e4e72ea1 |
History: delete a folder with its features, and suppress a whole folder (#7219) (#7220)
* claim: #7219 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * History: delete a folder with its features, and suppress a whole folder (#7219) `timeline.delete` and `timeline.suppress` take `groups: [timeline folder ids]`: every feature in those folders and their nested folders, in one undo step. A delete takes the folders themselves too; `timeline.ungroup` still keeps the features. The History on the left offers Suppress/Unsuppress Selected Folders and Delete Folders and Features… (asking first, like Delete Selected Features…, when something outside needs them); a folder whose features are all suppressed is drawn faint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * History folder actions: Arabic, Hebrew and Vietnamese strings (complete catalogs) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
06af6e1107 |
Pattern dialogs: Quantity is the count in every language, the motion plot keeps its own entry (#6538) (#6733)
The catalogue entry Quantity served both the pattern dialogs' number of instances and the motion study's plotted quantity. Nine locales had translated the second meaning, so the rectangular pattern dialog showed e.g. "Größe" above "Anzahl 2" in German. The motion study's row now reads motion.plot_quantity (a pending file that keeps every locale's previous word there). Quantity takes each catalogue's own ui.quantity text, which the "Quantity 2" row already shows; nothing is newly translated. The glossary lists Quantity under words with more than one meaning. Fixes #6538 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
4c4f25115b |
Bill of materials types: phantom, reference, purchased and inseparable (#3874) (#5107)
* Bill of materials types: phantom, reference, purchased and inseparable (#3874) A component's bill of materials type is a part property (`bom_type` in its metadata, set with component.metadata.set and read by component.metadata, as part_number is), so older releases keep it and no format change is needed. It isn't a design property: the Design Properties dialog doesn't list it and document.metadata.set refuses it. A word this build doesn't know reads as normal and is kept. assembly.bom counts by type: a phantom has no row and what it holds counts where it is placed, in the same rows as the same parts there; a reference counts nowhere, and nothing inside it does; purchased and inseparable components are one row, and in parts only an inseparable component's purchased parts are listed too. Rows of one part number but different types are different rows. Rows and children carry bom_type. With no types set the rows are as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Glossary: bill of materials and bill of materials type (#3874) The bill of materials types are a new idea, so the glossary gets their term, with the five types, and "normal" gets its fourth meaning in the table of words with more than one meaning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials types: a plain line for each (#3874) The guide's table and the glossary entry say what each type is for in plain words: something you make, something just to group, something to use as a reference, something you buy, something made as one piece. The names stay the five standard ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: kits fold together only when their contents' types match (#3874) With group_children, two kits with one part number share a row when what they hold reads the same. That reading (kit_key) compared each child by part number and count, but not by its bill of materials type, though rows themselves are told apart by type. So a kit holding a made bolt and a kit holding a bought one, both KIT, folded into one KIT x2 row listing the first kit's bolt twice: the other type was lost, and which one depended on creation order. 0xlillith found it in review of #5107. kit_key now includes each child's type. Equal part number, type and contents still fold. Test: two KIT kits each holding a BOLT fold into one row of two; once one bolt is purchased they are two rows, each listing its own bolt. Planted fault (the type left out of the key): caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0dffb206b1 |
Assembly: ground the first part; drag free joint chains (#2804) (#2805)
* assembly(feat): ground first parts and drag free joint chains Ground the first top-level part when it is created and let face dragging reposition free occurrences or any member of a floating joint chain in one undo step. Preserve exact repeated-placement frames, joint values, modifier selection and Escape cancellation. Keep the accumulated fixture, viewport layout and documentation integration fixes from the existing PR. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(fix): update movable fixtures for first-part grounding Accept the documented grounded override in component creation, explicitly free movement fixtures, and keep linked clipboard pastes movable even in an empty document. Cover first and reused linked pastes, default insertion grounding, and single-step undo in the existing link tests. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): keep the motion-cost crank free Unground the first component in the document-level joint-face measurement fixture so its motion samples can rotate after first-part grounding. Preserve the rotation and shared-measurement assertions that caught the Linux CI failure. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): free the frame placement fixture Create the frame-member placement fixture ungrounded before moving it above its root sketch. Keep its world-space member assertions while respecting first-part grounding in the frame tests added on main. Signed-off-by: Karl Von Richter<karl@embeint.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> |
||
|
|
b7a6c68702 |
Docs: a glossary of SolidCraft's terms (#1569) (#2484)
Thanks @CamWight. |