Commit Graph
89 Commits
Author SHA1 Message Date
jyvikoandClaude Opus 5.5 005b1e6ea0 SMLib pcurves: an edge past its face's patch gets a tolerance that covers it
An edge whose curve runs a few um past its vertex and its spline face's
patch was trimmed back by SMLib when it made the trim, and the face was
refused ("SMLib moved an edge's interval"). Our own measure never saw the
gap: STEP measures an edge against its surface only where the nearest point
is in closed form, and a spline face's gaps only on the pcurves the kernel
returns, after SMLib has trimmed the edge. Each bare use's edge is now
measured by SMLib (smlib_brep_edge_face_distance, over the patch) after the
sheet's import, its tolerance raised to cover the gap with
SURFACE_GAP_MARGIN and the sheet imported again: SMLib keeps the edge whole.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 22:12:21 -04:00
jyvikoandClaude Opus 5.5 5d6810128b STEP and SMLib: no edge or vertex tolerance past the 1 mm SMLib takes
An edge raised to cover its pcurves' gap could get past SMLib's limit
(Congé19: 0.98 mm off, tolerance 1.47 mm) and its whole solid then failed
as "SMLib rejected the input". The tolerance an edge or vertex would get,
not only its gap, is now held to that 1 mm: farther off is refused with
how far. The record mapping refuses a tolerance past it with a message
rather than handing SMLib what it rejects.

The margin over a surface gap moves to solidcraft_geom::brep::pcurve
(SURFACE_GAP_MARGIN) for SMLib's pcurves to use too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 22:12:21 -04:00
jyvikoandClaude Opus 5.5 0bee8c2ed2 solidcraft-smlib: Brep::edge_face_distance, SMLib's own edge/face gap
Binds smlib_brep_edge_face_distance: how far an edge lies from a face's
surface over the surface's own domain, the gap SMLib sizes an edge's
tolerance by.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 22:12:21 -04:00
jyvikoandClaude Opus 5.5 19c4a1502b SMLib pcurves: an end SMLib sets within the edge's tolerance is mapped onto our interval
SMLib may end an edge at a parameter of its own: a knot its vertex lies at (-1.0 where the
vertex's angle gives -0.99999998, a 2e-8 step on the edge's quarter arc, far under 1e-6 mm).
We refused any change beyond 1e-9 of the parameter, a bound with no geometric meaning:
"SMLib moved an edge's interval" on 8 of Poppy Humanoid's faces. The ends SMLib chose are now
measured on the edge's curve: within the edge's tolerance, its pcurve is mapped onto our
interval by the affine change of parameter (exact for a B-spline: its knots move), and the
record's check measures it as any pcurve; farther is SMLib trimming the edge, refused with
how far.

Poppy: 227 → 232 bodies, 17 → 15 solids not imported, no interval refusals left.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-27 20:53:08 -04:00
jyvikoandClaude Opus 5.5 31b9410f56 solidcraft-smlib: a horn torus to rounding is no ring torus
A revolved circle whose centre is as far from the axis as its radius (a horn torus, its
tube touching the axis) measured its major radius a few ulps above its minor from the
profile's control points, became SMLib's ring torus, and SMLib refused it
(SM_ERR_INVALID_INPUT: no ring torus of that NURBS). A ring torus now needs its tube
clear of the axis by more than rounding (1e-9 of the radius, the slack the same test
already takes for the circle's plane); a horn torus goes as its rational B-spline.

Test: a revolved unit circle 1.5 from the axis is a ring torus; at 1, 1 + 4 ulp and 0.5
it stays a revolution (develop calls the first two ring tori).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-27 17:06:34 -04:00
jyvikoandClaude Opus 5.5 9da3174bb7 solidcraft-smlib: a revolution goes to SMLib as its NURBS form alone
A face on a placed revolution that carries its NURBS form (every STEP surface of
revolution, read since b6a3b31ff) was written as two NURBS blocks: the revolution's own
net, then the form, flagged FACE_NURBS_FORM on a NURBS face. SMLib reads one block per
face, so the flat arrays did not add up and it refused the body (SM_ERR_INVALID_INPUT),
in the main import and in the one-face sheets SMLib makes pcurves on. SMLib has no class
for a revolution: the form is the face, its range and trims already in its parameters,
so it now goes as that NURBS face with no form flag. A revolution the analytic pass
recognises (a plane, cylinder, cone, sphere, ring torus) is unchanged.

Test: surface_of_revolution_sense_follows_iso, which develop fails with the refusal,
passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-27 17:06:34 -04:00
jyvikoandClaude Opus 5.5 4f6f254d04 smlib: a setback left open is a profiler span like every other SMLib call
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-27 12:24:10 -04:00
jyvikoandClaude Opus 5.5 b2fc5e1fbf smlib, kernel: a refused setback corner is named by its point and why
SMLib's out_failed_corner reaches Rust as Error::CornerRefused { corner }, and the
kernel names the corner by its point: a G2 fillet at a corner of mixed convexity
says where it is and that SMLib sets back only corners whose rounds are all
convex or all concave. Engine test checks the message through solid.fillet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
2026-10-27 12:24:10 -04:00
jyvikoandClaude Opus 5.5 6263db8d66 smlib: Brep::blend_setback_open, set-back corners left open with their holes
smlib_blend_setback_open's binding: the sheet, and per corner a Hole, its
edges in order (each starting where the one before ends), each with the face
beside it and whether that face runs it forwards. The holes' buffer starts at
64 edges a corner and grows once to the length a first call names. Tested on
the r5 box corner set back 8: 9/30/22, a sheet SMLib's check passes, one hole
of twelve edges chained end to start; an unrounded edge at the corner is
Unsupported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 12:24:10 -04:00
jyvikoandClaude Opus 5.5 9cd655259d Profiler: commands, feature evaluation, io; diagnostics.profile; CLI --profile
- Session::execute is a command span; Model::evaluate and each feature computed
  (by its type) are spans; io's import, export and design read/write too; the
  STEP reader's topology, pcurves and solid record.
- diagnostics.profile (contract + output schema): report, start/stop, reset,
  Chrome trace file.
- A STEP/IGES import's reply carries its own profile while recording.
- Every app compiles the profiler in by default (feature `profile`);
  SOLIDCRAFT_PROFILE=1 starts it.
- solidcraft-cli run/eval/bench-open --profile print the table on stderr,
  --profile-out writes the trace; run --profile works on designs and STEP files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 11:40:49 -04:00
jyvikoandClaude Opus 5.5 10ea00e740 Profiler: every SMLib C API call is a span, timed by the C API itself
The C API logs each call with its steady_clock time; the log sink records
that as an smlib span (child of whatever runs on the calling thread).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 11:40:49 -04:00
jyvikoandClaude Opus 5.5 e476aba94f SMLib in the browser: built with wasi-sdk for wasm32-unknown-unknown
On the web target the smlib build compiles SMLib for wasm32-wasip1 with wasi-sdk's clang
(WASI_SDK_PATH), with wasm exceptions in the exnref encoding that wasi-sdk's libc++ and Rust
use, and links wasi-sdk's libc++, libc++abi, libunwind and libc. The WASI calls libc makes are
defined in ffi.rs: stdout and stderr go to the log, the clocks are the page's (the C API times
every call), and there is no file system or environment. solidcraft-web gets an smlib
feature, off until CI has wasi-sdk.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
2026-10-27 02:28:53 -04:00
jyvikoandClaude Opus 5.5 562a5bd337 Formatting: rustfmt over the rebased branch
cargo fmt --all, nothing else: code from the branch's commits and from the rebase's
resolutions that was not yet in rustfmt's layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
2026-10-27 02:28:53 -04:00
jyvikoandClaude Opus 5.5 c2361c000f smlib: Brep::blend_setback, blends with corner setbacks (smlib_blend_setback)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:53 -04:00
jyvikoandClaude Opus 5.5 d433ce2c9f Thread runouts: the groove fades out instead of stopping square
Ladder 06/009 had no way to ask for one: "solid.thread has no runout (vanishing thread)
length". With SMLib's smlib_screw_sweep_radial (replay e7acea1):

- smlib: the FFI binding and Brep::screw_sweep_radial, the profile moved off the axis by a
  piecewise linear law of the turn; crate test: a tooth moved out 1 mm over three turns has
  A 2π (c turns + ∫ offset dt).
- kernel: sweep_helix_radial, sharing sweep_helix's checks (helix_profile).
- doc: `ease_in`, `ease_out` (a length, or ISO 3508's standard 2.5 P or short 1.25 P) fade the
  groove over that length, its section moving out of the material as it turns (outward for a
  shaft, inward for a nut). ease_in is at the end the thread starts from. The runout lies past
  the full-form length: beyond a square stop, before a shoulder up to its clearance; at a free
  end inside the face. Runouts longer than the thread are refused. No end gets one by default,
  so saved threads keep their geometry.

The cut is the integral over the turn of the clipped section's 2π∫ r dA: engine test (2.5 P
and 1.25 P between two collars) within the sweep's wall tolerance times the runouts' wall area
(0.029 against a 0.036 mm³ bound), ladder 06/009 (004's shaft, a 2 P runout before the
shoulder) graded in closed form (measured 1.7e-6 off).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:53 -04:00
jyvikoandClaude Opus 5.5 5aeff43f85 smlib: a horn or spindle torus face comes out as its NURBS form
The record's torus label is a ring torus (major > minor; the validator
refuses any other). SMLib keeps horn and spindle tori: a half disc revolved
about a line through its rim's end is a horn torus, its major radius a
rounding below its minor, and the export wrote it as a torus label the
record then refused (rig sweeps/4007, "ring torus radii"). Such a face is
now its NURBS form, unlabelled, which is its geometry in any case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 7d300984b2 kernel, kernel-cases: a shell whose walls would meet is refused, saying so
Rig case shell/4711 (a 60 x 40 x 10 block, an r3 through hole at (22.5, 7), a 10 x 10 notch on
the front edge, shelled 2 open at the bottom) failed with "SMLib shell: operation: SMLib failed
(status 1027)". The hole is 4 = 2 x 2 from the front face: the hole wall's offset (r5) is tangent
to the front's at (22.5, 2), the walls meet along a line and the cavity would pinch to zero
thickness there, which is no solid. Refusing it is right; the refusal did not say why.

SMLib now refuses an offset whose walls would meet with its own status, SMLIB_ERR_WALLS_TOUCH
(-1110). The smlib crate reads it as Error::WallsTouch; the kernel's offset backend turns it into
a sentence with the wall, as blends turn NoRoom into one: "shell: the 2 mm walls would meet along
a line (between a hole and the side, for example), which leaves no solid there; use a thinner or
thicker wall, or move the feature". Thicker builds too (SMLib shells 4711 at 2.5, the walls
crossing and merging between the hole and the front), so the sentence offers both.

4711 expects that refusal and its message ("outcome": "refused", "refusal"), its "what" and
"method" saying why: the wall is 4 = 2 x 2, the walls meet along a line. Tests: the smlib crate
shells 4711 built from primitives (2 refused as WallsTouch, 1.5 and 2.5 valid), the kernel a
plate whose hole is 3 from its side at 1.5 (refused, with "the 1.5 mm walls would meet along a
line").

Results (run-sc.sh against SMLib a759622's code, which differs from the tree run only in
comments and docs; baseline 858f381fc-5448b9a): rig 410/447 (409
before; 4711 fail -> pass as the refusal, nothing else changed), ladder 109/116 (unchanged),
kernel lib 535 passed / 202 failed (one new test; the same failing set), smlib crate 53 / 2
(one new test; the same failing set).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 237f0ae745 kernel, kernel-cases: a convex blend overflowing a cliff is built, with its analytic answer
SMLib now builds a round or chamfer whose rail runs off its face across a cliff (an opening's
rim, the body's outline): the blend is made as if its faces continued and what it removes is
subtracted, so it never bridges an opening (owner decision for rig 5158/5181; fork commit
"SMLib, capi: a convex blend overflowing a cliff is subtracted from the body"). The tests that
expected a refusal for such blends now expect the body, each answer from the geometry:

- variable_radius_on_a_box_edge: 2 -> 50 on the 10x20x30 box's top edge builds at
  3546.18767939 (circular sections in y = const, the r x r square less the quarter disc,
  clipped to the box; rel 1e-4).
- variable_radius_from_a_spline: the "big" law builds at 6000 - 726.5334566720 (de Boor law,
  split at the knot and where r crosses 10).
- a_chamfer_meets_sloped_end_planes: chamfer 25 removes 11500 - 4625 * slope
  (integral of 40 - 2 * slope * y over z >= y - 5).
- g2_fillet_refuses_invalid_geometry: G2 at 25 builds at 6138.1606889 (the quintic section
  with control points at thirds, clipped to 20x20, along 20).
- fillet_max_each_reduces_only_where_the_radius_does_not_fit: both edges take 4, 24438.7317761.
- hostile_inputs_are_errors: chamfer 30 on the cube builds at 1000 (y + z <= 10 along 20);
  R50 still fails.
- kernel-cases fillets/1080: the 9 mm chamfer into the openings builds at 3350
  (method in expected.json).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
2026-10-27 02:28:52 -04:00
jyviko 1d98d5111c smlib: solids touching round a pocket each export as one closed shell
A loft cut from a block's whole outline (flush with its sides) down to a pad cuts the slab
above it loose: the slab and the rest touch along the outline's four edges, round the pocket
the loft leaves. SMLib keeps the pocket as a void region of its own (its check finds the body
valid): its one runtime shell is the slab's underside and the loft's faces, so the slab's
material shell faces two empty runtime shells, the infinite region's and the pocket's, and so
does the rest's. The export made one record shell per pair of empty and material runtime
shells, so each solid's closed boundary came out as two open shells ("an open, wire or vertex
shell lies in one region").

A record shell is now one material runtime shell, whatever empty shells its faces face. Empty
regions one solid's boundary faces together are one record region: the infinite region where
it is among them, else the void whose outer shell bounds it alone. The pocket, which no record
shell bounds once the solids' shared edges are split, is part of the empty space round them.

Fixes rig sweeps/96-loft-cut-box-sections-pad-first and -top-first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 796920968265c57c59f11dd908ec022d53f5c647)
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 8799587210 pcurves: a flat patch's are a plane's; SMLib's sheet loops read either way round
A degree-1 patch of four control points on a parallelogram (a plane as an IGES
or STEP B-spline writes it) is that plane at every parameter, so its pcurves
take the plane's closed forms instead of going to SMLib (which drew the rim
circle of 3806's base as a 385-point spline).

SMLib may run a one-face sheet's loop against ours. A use's pcurve is the same
either way, so the loop's way round is read from an edge the face uses once and
every use is matched with it (3806 failed with 'a use SMLib did not keep').

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 1bf2062590 STEP and IGES import: SMLib makes the pcurves that have no closed form
A use with no closed-form pcurve (an approximated intersection curve on a cone,
a spline edge on a spline surface) no longer refuses its solid. Its face goes to
SMLib alone, an open sheet with the trims it has and without the others, and
SMLib makes those as it makes every trim it needs (GetOrCreateUVTrimCurve on
export); they come back on the record's parameters and the face is closed and
checked as before. The STEP reader takes the trim maker from the kernel
(read_solids_with, read_solid_with); read_solids stays exact-only.

Kernel lib tests: 490 pass, 239 fail (were 468 / 261; pushed head 475 / 254),
none newly failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:52 -04:00
jyvikoandClaude Opus 5.5 69702833ff solidcraft-smlib: ellipse edges on their NURBS form, as circles are (fork 0c5868e)
SMLib holds every ellipse as an exact rational NURBS; the fork now sends ellipse edges with that
form and takes them back with it. The export reads an ellipse with its form as it reads a circle
with one (its frame turned so its angle grows along the form, its trims carried over as they are);
the import writes an ellipse on its form as its conic entry plus the NURBS.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 76bd53403f solidcraft-smlib: the record relays SMLib's tolerances and edges as SMLib holds them (fork aec68dd)
No floor of ours on tolerances (1e-6 of the body's size, 30 times SMLib's 1e-5 default): the
record's tolerances go back into SMLib, which approximates to them, so the floor coarsened every
later operation. No recognition of NURBS edges as lines or circles: an edge is a circle where
SMLib holds an SmCircle (with its NURBS form), and a NURBS edge keeps SMLib's trims on its own
parameter. crashes/2992 and sweeps/1853 pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 6892ceac78 brep, kernel: code that reads an edge's angles takes them from the circle, code that evaluates takes the NURBS form
Edge::curve_interval (and brep::curve_interval for assemble's edges) gives the interval on the
edge's curve itself: a form circle's angles of its ends, its frame turned by the SMLib conversion
so the angle grows along the NURBS. lip and the ruled surfaces read arcs by it; the hull, the
blend tangents, the patch pcurves, point paths, IGES output and the prism runs evaluate on
Edge::parameters. assemble carries an edge's form through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 6adba90e2d solidcraft-smlib: circle edges on their NURBS form, SMLib's trims kept on them (fork deec9cb)
The SMLib conversion reads and writes EDGE_NURBS_FORM: a circle edge's record keeps the circle
as what it is and the NURBS SMLib holds it as as its parameter, so the trims on it carry over
exactly (TrimMap identity).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 b1326e48d6 brep: an edge on a line, circle or ellipse carries the NURBS form SMLib holds it as
The edge mirror of a face's NURBS form: Edge::nurbs keeps the NURBS SMLib holds a conic as, and
the edge's interval and its pcurves' parameter are its. Edge::parameters is the curve every
evaluation at a parameter uses; curve says what the edge is. Nothing writes the form yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 a683077c43 solidcraft-smlib: a plane face takes SMLib's own trims (fork c6530bf)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:51 -04:00
jyvikoandClaude Opus 5.5 2e26e05672 solidcraft-smlib: the export reads FACE_NURBS_FORM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 b6a3b31ff9 brep: a face on a cylinder, cone, sphere or torus carries the NURBS form SMLib holds it as
Every SMLib analytic surface is a B-spline surface, and its trims are in that NURBS's
parameters. Face::nurbs keeps that NURBS: the face's domain and pcurves are its (u, v), and
`surface` says what the face is. Face::parameters is the surface every (u, v) evaluation uses.
The SMLib conversion reads and writes it (fork FACE_NURBS_FORM, SMLIB_REV c4483f6); the STEP
writer writes the analytic surface and the face's edges without pcurves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 bcbb990051 kernel, smlib: a blend larger than its faces is SMLib's refusal; blends take exactly the given edges
SMLib (fork 68e3086) refuses a blend whose rails leave the faces they roll on with
SMLIB_ERR_NO_ROOM, which the kernel reports as KernelError::TooLarge. The kernel's own
pre-checks go: blend_fit's fit check and the 256-station band check of the variable fillet.
The shim no longer follows tangent chains; the Fillet/Chamfer dialog already expands a pick
to its chain (its Tangent Chain option) and stores every edge in the feature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 0185ccc1e9 solidcraft-smlib: Brep::union_all, the union of many bodies in one SMLib call
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 1b5ca02b8c solidcraft-smlib: SMLib's tangent draft corner meets lines at an edge (fork ccc56fd and docs)
Pinned at the fork's draft-corners head: a drafted rectangle (or any
line-line corner) has its walls meet at a corner edge under the tangent
rule as well, 6 faces rather than 14. A curvature refusal for a curve
that is neither a line nor an arc names that curve's start.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 384c5866f1 kernel: a tapered extrusion closes its corners by a rule, preserving curvature by default
extrude_tapered(_between) take a DraftCorner: PreserveCurvature (each wall
continues as itself, a line's plane or an arc's cone, until it meets its
neighbour; SMLib's SM_OC_CURVE_EXTENSION), Tangent (the offsets continued
along their end tangents) or Round (an arc about the corner). A corner
the rule cannot close is refused with its point and why
(solidcraft_smlib::Error::Corner). draft_corners reports, per sharp
corner of a profile, what each rule gives: how far each offset curve runs
on or is trimmed, whether the corner cuts inside the exact offset, or why
the rule refuses it. SMLib pinned at the fork's draft-corners head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 afce22bb60 solidcraft-smlib: mass properties of any body, by its material regions (fork 311946c)
SMLib's mass properties no longer refuse bodies that are not one manifold
solid: several lumps and lumps touching along edges or points are the sum
over their material regions, and a sheet is its faces' area and centre with
volume 0. Docs of Brep::mass_properties and kernel::measure say so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 78937d1dbc brep: one basis-derivative routine, bspline::basis_derivatives
The ruled surface's far-curve solve kept its own copy of NURBS Book A2.3. The
geom crate now exposes bspline::basis_derivatives (the basis functions alive at
a parameter and their derivatives up to an order, each from its local knots via
local_basis, on the span tess::span_of picks); tess's second-derivative surface
evaluation and the ruled surface both use it, and the copy is gone. smlib's
mod list back in order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:50 -04:00
jyvikoandClaude Opus 5.5 d803285955 solidcraft-smlib: face sections as SMLib's B-splines
Brep::face_section (smlib_face_section: one face cut by a plane) hands back
the NURBS SMLib made with their intervals, through one reader of smlib_curves
(take_curves) shared with project_curves. The face-pick errors map to
NoMatch/Ambiguous in one place (picked). SMLIB_REV at fork eedfa51.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 a6b41dd825 solidcraft-smlib: Brep::project_curves, curves projected onto a face as SMLib's B-splines
The FFI for smlib_project_curves and the smlib_curves result (fork 5f9af50),
and the safe call: a curve list projected along a direction onto the picked
face, back as Curve::Nurbs with each curve's interval. SMLIB_REV at 5f9af50
(fork integration head 1934b57 + the untrim status fix + the projection shim).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 c3f99d0e90 solidcraft-smlib: ssi hands out SMLib's intersection curves exactly, as schema 4 B-splines
ssi::intersect took a sample count and gave each intersection curve as
samples: its 3D points, its UV points on each surface and the surfaces at
them. The fork's 947eedc hands out the curves SMLib's intersectors return,
exactly (smlib_ssi_curve_nurbs: degree, knots, control points, weights), and
drops the samples; SMLIB_ABI_VERSION 4.

SsiCurve now holds the 3D curve as a schema 4 Curve::Spline or
Curve::RationalSpline (rational where a weight is not 1) and each UV curve
the method returned as a Curve2, with SMLib's type, deviation estimate and
the 3D curve's natural interval; ssi::intersect loses its sample count. A
curve SMLib does not hold as a B-spline is Error::Unsupported (it is never
approximated); a B-spline whose knot count is not points + degree + 1 is an
argument error.

The SSI corpus scorer (tests/ssi_corpus.rs) samples the exact curves itself
where the corpus runner samples them: 4001 parameters spread evenly over the
3D curve's natural interval and over each UV curve's interval, the surfaces
evaluated at the UV samples, samples that cannot be evaluated dropped. The
unit test plane_through_sphere_is_a_circle evaluates the exact curve.

Nothing else used the samples. SMLIB_REV: the fork at 947eedc.

clippy -p solidcraft-smlib --all-targets, with and without native: clean.
The corpus gate (smlib_global_intersect_at_1e_6) is not run here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 e1326f37f1 solidcraft-smlib: Brep::stitch and Brep::offset_sheet, and the fork pinned at e3d478d
The safe wrappers of the fork's smlib_stitch (a body's faces sewn at a tolerance,
oriented, with whether it closed) and smlib_offset_sheet (a sheet's faces onto
their offsets), for the kernel's Stitch and Offset Surface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 c802458efa solidcraft-smlib: Brep::face_points, a point inside each face (smlib_face_points)
Each face's point from SmFace::CalculateAnInternalPoint, in SMLib's face
order; the fork at 89a1933 (also: smlib_extend_sheet extends every surface
as SMLib's B-spline, its analytic kind given back).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 7225d3f2b6 kernel: Split Face and Split Body on SMLib, the tool as exact record surface patches
A tool is now a set of schema 4 record surfaces, each over a parameter box,
unbounded where the tool is: a plane; a face's surface over its own box; a
sketch curve as one patch per segment swept along the direction (a line a plane
strip, an arc swept square to its sketch a cylinder strip, any other segment its
exact rational Bezier extruded), an open curve continued along its end tangents
past the body. SMLib cuts the faces where the patches meet them
(Brep::split_faces: its intersection curves trimmed to each face by
MergeCurvesOnSurface) and slices a body with one patch (Brep::split_body); the
history is SMLib's own tags. Nothing is traced on a mesh, sampled or fitted.

Which side of the tool a point is on is its offset along the normal of the
nearest patch, each patch's surface prepared once with its projection grid
(ToolSide), never per point. ToolSide::of and side_of_point take the body the
tool must reach past; face_side becomes face_sides (every face of a body, one
mesh); analytic_field becomes analytic_face (a face of a body, on its record);
split_any returns the face map instead of the truck imprint. split_edges_at and
fit (a Catmull-Rom fit through samples) are deleted with the truck code.
ssi::Surface::from_record turns a record surface over a box into SMLib's.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 befcfecb77 solidcraft-smlib: Brep::split_faces and Brep::split_body on the fork's split shims
split_faces cuts faces (SMLib face order) where ssi::Surface tools meet them and
says per face how many faces it became; split_body cuts a solid in two by a
surface, the part behind it and the part in front. SMLIB_REV moves to the fork
commit that adds smlib_split_faces and smlib_split_body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:49 -04:00
jyvikoandClaude Opus 5.5 cfb5dc3ba3 solidcraft-smlib: Brep::planar_faces and Brep::boolean2d
Wrappers of the fork's smlib_planar_faces (a sheet of planar faces from closed curve loops in
one plane, nested by SMLib) and smlib_boolean2d (two such sheets combined as regions of the
plane by SM_API's 2D boolean, the inputs' own curves split where they cross; an empty result
is None). SMLIB_REV moves to the fork commit that adds them (78617dd).

clippy -p solidcraft-smlib --features native --all-targets -D warnings: clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 e36f8d7774 kernel: booleans, placements and splits on SMLib only, with no retries
A boolean is SMLib's boolean, its history SMLib's tags: the jittered retries, tool nudges, prism
and coaxial routes, the retry result guard and their diagnostics are gone. A rigid placement moves
the record; any other matrix goes through SMLib's transform (new Brep::transformed over
smlib_brep_transform). Bodies apart join as their records side by side (brep part::compound),
with each piece's faces, sources and history; apart means their exact boxes do not meet. A split
is the intersection with a half-space box, with no faces pushed off the plane.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 0a216d6925 kernel: extend on SMLib: the surface's own extension, up to a target by trim, to bounds by untrim
extend_surface keeps its signature, options and error messages. One model:
SMLib extends the surface past a side of the face's parameter box
(smlib_extend_sheet, CreateExtendedSurface: natural continues the end spans,
tangent G1, curvature G2) and the face stays one face on it, tagged so the
face is Modified and its sides keep their edges. Several picked sides grow
the box on each. Up to a target, the face is extended 50 body sizes past
its edge and trimmed back with trim_keep (SMLib's exact intersection),
keeping the piece the face lies in. Back to the bounds is untrim of the
picked edge's face, in place, with its holes; one already there is
refused. A plane's straight edges with neighbours lengthened still go
through surfaces::extend. Edges are picked on the schema 4 record (samples
of each edge's curve), an edge two faces share or of a hole refused as before.

Not ported (every far edge there was a cubic fitted through marched
samples, which the exact-B-splines rule forbids): an edge that is not a
whole side of its surface's box (trimmed edges, curved planar edges such as
a disc's, a notch), mitred corners on such faces, sides run square to the
edge on a non-box face, and bodies of more than one face. These now answer
"not supported yet: ...". Tangent and curvature no longer add a separate
run-off face: SMLib's G1/G2 extension is one face (the engine's
surface.extend description says so).

Tests ported keeping their assertions: the planar extension, the cylinder
strip along its axis, around and both (now an extruded arc, not a truck
revolution), the extruded strip, the parabola extended naturally (now a
conic extruded), back to bounds (the saddle from loft_sheet and trim),
hostile requests. Deleted, as what they test no longer exists:
neighbours_lengthened_or_square, self_intersecting_extensions_are_refused,
a_disc_grows_by_its_curved_edges, neighbouring_faces_extend_together, the
tangent/curvature run-off half of the B-spline test, and
a_continued_bspline_is_unchanged_on_its_range (the deleted continue_span).

SMLIB_REV: fork 9531966 (tags carried through untrim and extend).

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 7bbdd37130 kernel: untrim on SMLib (smlib_untrim_face), its history from SMLib's tags
untrim keeps its signature and messages. The face is picked in SMLib by a
point inside it (the centre of its largest mesh triangle), holes by their
points; SMLib deletes the holes or rebuilds the face over its surface's
parameter box with the holes kept (fork c6c7fb4). The body goes tagged as
operand 0, so faces and edges come back with their origins; the untrimmed
face is Modified. A face whose span goes all the way round its surface now
closes on the seam instead of being refused.

solidcraft-smlib: Brep::untrim_face (ffi/trim.rs, trim.rs) and
Error::NotExact for SMLIB_ERR_NOT_EXACT.

Tests: ported to the record (loops counted on brep_record; the saddle made by
loft_sheet and trim instead of truck types; the torus face copied out by a
point). Deleted: the_outer_loop_is_found_whatever_order_the_loops_are_in: it
built a truck face listing its hole first; SMLib's import always puts the
outer loop first, so the case no longer exists.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 3bd1cc5349 solidcraft-smlib: Brep::merge_faces, SMLib's removal of topological edges and vertices
The wrapper of the fork's smlib_merge_faces (SmBrep::RemoveTopologicalEdgesAndVertices): faces
on one surface meeting along an edge become one, edges on one curve meeting at a vertex nothing
else uses become one, and the edges under the given points stay. SMLIB_REV moves to the fork
commit that adds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 9268a1e881 solidcraft-smlib: SMLib's "no change" as Error::NoEffect, the fork pinned at its integration head
The fork's shims now hold an operation SMLib reports done to having done
something (SMLIB_ERR_NO_EFFECT, -1107: a blend that made no face, a face
move or draft that moved no face). It maps to Error::NoEffect, and the
kernel says "SMLib made no change: ..." for blends and for offset, shell
and draft. Case 1080 (chamfer over openings) returned an unchanged body
as success.

The fork pin moves to 6bb2938: the chamfer side fix of the piecewise
merge, the no-effect contract, and SmStatus marked must-use with the
dropped statuses of the shims and of the fillet, boolean, offset and sweep code passed on.

(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 c4bb4a3529 kernel: a cornered sweep carries on from where SMLib placed the profile
Brep::sweep_placed (smlib_sweep_placed, fork f6f428b) returns the rigid motions
carrying the profile onto the sweep's first, middle and last sections. Each run
of a path with corners now takes its end pose from the last motion (less the
straight lead-out along the end tangent) and its inside seeds from the middle
one, for every path segment kind: the 3D sketch spline next to a corner is no
longer refused. Deleted: the predicted carry along a run (carried) and
point_path::cubic_split, which only it used. SMLIB_REV at f6f428b.

Fork: build + ctest, only smlib_flat_roundtrip's known incline failure.
(not built: base in progress)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:48 -04:00
jyvikoandClaude Opus 5.5 667cd33560 solidcraft-smlib: pcurves on B-spline faces are SMLib's own UV trims
On a B-spline face the export now takes each edgeuse's UV trim exactly as
SMLib holds it (EDGEUSE_NURBS_*): the face's parameters are SMLib's, so the
trim is the pcurve, reversed exactly (knots t -> a + b - t) where the
edgeuse runs against its edge, its knots mapped onto the edge record's
parameter where that is an affine image of SMLib's (identity for spline
edges, as_line's map for NURBS lines, the C side's map for lines), and its
end knots set to the edge interval where they differ by rounding (within
the schema's 1e-9 slack, else an error). Changed: export.rs `curves`
(per-edge TrimMap), new `trims`, `mapped`, `Face::given`,
`Edge::trim_map`, the face loop in `native_ordered`, `pcurves`,
`outer_area`.

Analytic faces and circle/ellipse edges keep brep::pcurve: SMLib keeps an
analytic face's trims on its internal rational B-spline (SmCylinder.h:
"the map from one to the other is not linear") and a circle's on its NURBS
parameter, neither an exact B-spline in the record's angle parameters.

brep::pcurve::EdgeUse gains `given`, a producer's exact pcurve taken as it
is (structure and interval checked, moved by whole periods with its loop,
never refitted). Existing construction sites (STEP reader, tests, truck
adapter) pass `given: None`; the existing tests change only for the new
field.

Built, clippy-clean and tested on 4b2c0eaf before the rebase onto
kernel-smlib/no-truck (not built: base in progress).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
2026-10-27 02:28:47 -04:00