stack/render-11087
160
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
2ce55baba1 |
Dimensions: a radius leader and an aligned dimension's line reach their text (#12093)
The value text is drawn level, in an upright box, and the line runs through its middle. The layout stopped the line where the box's farthest corner reaches along it (half.x*|u.x| + half.y*|u.y|), not where the line leaves the box (min(half.x/|u.x|, half.y/|u.y|)). They agree only when the line is level or upright: at 45 degrees a radius leader stopped about 12 px short of its text, and an aligned dimension's line broke too wide around its value. One helper, box_exit, gives where the line leaves the box, for the radial leader, the linear break and the leader to a text pulled past the extension lines. Whether the text fits between the arrows still goes by the whole box. A text box that isn't finite counts as empty, and one larger than a sketch can be is held to MAX_COORD. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
aee947f0f9 |
Sketch: hovering over a large sketch no longer slows down (#9614)
* claim: Sketch: keep profile outlines and trim/extend cuts between mouse moves * Sketch: keep profile outlines and trim/extend cuts between mouse moves Hovering a large sketch sampled every profile's loops into polylines for each point asked, and Trim/Extend intersected the hovered curve with every other curve on every mouse move. - Loop2::contains rejects points clearly outside a box from the loop's end and control points before sampling; Region2::outline samples the loops once (RegionOutline). Profile keeps both in OnceLocks and answers Profile::contains from them (viewport pick, profile_at_point, profile selection by points). Answers are unchanged: the box margin covers rounding, and non-finite values or negative conic weights skip the box. - sketch_modify splits the cuts on a curve (TrimHover) from choosing the piece around the cursor. The UI keeps one per sketch state and curve, and Extend's preview per sketch state, curve and growing end (afresh when the sketch has an infinite line). Plate with 400 circles (801 profiles), release, per mouse move: UI frame 5.19 -> 1.11 ms, with Trim 9.45 -> 1.50 ms; 30 lines x 30 splines: Trim piece 6.10 -> 0.0002 ms. Equivalence tests compare with the old answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: keep the profile outline helpers in the sketch crate The outer loop's box, the clearly-outside test and the outline sampled once move from geom into crates/sketch/src/profiles.rs as private items built from geom's public types, so the PR leaves crates/geom untouched. Profile::contains answers exactly as before; the geom test moves to the sketch profile tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
863b0777da |
Sketch: dragging a constrained line by its middle no longer stalls (#11696) (#11714)
* claim: #11696 * Sketch: move constrained lines that stall during dragging |
||
|
|
4d738cd210 |
Sketch: an ellipse is drawn with its axes, and D measures its half-axes (#9291) (#9292)
* Sketch: an ellipse comes with its axes, and D measures its half-axes An ellipse could only be sized by its minor radius, drawn like a circle's radius, and there was no way to give its full axes. sketch.ellipse now also adds the major and minor axes as construction lines through the centre. The major axis runs from the major end to the point opposite it; the minor one is perpendicular to it, ends on the ellipse, and both are bisected by the centre. That adds six coordinates and six equations, so the ellipse keeps its five degrees of freedom, and it needs no new constraint kind and no format change. With the axes in place every ellipse size is an ordinary dimension. D on an axis line gives its length, the whole axis. D on the outline gives a half- axis, the distance from the centre to an axis end, chosen the way a line chooses horizontal or vertical but in the ellipse's own frame: text pulled across the major axis measures along it (the major half-axis), text pulled out past an end of it measures across it (the minor one). The end on the text's side is used. Near the boundary between the two, a dimension being placed keeps the half-axis it had (sketch.dimension's previous_axis, which the Dimension tool sends), so the preview does not flip. A half-axis and its whole axis determine each other, so the second becomes a driven dimension through the existing redundancy path. Deleting the ellipse leaves its axes, as deleting a Center Rectangle's edges leaves its construction diagonals. Ellipses without axes, from existing designs, keep the minor radius as before, and type radius still gives it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Guide: an ellipse's axes and half-axis dimensions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: test that an ellipse's half-axis preview keeps its axis near the boundary The Dimension tool sends the half-axis its last preview chose, so near the boundary between the major and the minor half-axis the preview keeps it. This covers that path from the tool, from both sides of the boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's axes select and drag with it, as a rectangle's diagonals do A double-click on a Center Rectangle's edge or diagonal selects its edges and both diagonals, and dragging a diagonal moves the rectangle without changing it, because its lines share corner points. An ellipse's axes are held by constraints instead, so a double-click selected only the ellipse (and Delete then left the axes behind), and dragging the major axis moved the ellipse but stretched its minor half-axis. Sketch::ellipse_axes now finds an ellipse's construction axes (the detection sketch.dimension already used, moved into the sketch crate). Sketch::chain treats an ellipse and its two axes as joined, so a double-click on any of them selects all three. Dragging either axis moves the ellipse and both axes as one, keeping both half-axes. Dragging the outline still sets the minor half-axis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a corner test reads its line's id instead of assuming l1 sketch.ellipse now adds two axis lines, which take the first line ids, so the extend test reads the id of the line it draws from the reply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's axes cut a trim, as a Center Rectangle's diagonals do Trim, extend and break take every other curve as a cutter, construction lines included, so an ellipse's construction axes stop them as a Center Rectangle's diagonals do. A test now states it for both shapes, and the guide says it. The freeform cutter test keeps the axes it used to delete and asserts the piece a trim removes: from where the major axis crosses the circle to where the ellipse does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: test dragging an ellipse's outline with its axes present Dragging the outline sets the minor half-axis, and the minor axis line, held on the ellipse at one end, follows it; the centre and the major half-axis stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: other dimension types on an ellipse with axes keep the minor radius Only auto, major and minor give a half-axis on an ellipse drawn with its axes. Any other type (radius, diameter, horizontal and the rest) gives what it gives on an ellipse without axes, as the parameter doc says, instead of quietly becoming a half-axis chosen by the text. The arm for a missing text_at is dropped: with no text the rule already picks the minor half-axis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: test an ellipse's half-axis dead zone from the major side too The tests only showed a previous minor half-axis being kept near the boundary; the point they used on the major side is major by geometry alone. A point inside the band where geometry says minor now shows a previous major half-axis kept, in the engine and in the Dimension tool's preview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a placed ellipse half-axis is the one its preview showed On an ellipse already sized, a half-axis is added as a driven dimension on the click, and that command left out the half-axis the preview kept near the boundary, so the click could place the other one. It now passes it as the preview does. The remembered half-axis also comes only from a draft whose text was placed (one without text is the minor half-axis by default and biased the first placement), is kept per sketch as well as per picks, and is forgotten once a dimension is placed or the picks are cleared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: say how an ellipse's axes are recognised and what that costs The axes are read from the constraints, with no mark in the design, so the doc comment says which lines count, that deleting the midpoint or point-on-curve constraint leaves an ellipse without axes, and that each lookup scans curves times constraints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse with one axis deleted still picks its half-axis by the text With one construction axis deleted, D on the ellipse fell back to the minor radius wherever the text was pulled, because the half-axis choice needed both axes. It now reads what is left of them and chooses as before: the major half-axis goes to the major end (also from the far side, when the point opposite is gone with its line), the minor one to its axis end, or as the minor radius when the minor axis is the one deleted. An ellipse with neither axis keeps the minor radius. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: the one-axis half-axis test checks what is measured to The test for an ellipse with one axis deleted checked only the reply's axis and value, which both ends of an axis give alike. It now checks the dimension's kind and end: the axis end on the text's side, the major end from either side once the point opposite is gone, a radius once the minor axis is. With the major axis deleted and no text the reply names the minor axis and measures to its end, where it used to be a radius with no axis named. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's minor radius is drawn as its half-axis, without R A radius on an ellipse is the minor half-axis, and it was drawn as a circle's radius: one leader from the centre towards the text, marked R, which measures nothing a reader can see. It is now drawn as the distance from the centre to the minor axis end on the text's side, the way the half-axis is drawn while the ellipse has its axes, and labelled with the length alone. This is what D gives once the minor axis line is deleted, and on an ellipse with no axes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's half-axis keeps a radius's stored text The half-axis frame read the stored text from the middle of the half-axis, so a radius placed on an ellipse in an existing design would show its text somewhere else. The text is stored from the centre again, as a radius's always was, and the side drawn to follows it. An unplaced one sits where a linear dimension to the minor axis end puts its text, and stacked texts step out from the centre as a radius's do. A view test reads the painted label, so the drawing cannot go back to R unnoticed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse moved, turned or scaled takes its axes along Move, Sketch Transform and Scale moved only the curves picked, so an ellipse moved without its axes left them where they were: its centre no longer halved them, the minor end left the ellipse, and the sketch stayed unsolved. A Center Rectangle's diagonals share its corners and always go along; an ellipse's axes share only the major end. The axes now go with the ellipse, as they do when it is dragged. Copy is unchanged: it copies no constraints, for a rectangle either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a preference draws ellipses without their axes, as before Drawing an ellipse with its construction axes changes what the Ellipse tool makes out of the box, so the old ellipse stays one setting away: Preferences › Sketch › Draw ellipses with their axes, on by default. Off, the tool draws the ellipse alone. sketch.ellipse takes axes: false for the same, and keeps drawing the axes when it is not given. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: sketch.ellipse refuses an axes value that is not true or false A string such as "false" was read as not given, so the axes were drawn; it is now refused as the text commands refuse a non-boolean bold or italic. The move test also covers an ellipse whose minor axis was deleted: the major axis left goes along. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: D picks a half-axis on an ellipse without axes too An ellipse with no axis lines (both deleted, a mirrored copy, one from an older design) gave the minor radius wherever the text was pulled, so its major half-axis could not be dimensioned on it. The half-axis is now chosen by where the text is on every ellipse: the major one to the ellipse's own major end, the minor one as its minor radius. With no text it is the minor radius, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: with one half-axis dimensioned, D on the ellipse gives the other D on an ellipse chose the half-axis by where the text was pulled even when that half-axis was already held by a dimension, so the second D usually guessed the one already there and was refused as over-constrained. With a driving dimension already on one half-axis (to an axis end, the minor radius, or the whole axis along its line or between its ends), D with no type now gives the other, in either order and with or without the axis lines. With both held it chooses as before; an explicit major or minor is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: the held half-axis rule is documented and its cases tested The Dimension command's parameters and the guide now say that with one half-axis held, D on the ellipse gives the other. Tests cover the whole axis held as a distance between its ends and as its line's length with the other axis deleted, and check that a mirrored ellipse has no axes. The placement test undoes its first dimension, so its second half still tests where the text is rather than the held half-axis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: Transform previews an ellipse with its axes OK in Sketch Transform moves, turns and scales an ellipse's axes with it, but the window drew where OK would leave only the picked curves, so the axes stayed put in the preview until OK. An ellipse picked alone is now drawn with the axis lines it has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: the typed-radius ellipse test counts the ellipse's axes Main's #10282 test drew an ellipse with typed radii and expected one curve; with the ellipse_axes preference on by default the tool also draws the two axes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's remaining axis still drags and selects it With one axis deleted, dragging the other axis did not hold the ellipse (with the minor axis left, the drag squashed it), and a double-click on the ellipse or that axis selected only the one curve. The drag and Sketch::chain now read whichever axes are left through ellipse_axis_lines, as Transform and Move already do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: drop the unreachable third arm of the held half-axis check A distance from the centre to the major end or the point opposite it is already matched by the first arm, so the third arm and its major_end closure never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: D on an ellipse's axis line is the whole axis wherever the value is pulled An axis line took the free line's rule, so on a turned ellipse a value pulled beside or above the box the axis spans gave its horizontal or vertical distance. An ellipse's axis is a construction axis, so auto now always gives its length, which the held half-axis check already counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's axis is never a side of a Fillet or Chamfer corner A line drawn from an ellipse's major end shares that point with the major axis, so Fillet or Chamfer there took the two as a corner (two lines skip the construction filter) and rounded the line into the axis. The axes are left out of a corner, picked by its point or as a and b. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: test the move reply, extend and the one-axis Transform preview for ellipse axes The reply of sketch.move, sketch.transform and sketch.scale lists the axis lines, Extend stops at an axis, and Sketch Transform previews an ellipse with the one axis left after the other was deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: with Draw ellipses with their axes off, D on an ellipse is its minor radius as before The preference brought back the old drawing only; D on an ellipse had changed with no way back. sketch.dimension takes half_axes (default true, refused when not true or false); false makes auto on an ellipse the minor radius wherever the text is. The Dimension tool and the context menu's Sketch Dimension pass it from the preference, and with it off a radius on an ellipse is drawn and labelled R as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: read an ellipse's axes in one pass over the constraints ellipse_axis_lines scanned every constraint for every curve, so 500 ellipses with their axes (1500 curves, 2000 constraints) took 1.6 s to read and Move on all of them 2.0 s. It now collects the lines the centre bisects first: 3 ms and 0.36 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: the dimension and corner parameters say how an ellipse's axis lines take part Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Preferences: Draw ellipses with their axes says D gives the minor radius when off Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: ask only the ellipses centred on a line's midpoint whether it is their axis is_ellipse_axis read every ellipse's axes to answer for one line. An axis is bisected by its ellipse's centre, so it now asks only the ellipses centred on a point that bisects the line. The answer is the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a horizontal or vertical dimension across a level major axis holds it for D on the ellipse half_axes_held counted a distance, a length and a radius, but not a horizontal or vertical dimension across the major axis, which is its length when the axis lies that way. D on the outline could then take the held major half-axis and be refused as determined; it now gives the minor one. Across a slanted axis such a dimension is only a projection and does not count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Dimension: a draft on an ellipse is drawn with the axes preference it was made with The frame read the preference as it is now, while the dimension added is the draft's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a horizontal or vertical dimension across an upright minor axis holds it too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: drop the unused Sketch::ellipse_axes; ellipse_axis_lines says how the axes are read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse's own axes do not cut it, so Trim takes a lone ellipse whole and stops at real crossings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: Fillet and Chamfer offer no corner at an ellipse's axis end, as the engine takes none Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a deleted ellipse leaves its centre on its axes, as a Center Rectangle's centre stays Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: ellipse axis docs say what they do, and the corner picker tests a curve's ends before its axis role Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: the trim-at-a-crossing test checks that part of the ellipse is left Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: an ellipse axis moved, turned or scaled on its own takes its ellipse along, as a drag does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a selection dragged by an ellipse axis takes the ellipse along, as the axis alone does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Docs: the Sketch preferences page lists Draw ellipses with their axes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: the ellipse axes help text says D gives the minor radius, drawn and labelled R as before, wherever the value is pulled Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
dc38349cbf |
Layer split stage 1: the B-rep record, native body file and Vec/Plane come from solidcore-record (#11496)
* Kernel: the B-rep record and the native body file come from solidcore-record SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history, envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses `solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted. What computes from coordinates stays with the kernel, in geom's `brep`: - `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes, unit revolution axes, non-singular placements). `check::validate` and `check::validate_built` are the record's validation and these together, and every caller of `Brep::validate` uses them, so what is accepted is unchanged; - `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`, `edge_curve_interval` and `form_turns`; - `brep::pcurve::eval`: a pcurve's point; - `geometry::check`, `placement::moved` and `split_edges` become functions on the record. The kernel's native module keeps the conversion between a body and its saved record (metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module declared, is deleted. solidcore-record is pinned to its rev on solidcore's `layer-record` branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`, `Region2`) moves to `solidcore-record`, with its constants and component-wise operators only (owner decision, solidcore layer split). Their geometry stays in geom as traits: `Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`, `Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller names the types from `solidcore_record`; geom no longer defines or re-exports them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Kernel: pin solidcore-record to solidcore main f5e8e9a29 solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is identical to the rev pinned before but for its clippy configuration. The lock is regenerated against the merged rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ea772a0438 |
Merge develop into main: SolidCraft on the SMLib kernel (v1.1.0-alpha) (#11351)
* UI: rim and wall picking tests for a circle of arcs that is one wall A circle drawn as two half arcs now extrudes to one full-turn wall with its seam edge, and each rim is one closed edge (tangency-labs/smlib#67). The tests keep their intent on that body: a rim clicked once is one item, measured and highlighted whole and picked from either side; a wall picked either side of its seam is the same surface, lit whole, and toggles off from the other side; every face is its own patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillets: a later round at a corner where earlier rounds meet blends them again with it The owner's ruling of 2026-10-30: a later fillet on an edge at a vertex where earlier rounds already meet in a mitre makes the corner rounding all of them at once makes, one smooth patch, the mitre gone. A body made by constant-radius rounds keeps what they were made on and which edges they rounded at which radius; a later round reaching such a corner blends the earlier rounds' edges (from the earliest of those meeting there on) with the new edges in one SMLib blend of the body before them. The result's history is put over the body the later round was given: an earlier round's face is that face trimmed anew (its name kept), the corner patch and the new rounds are the later fillet's. A picked mitre seam has no round of its own: it is refused unless a new edge of its radius meets it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a later r3 round at an r2 mitre, through the Fillet feature, makes the all-at-once corner Two box edges rounded r2 in one fillet, then the upright edge at their mitre r3 in a second fillet (tangent chain on, so the seam comes with it): 10 faces, 7928.743041 mm³ as fillet_radii of the box gives, the r2 rounds' names kept, the r3 round and the corner patch the second fillet's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel: a body's record of rounds goes with its history, and can be read back The rounds that made a body are over the body its history is over: a new history (an operation carrying a step's result back to its own operands) leaves the record out, so a later round never reads one history against another body. Body::rounds gives the record and Body::with_rounds_of takes one back, checked (edges of the body before them, a fillet's radii, the body's history over that body), for a saved model to keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Model cache: a body made by rounds keeps them, so a later round blends them the same after opening A design gave another body when opened from its model cache: the rounds a body was made of lived only in memory, so a later round at their mitre was built sequentially (or refused, as too large) after opening and blended with them when evaluated anew. The saved model now records, per kernel body made by rounds, the body they were made on (a place in the bodies, stored once though no state holds it) and the edges with their radii; reading it attaches them back down each chain, and a thinned model keeps those bodies with the bodies made from them. Model cache format 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a corner patch of rounds 2/3/4 takes no more than the strips leave in its block three_rounds_at_a_corner bounded the patch's extra cut at 3 mm³ beyond the strips, a figure with no derivation; SMLib's all-at-once body at radii 2, 3, 4 takes 3.099 (V 7878.579574 against strips 7881.678). That body is the strips' outside the block its patch lies in: its rounds are the strips' cylinders ending at a's section y = rc, b's x = 20 − rc and c's rails where they meet a's and b's (the patch's four corners, now asserted), so the patch takes at most what the strips leave in that block (11.86 at 2/2/3, 32.69 at 2/3/4). The lower bound is that block; the upper one, at most the strips' volume, stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: the io crate's hand-built saved models list their rounds, as format 7 records do Model cache format 7 ( |
||
|
|
6649cf4cfe |
Project: a refusal that names no body names the kind alone (#10626) (#10859)
The refusal of sketch.project ended in "face of " with nothing after the
"of" when the reference named no body: a picked face, edge or vertex is
found by its geometry, so the body it belongs to is not in the reference.
LinkSource::describe() now drops the "of <body>" when there is no body to
name and names the kind alone ("face", "edge", "vertex", "spun
profile", "isoparametric curve"). A source that names a body keeps its
name.
Only the text changes: the command refuses exactly what it refused before.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
||
|
|
3ca311f922 |
Sketch: a dog bone's outline outside it meets outside both notches (#10984) (#11000)
* Sketch: a dog bone's outline outside it meets outside both notches (#10984) Where two tangent arcs touch at a cusp, the copies of the two arcs cross twice, both crossings as far from the cusp, and rounding chose one: on one side of a dog bone the outline ran both copies on and drew a loop into the bone. Such a tie now takes the crossing that cuts both copies short. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Dog bone test: the outline goes outside, away from the picked bottom line Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b978eeddcd |
Sketch: preserve short reference-line directions when dimensioning (#11001) (#11117)
* claim: #11001 * fix(sketch): keep short infinite references aligned |
||
|
|
b470d46ffc |
Sketch: rebuilding a projection keeps the sketch's own curves on its points (#5388) (#5537)
* claim: #5388 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: rebuilding a projection keeps the sketch's own curves on its points (#5388) When a projected face changed shape, update_link rebuilt the link with drop_link_entities, whose remove_points also deleted every curve using a projected point: a circle the user drew on a projected hole's centre vanished, and the extrude on it lost its profile. Before the projected points go, the sketch's own curves on them move to a free point at the same place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3fe2b3386f |
Sketch: Remove Spline Point takes one point out of a spline (#10783) (#10793)
* Sketch: Remove Spline Point takes one fit point out of a spline (#10783) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: Remove Spline Point takes one point out of a spline (#10783) sketch.spline.remove_point takes one fit or control point out of a spline. The spline keeps its id and runs through its other points, which stay where they are. The point goes with the constraints on it, unless another curve uses it. A closed spline's closing point, an end joined to other geometry, the last 2 points (3 when closed), and projected, offset or patterned splines are refused with a message. The right-click menu of a spline point, picked alone, offers it beside Reverse Spline Direction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> |
||
|
|
9e30ff5878 |
fix(#5505): a zero length dimension keeps constraining the sketch (#10790)
The residual of a length dimension is the magnitude of the distance between the line's two ends. At zero the magnitude has no derivative, so the rank analysis read the constraint as if it were not there and the sketch reported a degree of freedom that was not there. At zero the two ends of the line meet, so the residual says it with the vector between them, the way a coincidence does. That is the treatment a distance of zero already gets (upstream #4397); the length family was left out of it. Regression test: crates/sketch/src/tests.rs, zero_length_keeps_the_line_constrained. Co-authored-by: Homero Thompson <homero@local> |
||
|
|
afa4f72f7d |
Insert SVG: say why a sketch is too large (#10874) (#10880)
* claim: #10874 Co-authored-by: Cursor <cursoragent@cursor.com> * Insert drawing: name the sketch size cap when a file is too dense (#10874) A large SVG/DXF failed with opaque \"sketch is too large\". Say the 20000 point/curve limit and that scale alone does not reduce entity count, and refuse dense drawings before adding them. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> |
||
|
|
fcb0a925e2 |
Sketch: hash sets for the stale-pattern check before each solve (#10493)
* claim: Sketch: use a lookup map for curves in pattern upkeep * Sketch: use a lookup map for curves in pattern upkeep Pattern upkeep runs before every solve, each drag frame included, and looked up every copy curve and its arc points with a linear search over all ids. Dragging another line in a sketch with a 500-copy slot pattern spent about two thirds of each frame there. The ids now resolve through maps built once per call; the result is the same to the bit. The solve bench gains a circular slot pattern section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: hash sets for the stale-pattern check before each solve The check whether a pattern lost a seed, copy or relation built three ordered sets of all ids before every solve. Only membership is asked, so hash sets give the same answer; a drag frame in a sketch with a 500-copy pattern takes another third less. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
71624cf7fa |
Sketch: use a lookup map for curves in pattern upkeep (#10524)
* claim: Sketch: use a lookup map for curves in pattern upkeep * Sketch: use a lookup map for curves in pattern upkeep Pattern upkeep runs before every solve, each drag frame included, and looked up every copy curve and its arc points with a linear search over all ids. Dragging another line in a sketch with a 500-copy slot pattern spent about two thirds of each frame there. The ids now resolve through maps built once per call; the result is the same to the bit. The solve bench gains a circular slot pattern section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
68105938e2 |
Sketch: a text rebuilt with other words keeps the far-move walk (#10357)
A sketch holding a text whose words come from a text parameter is left unsolved after the words change and its links then move far, with the warning "the sketch constraints conflict (k1, ..., k10)". The same two changes the other way round solve. Repro: a sketch with three projected points, a construction rectangle on them and a centred text along its far side, the text's words given by a text parameter. Change the parameter's words, then move the source geometry about 280 mm. Without the word change it solves; with it, the sketch warns of conflicting constraints. Other words are other outlines: the text is built anew with new points and curves. The solve that walks a sketch from its stored state to a far link move (and the check for sides the jump turned over) refused the two sketches as not the same entities, and the single jump left alone failed. `Sketch::stored_with_rebuilt_texts` gives the stored sketch as this one has its entities when they differ only by rebuilt texts: the texts' entities as they are now, every other point, radius, arc turn and constraint value as stored. `Document::solve_sketch` walks from that, so the points pair up again. Sketches that differ in anything else are refused as before. Test: sketch_project::side_tests::a_label_follows_its_source_far_after_a_text_parameter_gave_it_other_words (fails without the fix with the conflict warning above). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e0c1b8adbd |
Sketch: snap to infinite construction-line crossings (#10011) (#10285)
* claim: #10011 * Fix snapping at infinite construction-line crossings (#10011) |
||
|
|
cf0508e5c8 |
Sketch: held solves that cannot succeed give up sooner (#6606) (#10208)
* claim: #6606 * Sketch: held solves that cannot succeed give up sooner (#6606) A status-only solve (the held solves of a drag) only asks whether it succeeds. When LM sits in a least-squares valley of conflicting constraints it crawled on to its 500-iteration limit, and a held solve runs LM up to three times. Such a solve now leaves a component once the iteration has stalled far from a solution: over the last 20 iterations the sum of squared residuals fell by at most 1e-5 of itself while the largest residual is still above 1e-4 mm. Successful solves are unaffected: on about 62,000 LM runs that succeeded (the sketch and engine tests and 120 generated sketch scripts with 2,900 drags) the slowest still fell by 1.4e-3 over any 20 iterations while that far off. Solves with an analysis keep iterating (their report names the violated constraints), and live frames are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
510378d965 |
Sketch offset: an offset circle no longer reports a degree of freedom (#9264) (#9573)
The offset sets an offset circle's radius from its source after the solve, but the solve still counted that radius as a free unknown, so a dimensioned circle and its offset reported 1 DOF instead of 0. Lines and arcs were not affected: the offset already holds their end points. The solve now holds an offset circle's radius too. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
2e981d66e8 |
Sketch: allow dimension edits with tangent caps (#4823) (#9494)
* claim: #4823 * fix: resize sketches with tangent offset caps (#4823) |
||
|
|
5bb3b6717f |
Equation curves: the variable can carry its range's unit (#9333) (#9549)
* claim: #9333 * Equation curves: the variable can carry its range's unit (#9333) A curve can set variable_unit "range" (or tick the new box in its window): the variable is then a length, so a ^ 2 / (4 * t) is a length when a is one. Start and end must both be lengths, or one a length and the other a plain number in the design's unit; anything else is refused. Saved only when set, as one pending format change; without it curves behave as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0b2d51d301 |
Sketch: a projected face follows a resize that moves its corners far (#9001) (#9453)
* claim: #9001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a projected face follows a resize that moves its corners far (#9001) A sketch on the face of an angle kept its projected face boundary (and reported "projected face boundary identity is ambiguous") when the wall thickness changed: the inner corner moved by more than a tenth of the face, past the nearest-point match, and the same-order fallback refused faces. Accept the same-order layout when, for every point, the point read in that order is also clearly the nearest one on the same loop with lines the same way. Rims and holes, and rotated readings of a rectangle, stay refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
1e5eb1e3b8 |
Sketch: find profiles island by island, so dragging in a large imported logo stays smooth (#6896) (#9313)
* claim: #6896 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WUFq6QFBqmZjxwaKy2J1M * Sketch: find profiles island by island and say when the search is cut short (#6896) Every live drag frame ran the profile search over the whole sketch: every spline piece of a large imported logo was sampled, checked for crossings and traced again, about 100 ms per frame at 6,000 degrees of freedom. Profile curves are now split into islands whose enlarged piece boxes do not touch (the margin exceeds every tolerance the search uses), each island's loops are found on their own and cached by a fingerprint of its geometry, and the loops are nested into profiles over the whole sketch in the order a single search finds them, so profiles, ids, holes and whole-boundary certificates stay the same. The end-near-crossing lookup covers its whole reach, independent of the grid's cell size. The 50,000-piece limit now holds per island, and a sketch that still exceeds it gets a warning instead of silently missing profiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WUFq6QFBqmZjxwaKy2J1M --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5a24d4095a |
Sketch: an old edge-on projection keeps its line when it is re-resolved (#9025) (#9097)
* claim: #9025 Co-Authored-By: Claude Code <noreply@anthropic.com> * Sketch: an old edge-on projection keeps its line when it is re-resolved (#9025) A face seen edge-on was saved as two lines on the same two points, one each way, and is one line now. Re-resolving the link dropped both lines and built a new one under a new id, so an offset that names the first line as its source failed with "an offset source vanished or changed shape". Keep the first line and drop only the second. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com> |
||
|
|
31218b1451 |
Sketch drag: an end the cursor can't reach stays where it is (#8944) (#8967)
The cursor correction tries the constraints' free directions a whole step at a time and took a step as soon as the cursor's distance fell, by any amount. Along freedom that can't reach the cursor (the far end of a line held only by its direction), retracting onto the constraints still moves the cursor by rounding, so such steps were taken: the end walked away a step at a time, and a line measured by an angle could shrink to nothing, as in #7635. A step now has to move the cursor itself by more than the solve's tolerance. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a7048f41ab |
Sketch: equation-driven curve, a curve from x(t) and y(t) formulas (#8352) (#8353)
* claim: #8352 * Sketch: equation-driven curve, a fit point spline from x(t) and y(t) formulas (#8352) sketch.equation_curve draws a curve from formulas in the expression language and the design's parameters: x(t) and y(t) over a range of t, or y = f(x) over a range of x. The curve is a cubic fit spline through fixed points sampled from the formulas, as many as keep it within a tolerance (0.01 mm by default, at most 500 points); a curve that ends where it starts closes smoothly. The sketch keeps the formulas (one new design-format file), places the points again before every solve so they follow the parameters, and sketch.equation_curve.edit changes them, keeping the joined end points. Both commands have input and output schemas. * Sketch: Equation Curve window, its Edit menu item, labels and guide (#8352) The ribbon's Equation Curve opens a window for the form (parametric or explicit), the formulas, the range and the tolerance; OK runs sketch.equation_curve. Right-clicking an equation curve offers Edit Equation Curve, which reopens the window on its formulas and runs sketch.equation_curve.edit. New labels and help in a pending locale file (with ar, de, he, ja, ko, vi and zh), the icon, the glossary term and the sketching guide. * Equation curve: one if for closing the sampled points (clippy collapsible_if) |
||
|
|
d0b357d532 |
Sketch profiles: close the joints near-coincident curves leave open (#8639) (#8922)
* claim: #8639 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch profiles: close the joints near-coincident curves leave open (#8639) Two free-form curves that lie on each other along a stretch (a DXF that carries an outline twice, with the same straight sides and different corners) are cut into sampled pieces whose ends the graph joins into one node within 1e-4 mm, but the pieces keep their own ends, a few millionths apart. Only analytic edges were closed at those joints, so the sliver loops between the two curves stayed open by up to 1e-5 mm, more than the 1e-6 a solid needs. The region around them took those loops as holes: extruding it failed with "profile loop is not closed" and it drew no fill when picked, so it looked unselectable. Close a line's joint in each finished loop: line to line at their middle, a line onto any other segment's end. On the reporter's DXF the band between the outer two rings now extrudes (110.5 mm2 by 2 mm = 220.9 mm3), and the zero-area slivers no longer form profiles (221 -> 216). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
162b3cd4ed |
Sketch Intersect: add Faces/Bodies and Projection Link options (#1110) (#7989)
* Sketch Intersect: add Faces/Bodies and Projection Link options (#1110) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Sketch Project: add Geometry/Bodies and Projection Link options (#1110) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Sketch Project/Intersect: keep exact lines and arcs of whole bodies, no noisy rebuild warning (#1110) Whole-body silhouettes and sections fit lines and arcs tightly and snap arcs tangent to their neighbours. A rebuilt projection warns only when it removed the user's own constraints or curves. Pending locales cover ar, he and vi, and the preselection tests use the direct-pick workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Select Other: label curves from Intersect as intersected (#1110) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
4e78acc7a2 |
Sketch: the same constraint twice is one constraint (#5224) (#8850)
* claim: #5224 * Sketch: the same constraint twice is one constraint (#5224) |
||
|
|
cf86f18c11 |
Sketch: an end held on a removed curve where another curve ends stays tied (#8779)
A trimmed circle ended on a line exactly where an arc started on that line, held there by a point-on-curve tie. Trimming the line away dropped the tie and left the two ends on one spot, untied. remove_curves now ties each point held on a removed curve at one of its ends to that end before the curve goes (found by a local trim fuzzer, 15 -> 12 cases in 2000 seeds). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
aee57875f5 |
Sketch Fillet: 3D sketch lines are not offered and say they can't be filleted yet (#4160) (#4177)
* claim: #4160 * Sketch Fillet: 3D sketch lines are not offered, and say they can't be filleted (#4160) The Fillet tool offered 3D sketch lines as picks, and sketch.fillet then refused them with "`a` must be a line". The tool no longer offers them, and the command refuses them with "not supported yet: filleting 3D sketch lines". * Sketch Fillet and Chamfer: refuse all spatial sketch curves (#4160) * Sketch corner test: give the picked curve its point (#4160) main added a point to sketch-curve hits after this branch was written. |
||
|
|
5241c64aa6 |
Sketch solver: eliminate row by row on slices, so the dense solve vectorises (#8631)
The dense solve updated each matrix element through bounds-checked get/add; on slow scripted drags it was most of the time. The same operations in the same order on row slices give bit-identical solutions, about twice as fast. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f4e52c4d3e |
Sketch: points tied only through a removed curve's end stay tied (#8640)
* Sketch: points tied only through a removed curve's end stay tied Removing a curve removed its orphaned end points with their constraints, so two points made coincident with such an end lost their tie although they still met: two rectangles' corners on one arc end came apart when the arc was trimmed. They are now tied to each other before the point goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: keep the tie test with the other trim tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
be757154d6 |
fix(sketch): join nearby profile endpoints (#7269)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
d67c8e6231 |
Sketch text: Arabic and Hebrew are ordered right to left and joined (#8237) (#8324)
* claim: #8237 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Sketch text: right-to-left lines are ordered and shaped (#8237) A line with Arabic or Hebrew letters is split into display-order runs by the Unicode bidirectional algorithm (unicode-bidi) and each run is shaped with the font's own rules (harfrust), so letters join and marks sit where the font puts them. Lines without right-to-left characters keep the glyph-by-glyph layout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Sketch text: a line break inside a right-to-left line keeps the text after it (#8237) The bidirectional algorithm ends a paragraph at a line break; every paragraph is shaped now, not only the first, so measuring such a line counts all of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
a3ee8957f4 |
Sketch: conic curves take their own id prefix, not the constraints' k (#6173) (#8407)
* claim: #6173 * Sketch: conic curves take the id prefix n, not the constraints' k (#6173) |
||
|
|
9628e60ca0 |
Sketch: Reverse Spline Direction (#8224) (#8414)
A new command, sketch.spline.reverse, runs a spline the other way: its point list is reversed in place, so its last point becomes its first and the curve keeps its path (chord-length fits, uniform clamped knots and closed fits read the same both ways). Points and constraints stay. A projected spline and one an offset uses or makes are refused. The sketch's right-click menu offers it for one selected spline. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
1eec6d90b7 |
Sketch text: Bold in a variable font sets its weight axis (#8211) (#8331)
A variable font (one file for every weight, as most web fonts ship) has no face marked bold, so Bold failed with "has no bold face". Without a bold face, a face whose wght axis reaches past semibold is now set to weight 700. ttf-parser gets its variable-fonts feature for that. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a5f472c23e |
Prevent angular drags from collapsing construction geometry (#8148) (#8160)
* Reject newly collapsed angular reference lines (#8148) Reject angular solutions that collapse a reference relative to its input length. Cover constrained drags and already-short references. Engine replay and full CI validation remain in progress. * Cover live and non-live angular drags (#8148) Adds a replay of #8148 for live and non-live drags. The integration test compiles locally, but the Windows GNU test executable exits with STATUS_ACCESS_VIOLATION before running tests, including with --list/--help. Kept in the draft PR pending validation on a working native runner. |
||
|
|
64ff25f380 |
Fix sketch drag breaking midpoint-constrained line solver (#7635) (#7810)
* claim: #7635 * Keep the drag cursor on the manifold of an ill-conditioned sketch (#7635) A construction line collapsed to zero length makes its angle row's entries on that line ~1e7 while the same row's entries on the measured line are ~1. Dragging an endpoint of the midpoint-pinned line then failed two ways: the null-space rank analysis, which scaled rows only, hid the small (physically meaningful) entries below its pivot tolerance and let the measured line rotate freely; and the cursor's refinement, which demanded a TOL-tight correction the ill-conditioned system cannot deliver, gave up entirely and let the drag leave an unsolvable step placed - breaking the perpendicular and angle constraints. Equilibrate the null-space Jacobian on both sides (columns by their largest entry, then rows) so one row's entries share a scale, and let the cursor keep working from a pose the solver itself calls solved (residual below ACCEPT) when refinement stalls above TOL, accepting corrected trials at the same tolerance the final validation uses. --------- Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com> |
||
|
|
3179cd2ebd |
Sketch text: cover line pitch and format-12 glyph zero (#6570) (#6574)
* claim: #6570 * test(text): cover nonpositive pitch and format-12 glyph zero (#6570) Original synthetic font regressions. Focused native font tests, strict scoped Clippy and wasm pass. Full repository gate status is recorded in PR #6574; no CI infrastructure changes. |
||
|
|
ec877315c3 |
Sketch: add points to an existing spline (#6533) (#7384)
* claim: #6533 * Sketch: add points to an existing spline (#6533) A spline could not take more points after it was drawn. The new command sketch.spline.insert_point inserts a fit point on the curve where it passes nearest a spot, between its neighbours, or adds a new first or last point. Existing points keep their indices, so constraints stay. A right-click on a fit point spline offers Add Spline Point at the clicked spot. Control point splines are refused for now: with uniform knots one more control point would reshape the whole curve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Locales: Arabic and Hebrew for Add Spline Point ar and he are complete catalogs on main now (#3458). The pending-messages test compares right-to-left messages in display order once #7532 lands (#7527). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Locales: Vietnamese for the new strings Vietnamese became a complete catalog on main (#5823), so every new English message needs it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
285fa9433b |
Sketch: a distance along a line keeps its side (#7506) (#7510)
A point a distance from another point on the same line has two places on it, the same distance either way. A solve after a value edit or a link move could land on the other one and report the sketch solved, with no warning: the point jumped to the other side of its anchor, twice the distance away. Such a distance is now an orientation the solves keep, like an unsigned offset's side: which way along the line the one point lies from the other. One point must be on the line by a constraint (an end, a point held on it, or coincident with either); the other may lie on it by what else holds it (the mirror image of a point on it across a line square to it), read where it is in the reference state. Test: a point 3 mm along a linked rail from a point held on it, or mirrored onto it: the image back past that point counts as a flip, and the rail walked far keeps the side. Fixes #7506. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0f8593b180 |
Sketch: a tangent at an end the line and the round share keeps its side (#7428) (#7447)
A tangency at a point the two curves share (or a line's end held on the round) is solved as a block of its own, and the orientations a solve keeps left it out. When a point placed by parameters moved far, the line could land on the other tangent from its far end (its mirror image) with every constraint met and no warning. It now keeps the round's side of the line, as a tangency away from the ends already does: kept where the move can be walked there, reported as a flip where it can't. Fixes #7428. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f8d2d90a16 |
Sketch: dimension placement and editing (#44) (#7056)
* claim: #44 * Sketch: step dimension texts clear of each other and keep placed offsets (#44) * chore: re-trigger checks (Duplicate PR check was canceled by runner) --------- Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com> |
||
|
|
2863b80574 |
Sketch: 3D arc command (#5681) (#5682)
* claim: #5681 * sketch: exact circular arcs on drawn 3D wires (#5681) Add WireArc (centre, unit normal, radius, start/end) as an optional analytic form on drawn 3D sketch wires, with arc_from_3_points, arc_sweep and sagitta-bounded arc_polyline; add_drawn_arc_in stores the arc, its three defining fit points and its samples; move_drawn_point re-derives the arc atomically and refuses collinear points; validate_wires checks saved arcs. * engine,ui: sketch.arc3d exact 3D arc command (#5681) sketch.arc3d draws an exact circular arc through three world points in a 3D sketch, stored analytically beside its fit points and samples; sketch.move3d rebuilds it, sketch.inspect reports centre/radius/sweep; placement mapping (map_wire, now shared with the engine's world state) transforms the arc. One pending design-format file records the new field. The viewport's 3-Point Arc tool draws a 3D arc when clicked off the sketch plane, with a live arc preview; the SKETCH panel offers sketch.arc3d. * ui,engine: 3D Arc button starts an interactive tool (#5681) sketch.arc3d now maps to a Draw(3) tool handled by sketch3d: three world clicks (start, end, through - same order as the 2D arc tool) run the command, with the live arc preview and snapping. The command is only enabled while a 3D sketch is open, so the toolbar never offers a tool that could only fail. Locale labels for the command. * ui: cargo fmt --------- Co-authored-by: RayGalt <RayGalt@pm.me> |
||
|
|
484f0cf8ae |
Sketch: keep nested circles ordered when diameters change (#6764) (#6789)
* claim: #6764 * fix(sketch): preserve nested-circle order during dimension edits (#6764) |
||
|
|
e2c9f908f8 |
Sketch: an offset slot can still be moved by the dimension that places it (#6569) (#6697)
* claim: #6569 * Sketch: an offset slot can still be moved by the dimension that places it (#6569) An offset arc is drawn round its source's own centre, and its ends are held while the sketch solves (the offset is rebuilt from its source afterwards). Its arc condition, both ends as far from the centre, then only tied that shared centre, and the source arc with it, to the middle of the held ends: a slot offset by 1 mm lost a degree of freedom, and the length that places it was refused as conflicting. The solver and the constructive reading now leave out the arc condition of an offset arc round its source's centre (Sketch::offset_arc_follows_source), as #4466 did for the Parallel between an offset line and its source. The source's own arc keeps the centre; nothing changes without an offset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a test for a rounded rectangle with an offset round it (#6569) kaievns's case from the review: the offset's corner arcs tied each corner centre to a 45 degree line, so the height followed the width and every width change was refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
41a938e731 |
Sketch: a fillet stays the arc of its corner when the corner mirrors or a line is dragged through it (#5677)
A line tangent to an arc at the arc's end had no sense: the tangency held with the line on either side of its touch point, so pinning a line's far end across the corner left the line cutting back through its fillet, and when the solver found the mirrored corner the arc kept its stored direction and became its three-quarter complement, inside out. The solver now keeps each fillet an arc of its corner. A line tangent at an arc's end keeps its sense there (it leaves the arc as it did) and the arc its side of its chord, compared with the positions before an interactive move or the stored ones. A corner that mirrored gets its arc on the mirrored side: its ends swapped where the solve ran the arc round the other way with the lines following, or the arc reflected across the line that stayed and solved again where a line cut back through. A solve that would loop the arc the other way round, or fold a line onto it, is refused as a fold is. A drag's cursor-following steps keep the fillets too, so a line dragged through its own fillet stops at the arc. |
||
|
|
878339cac8 | Sketch patterns: count, spacing, and angle follow parameters (#5231) (#5332) |