diff --git a/tests/kernel-cases/README.md b/tests/kernel-cases/README.md index 2c3a95c0d..3cb355a20 100644 --- a/tests/kernel-cases/README.md +++ b/tests/kernel-cases/README.md @@ -57,6 +57,9 @@ parts): every issue and PR looked at that did not become a case, with one line e [{"source": "tangency-labs/solidcraft#123", "why": "UI only: the selection highlight, no geometry"}] ``` +`sources.json` says what kind each source number is (an open or closed issue, a merged PR, one of +the frozen truck-geometry PRs, a `kernel-paused` PR), for the report's coverage by source. + ## expected.json ```json diff --git a/tests/kernel-cases/crashes/2357-join-ring-of-90-cylinder-segments/expected.json b/tests/kernel-cases/crashes/2357-join-ring-of-90-cylinder-segments/expected.json new file mode 100644 index 000000000..08e80e282 --- /dev/null +++ b/tests/kernel-cases/crashes/2357-join-ring-of-90-cylinder-segments/expected.json @@ -0,0 +1,10 @@ +{ + "sources": [ + "tangency-labs/solidcraft#2357" + ], + "what": "one join of a ring of 90 straight cylinder segments, each overlapping its neighbour at a 4 degree joint: a caught truck panic, then a refusal after 21 minutes", + "source": "invariants", + "method": "the segments (diameter 5, 7.6 long, centred on radius 100, every 4 degrees) overlap their neighbours (the 4 degree chord at radius 100 is 6.98 < 7.6), so they join into one closed ring: one body with one shell, valid. The joint overlaps have no simple closed form, so no volume is graded. The rig's timeout bounds the time (the issue expects time to grow about linearly with the segment count)", + "body_count": 1, + "shells": 1 +} diff --git a/tests/kernel-cases/crashes/2357-join-ring-of-90-cylinder-segments/recipe.json b/tests/kernel-cases/crashes/2357-join-ring-of-90-cylinder-segments/recipe.json new file mode 100644 index 000000000..127385da7 --- /dev/null +++ b/tests/kernel-cases/crashes/2357-join-ring-of-90-cylinder-segments/recipe.json @@ -0,0 +1,128 @@ +{ + "commands": [ + { + "command": "solid.cylinder", + "params": { + "diameter": 5, + "height": 7.6, + "base": [ + -3.8, + 100, + 0 + ], + "axis": "X", + "operation": "new", + "name": "Seg" + } + }, + { + "command": "solid.pattern.circular", + "params": { + "features": [ + "Seg" + ], + "axis": "Z", + "count": 90, + "name": "Segs" + } + }, + { + "command": "solid.combine", + "params": { + "target": "Body1", + "tools": [ + "Body2", + "Body3", + "Body4", + "Body5", + "Body6", + "Body7", + "Body8", + "Body9", + "Body10", + "Body11", + "Body12", + "Body13", + "Body14", + "Body15", + "Body16", + "Body17", + "Body18", + "Body19", + "Body20", + "Body21", + "Body22", + "Body23", + "Body24", + "Body25", + "Body26", + "Body27", + "Body28", + "Body29", + "Body30", + "Body31", + "Body32", + "Body33", + "Body34", + "Body35", + "Body36", + "Body37", + "Body38", + "Body39", + "Body40", + "Body41", + "Body42", + "Body43", + "Body44", + "Body45", + "Body46", + "Body47", + "Body48", + "Body49", + "Body50", + "Body51", + "Body52", + "Body53", + "Body54", + "Body55", + "Body56", + "Body57", + "Body58", + "Body59", + "Body60", + "Body61", + "Body62", + "Body63", + "Body64", + "Body65", + "Body66", + "Body67", + "Body68", + "Body69", + "Body70", + "Body71", + "Body72", + "Body73", + "Body74", + "Body75", + "Body76", + "Body77", + "Body78", + "Body79", + "Body80", + "Body81", + "Body82", + "Body83", + "Body84", + "Body85", + "Body86", + "Body87", + "Body88", + "Body89", + "Body90" + ], + "operation": "join" + } + } + ] +} \ No newline at end of file diff --git a/tests/kernel-cases/sources.json b/tests/kernel-cases/sources.json new file mode 100644 index 000000000..8f9337150 --- /dev/null +++ b/tests/kernel-cases/sources.json @@ -0,0 +1,1575 @@ +{ + "9": "issue, open", + "10": "issue, open", + "11": "issue, closed", + "12": "issue, closed", + "13": "issue, closed", + "14": "issue, closed", + "15": "issue, closed", + "24": "issue, closed", + "25": "issue, open", + "29": "issue, closed", + "30": "issue, closed", + "40": "issue, closed", + "46": "issue, closed", + "48": "issue, closed", + "50": "issue, closed", + "52": "issue, open", + "58": "issue, open", + "59": "issue, open", + "63": "issue, open", + "68": "issue, closed", + "78": "issue, closed", + "79": "issue, closed", + "85": "merged PR", + "92": "issue, closed", + "95": "PR, not merged", + "96": "merged PR", + "102": "merged PR", + "108": "merged PR", + "109": "merged PR", + "114": "issue, open", + "117": "merged PR", + "118": "merged PR", + "121": "merged PR", + "122": "merged PR", + "125": "merged PR", + "132": "PR, not merged", + "133": "issue, open", + "134": "merged PR", + "140": "issue, closed", + "141": "issue, open", + "142": "issue, open", + "168": "issue, open", + "171": "issue, closed", + "173": "issue, closed", + "174": "merged PR", + "175": "issue, closed", + "190": "issue, closed", + "193": "issue, closed", + "195": "issue, open", + "199": "issue, closed", + "200": "issue, open", + "201": "issue, closed", + "202": "merged PR", + "206": "issue, open", + "209": "issue, closed", + "214": "merged PR", + "215": "issue, closed", + "219": "issue, closed", + "237": "issue, closed", + "238": "merged PR", + "255": "issue, open", + "256": "merged PR", + "258": "issue, open", + "262": "issue, closed", + "264": "issue, closed", + "271": "issue, closed", + "277": "merged PR", + "279": "merged PR", + "286": "merged PR", + "287": "issue, open", + "291": "issue, open", + "293": "issue, open", + "296": "issue, closed", + "299": "PR, not merged", + "301": "PR, not merged", + "307": "issue, closed", + "308": "issue, closed", + "311": "issue, open", + "317": "merged PR", + "318": "merged PR", + "324": "issue, open", + "327": "truck-geometry PR", + "331": "issue, open", + "334": "issue, closed", + "335": "merged PR", + "344": "issue, open", + "346": "issue, open", + "349": "merged PR", + "352": "merged PR", + "355": "merged PR", + "358": "issue, open", + "362": "merged PR", + "363": "merged PR", + "367": "issue, open", + "388": "merged PR", + "390": "issue, open", + "391": "issue, open", + "396": "issue, closed", + "397": "issue, open", + "404": "merged PR", + "405": "issue, closed", + "406": "merged PR", + "407": "merged PR", + "415": "issue, open", + "416": "issue, closed", + "423": "issue, open", + "424": "issue, open", + "425": "merged PR", + "430": "merged PR", + "431": "issue, open", + "436": "issue, closed", + "438": "issue, open", + "442": "issue, closed", + "443": "issue, closed", + "446": "issue, open", + "447": "merged PR", + "450": "issue, closed", + "451": "issue, open", + "452": "merged PR", + "456": "issue, open", + "458": "issue, open", + "461": "truck-geometry PR", + "466": "issue, open", + "467": "issue, open", + "469": "issue, open", + "470": "issue, closed", + "472": "merged PR", + "474": "merged PR", + "477": "merged PR", + "479": "issue, closed", + "482": "merged PR", + "485": "issue, closed", + "487": "issue, closed", + "488": "merged PR", + "490": "merged PR", + "493": "issue, closed", + "494": "issue, closed", + "495": "issue, closed", + "500": "issue, open", + "501": "issue, open", + "514": "issue, open", + "519": "issue, open", + "522": "issue, open", + "524": "issue, open", + "529": "issue, closed", + "533": "issue, closed", + "534": "merged PR", + "535": "issue, closed", + "536": "merged PR", + "539": "merged PR", + "541": "issue, closed", + "542": "issue, closed", + "550": "merged PR", + "552": "merged PR", + "556": "issue, closed", + "559": "issue, open", + "560": "issue, closed", + "561": "issue, closed", + "562": "issue, open", + "566": "issue, open", + "570": "issue, closed", + "572": "PR, not merged", + "577": "merged PR", + "581": "issue, closed", + "586": "issue, open", + "593": "issue, closed", + "594": "merged PR", + "601": "merged PR", + "602": "issue, closed", + "604": "merged PR", + "607": "merged PR", + "608": "issue, open", + "611": "issue, open", + "612": "issue, closed", + "613": "issue, closed", + "615": "issue, open", + "618": "merged PR", + "620": "issue, open", + "622": "issue, open", + "623": "issue, closed", + "625": "merged PR", + "626": "issue, open", + "632": "issue, open", + "634": "merged PR", + "636": "merged PR", + "638": "issue, closed", + "639": "issue, closed", + "642": "issue, closed", + "646": "merged PR", + "647": "issue, closed", + "650": "merged PR", + "652": "PR, not merged", + "653": "PR, not merged", + "654": "merged PR", + "656": "merged PR", + "658": "issue, closed", + "659": "issue, closed", + "661": "issue, open", + "667": "merged PR", + "669": "issue, open", + "673": "issue, closed", + "675": "merged PR", + "677": "merged PR", + "688": "issue, open", + "691": "issue, open", + "692": "merged PR", + "700": "merged PR", + "702": "merged PR", + "705": "merged PR", + "706": "PR, not merged", + "709": "merged PR", + "714": "merged PR", + "720": "issue, closed", + "723": "issue, closed", + "725": "merged PR", + "726": "issue, closed", + "732": "issue, open", + "742": "issue, open", + "744": "issue, open", + "745": "issue, open", + "746": "issue, open", + "749": "merged PR", + "752": "merged PR", + "756": "issue, closed", + "757": "issue, open", + "758": "issue, closed", + "759": "issue, open", + "762": "issue, closed", + "763": "issue, closed", + "764": "issue, closed", + "766": "issue, closed", + "767": "issue, open", + "769": "issue, open", + "770": "issue, open", + "771": "issue, closed", + "772": "issue, open", + "774": "issue, closed", + "775": "issue, closed", + "776": "merged PR", + "777": "merged PR", + "783": "issue, closed", + "784": "issue, closed", + "789": "merged PR", + "793": "issue, open", + "796": "issue, closed", + "797": "merged PR", + "800": "PR, not merged", + "802": "merged PR", + "803": "merged PR", + "805": "merged PR", + "806": "merged PR", + "809": "merged PR", + "810": "merged PR", + "811": "PR, not merged", + "813": "issue, open", + "814": "issue, closed", + "818": "issue, open", + "819": "issue, closed", + "820": "merged PR", + "823": "issue, open", + "824": "merged PR", + "827": "issue, closed", + "828": "issue, closed", + "829": "issue, closed", + "831": "issue, open", + "837": "merged PR", + "839": "merged PR", + "842": "issue, open", + "843": "merged PR", + "844": "issue, closed", + "847": "merged PR", + "849": "PR, not merged", + "851": "issue, closed", + "854": "merged PR", + "855": "merged PR", + "856": "merged PR", + "858": "issue, open", + "862": "merged PR", + "864": "issue, open", + "870": "merged PR", + "873": "issue, open", + "878": "issue, closed", + "881": "issue, closed", + "882": "issue, closed", + "884": "issue, closed", + "887": "issue, open", + "888": "PR, not merged", + "889": "PR, not merged", + "893": "merged PR", + "894": "merged PR", + "896": "issue, closed", + "900": "issue, closed", + "903": "issue, open", + "906": "merged PR", + "914": "merged PR", + "916": "merged PR", + "917": "merged PR", + "921": "merged PR", + "924": "issue, open", + "926": "merged PR", + "935": "merged PR", + "936": "merged PR", + "938": "issue, open", + "940": "merged PR", + "949": "merged PR", + "953": "issue, open", + "955": "merged PR", + "956": "merged PR", + "958": "merged PR", + "961": "merged PR", + "962": "merged PR", + "963": "merged PR", + "964": "merged PR", + "967": "issue, open", + "968": "issue, closed", + "974": "issue, closed", + "977": "merged PR", + "978": "merged PR", + "982": "merged PR", + "983": "merged PR", + "984": "issue, open", + "987": "issue, open", + "989": "issue, open", + "990": "issue, open", + "992": "issue, open", + "995": "issue, closed", + "999": "issue, open", + "1001": "issue, open", + "1002": "issue, open", + "1003": "merged PR", + "1004": "issue, open", + "1008": "issue, open", + "1012": "issue, closed", + "1017": "issue, open", + "1018": "merged PR", + "1019": "merged PR", + "1020": "merged PR", + "1022": "merged PR", + "1023": "issue, open", + "1024": "issue, open", + "1025": "issue, open", + "1026": "issue, closed", + "1030": "issue, open", + "1033": "issue, open", + "1038": "issue, closed", + "1039": "issue, open", + "1040": "merged PR", + "1041": "merged PR", + "1046": "merged PR", + "1066": "merged PR", + "1067": "merged PR", + "1080": "issue, closed", + "1084": "merged PR", + "1087": "PR, not merged", + "1089": "issue, closed", + "1090": "issue, closed", + "1092": "issue, closed", + "1093": "issue, open", + "1095": "merged PR", + "1098": "issue, closed", + "1099": "merged PR", + "1104": "issue, open", + "1107": "issue, open", + "1113": "issue, closed", + "1120": "issue, open", + "1123": "issue, open", + "1124": "merged PR", + "1125": "issue, open", + "1126": "issue, open", + "1133": "issue, open", + "1136": "PR, not merged", + "1137": "issue, open", + "1140": "issue, open", + "1142": "merged PR", + "1147": "issue, open", + "1152": "merged PR", + "1157": "merged PR", + "1161": "issue, open", + "1163": "merged PR", + "1176": "merged PR", + "1183": "issue, open", + "1184": "issue, closed", + "1191": "issue, open", + "1195": "truck-geometry PR", + "1198": "issue, closed", + "1200": "issue, open", + "1201": "merged PR", + "1202": "issue, open", + "1207": "issue, open", + "1208": "issue, closed", + "1213": "issue, closed", + "1216": "issue, open", + "1218": "issue, closed", + "1219": "issue, open", + "1223": "PR, not merged", + "1225": "issue, open", + "1228": "issue, closed", + "1231": "issue, open", + "1232": "issue, closed", + "1237": "issue, open", + "1249": "merged PR", + "1250": "issue, open", + "1251": "merged PR", + "1252": "issue, closed", + "1253": "issue, open", + "1254": "merged PR", + "1259": "issue, closed", + "1262": "issue, closed", + "1263": "issue, closed", + "1267": "merged PR", + "1269": "merged PR", + "1272": "merged PR", + "1275": "issue, closed", + "1276": "issue, open", + "1279": "issue, open", + "1280": "merged PR", + "1281": "merged PR", + "1282": "merged PR", + "1284": "issue, closed", + "1285": "issue, closed", + "1287": "issue, closed", + "1289": "issue, closed", + "1291": "merged PR", + "1293": "issue, open", + "1294": "merged PR", + "1295": "issue, closed", + "1300": "merged PR", + "1303": "issue, closed", + "1307": "merged PR", + "1308": "kernel-paused PR", + "1309": "merged PR", + "1311": "merged PR", + "1313": "merged PR", + "1314": "merged PR", + "1317": "kernel-paused PR", + "1319": "merged PR", + "1320": "issue, closed", + "1324": "merged PR", + "1325": "issue, open", + "1326": "issue, open", + "1327": "issue, closed", + "1328": "issue, open", + "1332": "issue, closed", + "1337": "issue, open", + "1338": "merged PR", + "1339": "issue, closed", + "1340": "merged PR", + "1343": "issue, open", + "1345": "issue, open", + "1346": "issue, closed", + "1348": "PR, not merged", + "1351": "issue, open", + "1355": "issue, open", + "1356": "merged PR", + "1358": "issue, closed", + "1364": "merged PR", + "1368": "issue, open", + "1369": "issue, open", + "1370": "issue, open", + "1372": "merged PR", + "1374": "issue, open", + "1379": "issue, open", + "1384": "issue, closed", + "1385": "issue, closed", + "1389": "issue, open", + "1390": "issue, open", + "1391": "issue, open", + "1394": "merged PR", + "1395": "merged PR", + "1397": "issue, open", + "1400": "issue, open", + "1402": "issue, open", + "1409": "issue, open", + "1411": "issue, open", + "1420": "PR, not merged", + "1421": "PR, not merged", + "1425": "merged PR", + "1428": "merged PR", + "1431": "issue, open", + "1434": "issue, closed", + "1436": "issue, open", + "1437": "issue, open", + "1440": "issue, open", + "1441": "issue, open", + "1442": "issue, open", + "1443": "issue, open", + "1446": "merged PR", + "1451": "issue, open", + "1452": "issue, open", + "1454": "issue, closed", + "1455": "merged PR", + "1459": "merged PR", + "1460": "merged PR", + "1461": "merged PR", + "1462": "merged PR", + "1464": "issue, closed", + "1466": "merged PR", + "1467": "issue, open", + "1468": "issue, open", + "1471": "issue, open", + "1475": "issue, open", + "1477": "merged PR", + "1481": "merged PR", + "1483": "issue, closed", + "1484": "merged PR", + "1488": "issue, open", + "1490": "issue, closed", + "1492": "issue, closed", + "1493": "issue, open", + "1494": "issue, open", + "1496": "merged PR", + "1501": "merged PR", + "1508": "merged PR", + "1511": "issue, open", + "1512": "merged PR", + "1517": "merged PR", + "1524": "merged PR", + "1525": "issue, open", + "1527": "merged PR", + "1531": "issue, open", + "1533": "merged PR", + "1535": "issue, closed", + "1543": "merged PR", + "1552": "issue, open", + "1553": "issue, open", + "1555": "merged PR", + "1556": "merged PR", + "1557": "issue, closed", + "1559": "issue, open", + "1572": "issue, open", + "1573": "issue, open", + "1574": "issue, closed", + "1579": "merged PR", + "1581": "merged PR", + "1597": "issue, open", + "1600": "PR, not merged", + "1603": "issue, open", + "1605": "PR, not merged", + "1606": "kernel-paused PR", + "1609": "truck-geometry PR", + "1613": "PR, not merged", + "1615": "merged PR", + "1617": "issue, closed", + "1626": "issue, open", + "1640": "kernel-paused PR", + "1642": "merged PR", + "1647": "issue, open", + "1648": "issue, closed", + "1649": "issue, open", + "1651": "issue, open", + "1652": "PR, not merged", + "1653": "merged PR", + "1654": "issue, open", + "1655": "issue, open", + "1656": "issue, open", + "1658": "PR, not merged", + "1662": "issue, open", + "1666": "issue, open", + "1667": "issue, closed", + "1668": "issue, closed", + "1669": "issue, open", + "1670": "merged PR", + "1672": "issue, open", + "1675": "merged PR", + "1677": "issue, closed", + "1683": "merged PR", + "1684": "merged PR", + "1687": "PR, not merged", + "1690": "issue, open", + "1691": "issue, open", + "1692": "issue, open", + "1693": "issue, open", + "1694": "issue, open", + "1695": "issue, open", + "1696": "issue, open", + "1698": "PR, not merged", + "1699": "PR, not merged", + "1700": "PR, not merged", + "1702": "merged PR", + "1706": "issue, open", + "1708": "issue, open", + "1709": "PR, not merged", + "1717": "issue, open", + "1718": "merged PR", + "1719": "issue, open", + "1720": "merged PR", + "1721": "PR, not merged", + "1722": "issue, open", + "1723": "issue, open", + "1724": "issue, open", + "1726": "PR, not merged", + "1728": "issue, open", + "1730": "merged PR", + "1731": "issue, open", + "1736": "issue, open", + "1737": "issue, open", + "1739": "issue, closed", + "1742": "merged PR", + "1743": "merged PR", + "1753": "merged PR", + "1759": "merged PR", + "1760": "issue, open", + "1765": "issue, open", + "1768": "merged PR", + "1773": "PR, not merged", + "1774": "issue, open", + "1775": "issue, open", + "1776": "merged PR", + "1777": "issue, open", + "1783": "issue, open", + "1784": "issue, open", + "1788": "issue, closed", + "1792": "issue, open", + "1794": "issue, open", + "1797": "issue, closed", + "1799": "merged PR", + "1806": "merged PR", + "1807": "issue, open", + "1812": "merged PR", + "1813": "merged PR", + "1824": "issue, closed", + "1826": "merged PR", + "1834": "issue, open", + "1848": "issue, open", + "1850": "merged PR", + "1851": "merged PR", + "1853": "issue, closed", + "1854": "PR, not merged", + "1856": "issue, open", + "1858": "merged PR", + "1865": "issue, open", + "1866": "merged PR", + "1875": "issue, open", + "1876": "issue, open", + "1882": "issue, open", + "1885": "merged PR", + "1891": "PR, not merged", + "1902": "issue, closed", + "1907": "merged PR", + "1910": "truck-geometry PR", + "1912": "PR, not merged", + "1926": "issue, open", + "1927": "merged PR", + "1928": "truck-geometry PR", + "1929": "merged PR", + "1933": "issue, open", + "1934": "issue, closed", + "1940": "issue, open", + "1944": "issue, open", + "1945": "issue, open", + "1946": "issue, open", + "1949": "merged PR", + "1951": "issue, open", + "1955": "issue, open", + "1957": "issue, open", + "1963": "issue, open", + "1964": "issue, open", + "1965": "issue, open", + "1967": "issue, open", + "1969": "issue, open", + "1972": "issue, open", + "1974": "issue, closed", + "1978": "issue, closed", + "1979": "issue, closed", + "1980": "merged PR", + "1981": "merged PR", + "1983": "issue, open", + "1984": "merged PR", + "1985": "issue, closed", + "1986": "issue, open", + "1988": "issue, open", + "1995": "issue, open", + "1996": "issue, open", + "2002": "kernel-paused PR", + "2003": "issue, open", + "2004": "issue, open", + "2005": "issue, closed", + "2008": "truck-geometry PR", + "2009": "issue, open", + "2010": "merged PR", + "2015": "issue, closed", + "2034": "PR, not merged", + "2037": "issue, open", + "2038": "issue, open", + "2040": "issue, open", + "2041": "truck-geometry PR", + "2042": "issue, open", + "2043": "merged PR", + "2044": "merged PR", + "2048": "issue, open", + "2051": "issue, open", + "2052": "issue, open", + "2054": "issue, closed", + "2055": "issue, open", + "2056": "issue, closed", + "2057": "merged PR", + "2059": "issue, closed", + "2064": "merged PR", + "2067": "PR, not merged", + "2069": "kernel-paused PR", + "2073": "kernel-paused PR", + "2074": "kernel-paused PR", + "2075": "kernel-paused PR", + "2076": "issue, open", + "2079": "issue, open", + "2081": "issue, open", + "2083": "issue, open", + "2086": "merged PR", + "2090": "merged PR", + "2095": "merged PR", + "2102": "merged PR", + "2114": "issue, closed", + "2115": "issue, open", + "2116": "issue, open", + "2127": "merged PR", + "2128": "issue, open", + "2130": "issue, open", + "2134": "merged PR", + "2135": "issue, open", + "2152": "issue, open", + "2153": "issue, open", + "2156": "PR, not merged", + "2158": "truck-geometry PR", + "2170": "issue, open", + "2174": "issue, closed", + "2183": "issue, open", + "2189": "issue, open", + "2191": "PR, not merged", + "2192": "issue, open", + "2193": "issue, open", + "2194": "PR, not merged", + "2205": "merged PR", + "2209": "merged PR", + "2213": "issue, open", + "2215": "issue, open", + "2216": "issue, open", + "2230": "issue, open", + "2235": "issue, open", + "2242": "merged PR", + "2243": "merged PR", + "2245": "issue, open", + "2259": "truck-geometry PR", + "2263": "PR, not merged", + "2264": "merged PR", + "2265": "merged PR", + "2269": "issue, open", + "2272": "issue, closed", + "2274": "kernel-paused PR", + "2275": "merged PR", + "2276": "PR, not merged", + "2286": "issue, open", + "2295": "issue, open", + "2296": "issue, open", + "2298": "issue, open", + "2301": "issue, open", + "2318": "issue, open", + "2320": "issue, open", + "2325": "issue, open", + "2333": "issue, open", + "2341": "issue, open", + "2342": "kernel-paused PR", + "2343": "kernel-paused PR", + "2350": "issue, open", + "2357": "issue, open", + "2367": "issue, open", + "2369": "issue, open", + "2375": "issue, open", + "2379": "issue, open", + "2383": "issue, open", + "2394": "issue, open", + "2399": "issue, open", + "2406": "issue, open", + "2407": "issue, open", + "2408": "issue, closed", + "2409": "merged PR", + "2418": "issue, open", + "2420": "issue, closed", + "2421": "issue, closed", + "2422": "issue, open", + "2428": "merged PR", + "2432": "issue, open", + "2435": "issue, closed", + "2439": "issue, open", + "2440": "issue, open", + "2441": "PR, not merged", + "2442": "issue, open", + "2445": "issue, open", + "2447": "merged PR", + "2450": "issue, open", + "2451": "issue, open", + "2452": "issue, open", + "2453": "issue, open", + "2454": "issue, open", + "2461": "issue, closed", + "2464": "issue, open", + "2465": "truck-geometry PR", + "2466": "issue, open", + "2467": "issue, open", + "2468": "PR, not merged", + "2470": "issue, open", + "2472": "issue, open", + "2477": "issue, open", + "2478": "issue, open", + "2480": "issue, open", + "2482": "merged PR", + "2485": "merged PR", + "2486": "merged PR", + "2487": "merged PR", + "2488": "merged PR", + "2490": "merged PR", + "2493": "issue, open", + "2495": "issue, open", + "2497": "merged PR", + "2498": "issue, closed", + "2500": "issue, open", + "2503": "issue, open", + "2506": "merged PR", + "2508": "PR, not merged", + "2509": "PR, not merged", + "2513": "kernel-paused PR", + "2515": "issue, open", + "2516": "issue, open", + "2519": "issue, open", + "2522": "issue, open", + "2524": "issue, open", + "2525": "issue, open", + "2526": "kernel-paused PR", + "2527": "issue, open", + "2528": "issue, open", + "2531": "issue, open", + "2532": "issue, open", + "2533": "issue, open", + "2534": "issue, open", + "2538": "issue, open", + "2541": "issue, open", + "2543": "issue, open", + "2545": "kernel-paused PR", + "2551": "issue, open", + "2552": "issue, open", + "2553": "issue, open", + "2556": "issue, open", + "2557": "issue, open", + "2560": "issue, open", + "2564": "kernel-paused PR", + "2565": "issue, open", + "2566": "issue, open", + "2567": "issue, open", + "2568": "kernel-paused PR", + "2570": "issue, closed", + "2572": "PR, not merged", + "2573": "issue, open", + "2574": "issue, open", + "2576": "issue, open", + "2579": "issue, closed", + "2580": "merged PR", + "2581": "issue, open", + "2583": "merged PR", + "2586": "issue, open", + "2589": "issue, open", + "2591": "issue, open", + "2593": "issue, open", + "2599": "issue, closed", + "2601": "issue, open", + "2602": "issue, open", + "2603": "merged PR", + "2605": "issue, open", + "2607": "issue, open", + "2610": "issue, open", + "2621": "issue, closed", + "2653": "issue, open", + "2654": "issue, open", + "2656": "issue, open", + "2662": "issue, open", + "2663": "issue, open", + "2667": "issue, open", + "2672": "issue, closed", + "2673": "issue, open", + "2675": "kernel-paused PR", + "2679": "merged PR", + "2686": "issue, open", + "2688": "issue, closed", + "2690": "issue, open", + "2692": "issue, open", + "2694": "issue, open", + "2695": "issue, open", + "2696": "kernel-paused PR", + "2698": "issue, open", + "2699": "issue, open", + "2703": "issue, open", + "2704": "issue, open", + "2705": "issue, open", + "2706": "issue, open", + "2708": "issue, open", + "2711": "issue, closed", + "2712": "merged PR", + "2719": "issue, open", + "2729": "issue, open", + "2732": "issue, open", + "2739": "merged PR", + "2740": "issue, open", + "2745": "issue, open", + "2747": "issue, open", + "2748": "issue, open", + "2750": "issue, closed", + "2752": "issue, open", + "2754": "issue, open", + "2755": "issue, closed", + "2761": "issue, open", + "2763": "issue, closed", + "2765": "issue, open", + "2766": "issue, open", + "2768": "merged PR", + "2769": "issue, open", + "2770": "issue, open", + "2771": "issue, open", + "2774": "issue, open", + "2775": "kernel-paused PR", + "2776": "issue, closed", + "2780": "PR, not merged", + "2781": "issue, open", + "2783": "issue, open", + "2784": "issue, open", + "2787": "truck-geometry PR", + "2791": "merged PR", + "2794": "issue, open", + "2795": "issue, open", + "2796": "issue, open", + "2797": "issue, open", + "2798": "issue, open", + "2799": "issue, open", + "2800": "issue, open", + "2801": "merged PR", + "2802": "issue, open", + "2803": "issue, open", + "2809": "issue, open", + "2810": "issue, closed", + "2811": "issue, open", + "2813": "merged PR", + "2814": "issue, open", + "2815": "PR, not merged", + "2816": "issue, open", + "2820": "issue, open", + "2822": "issue, open", + "2826": "issue, closed", + "2827": "merged PR", + "2843": "issue, open", + "2844": "issue, open", + "2846": "issue, open", + "2847": "issue, closed", + "2852": "merged PR", + "2853": "merged PR", + "2856": "merged PR", + "2862": "issue, open", + "2865": "issue, closed", + "2867": "merged PR", + "2868": "PR, not merged", + "2872": "issue, closed", + "2873": "issue, open", + "2874": "issue, open", + "2875": "merged PR", + "2876": "PR, not merged", + "2880": "issue, open", + "2882": "issue, closed", + "2883": "issue, open", + "2885": "issue, open", + "2886": "issue, open", + "2887": "issue, open", + "2890": "issue, open", + "2891": "issue, open", + "2892": "issue, open", + "2893": "merged PR", + "2894": "truck-geometry PR", + "2895": "merged PR", + "2896": "truck-geometry PR", + "2904": "issue, closed", + "2905": "issue, open", + "2907": "issue, open", + "2908": "issue, closed", + "2911": "issue, open", + "2917": "issue, open", + "2918": "kernel-paused PR", + "2921": "issue, open", + "2922": "issue, closed", + "2924": "merged PR", + "2928": "PR, not merged", + "2929": "issue, closed", + "2935": "issue, closed", + "2939": "issue, open", + "2941": "issue, open", + "2946": "kernel-paused PR", + "2947": "issue, open", + "2948": "truck-geometry PR", + "2949": "issue, open", + "2950": "issue, open", + "2954": "issue, open", + "2959": "issue, open", + "2963": "issue, open", + "2965": "issue, open", + "2966": "issue, closed", + "2968": "PR, not merged", + "2969": "issue, open", + "2970": "issue, open", + "2971": "issue, open", + "2972": "issue, open", + "2973": "issue, open", + "2974": "issue, open", + "2976": "issue, open", + "2978": "issue, open", + "2979": "issue, open", + "2983": "issue, open", + "2986": "issue, open", + "2987": "issue, open", + "2990": "issue, open", + "2992": "issue, open", + "2993": "issue, open", + "2997": "issue, open", + "2998": "issue, closed", + "2999": "merged PR", + "3000": "issue, open", + "3001": "issue, closed", + "3006": "issue, open", + "3007": "issue, open", + "3012": "merged PR", + "3013": "PR, not merged", + "3019": "issue, open", + "3020": "issue, closed", + "3026": "issue, open", + "3027": "merged PR", + "3031": "issue, open", + "3034": "issue, open", + "3035": "issue, open", + "3038": "issue, open", + "3042": "issue, open", + "3046": "merged PR", + "3047": "merged PR", + "3050": "issue, open", + "3051": "issue, open", + "3056": "issue, open", + "3059": "PR, not merged", + "3060": "kernel-paused PR", + "3062": "issue, open", + "3063": "issue, open", + "3064": "issue, open", + "3066": "issue, open", + "3071": "issue, open", + "3072": "PR, not merged", + "3074": "issue, open", + "3075": "issue, open", + "3076": "issue, open", + "3078": "issue, closed", + "3079": "issue, open", + "3082": "issue, open", + "3085": "issue, open", + "3088": "issue, open", + "3090": "issue, open", + "3091": "issue, closed", + "3092": "PR, not merged", + "3093": "merged PR", + "3098": "kernel-paused PR", + "3100": "issue, open", + "3101": "issue, open", + "3102": "merged PR", + "3103": "issue, open", + "3104": "merged PR", + "3105": "issue, open", + "3106": "PR, not merged", + "3108": "issue, open", + "3110": "issue, open", + "3111": "issue, open", + "3112": "issue, open", + "3115": "issue, open", + "3117": "issue, open", + "3118": "issue, open", + "3119": "issue, open", + "3120": "issue, closed", + "3125": "issue, open", + "3126": "issue, open", + "3127": "merged PR", + "3130": "issue, open", + "3131": "issue, open", + "3132": "issue, open", + "3133": "issue, open", + "3134": "kernel-paused PR", + "3135": "PR, not merged", + "3138": "issue, open", + "3142": "issue, closed", + "3145": "issue, open", + "3147": "issue, open", + "3149": "issue, open", + "3150": "merged PR", + "3154": "issue, open", + "3156": "issue, open", + "3157": "issue, open", + "3158": "issue, open", + "3159": "issue, open", + "3161": "issue, open", + "3163": "issue, open", + "3165": "issue, open", + "3169": "issue, open", + "3170": "issue, open", + "3172": "issue, open", + "3175": "merged PR", + "3176": "issue, open", + "3178": "merged PR", + "3179": "PR, not merged", + "3180": "issue, open", + "3181": "issue, open", + "3183": "issue, open", + "3185": "merged PR", + "3187": "issue, open", + "3188": "PR, not merged", + "3190": "PR, not merged", + "3191": "issue, open", + "3192": "issue, closed", + "3193": "issue, open", + "3194": "issue, open", + "3205": "issue, open", + "3207": "kernel-paused PR", + "3208": "merged PR", + "3209": "PR, not merged", + "3211": "issue, open", + "3212": "issue, open", + "3215": "issue, open", + "3216": "issue, open", + "3221": "issue, closed", + "3223": "issue, closed", + "3224": "truck-geometry PR", + "3226": "issue, open", + "3227": "issue, open", + "3232": "issue, open", + "3233": "issue, open", + "3234": "issue, closed", + "3237": "issue, open", + "3241": "issue, closed", + "3243": "issue, open", + "3247": "issue, open", + "3249": "issue, closed", + "3251": "issue, open", + "3255": "issue, open", + "3258": "merged PR", + "3268": "kernel-paused PR", + "3271": "issue, open", + "3272": "kernel-paused PR", + "3273": "merged PR", + "3274": "merged PR", + "3276": "issue, open", + "3279": "issue, open", + "3280": "merged PR", + "3282": "issue, open", + "3283": "issue, open", + "3284": "issue, open", + "3289": "kernel-paused PR", + "3290": "issue, open", + "3293": "issue, open", + "3295": "merged PR", + "3297": "PR, not merged", + "3300": "issue, open", + "3302": "issue, open", + "3303": "issue, open", + "3307": "issue, open", + "3308": "issue, open", + "3309": "truck-geometry PR", + "3311": "issue, open", + "3316": "merged PR", + "3317": "issue, open", + "3318": "truck-geometry PR", + "3324": "issue, closed", + "3325": "merged PR", + "3326": "issue, open", + "3327": "truck-geometry PR", + "3333": "issue, open", + "3337": "issue, closed", + "3340": "merged PR", + "3341": "issue, open", + "3342": "issue, open", + "3345": "issue, open", + "3346": "issue, open", + "3351": "issue, open", + "3352": "PR, not merged", + "3353": "issue, closed", + "3354": "merged PR", + "3358": "issue, closed", + "3359": "merged PR", + "3366": "issue, open", + "3367": "issue, open", + "3368": "truck-geometry PR", + "3369": "issue, open", + "3370": "issue, closed", + "3371": "merged PR", + "3374": "issue, open", + "3377": "issue, open", + "3378": "issue, closed", + "3379": "issue, open", + "3383": "issue, closed", + "3386": "issue, open", + "3392": "issue, open", + "3394": "issue, closed", + "3396": "issue, open", + "3397": "PR, not merged", + "3398": "issue, closed", + "3400": "PR, not merged", + "3401": "issue, open", + "3402": "issue, open", + "3403": "issue, open", + "3404": "issue, open", + "3405": "issue, open", + "3406": "issue, open", + "3410": "truck-geometry PR", + "3411": "issue, open", + "3412": "merged PR", + "3417": "issue, closed", + "3418": "issue, open", + "3421": "merged PR", + "3425": "issue, open", + "3426": "issue, open", + "3427": "issue, open", + "3428": "issue, open", + "3430": "issue, open", + "3431": "issue, open", + "3433": "issue, open", + "3435": "issue, open", + "3436": "issue, open", + "3437": "merged PR", + "3439": "merged PR", + "3441": "kernel-paused PR", + "3442": "issue, open", + "3445": "issue, open", + "3447": "truck-geometry PR", + "3448": "issue, open", + "3450": "issue, open", + "3452": "merged PR", + "3454": "issue, open", + "3455": "issue, open", + "3456": "issue, open", + "3460": "issue, open", + "3462": "issue, open", + "3464": "issue, open", + "3465": "PR, not merged", + "3467": "issue, open", + "3468": "issue, open", + "3472": "kernel-paused PR", + "3473": "issue, open", + "3476": "PR, not merged", + "3479": "issue, open", + "3480": "PR, not merged", + "3485": "truck-geometry PR", + "3486": "issue, open", + "3492": "issue, open", + "3493": "issue, open", + "3496": "issue, open", + "3497": "truck-geometry PR", + "3498": "issue, open", + "3500": "issue, open", + "3501": "issue, open", + "3502": "issue, open", + "3503": "issue, open", + "3504": "issue, open", + "3505": "kernel-paused PR", + "3506": "issue, open", + "3508": "issue, open", + "3514": "issue, open", + "3516": "issue, open", + "3517": "kernel-paused PR", + "3518": "issue, open", + "3519": "issue, open", + "3520": "issue, open", + "3524": "issue, open", + "3525": "truck-geometry PR", + "3526": "issue, open", + "3528": "issue, open", + "3531": "issue, closed", + "3533": "issue, open", + "3537": "issue, open", + "3539": "issue, open", + "3540": "issue, open", + "3541": "issue, open", + "3545": "issue, open", + "3547": "issue, open", + "3548": "PR, not merged", + "3549": "issue, open", + "3551": "kernel-paused PR", + "3552": "truck-geometry PR", + "3557": "kernel-paused PR", + "3561": "issue, open", + "3562": "issue, open", + "3563": "issue, open", + "3565": "issue, open", + "3567": "issue, open", + "3569": "kernel-paused PR", + "3572": "issue, open", + "3573": "issue, open", + "3574": "issue, open", + "3575": "issue, open", + "3576": "truck-geometry PR", + "3578": "issue, open", + "3581": "PR, not merged", + "3585": "issue, open", + "3586": "issue, open", + "3587": "issue, open", + "3592": "kernel-paused PR", + "3594": "kernel-paused PR", + "3595": "issue, open", + "3598": "issue, open", + "3602": "issue, open", + "3603": "issue, open", + "3604": "issue, open", + "3606": "issue, open", + "3607": "issue, open", + "3608": "issue, open", + "3609": "merged PR", + "3611": "issue, open", + "3612": "truck-geometry PR", + "3613": "truck-geometry PR", + "3616": "merged PR", + "3619": "issue, open", + "3621": "issue, open", + "3622": "merged PR", + "3630": "issue, open", + "3632": "issue, open", + "3633": "issue, open", + "3634": "issue, open", + "3635": "issue, open", + "3636": "issue, open", + "3644": "issue, open", + "3645": "issue, open", + "3648": "issue, closed", + "3649": "issue, open", + "3650": "issue, open", + "3651": "issue, open", + "3652": "issue, open", + "3655": "issue, open", + "3656": "issue, open", + "3657": "issue, open", + "3660": "PR, not merged", + "3665": "issue, open", + "3666": "truck-geometry PR", + "3667": "issue, open", + "3669": "issue, open", + "3670": "merged PR", + "3671": "truck-geometry PR", + "3672": "issue, open", + "3680": "issue, open", + "3682": "truck-geometry PR", + "3684": "issue, open", + "3685": "truck-geometry PR", + "3686": "issue, open", + "3691": "issue, open", + "3694": "issue, open", + "3695": "truck-geometry PR", + "3697": "issue, open", + "3699": "PR, not merged", + "3700": "kernel-paused PR", + "3702": "kernel-paused PR", + "3703": "issue, open", + "3707": "issue, open", + "3708": "issue, open", + "3709": "issue, open", + "3710": "issue, open", + "3712": "kernel-paused PR", + "3713": "issue, open", + "3716": "PR, not merged", + "3717": "issue, open", + "3719": "issue, open", + "3720": "issue, open", + "3721": "issue, open", + "3722": "issue, open", + "3724": "issue, open", + "3725": "issue, open", + "3726": "issue, open", + "3727": "issue, open", + "3729": "issue, closed", + "3730": "issue, closed", + "3731": "issue, open", + "3732": "issue, open", + "3734": "issue, open", + "3735": "issue, open", + "3736": "issue, open", + "3737": "issue, open", + "3738": "PR, not merged", + "3739": "issue, open", + "3741": "issue, open", + "3742": "issue, open", + "3745": "issue, closed", + "3746": "issue, open", + "3747": "issue, open", + "3752": "issue, open", + "3753": "issue, open", + "3754": "PR, not merged", + "3755": "issue, closed", + "3756": "kernel-paused PR", + "3757": "issue, open", + "3758": "truck-geometry PR", + "3763": "issue, open", + "3767": "issue, open", + "3774": "issue, open", + "3777": "issue, open", + "3779": "issue, open", + "3781": "issue, open", + "3782": "kernel-paused PR", + "3784": "issue, open", + "3785": "issue, open", + "3787": "issue, closed", + "3789": "issue, open", + "3790": "issue, open", + "3791": "issue, open", + "3793": "issue, open", + "3795": "issue, open", + "3796": "PR, not merged", + "3803": "issue, open", + "3804": "kernel-paused PR", + "3806": "issue, closed", + "3808": "issue, open", + "3811": "issue, open", + "3813": "merged PR", + "3816": "issue, open", + "3818": "merged PR", + "3819": "issue, open", + "3823": "issue, open", + "3824": "issue, open", + "3828": "issue, open", + "3830": "issue, open", + "3832": "issue, open", + "3837": "issue, open", + "3840": "PR, not merged", + "3841": "truck-geometry PR", + "3842": "kernel-paused PR", + "3843": "issue, open", + "3844": "issue, open", + "3845": "issue, closed", + "3846": "merged PR", + "3847": "issue, open", + "3849": "PR, not merged", + "3850": "PR, not merged", + "3853": "issue, open", + "3854": "issue, open", + "3858": "issue, open", + "3859": "PR, not merged", + "3860": "PR, not merged", + "3861": "kernel-paused PR", + "3862": "issue, open", + "3864": "kernel-paused PR", + "3865": "issue, open", + "3866": "issue, open", + "3868": "PR, not merged", + "3869": "issue, open", + "3870": "PR, not merged", + "3871": "merged PR", + "3872": "merged PR", + "3873": "merged PR", + "3879": "issue, open", + "3880": "merged PR", + "3885": "issue, closed", + "3886": "merged PR", + "3887": "truck-geometry PR", + "3888": "truck-geometry PR", + "3892": "issue, open", + "3893": "kernel-paused PR", + "3897": "issue, open", + "3898": "kernel-paused PR", + "3899": "issue, closed", + "3900": "kernel-paused PR", + "3901": "merged PR", + "3904": "issue, open", + "3906": "issue, open", + "3907": "kernel-paused PR", + "3908": "PR, not merged", + "3910": "issue, open", + "3911": "issue, open", + "3912": "issue, open", + "3913": "kernel-paused PR", + "3914": "kernel-paused PR", + "3915": "PR, not merged", + "3922": "PR, not merged", + "3924": "issue, open", + "3925": "kernel-paused PR", + "3926": "issue, open", + "3928": "issue, open", + "3932": "issue, open", + "3933": "issue, open", + "3936": "issue, open", + "3937": "merged PR", + "3942": "issue, open", + "3943": "issue, open", + "3946": "merged PR", + "3948": "issue, open", + "3952": "issue, open", + "3960": "issue, open", + "3961": "issue, open", + "3962": "issue, open", + "3963": "kernel-paused PR", + "3968": "issue, open", + "3971": "issue, open", + "3972": "PR, not merged", + "3974": "PR, not merged", + "3975": "issue, open", + "3976": "PR, not merged", + "3978": "issue, open", + "3981": "merged PR", + "3982": "issue, open", + "3987": "PR, not merged", + "3992": "issue, open", + "3997": "PR, not merged", + "4002": "issue, open", + "4005": "issue, open", + "4006": "issue, open", + "4007": "issue, open", + "4008": "issue, open", + "4009": "issue, open", + "4010": "issue, open", + "4011": "issue, open", + "4012": "truck-geometry PR", + "4017": "issue, open", + "4021": "PR, not merged", + "4024": "PR, not merged", + "4027": "issue, open", + "4029": "issue, open", + "4031": "issue, open", + "4033": "issue, open", + "4034": "issue, open", + "4036": "issue, open", + "4037": "issue, closed", + "4041": "issue, open", + "4042": "issue, open", + "4047": "issue, open", + "4052": "issue, open", + "4055": "issue, open", + "4056": "issue, open", + "4058": "issue, open", + "4059": "PR, not merged", + "4066": "issue, open", + "4070": "issue, open", + "4073": "issue, open", + "4075": "issue, open", + "4076": "issue, open", + "4077": "issue, open", + "4079": "issue, open", + "4080": "PR, not merged", + "4083": "issue, open", + "4085": "issue, open", + "4086": "issue, open", + "4087": "issue, open", + "4092": "issue, open", + "4093": "issue, open", + "4094": "issue, open", + "4095": "issue, open", + "4096": "PR, not merged", + "4097": "issue, open", + "4098": "issue, open", + "4100": "issue, open", + "4101": "issue, open", + "4102": "issue, open", + "4105": "issue, open", + "4106": "PR, not merged", + "4111": "issue, open", + "4120": "issue, open", + "4124": "issue, open", + "4127": "issue, open", + "4130": "issue, open", + "4133": "issue, open", + "4137": "issue, open", + "4139": "issue, open", + "4140": "issue, open", + "4141": "issue, open", + "4143": "issue, open", + "4144": "issue, open", + "4145": "issue, open", + "4148": "issue, open", + "4149": "issue, open", + "4153": "issue or PR, newer than this list", + "4154": "issue or PR, newer than this list", + "4155": "issue or PR, newer than this list", + "4157": "issue or PR, newer than this list", + "4160": "issue or PR, newer than this list" +} diff --git a/xtask/src/kernel_cases.rs b/xtask/src/kernel_cases.rs index c046c7069..daaf5bd9d 100644 --- a/xtask/src/kernel_cases.rs +++ b/xtask/src/kernel_cases.rs @@ -213,6 +213,32 @@ fn link(source: &str) -> String { } } +/// Coverage by kind of source (issue, merged PR, a frozen truck-geometry PR...), from +/// `sources.json`: how many were looked at, how many became cases, how many were skipped. +fn source_kinds(dir: &Path, cited: &BTreeMap>) -> Result { + let kinds = read(&dir.join("sources.json")); + let Some(kinds) = kinds.as_object() else { return Ok(String::new()) }; + let cited: std::collections::BTreeSet = cited.keys().map(|s| source_number(s)).collect(); + let mut table: BTreeMap = BTreeMap::new(); + for (n, kind) in kinds { + let row = table.entry(kind.as_str().unwrap_or("?").to_string()).or_default(); + if n.parse::().is_ok_and(|n| cited.contains(&n)) { + row.0 += 1; + } else { + row.1 += 1; + } + } + let mut md = String::from("\n## Coverage by source\n\n| Source | Looked at | Became cases | Skipped |\n|---|---|---|---|\n"); + let (mut a, mut b) = (0, 0); + for (kind, (cases, skipped)) in &table { + md += &format!("| {kind} | {} | {cases} | {skipped} |\n", cases + skipped); + a += cases; + b += skipped; + } + md += &format!("| **all** | {} | {a} | {b} |\n", a + b); + Ok(md) +} + fn write_report(o: &Options, dir: &Path, list: &[PathBuf], results: &[Value]) -> Result { let key = |r: &Value| (r["area"].as_str().unwrap_or("").to_string(), r["case"].as_str().unwrap_or("").to_string()); let mut by_case: BTreeMap<(String, String), BTreeMap> = BTreeMap::new(); @@ -284,6 +310,7 @@ fn write_report(o: &Options, dir: &Path, list: &[PathBuf], results: &[Value]) -> for (s, cs) in &per_source { md += &format!("| {} | {} |\n", link(s), cs.join(", ")); } + md += &source_kinds(dir, &per_source)?; // What was looked at and skipped, area by area (`/skipped.json`). md += "\n## Looked at and skipped\n\n"; let mut skipped = 0;