From db757efc7ce7eb0d40856d407f026a0b082c5156 Mon Sep 17 00:00:00 2001 From: jyviko <2501648+jyviko@users.noreply.github.com> Date: Thu, 29 Oct 2026 22:59:35 -0400 Subject: [PATCH] Tests: the pi case and the hole wall read as on green-truck-era-tests, so both branches agree Co-Authored-By: Claude Opus 5.5 --- apps/solidcraft-cli/tests/rebuild_topology.rs | 10 ++++++---- crates/ui-egui/src/preselect_tests.rs | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/apps/solidcraft-cli/tests/rebuild_topology.rs b/apps/solidcraft-cli/tests/rebuild_topology.rs index c8a0223bf..ce80304d5 100644 --- a/apps/solidcraft-cli/tests/rebuild_topology.rs +++ b/apps/solidcraft-cli/tests/rebuild_topology.rs @@ -146,10 +146,12 @@ fn a_parameter_edit_rebuilds_like_a_fresh_build_and_reverts_exactly() { /// wall at 24) into strips along the openings' tops and bottoms. #[test] fn pi_case_faces_per_step_at_both_heights() { - // Sketch1 (1) .. RectangularPattern2 (14): the faces once features 1..=k are built. Each - // standoff (Extrude2, then three more by RectangularPattern1) is a tube on the floor: its - // outer and inner walls (one face each, closed on its seam), its top, and the floor inside - // it, four faces. + // Sketch1 (1) .. RectangularPattern2 (14): the faces once features 1..=k are built. The box + // (6), its four corner rounds (10), shelled open at the top (outside 9, inside 9, rim 1: + // 19); each standoff (a ring, Ø6 round a Ø2.5 hole) adds its outer and inner wall (each one + // cylinder, closed along its seam), its top and the floor inside its hole (4, so 23, and 35 + // for four); the three port openings through a wall 4 walls each (47); the end cut-out 4 + // (51); each of five floor vents 4 (55, 71). const FACES: [(usize, usize); 13] = [(2, 6), (3, 10), (4, 19), (5, 19), (6, 23), (7, 35), (8, 35), (9, 47), (10, 47), (11, 51), (12, 51), (13, 55), (14, 71)]; let dir = scratch_dir("pi"); diff --git a/crates/ui-egui/src/preselect_tests.rs b/crates/ui-egui/src/preselect_tests.rs index 0fdcdcecc..dce8a18d0 100644 --- a/crates/ui-egui/src/preselect_tests.rs +++ b/crates/ui-egui/src/preselect_tests.rs @@ -799,7 +799,7 @@ fn press_pull_then_curved_face_offsets_it() { crate::viewport::dialog_pick(&mut app, &hit, Sel::Face { body: "Body1".into(), index: wall, point: p }); let d = app.dialog.clone().unwrap(); assert!(matches!(d.kind, Kind::OffsetFaces { .. })); - // The hole's whole wall: one face, closed on its seam. + // The hole's wall: one face, closed along its seam. assert_eq!(d.inputs[0].items.len(), 1); let mut app = app_with(script);