From cf2a15ace844f02ef1709d9517ff8c43b3205729 Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Fri, 30 Oct 2026 14:56:39 +0100 Subject: [PATCH] smlib: solidcore's four fork-carried opt-ins are on; only the trim base v opt-in waits fillet_torus_span_from_start_section (WR-568, smlib@985faae), fillet_knife_edge_rounds (WR-570, smlib@b7ec55b), taper_wall_closes_at_apex (WR-571, smlib@183ea65) and revolution_round_offset_collapses (WR-567, smlib@8b2090f) are on: their fork commits are in SMLIB_REV 985faaee. HELD_BACK keeps only precise_properties_trim_base_v, which has no fork commit. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- crates/smlib/src/core.rs | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index 7571971d6..435eb2cb0 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -182,23 +182,18 @@ pub(crate) fn fixes() -> UpstreamFixes { f.edge_check_orders_tangent_faces = true; f.revolve_arc_touching_axis_is_horn_torus = true; f.thicken_planar_side_walls = true; + f.fillet_torus_span_from_start_section = true; + f.fillet_knife_edge_rounds = true; + f.taper_wall_closes_at_apex = true; + f.revolution_round_offset_collapses = true; f } /// Opt-in fixes left off because the C++ fork (`SMLIB_REV`) does not carry them yet, so turning /// them on would part this backend from the C++ one. `precise_properties_trim_base_v` -/// (solidcore#1664, WR-563) has no fork commit; the others' fork commits are past `SMLIB_REV`: -/// `fillet_torus_span_from_start_section` (WR-568, smlib@985faae), `fillet_knife_edge_rounds` -/// (WR-570, smlib@b7ec55b), `taper_wall_closes_at_apex` (WR-571, smlib@183ea65) and -/// `revolution_round_offset_collapses` (WR-567, smlib@8b2090f). +/// (solidcore#1664, WR-563) has no fork commit. #[cfg(test)] -const HELD_BACK: &[&str] = &[ - "precise_properties_trim_base_v", - "fillet_torus_span_from_start_section", - "fillet_knife_edge_rounds", - "taper_wall_closes_at_apex", - "revolution_round_offset_collapses", -]; +const HELD_BACK: &[&str] = &["precise_properties_trim_base_v"]; fn fresh() -> Kernel { let mut k = Kernel::new(&KernelOptions::default());