From bcb67cc2ec9945a939d8b3c49111b45e9b3a976e Mon Sep 17 00:00:00 2001 From: semmelrinde <124386289+semmelrinde@users.noreply.github.com> Date: Wed, 28 Oct 2026 15:38:41 +0000 Subject: [PATCH] Mirror and Pattern: a body feature reopens with Bodies and its Operation (#8207) (#8298) Editing a body Mirror from the history showed Object Type Features (the dialog starts from the timeline selection, the Mirror itself, which turns pattern objects into features) and dropped its saved Join. The editor now sets the objects back to Bodies for a body Mirror or Pattern and restores the Mirror's combine. Co-authored-by: Claude Opus 5.5 --- crates/ui-egui/src/dialogs.rs | 13 ++++++++- crates/ui-egui/src/preselect_tests.rs | 39 +++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/crates/ui-egui/src/dialogs.rs b/crates/ui-egui/src/dialogs.rs index 6b1865bb4..ea16cd7d6 100644 --- a/crates/ui-egui/src/dialogs.rs +++ b/crates/ui-egui/src/dialogs.rs @@ -5653,12 +5653,17 @@ pub fn for_feature(app: &SolveApp, id: u64, marker: Option) -> Option { + FeatureKind::Mirror { features, plane, bodies, placements, combine } => { let mut d = start("solid.mirror")?; let ids: Vec = features.iter().map(|f| f.0).collect(); // Replay references stay features, including features that created a body. let as_features = !features.is_empty(); if let Some(inp) = d.inputs.get_mut(0) { + if !as_features { + // Bodies, though the editor opened with this feature selected in the timeline (#8207). + inp.accept = BODIES; + inp.label = objects_label(inp.accept); + } if !bodies.is_empty() { // Each body as the placement it was mirrored at shows it (an instance by its world name). let own = s.model.state(); @@ -5678,6 +5683,10 @@ pub fn for_feature(app: &SolveApp, id: u64, marker: Option) -> Option { @@ -5755,6 +5764,8 @@ pub fn for_feature(app: &SolveApp, id: u64, marker: Option) -> Option