From b0568524bed0a2065d81919ac2e95d01cfa21d00 Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Fri, 30 Oct 2026 21:52:58 +0100 Subject: [PATCH] smlib: solidcore's four new fork-carried opt-ins are on; the trimmed face tight box waits boolean_new_face_closure_both_sides (WR-584, smlib@69c5198), linear_sweep_arc_is_cylinder (#1477, smlib@12918e9), offset_closes_loop_gaps (WR-578, smlib@7ff0a94 and 34318f4) and cylinder_plane_tangent_within_tolerance (WR-510, #1525; smlib#55, squash-merged as c2f1788 with SmCone.cpp as in the bd20f6e the flag cites) are on: their fork commits are in SMLIB_REV 68fb9162. face_tight_box_searches_trim (WR-588, solidcore#1811) is the fork's beb6061 from smlib#68, which landed after 68fb9162, so it goes on HELD_BACK. The three held-back flags have no fork commit in 68fb9162 yet. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- crates/smlib/src/core.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index 4440b0adf..635b159f3 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -194,6 +194,10 @@ pub(crate) fn fixes() -> UpstreamFixes { f.local_operation_closes_walls_to_nothing = true; f.linear_sweep_arc_to_cylinder_zero = true; f.imprint_reuses_coincident_face_edge = true; + f.boolean_new_face_closure_both_sides = true; + f.linear_sweep_arc_is_cylinder = true; + f.offset_closes_loop_gaps = true; + f.cylinder_plane_tangent_within_tolerance = true; f } @@ -201,9 +205,15 @@ pub(crate) fn fixes() -> UpstreamFixes { /// them on would part this backend from the C++ one. `precise_properties_trim_base_v` /// (solidcore#1664, WR-563), `bspline_trim_keeps_rational_end_spans` (solidcore#1711, WR-575) and /// `fillet_blend_curve_revolved_on_arc` (solidcore#1759, WR-581, an own design waiting for the -/// fork's fix) have no fork commit. +/// fork's fix) have no fork commit. `face_tight_box_searches_trim` (solidcore#1811, WR-588) is the +/// fork's beb6061, which landed after `SMLIB_REV` (tangency-labs/smlib#68). #[cfg(test)] -const HELD_BACK: &[&str] = &["precise_properties_trim_base_v", "bspline_trim_keeps_rational_end_spans", "fillet_blend_curve_revolved_on_arc"]; +const HELD_BACK: &[&str] = &[ + "precise_properties_trim_base_v", + "bspline_trim_keeps_rational_end_spans", + "fillet_blend_curve_revolved_on_arc", + "face_tight_box_searches_trim", +]; fn fresh() -> Kernel { let mut k = Kernel::new(&KernelOptions::default());