From a3f150257f95b3811b6efce3a1998a1ffa72ab18 Mon Sep 17 00:00:00 2001 From: jyviko <2501648+jyviko@users.noreply.github.com> Date: Thu, 29 Oct 2026 22:55:46 -0400 Subject: [PATCH] Tests: the tapered bosses' volume in closed form, not truck's measure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fillets_on_tapered_bosses_saved_before_still_find_their_edges compared the part with 69454.885209 mm³, what the truck build that saved it measured. In closed form: the 80 × 40 × 20 block (64000); the 20 × 20 boss 10 high tapered 5° in, a frustum to a 20 − 20 tan 5° square (3660.251034); the Ø16 boss tapered alike, a cone frustum to radius 8 − 10 tan 5° (1798.751833); less the R1 round on a sloping corner, the corner's section r²(cot φ/2 − (π − φ)/2) at its dihedral angle φ = 90.435° times its length between z = 20 and 30 (2.124401), and the R0.5 round all round the cone's top, the section at the rim's 95° turned about the axis by Pappus (1.928463): 69454.950004. SMLib's part measures 69454.950004. The test still fails before that check: Fillet2's saved edge `F4:side:c1#1|F4:top#[F4:side:c1]` names a half of the cone wall truck built, which SMLib builds whole, so it is found with a "was split" warning (a persistent-name question, see the PR). Co-Authored-By: Claude Opus 5.5 --- crates/engine/src/cmd/features_more_tests.rs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/engine/src/cmd/features_more_tests.rs b/crates/engine/src/cmd/features_more_tests.rs index aeb96898d..2c7b0fef6 100644 --- a/crates/engine/src/cmd/features_more_tests.rs +++ b/crates/engine/src/cmd/features_more_tests.rs @@ -1870,8 +1870,14 @@ fn fillets_on_tapered_bosses_saved_before_still_find_their_edges() { let r = s.model.result(id).unwrap(); assert!(r.error.is_none() && r.warning.is_none(), "{name}: {:?} {:?}", r.error, r.warning); } - // The build that saved it measured 69454.885209 mm³. - assert!((volume - 69454.8852092132).abs() < 1e-3, "{volume}"); + // In closed form: the 80 × 40 × 20 block, the 20 × 20 boss 10 high tapered 5° in (a frustum, + // top 20 − 20 tan 5° square: 3660.251034), the Ø16 boss tapered alike (a cone frustum, top + // radius 8 − 10 tan 5°: 1798.751833); less the R1 round along a sloping corner (the corner's + // section, r²(cot φ/2 − (π − φ)/2) at its dihedral angle φ = 90.435°, times its length + // between z = 20 and 30: 2.124401) and the R0.5 round all round the cone's top (the section + // at the rim's 95°, turned about the axis by Pappus: 1.928463). The build that saved it, + // with truck, measured 69454.885209. + assert!((volume - 69454.950004).abs() < 1e-3, "{volume}"); assert_eq!(s.world_state().unwrap().bodies.len(), 1); }