From 976acfd76ced26fce47bcb1c3a056ef4c927a8ae Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Wed, 28 Oct 2026 23:18:10 +0100 Subject: [PATCH] Conversion tests: each ignored case names its solidcore issue (#1431, #1432, #1433) Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt --- crates/smlib/src/core/convert_tests.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/smlib/src/core/convert_tests.rs b/crates/smlib/src/core/convert_tests.rs index fb0ac5547..a40231e9d 100644 --- a/crates/smlib/src/core/convert_tests.rs +++ b/crates/smlib/src/core/convert_tests.rs @@ -158,13 +158,13 @@ macro_rules! primitive { } primitive!(box_, "box"); -primitive!(cylinder, "cylinder", round_trip: ignore = "solidcore: no SmCylinder::IsNurbSurfaceCylinder (nor SmCircle::IsNurbCurveCircle)"); +primitive!(cylinder, "cylinder", round_trip: ignore = "solidcore#1433, #1432: no SmCylinder::IsNurbSurfaceCylinder (nor SmCircle::IsNurbCurveCircle)"); primitive!(sphere, "sphere", - volume: ignore = "solidcore: brep_volume of a sphere fails with SM_ERR at accuracy 1e-8", - round_trip: ignore = "solidcore: no SmCircle::IsNurbCurveCircle"); -primitive!(cone, "cone", round_trip: ignore = "solidcore: no SmCircle::IsNurbCurveCircle"); -primitive!(frustum, "frustum", round_trip: ignore = "solidcore: no SmCircle::IsNurbCurveCircle"); -primitive!(torus, "torus", round_trip: ignore = "solidcore: no SmTorus::IsNurbSurfaceTorus (nor SmCircle::IsNurbCurveCircle)"); + volume: ignore = "solidcore#1431: brep_volume of a sphere fails with SM_ERR at accuracy 1e-8", + round_trip: ignore = "solidcore#1432: no SmCircle::IsNurbCurveCircle"); +primitive!(cone, "cone", round_trip: ignore = "solidcore#1432: no SmCircle::IsNurbCurveCircle"); +primitive!(frustum, "frustum", round_trip: ignore = "solidcore#1432: no SmCircle::IsNurbCurveCircle"); +primitive!(torus, "torus", round_trip: ignore = "solidcore#1433, #1432: no SmTorus::IsNurbSurfaceTorus (nor SmCircle::IsNurbCurveCircle)"); #[test] fn hostile_arrays_are_refused() {