From 7da12cb981cd0fead76bd30154927c8a0267af0e Mon Sep 17 00:00:00 2001 From: bherbruck Date: Thu, 5 Nov 2026 19:04:20 -0500 Subject: [PATCH] Known failures: drop the seven tests 9856ffee5 fixes; ladder housing recorded Pass at the new pin, off the list: the four issue_851 two-round cases, a_round_next_to_a_round_of_another_radius, a_propagated_chain_that_cannot_build_says_how_to_blend_the_edge_alone and fillet_takes_exactly_the_picked_edges (the smooth-vertex End solidcore#2364 brought is gone). The ladder golden is main's again for 07-fillets/012 and 021, which build as at 8ddce9016; 11-cumulative-parts/004-housing is recorded failing at the new pin. Co-Authored-By: Claude Opus 5.5 --- tests/KNOWN_FAILING_TESTS | 7 ------- tests/kernel-cases/ladder/golden.json | 14 +++++++------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/tests/KNOWN_FAILING_TESTS b/tests/KNOWN_FAILING_TESTS index 61cc531c1..f8196f19b 100644 --- a/tests/KNOWN_FAILING_TESTS +++ b/tests/KNOWN_FAILING_TESTS @@ -10,7 +10,6 @@ solidcraft-cli::action_matrix::action_matrix_sample 3 baseline actions fail, the same 3 as on C++: 2 shells (Bad Loop Orient on issue-616-lid-ribs; status 1001 on filleted-shelled-box), 1 fillet (SmSurfOfRevolution Test #7 on oblique_cut_of_cylinder) solidcraft-cli::model_cache::a_later_round_after_opening_blends_the_saved_rounds_again the later r3 round at the r2 mitre builds 7927.724283 since solidcore#2382 (a9ef4c707, the least-certifying setback scale); the test wants SMLib f916a8d's setback corner (smlib#104), 15 faces, 7928.142563938, which solidcore#2369 built (7928.142564) solidcraft-cli::naming_corpus::corpus_designs_name_alike_every_build_and_fail_where_a_reference_is_gone oracle/83-boundary-loop-thicken does not load: step 8, thicken status 1001, as on C++ -solidcraft-doc::eval::chain_tests::a_propagated_chain_that_cannot_build_says_how_to_blend_the_edge_alone with tangent_chain off the r3 round builds 9 faces, the test wants 8, since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d solidcraft-doc::eval::cost_tests::a_tap_marking_searches_only_the_bodies_near_it main's mesh-based version (#10303) not taken; the exact replacement is to come solidcraft-doc::eval::cost_tests::a_tap_marking_still_searches_the_bodies_within_its_reach main's mesh-based version (#10303) not taken; the exact replacement is to come solidcraft-engine::boolean_regression_tests::box_intersect_splits_the_end_off_a_raked_wedge_after_its_end_rounds the wedge's end rounds fail status 1001 since solidcore#2480 (819a5ad3a, the procedural blend record); passes at 7906d0d0c @@ -31,7 +30,6 @@ solidcraft-engine::tests::robustness::a_boundary_found_across_a_seam_is_not_used solidcraft-engine::tests::robustness::fillet_into_an_earlier_round the r3 round into the r2 round measures 35923.387 against the closed form 35919.524 (within 2 wanted) since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d solidcraft-kernel::blend::corner_tests::a_round_ending_in_an_earlier_round_matches_both_together fillet status 1001 on the round that ends in the earlier one, as on C++ solidcraft-kernel::blend::corner_tests::corner_blends_hold_at_any_scale at 0.01x the arc case's rounds remove 72.783 (scaled back) against 72.713 at 1x, as on C++ -solidcraft-kernel::blend_corner::tests::a_round_next_to_a_round_of_another_radius the r3 round ending on the r2 round makes 9 faces, the test wants 8, since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d solidcraft-kernel::blend_corner::tests::issue2422_vertical_after_separate_bottom_rounds the vertical edge after the separate bottom rounds is refused as smooth ("its faces meet tangentially, so there is nothing to round"): the rounds leave it tangent at solidcore 8ddce9016 solidcraft-kernel::blend_smlib::tests::smooth_edges_and_unfinished_tangent_chains_are_refused_saying_why the r1 top round alone measures 7957.723 against the closed form 7957.505 since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d solidcraft-kernel::blend_variable::tests::variable_radius_with_a_corner_through_a_middle_point solidcore refuses a variable fillet whose law has a corner (solidcore#430) @@ -39,13 +37,8 @@ solidcraft-kernel::corner_g2::tests::a_long_setback_keeps_the_g2_patch_inside_th solidcraft-kernel::corner_g2::tests::curvature_rounds_meet_at_a_g2_corner the corner between curvature rounds jumps 2.07 in curvature over 538 stations on solidcore; the test wants it curvature continuous, as SMLib f916a8d's setback corner (smlib#104), which solidcore ports in solidcore#2310 builds it solidcraft-kernel::corner_g2::tests::the_box_corner_g2_patch_is_a_closed_solid_curvature_continuous_to_its_neighbours the fitted G2 corner patch bulges 1.7e-5 past the box, as on C++ solidcraft-kernel::fillet_setback_tests::a_setback_not_past_the_radius_is_refused_naming_the_least solidcore builds setback 5.5 (15 faces) where SMLib f916a8d's setback corner (smlib#104), which solidcore ports in solidcore#2310 refuses it naming the least that builds; nothing names the least setback on solidcore until then -solidcraft-kernel::issue_851_tests::blend_the_arc_top_edge_and_the_top_front_edge the arc then the front removes 59.148 against 60.122 since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d -solidcraft-kernel::issue_851_tests::fillet_the_arc_top_edge_and_the_front_upright_at_the_arc the arc then the upright removes 31.497 against 32.310 since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d -solidcraft-kernel::issue_851_tests::fillet_the_top_front_edge_and_the_front_left_upright the top front then the upright removes 42.236 against 43.187 since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d -solidcraft-kernel::issue_851_tests::fillet_the_top_front_edge_and_the_front_upright_at_the_arc the top front then the upright removes 41.341 against 42.146 since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d solidcraft-kernel::native::tests::box_and_fillet_have_stable_wire_records the box-edge round's wire record differs from the fixture at solidcore 8ddce9016 (a value 3 is 5): the fixture is re-blessed (NATIVE_BREP_BLESS=1) once the change is shown right solidcraft-kernel::tests::fillet_partial_mixed_arc_and_line_perimeter_run the partial arc-and-line run fails status 1001 since solidcore#2480 (819a5ad3a, the procedural blend record); passes at 7906d0d0c solidcraft-kernel::tests::fillet_tabbed_plate_outer_loop_and_partial_selection_after_hole the tabbed plate's outer-loop rounds fail status 1001 since solidcore#2480 (819a5ad3a, the procedural blend record); passes at 7906d0d0c solidcraft-smlib::core::blend_tests::tabbed_plate_rounds_mitred_on_the_arcs_continuation the rounds fail status 1001 since solidcore#2480 (819a5ad3a, the procedural blend record); passes at 7906d0d0c solidcraft-smlib::ops::tests::a_variable_round_with_a_corner_in_its_law_is_its_balls_union solidcore refuses a variable fillet whose law has a corner (solidcore#430) -solidcraft-smlib::ops::tests::fillet_takes_exactly_the_picked_edges one picked edge of the rim's tangent chain adds 9 faces, the test wants 1, since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d diff --git a/tests/kernel-cases/ladder/golden.json b/tests/kernel-cases/ladder/golden.json index e1b3c034d..18a66e241 100644 --- a/tests/kernel-cases/ladder/golden.json +++ b/tests/kernel-cases/ladder/golden.json @@ -1822,15 +1822,15 @@ }, "ladder/11-cumulative-parts/004-housing": { "measured": { - "area_mm2": 21105.287553425696, + "area_mm2": 21156.77865711942, "body_count": 1, - "edges": 210, - "faces": 78, - "vertices": 139, - "volume_mm3": 15138.519861452509 + "edges": 218, + "faces": 81, + "vertices": 144, + "volume_mm3": 15111.545095711903 }, "seconds": 4.128625132, - "status": "pass" + "status": "fail" }, "ladder/12-sheet-metal/001-base-flange": { "measured": { @@ -2001,5 +2001,5 @@ "status": "pass" } }, - "reason": "a modelled external thread running a whole face to a shoulder now runs on through the plane of the face end and is trimmed there (#11610): 06-threads/004, 007, 010, 025, 026 and 11-cumulative-parts/003 gain the faces of the trimmed last turn, their volumes worked out again by hand; every other case as before. Before: 04-spline-profiles/009 and 012 re-recorded, an extruded spline or ellipse sweeps one wall (one-curve extrude): 009 makes 3 faces, 3 edges and 2 vertices (8, 18 and 12 per span before); 012 makes 28 faces, 78 edges and 52 vertices (31, 86 and 57 before); every other case as before. Before: recorded at solidcore 8ddce9016: 06-threads/018 makes 606 edges and 404 vertices (486 and 324 at 97ed188db), its 204 faces, area and volume the same to 1e-11; every other case as before. Before: recorded on solidcore, the only kernel since the C++ SMLib kernel was removed (the golden before was C++ SMLib v1.1.0-alpha, a18bbe5): 07-fillets/012 passes (the variable round no longer gains the End at the smooth vertex: 8 faces, 18 edges, 12 vertices, 47755.12 mm3); 07-fillets/021 has 24 edges and 15 vertices (no End cap edge); 07-fillets/013 removes 47325.53 mm3; 06-threads/018 makes 486 edges and 324 vertices every run, so it is no longer marked unstable" + "reason": "solidcore pin 9856ffee5: 11-cumulative-parts/004-housing fails, 81 faces, 218 edges and 144 vertices (78, 210 and 139 before) and 15111.545 mm3 against its answer 15138.533; every other case as before. Before: a modelled external thread running a whole face to a shoulder now runs on through the plane of the face end and is trimmed there (#11610): 06-threads/004, 007, 010, 025, 026 and 11-cumulative-parts/003 gain the faces of the trimmed last turn, their volumes worked out again by hand; every other case as before. Before: 04-spline-profiles/009 and 012 re-recorded, an extruded spline or ellipse sweeps one wall (one-curve extrude): 009 makes 3 faces, 3 edges and 2 vertices (8, 18 and 12 per span before); 012 makes 28 faces, 78 edges and 52 vertices (31, 86 and 57 before); every other case as before. Before: recorded at solidcore 8ddce9016: 06-threads/018 makes 606 edges and 404 vertices (486 and 324 at 97ed188db), its 204 faces, area and volume the same to 1e-11; every other case as before. Before: recorded on solidcore, the only kernel since the C++ SMLib kernel was removed (the golden before was C++ SMLib v1.1.0-alpha, a18bbe5): 07-fillets/012 passes (the variable round no longer gains the End at the smooth vertex: 8 faces, 18 edges, 12 vertices, 47755.12 mm3); 07-fillets/021 has 24 edges and 15 vertices (no End cap edge); 07-fillets/013 removes 47325.53 mm3; 06-threads/018 makes 486 edges and 324 vertices every run, so it is no longer marked unstable" }