From 6e5722af98a284c86fa18f700d2b92821de7cf82 Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Thu, 29 Oct 2026 09:05:14 +0100 Subject: [PATCH] solidcore: move the pin to fa3caa94 (main, with solidcore#1463: a revolve's cylinder is never inside out, and an inside-out NURB cylinder keeps its frame) Turns on the new flag nurb_cylinder_inside_out_frame. Also brings solidcore PR #1460 (SmSurface::AssertValid and the surface checks, part of #1419). Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- Cargo.lock | 2 +- Cargo.toml | 2 +- crates/smlib/src/core.rs | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index d7ab4da38..40e9d861d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4054,7 +4054,7 @@ dependencies = [ [[package]] name = "solidcore" version = "0.0.1" -source = "git+https://github.com/tangency-labs/solidcore?rev=2a47645e9c289f35619bf97401857b5aafa67fc0#2a47645e9c289f35619bf97401857b5aafa67fc0" +source = "git+https://github.com/tangency-labs/solidcore?rev=fa3caa94760625a65bfe6390531d62d5e8b770db#fa3caa94760625a65bfe6390531d62d5e8b770db" dependencies = [ "thiserror 2.0.21", ] diff --git a/Cargo.toml b/Cargo.toml index ed1c14f6b..86aa24b9f 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -35,7 +35,7 @@ solidcraft-3dx-client = { path = "crates/threedx-client" } # they reach parity (crates/smlib/src/route.rs). Pinned; move the rev on its own commit. For a # local checkout, add `[patch."https://github.com/tangency-labs/solidcore"] solidcore = { path = # "../solidcore/crates/solidcore" }` to a `.cargo/config.toml` outside the repository. -solidcore = { git = "https://github.com/tangency-labs/solidcore", rev = "2a47645e9c289f35619bf97401857b5aafa67fc0" } +solidcore = { git = "https://github.com/tangency-labs/solidcore", rev = "fa3caa94760625a65bfe6390531d62d5e8b770db" } # foundation thiserror = "2" diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index 6dc9d27f5..4459b82f6 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -90,6 +90,7 @@ pub(crate) fn fixes() -> UpstreamFixes { f.offset_walls_touch_refused = true; f.offset_analytic_mate_edges = true; f.precise_properties_split_at_surface_knots = true; + f.nurb_cylinder_inside_out_frame = true; f.offset_collapsed_rounds_mated = true; f.offset_missing_surface_fails = true; f.fillet_nx1_end_rib_global_merge = true;