From 6a06226ad95a843da849cdfe47d64eb524e6a5ac Mon Sep 17 00:00:00 2001 From: jyviko <2501648+jyviko@users.noreply.github.com> Date: Thu, 29 Oct 2026 09:38:45 -0400 Subject: [PATCH] UI tests: the split face's isocurve pieces are each wider than the lines' spacing isocurves_of_a_split_face_run_on_across_the_split split the box's front face at x = -2 and 22, leaving an 8 mm piece. Since a body's size counts its edges (the boss's rims reach y = -32 and z = 50), the lines' spacing grew to 10 (x = -20, -10 on the left piece), and the 8 mm piece had no line up it to compare. The boss now leaves pieces x < -6 and x > 18, room for two lines and one: the test still checks that both pieces' lines lie on one ladder. Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/src/viewport.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/crates/ui-egui/src/viewport.rs b/crates/ui-egui/src/viewport.rs index b796e7011..86eeba081 100644 --- a/crates/ui-egui/src/viewport.rs +++ b/crates/ui-egui/src/viewport.rs @@ -6063,10 +6063,12 @@ mod tests { fn isocurves_of_a_split_face_run_on_across_the_split() { let mut h = crate::scenario::Harness::new(); h.app.run("solid.box", json!({"length": 60, "width": 40, "height": 30, "center": [0, 0, 15]})).unwrap(); - // Through the front face from bottom to top: the face is left in two pieces, x < -2 and x > 22. - h.app.run("solid.cylinder", json!({"radius": 12, "height": 50, "base": [10, -20, 0], "operation": "join"})).unwrap(); + // Through the front face from bottom to top: the face is left in two pieces, x < -6 and + // x > 18, wide enough for two and one of the lines (10 apart: the body with the boss is + // 60 x 52 x 50). + h.app.run("solid.cylinder", json!({"radius": 12, "height": 50, "base": [6, -20, 0], "operation": "join"})).unwrap(); h.settle(); - h.app.run("inspect.isocurve", json!({"faces": [[-16, -20, 15], [26, -20, 15]]})).unwrap(); + h.app.run("inspect.isocurve", json!({"faces": [[-18, -20, 15], [24, -20, 15]]})).unwrap(); let faces = h.app.session.isocurve_lines(); assert_eq!(faces.len(), 2, "{:?}", h.app.status); // Each piece's lines up the face (x held) and across it (z held), by where they are held.