From 5d8bd85b7d649e0bf729a40d8d4babc8ad711bec Mon Sep 17 00:00:00 2001 From: bherbruck Date: Thu, 5 Nov 2026 18:20:51 -0500 Subject: [PATCH] Fillet rig: four cases #11875 listed pass at 9856ffee5 1080-fillet-notched-block-top-outline-r8, 1207-fillet-box-end-edge-into-unblended-round-partial-chain, 5158-fillet-adjacent-plate-edges-as-thick-as-plate and every-fillet-after-fillet-curvature-front-then-side-r3-partial-chain meet their continuity again: the smooth-vertex End solidcore#2364 brought is gone from them at the new pin. Co-Authored-By: Claude Opus 5.5 --- tests/kernel-cases/fillets/KNOWN_FAILING | 6 +----- tests/kernel-cases/ladder/golden.json | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/tests/kernel-cases/fillets/KNOWN_FAILING b/tests/kernel-cases/fillets/KNOWN_FAILING index 61430fa31..93874509f 100644 --- a/tests/kernel-cases/fillets/KNOWN_FAILING +++ b/tests/kernel-cases/fillets/KNOWN_FAILING @@ -1,15 +1,12 @@ # The fillets cases that fail today on solidcore, one a line: ` `. Sorted. # The kernel rig gate fails on a case that fails and is not listed, and on a listed case that passes. -# Baseline: solidcore pin 5d2635d36, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux. +# Baseline: solidcore pin 9856ffee5, tests/kernel-cases run by `cargo xtask kernel-cases`, x86_64 Linux. 1080-fillet-equal-slope-basin-1-mm-rim-loop-4 [fail] continuity_order: got {'body': 'Slab', 'edges': 'blend', 'order': 'g0', want >= g1 at every blend seam -1080-fillet-notched-block-top-outline-r8 [fail] continuity_order: g0, a blend seam meets at 90 degrees, want >= g1 at every blend seam; 15 faces (13 before) since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d 1080-fillet-sloped-basin-1-mm-rim-r4-2-edges [fail] continuity_order: got {'body': 'Slab', 'edges': 'blend', 'order': 'g0', want >= g1 at every blend seam 1080-fillet-sloped-basin-1-mm-rim-r4-4-edges [fail] continuity_order: got {'body': 'Slab', 'edges': 'blend', 'order': 'g0', want >= g1 at every blend seam -1207-fillet-box-end-edge-into-unblended-round-partial-chain [fail] continuity_order: g0, a contact seam meets at 90 degrees, want >= g1 at every blend seam; 9 faces (8 before) since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d 2893-chamfer-distance-and-angle-past-the-wall-refused [fail] refused, but not because "angle": step 2 (solid.chamfer): SMLib chamfer: operation: SMLib rejected the input (SM_ERR_INVALID_INPUT) 2893-chamfer-two-distances-elliptical-rim [fail] refused, but not because "not supported yet": step 3 (solid.chamfer): SMLib chamfer: operation: SMLib failed (status 1001) (tangent propagation blended the picked edges' tangent chain with them; with it off, tangent_chain: 4782-fillet-bar-edge-wider-than-both-faces [fail] continuity_order: got Box: no null seams want >= g1 at every blend seam -5158-fillet-adjacent-plate-edges-as-thick-as-plate [fail] continuity_order: g0, a contact seam meets at 90 degrees, want >= g1 at every blend seam; 10 faces (8 before) since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d 9-fillet-corner-curvature-with-reduce-fit [unsupported] solid.fillet builds `corner: g2` with `fit: exact` only 9-fillet-corner-curvature-with-taper-fit [unsupported] solid.fillet builds `corner: g2` with `fit: exact` only cov-fillet-g2-corner-beside-a-cylinder [fail] step 6 (solid.fillet): the open setback corner is not a closed solid, as on SMLib d01d7b0 @@ -22,7 +19,6 @@ cov-junction-boss-tilt-20-root-round [fail] fillet status 1001 on a cylinder til cov-junction-tee-equal-round [fail] the result is not a closed solid, as on SMLib: equal pipes' intersection is two plane ellipses crossing, a corner the old corner code cannot join (the corner step) cov-junction-y-junction-120-round [unsupported] refused as on SMLib: the faces between the three intersection curves narrow to nothing at the two triple points, so the room check trips (the corner step) every-block-cylinder-tangent-concave-arc-r2-partial-chain [fail] continuity_order: g0, a contact seam meets at 90 degrees, want >= g1 at every blend seam since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d -every-fillet-after-fillet-curvature-front-then-side-r3-partial-chain [fail] continuity_order: g0, a contact seam meets at 90 degrees, want >= g2 at every blend seam since solidcore#2364 (845bdb4e0, the smooth-vertex End); passes at fb937dd8d report-drafted-peg-front-and-concave-rounds-together-r2 [unsupported] step 13 (solid.fillet): invalid input: not supported yet: the fillet meets a corner of this kind, which SMLib's blends do not handle yet (where its ed report-fillet-curvature-three-edges-at-bar-corner [fail] continuity_order: G1 at one seam where the corner patch meets a contact face (g2 wanted), as on SMLib d01d7b0 (see KNOWN_FAILING) report-fillet-curvature-three-edges-at-bar-corner-solver-residues [fail] continuity_order: G1 at one seam where the corner patch meets a contact face (g2 wanted), as on SMLib d01d7b0 (see KNOWN_FAILING) diff --git a/tests/kernel-cases/ladder/golden.json b/tests/kernel-cases/ladder/golden.json index 488e82e3b..e1b3c034d 100644 --- a/tests/kernel-cases/ladder/golden.json +++ b/tests/kernel-cases/ladder/golden.json @@ -1318,15 +1318,15 @@ }, "ladder/07-fillets/012-variable-into-rounded-corner": { "measured": { - "area_mm2": 8680.795661185239, + "area_mm2": 8665.945693077198, "body_count": 1, - "edges": 20, - "faces": 9, - "vertices": 13, - "volume_mm3": 47770.94594616632 + "edges": 18, + "faces": 8, + "vertices": 12, + "volume_mm3": 47755.118560933464 }, "seconds": 0.08138784, - "status": "fail" + "status": "pass" }, "ladder/07-fillets/013-corner-setback": { "measured": { @@ -1402,12 +1402,12 @@ }, "ladder/07-fillets/021-corner-three-sequential-r5-r3-r2-partial-chain": { "measured": { - "area_mm2": 8593.662753693226, + "area_mm2": 8591.67500897809, "body_count": 1, - "edges": 25, + "edges": 24, "faces": 11, - "vertices": 16, - "volume_mm3": 47591.48201214169 + "vertices": 15, + "volume_mm3": 47589.77046707538 }, "seconds": 0.091579704, "status": "pass" @@ -2001,5 +2001,5 @@ "status": "pass" } }, - "reason": "07-fillets/012 and 021 re-recorded at solidcore 5d2635d36, both from solidcore#2364 (the smooth-vertex End): 012's variable round into the rounded corner fails (9 faces, 20 edges, 13 vertices against 8, 18 and 12; 47770.946 mm3 against its answer 47755.126); 021 makes 25 edges and 16 vertices (24 and 15 before) and 47591.482 mm3 (47589.770 before); times as before. Before: a modelled external thread running a whole face to a shoulder now runs on through the plane of the face end and is trimmed there (#11610): 06-threads/004, 007, 010, 025, 026 and 11-cumulative-parts/003 gain the faces of the trimmed last turn, their volumes worked out again by hand; every other case as before. Before: 04-spline-profiles/009 and 012 re-recorded, an extruded spline or ellipse sweeps one wall (one-curve extrude): 009 makes 3 faces, 3 edges and 2 vertices (8, 18 and 12 per span before); 012 makes 28 faces, 78 edges and 52 vertices (31, 86 and 57 before); every other case as before. Before: recorded at solidcore 8ddce9016: 06-threads/018 makes 606 edges and 404 vertices (486 and 324 at 97ed188db), its 204 faces, area and volume the same to 1e-11; every other case as before. Before: recorded on solidcore, the only kernel since the C++ SMLib kernel was removed (the golden before was C++ SMLib v1.1.0-alpha, a18bbe5): 07-fillets/012 passes (the variable round no longer gains the End at the smooth vertex: 8 faces, 18 edges, 12 vertices, 47755.12 mm3); 07-fillets/021 has 24 edges and 15 vertices (no End cap edge); 07-fillets/013 removes 47325.53 mm3; 06-threads/018 makes 486 edges and 324 vertices every run, so it is no longer marked unstable" + "reason": "a modelled external thread running a whole face to a shoulder now runs on through the plane of the face end and is trimmed there (#11610): 06-threads/004, 007, 010, 025, 026 and 11-cumulative-parts/003 gain the faces of the trimmed last turn, their volumes worked out again by hand; every other case as before. Before: 04-spline-profiles/009 and 012 re-recorded, an extruded spline or ellipse sweeps one wall (one-curve extrude): 009 makes 3 faces, 3 edges and 2 vertices (8, 18 and 12 per span before); 012 makes 28 faces, 78 edges and 52 vertices (31, 86 and 57 before); every other case as before. Before: recorded at solidcore 8ddce9016: 06-threads/018 makes 606 edges and 404 vertices (486 and 324 at 97ed188db), its 204 faces, area and volume the same to 1e-11; every other case as before. Before: recorded on solidcore, the only kernel since the C++ SMLib kernel was removed (the golden before was C++ SMLib v1.1.0-alpha, a18bbe5): 07-fillets/012 passes (the variable round no longer gains the End at the smooth vertex: 8 faces, 18 edges, 12 vertices, 47755.12 mm3); 07-fillets/021 has 24 edges and 15 vertices (no End cap edge); 07-fillets/013 removes 47325.53 mm3; 06-threads/018 makes 486 edges and 324 vertices every run, so it is no longer marked unstable" }