From 57080f88ce51642677d52b534f696ccb8b80636d Mon Sep 17 00:00:00 2001 From: jyviko <2501648+jyviko@users.noreply.github.com> Date: Fri, 23 Oct 2026 17:01:07 -0400 Subject: [PATCH] fixup! sew: faces and edges on their NURBS forms, their pcurves exact Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm --- crates/geom/src/brep/pcurve.rs | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/crates/geom/src/brep/pcurve.rs b/crates/geom/src/brep/pcurve.rs index ba7cead19..4ecd8b844 100644 --- a/crates/geom/src/brep/pcurve.rs +++ b/crates/geom/src/brep/pcurve.rs @@ -199,17 +199,6 @@ impl On { Ok(On { surface, starts: uv::Starts::default(), dom, face: None }) } - fn surface_kind(&self) -> &'static str { - match &self.surface { - SurfaceEval::Eval(crate::tess::EvalSurface::Plane { .. }, _) => "plane", - SurfaceEval::Cylinder { .. } => "cylinder", - SurfaceEval::Cone { .. } => "cone", - SurfaceEval::Sphere { .. } => "sphere", - SurfaceEval::Torus { .. } => "torus", - _ => "other", - } - } - fn within(self, face: Option<[[f64; 2]; 2]>) -> Self { let face = face.filter(|f| f.iter().flatten().all(|x| x.is_finite())); On { face, ..self } @@ -221,8 +210,7 @@ impl On { { return Ok(pc); } - let _ = tol; - Err(Error::Failed(format!("no exact pcurve: {:?} on {}", std::mem::discriminant(record), self.surface_kind()))) + self.fit(record, curve, range, tol) } /// The closed-form pcurve where there is one (unchecked).