From 4bdffef06180fb3a2e8fbd4b15c7d3f60e55bd11 Mon Sep 17 00:00:00 2001 From: bherbruck Date: Tue, 3 Nov 2026 02:17:58 -0500 Subject: [PATCH] Release: build Arch packages for pre-release versions (#11484) The packaging action can't read a hyphenated version from the tarball's name, so the job gives it a name without the hyphen and renames the package back. A hyphenated version no longer fails the build if its Arch job fails; a plain version still does. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 007de0fab..d1d192344 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -234,6 +234,8 @@ jobs: if: needs.version.outputs.build == 'true' # makepkg only repackages the tarball's prebuilt binaries, so both architectures build here. runs-on: ubuntu-24.04 + # A pre-release or nightly without an Arch package is still worth having; a stable release isn't. + continue-on-error: ${{ contains(needs.version.outputs.version, '-') }} strategy: fail-fast: false matrix: @@ -250,10 +252,29 @@ jobs: # makepkg in an archlinux:base-devel container. The package is named after the tarball's # .desktop file (io.tangencylabs.solidcraft) and written as # dist/release/solidcraft--linux-.pkg.tar.zst. + # An Arch version can't hold a hyphen, and the action reads the version from the tarball's name + # (a hyphenated one comes out as 0.0.0): 0.40.0-rc.1 goes in as 0.40.0rc.1, which pacman sorts + # before 0.40.0, and the package keeps the release's name. + - id: pkgver + name: Arch version + run: | + pkgver="${VERSION//-/}" + echo "pkgver=$pkgver" >>"$GITHUB_OUTPUT" + if [ "$pkgver" != "$VERSION" ]; then + cp "dist/linux/solidcraft-$VERSION-linux-$ARCH.tar.gz" "dist/linux/solidcraft-$pkgver-linux-$ARCH.tar.gz" + fi + env: + ARCH: ${{ matrix.arch }} - uses: storytold/craft-common-actions/actions/arch-package@fa5ef18780cf5e7d5d3b8de068de56cffc83cac5 # main with: - tarball: dist/linux/solidcraft-${{ env.VERSION }}-linux-${{ matrix.arch }}.tar.gz + tarball: dist/linux/solidcraft-${{ steps.pkgver.outputs.pkgver }}-linux-${{ matrix.arch }}.tar.gz arch: ${{ matrix.arch }} + - name: The package under the release's version + if: steps.pkgver.outputs.pkgver != env.VERSION + env: + ARCH: ${{ matrix.arch }} + PKGVER: ${{ steps.pkgver.outputs.pkgver }} + run: sudo mv "dist/release/solidcraft-$PKGVER-linux-$ARCH.pkg.tar.zst" "dist/release/solidcraft-$VERSION-linux-$ARCH.pkg.tar.zst" - name: Check the package env: PKG: dist/release/solidcraft-${{ env.VERSION }}-linux-${{ matrix.arch }}.pkg.tar.zst