From 2e8847512baf43c91ab4e2c407750d6f896b6053 Mon Sep 17 00:00:00 2001 From: bherbruck Date: Fri, 6 Nov 2026 01:29:50 -0500 Subject: [PATCH] Ladder golden: 004-housing as on main again The housing's change at the new pin (81 faces, 15111.545 mm3 against its answer 15138.533, from solidcore#2735) is a regression the gate should show, not record: filed as tangency-labs/solidcore#2908. Co-Authored-By: Claude Opus 5.5 --- tests/kernel-cases/ladder/golden.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kernel-cases/ladder/golden.json b/tests/kernel-cases/ladder/golden.json index 9cf2edb18..e1b3c034d 100644 --- a/tests/kernel-cases/ladder/golden.json +++ b/tests/kernel-cases/ladder/golden.json @@ -1822,15 +1822,15 @@ }, "ladder/11-cumulative-parts/004-housing": { "measured": { - "area_mm2": 21156.77865711942, + "area_mm2": 21105.287553425696, "body_count": 1, - "edges": 218, - "faces": 81, - "vertices": 144, - "volume_mm3": 15111.545095711903 + "edges": 210, + "faces": 78, + "vertices": 139, + "volume_mm3": 15138.519861452509 }, "seconds": 4.128625132, - "status": "fail" + "status": "pass" }, "ladder/12-sheet-metal/001-base-flange": { "measured": { @@ -2001,5 +2001,5 @@ "status": "pass" } }, - "reason": "solidcore pin 9856ffee5: 11-cumulative-parts/004-housing fails since solidcore#2735 (the M16 groove cut grazing the boss's root round is now valid), 81 faces, 218 edges and 144 vertices (78, 210 and 139 before) and 15111.545 mm3 against its answer 15138.533; every other case as before. Before: a modelled external thread running a whole face to a shoulder now runs on through the plane of the face end and is trimmed there (#11610): 06-threads/004, 007, 010, 025, 026 and 11-cumulative-parts/003 gain the faces of the trimmed last turn, their volumes worked out again by hand; every other case as before. Before: 04-spline-profiles/009 and 012 re-recorded, an extruded spline or ellipse sweeps one wall (one-curve extrude): 009 makes 3 faces, 3 edges and 2 vertices (8, 18 and 12 per span before); 012 makes 28 faces, 78 edges and 52 vertices (31, 86 and 57 before); every other case as before. Before: recorded at solidcore 8ddce9016: 06-threads/018 makes 606 edges and 404 vertices (486 and 324 at 97ed188db), its 204 faces, area and volume the same to 1e-11; every other case as before. Before: recorded on solidcore, the only kernel since the C++ SMLib kernel was removed (the golden before was C++ SMLib v1.1.0-alpha, a18bbe5): 07-fillets/012 passes (the variable round no longer gains the End at the smooth vertex: 8 faces, 18 edges, 12 vertices, 47755.12 mm3); 07-fillets/021 has 24 edges and 15 vertices (no End cap edge); 07-fillets/013 removes 47325.53 mm3; 06-threads/018 makes 486 edges and 324 vertices every run, so it is no longer marked unstable" + "reason": "a modelled external thread running a whole face to a shoulder now runs on through the plane of the face end and is trimmed there (#11610): 06-threads/004, 007, 010, 025, 026 and 11-cumulative-parts/003 gain the faces of the trimmed last turn, their volumes worked out again by hand; every other case as before. Before: 04-spline-profiles/009 and 012 re-recorded, an extruded spline or ellipse sweeps one wall (one-curve extrude): 009 makes 3 faces, 3 edges and 2 vertices (8, 18 and 12 per span before); 012 makes 28 faces, 78 edges and 52 vertices (31, 86 and 57 before); every other case as before. Before: recorded at solidcore 8ddce9016: 06-threads/018 makes 606 edges and 404 vertices (486 and 324 at 97ed188db), its 204 faces, area and volume the same to 1e-11; every other case as before. Before: recorded on solidcore, the only kernel since the C++ SMLib kernel was removed (the golden before was C++ SMLib v1.1.0-alpha, a18bbe5): 07-fillets/012 passes (the variable round no longer gains the End at the smooth vertex: 8 faces, 18 edges, 12 vertices, 47755.12 mm3); 07-fillets/021 has 24 edges and 15 vertices (no End cap edge); 07-fillets/013 removes 47325.53 mm3; 06-threads/018 makes 486 edges and 324 vertices every run, so it is no longer marked unstable" }