From 2647b12e55a7743f211c1b9c128129e818bb33a3 Mon Sep 17 00:00:00 2001 From: brett19 Date: Sat, 31 Oct 2026 08:12:56 -0700 Subject: [PATCH] Hold back fillet_refuse_crossing_rails: not in the fork The fork has no such check: SmFilletExecutive.cpp:3654 stops overlapping bands, which stays on. Off, 5 of the 12 action-matrix failures on solidcore pass (oracle/28, 30, 36, 54, typical/filleted-shelled-box's fillet), each failing with the flag's closest-point query's 1001; the rig does not move. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- crates/smlib/src/core.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index a5642bd4e..68d628c33 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -71,7 +71,6 @@ pub(crate) fn fixes() -> UpstreamFixes { f.fillet_refuse_rails_leaving_faces = true; f.fillet_refuse_face_consuming_blends = true; f.fillet_refuse_non_manifold_result = true; - f.fillet_refuse_crossing_rails = true; f.fillet_vertex_error_diagnostics = true; f.fillet_corner_ball_patch = true; f.fillet_chamfer_cone_on_arc = true; @@ -299,7 +298,10 @@ pub(crate) fn fixes() -> UpstreamFixes { /// The fork has no such code: `offset_splits_corner_vertices` (WR-657: `CloseLoopGaps` splits no /// corner and an offset's result is not refused for being open), `defeature_refuses_open_base` /// (WR-656: `DoDefeature` drops `BuildPatches`' outcome) and `ssi_start_loop_trace_budget` (HANG-52: -/// `DoIntersection`'s start-point loop has no budget). +/// `DoIntersection`'s start-point loop has no budget). `fillet_refuse_crossing_rails` (WR-460: "not +/// upstream"; the fork stops such rounds with the overlapping bands' check, SmFilletExecutive.cpp:3654, +/// and refuses a result that is no closed solid) also fails sound rounds, with the closest-point +/// query's 1001 (a box's top loop, R4 on R8 corners). /// /// On since `SMLIB_REV` eaa998a: `fillet_trim_inside_by_best_dot` (fork de4dae6), /// `fillet_half_degree_crease` (2e8758b), `fillet_split_edge_keeps_near_half` (ceb3272) and @@ -356,6 +358,7 @@ const HELD_BACK: &[&str] = &[ "analytic_corner_failure_is_false", "defeature_refuses_open_base", "ssi_start_loop_trace_budget", + "fillet_refuse_crossing_rails", ]; fn fresh() -> Kernel {