From 22a1c20b1d79e39178db5f3b18f133ad858b60cb Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Thu, 29 Oct 2026 21:23:31 +0100 Subject: [PATCH] solidcore: move the pin to b3baca8e (main, with solidcore#1490 and #1491: a revolve's torus is never inside out and keeps the flag, and a one-circle full turn puts its seam at the profile) Turns on the new flags torus_keeps_inside_out and internal_pole_row_through_knot. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- Cargo.lock | 2 +- Cargo.toml | 2 +- crates/smlib/src/core.rs | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 8fd086d56..6e64d53a9 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4054,7 +4054,7 @@ dependencies = [ [[package]] name = "solidcore" version = "0.0.1" -source = "git+https://github.com/tangency-labs/solidcore?rev=b19dbcb521f13c522c8dbf7f7802219597c7a54b#b19dbcb521f13c522c8dbf7f7802219597c7a54b" +source = "git+https://github.com/tangency-labs/solidcore?rev=b3baca8e077ac58465b4446ab5e4157cf27d17c3#b3baca8e077ac58465b4446ab5e4157cf27d17c3" dependencies = [ "thiserror 2.0.21", ] diff --git a/Cargo.toml b/Cargo.toml index f61ba689a..75fdb4911 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -35,7 +35,7 @@ solidcraft-3dx-client = { path = "crates/threedx-client" } # they reach parity (crates/smlib/src/route.rs). Pinned; move the rev on its own commit. For a # local checkout, add `[patch."https://github.com/tangency-labs/solidcore"] solidcore = { path = # "../solidcore/crates/solidcore" }` to a `.cargo/config.toml` outside the repository. -solidcore = { git = "https://github.com/tangency-labs/solidcore", rev = "b19dbcb521f13c522c8dbf7f7802219597c7a54b" } +solidcore = { git = "https://github.com/tangency-labs/solidcore", rev = "b3baca8e077ac58465b4446ab5e4157cf27d17c3" } # foundation thiserror = "2" diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index ba1932a61..dcd221b16 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -98,6 +98,8 @@ pub(crate) fn fixes() -> UpstreamFixes { f.fillet_nx1_opposite_continuation_side_edge = true; f.fillet_trace_rejects_short_step = true; f.torus_iso_circle_axis_from_midpoint = true; + f.torus_keeps_inside_out = true; + f.internal_pole_row_through_knot = true; f.offset_collapsed_rounds_mated = true; f.offset_missing_surface_fails = true; f.fillet_nx1_end_rib_global_merge = true;