From 0bed45d82ca8339910533e6d8ecdee68f29e1634 Mon Sep 17 00:00:00 2001 From: Brett Lawson Date: Fri, 30 Oct 2026 13:55:13 +0100 Subject: [PATCH] smlib: solidcore's planar thicken side walls opt-in is on; four opt-ins wait for the fork thicken_planar_side_walls (WR-564, solidcore#1665) is on: its fork commit, smlib@d384e86, is in SMLIB_REV. fillet_torus_span_from_start_section (smlib@985faae), fillet_knife_edge_rounds (smlib@b7ec55b), taper_wall_closes_at_apex (smlib@183ea65) and revolution_round_offset_collapses (smlib@8b2090f) are past SMLIB_REV, so they go on HELD_BACK. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- crates/smlib/src/core.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index b77b46156..149968c46 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -180,14 +180,24 @@ pub(crate) fn fixes() -> UpstreamFixes { f.local_operation_step_walls = true; f.edge_check_orders_tangent_faces = true; f.revolve_arc_touching_axis_is_horn_torus = true; + f.thicken_planar_side_walls = true; f } /// Opt-in fixes left off because the C++ fork (`SMLIB_REV`) does not carry them yet, so turning /// them on would part this backend from the C++ one. `precise_properties_trim_base_v` -/// (solidcore#1664, WR-563) has no fork commit. +/// (solidcore#1664, WR-563) has no fork commit; the others' fork commits are past `SMLIB_REV`: +/// `fillet_torus_span_from_start_section` (WR-568, smlib@985faae), `fillet_knife_edge_rounds` +/// (WR-570, smlib@b7ec55b), `taper_wall_closes_at_apex` (WR-571, smlib@183ea65) and +/// `revolution_round_offset_collapses` (WR-567, smlib@8b2090f). #[cfg(test)] -const HELD_BACK: &[&str] = &["precise_properties_trim_base_v"]; +const HELD_BACK: &[&str] = &[ + "precise_properties_trim_base_v", + "fillet_torus_span_from_start_section", + "fillet_knife_edge_rounds", + "taper_wall_closes_at_apex", + "revolution_round_offset_collapses", +]; fn fresh() -> Kernel { let mut k = Kernel::new(&KernelOptions::default());