From 0b48548af02bfb7e7603448a2d49ee73fd937885 Mon Sep 17 00:00:00 2001 From: brett19 Date: Sat, 31 Oct 2026 15:57:25 -0700 Subject: [PATCH] Turn on solidcore's new fixes and take the rational-span flag off HELD_BACK New on: fillet_exact_round_classes, curve_check_zero_speed_tangent_end, cpoly_remove_poly_face_check_member, check_seam_crossing_unclosed, ascii_doubles_round_trip. bspline_trim_keeps_rational_end_spans: sheet-metal/3078 passes its check with it on since solidcore#2097, volume unchanged (31362.04580633055). geometric_g2_continuity stays held: the fix for solidcore#2091 (#2108) has not merged. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk --- crates/smlib/src/core.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/smlib/src/core.rs b/crates/smlib/src/core.rs index ebc27d60f..9c2619d3f 100644 --- a/crates/smlib/src/core.rs +++ b/crates/smlib/src/core.rs @@ -301,6 +301,12 @@ pub(crate) fn fixes() -> UpstreamFixes { f.fillet_refuse_crossing_rails = true; f.proto_edge_split_upper_keeps_the_old_max = true; f.point_on_start_point_squared_tolerance = true; + f.bspline_trim_keeps_rational_end_spans = true; + f.fillet_exact_round_classes = true; + f.curve_check_zero_speed_tangent_end = true; + f.cpoly_remove_poly_face_check_member = true; + f.check_seam_crossing_unclosed = true; + f.ascii_doubles_round_trip = true; f } @@ -311,9 +317,6 @@ pub(crate) fn fixes() -> UpstreamFixes { /// against its closed form is a win. #[cfg(test)] const HELD_BACK: &[&str] = &[ - // sheet-metal/3078-flange-on-the-side-edge-of-a-flange: with it on the body's check fails with - // "SmBSplineCurve::Test #15 Bad Repeated CPts" (volume unchanged, 31362.04580633055); off it passes. - "bspline_trim_keeps_rational_end_spans", // crashes/2992-join-disk-and-36-twisted-loft-blades takes 121 s with it on, 31 s off, run alone on one // machine (the C++ kernel: 26 s), and times out in a loaded rig. The result is the same. "geometric_g2_continuity",