Sketch on a face: project from the model's own body, not a copy that meshes it again (#3981)
A sketch attached to a face is evaluated in the face's frame. When that frame is the body's own, the body was still rebuilt as a new ModelBody with empty mesh cells, so projecting the face's edges display-meshed a throwaway copy and the next cut or join meshed the same body a second time. On a body whose cut edges are slow to mesh this added about a second to each feature after a sketch on a face. In place, the anchored body is now the model's own clone and shares its mesh. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
9b80163421
commit
08eff4f9dd
2 files changed
+21
-2
No files matched your search
@@ -723,3 +723,17 @@ fn a_custom_plane_origin_that_is_not_numbers_is_refused_not_zeroed() {
|
||||
assert_eq!(origin_of(&mut s, json!({"origin": [20, 0, 0], "x_dir": [0, 1, 0], "y_dir": [0, 0, 1]})), json!([20.0, 0.0, 0.0]));
|
||||
assert_eq!(origin_of(&mut s, json!({"x_dir": [0, 1, 0], "y_dir": [0, 0, 1]})), json!([0.0, 0.0, 0.0]));
|
||||
}
|
||||
/// A sketch on a body's face projects that face's edges from the body's display mesh. The body
|
||||
/// it projects from is the model's own, not a copy that meshes it again: on a body whose curved
|
||||
/// edges are slow to mesh, the copy's mesh was thrown away and the next feature meshed the body
|
||||
/// a second time, which made a sketch on a face as slow as a cut.
|
||||
#[test]
|
||||
fn a_sketch_on_a_face_meshes_its_body_once() {
|
||||
let mut s = Session::default();
|
||||
run(&mut s, "solid.box", json!({"length":10,"width":10,"height":10,"body_name":"Base","name":"BaseFeature"}));
|
||||
assert!(s.model.state().body("Base").unwrap().cached_mesh().is_none());
|
||||
let pick = top_pick(&s, "Base");
|
||||
run(&mut s, "sketch.create", json!({"name":"Attached","plane":pick}));
|
||||
run(&mut s, "sketch.finish", json!({}));
|
||||
assert!(s.model.state().body("Base").unwrap().cached_mesh().is_some(), "the sketch's projection meshed a copy of the body");
|
||||
}
|
||||
Reference in new issue
Block a user