From 04955683f8fe27e68ba413b2ce63a9e9c92a862a Mon Sep 17 00:00:00 2001 From: jyviko <2501648+jyviko@users.noreply.github.com> Date: Fri, 30 Oct 2026 12:25:06 -0400 Subject: [PATCH] Tests: a strip's tangent and curvature run-offs are the distance long across the surface SMLib measures an extension's distance across the surface (smlib_extend_sheet corrects CreateExtendedSurface until the parameter line through the side's middle is that long), so each run-off of the cylinder strip, swept 20 along z, adds 5 x 20: 10 pi/2 20 + 100 = 414.159 for both. The parabola-length formula (418.18) was truck's. Ruling d2 (2026-10-30). Co-Authored-By: Claude Opus 5.5 --- crates/engine/src/cmd/surface.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/crates/engine/src/cmd/surface.rs b/crates/engine/src/cmd/surface.rs index 85fbab8f0..e1c054a71 100644 --- a/crates/engine/src/cmd/surface.rs +++ b/crates/engine/src/cmd/surface.rs @@ -1294,8 +1294,9 @@ mod tests { /// Extend a cylinder strip: naturally 5 along its axis (10 · π/2 · 25, one face, still a /// cylinder), up to the plane z = 30 (10 · π/2 · 30), and by tangent and curvature run-offs /// along a straight edge, 20 long: each SMLib's G1 or G2 extension of the surface, so the - /// strip stays one face (the tangent one a flat 5 × 20, the curvature one the parabola - /// s ↦ s·R + ½κs²·n with the cylinder's κ = 1/10, its section ∫₀⁵ √(1 + κ²s²) ds long). + /// strip stays one face. The distance is measured across the surface (the run-off's section + /// is 5 long, whatever its curvature) and the strip is its section swept 20 along z, so each + /// run-off adds 5 × 20: 10 · π/2 · 20 + 100. /// Undo, redo and reopening; the default saves nothing new. #[test] fn extend_a_cylinder_strip_every_way() { @@ -1322,11 +1323,9 @@ mod tests { run(&mut s, "edit.undo", json!({})); let side = [0.0, 10.0, 10.0]; - let k: f64 = 0.1; - let parabola = 2.5 * (1.0 + 25.0 * k * k).sqrt() + (5.0 * k).asinh() / (2.0 * k); - for (mode, run_off) in [("tangent", 5.0), ("curvature", parabola)] { + for mode in ["tangent", "curvature"] { run(&mut s, "surface.extend", json!({"body": "Strip", "edges": [side], "distance": 5, "mode": mode})); - let want = 10.0 * pi / 2.0 * 20.0 + run_off * 20.0; + let want = 10.0 * pi / 2.0 * 20.0 + 5.0 * 20.0; assert!((area(&s, "Strip") - want).abs() < want * 1e-3, "{mode}: {} vs {want}", area(&s, "Strip")); // (measured on meshes) let cold = Session::new(solidcraft_doc::Document::from_json(&s.doc.to_json()).unwrap()); assert!((area(&cold, "Strip") - area(&s, "Strip")).abs() < 1e-9, "{mode}");