1be080403d
When a username or model name is uppercase the registry will reject the push. This is done for file-system compatibility. If we rely on the registry error on push the message returned is 'file not found', which does not convey why the push actually failed.
45 lines
965 B
Go
45 lines
965 B
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/ollama/ollama/api"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestPushModel(t *testing.T) {
|
|
noOpProgress := func(resp api.ProgressResponse) {}
|
|
|
|
tests := []struct {
|
|
modelStr string
|
|
regOpts *registryOptions
|
|
wantErr string
|
|
}{
|
|
{
|
|
modelStr: "http://example.com/namespace/repo:tag",
|
|
regOpts: ®istryOptions{Insecure: false},
|
|
wantErr: "insecure protocol http",
|
|
},
|
|
{
|
|
modelStr: "docker://Example/repo:tag",
|
|
regOpts: ®istryOptions{},
|
|
wantErr: "namespace must be lowercase, but is Example",
|
|
},
|
|
{
|
|
modelStr: "docker://example/Repo:tag",
|
|
regOpts: ®istryOptions{},
|
|
wantErr: "model name must be lowercase, but is Repo",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.modelStr, func(t *testing.T) {
|
|
err := PushModel(context.Background(), tt.modelStr, tt.regOpts, noOpProgress)
|
|
|
|
assert.Error(t, err)
|
|
assert.EqualError(t, err, tt.wantErr)
|
|
})
|
|
}
|
|
}
|