From c98848f1f82c7d1d144fdf1970e34268ca337823 Mon Sep 17 00:00:00 2001 From: unbiasedcodex Date: Sat, 6 Dec 2025 04:23:54 -0300 Subject: [PATCH] cmd: preserve relative paths for files and adapters in CreateHandler Previously, filepath.Base() was used which stripped directory information from file paths, causing issues when files with the same name existed in different subdirectories. The second file would overwrite the first in the map, losing the reference to one of the files. This change preserves the full relative path, fixing the issue described in the TODO comments that were also removed. Fixes #10333 --- cmd/cmd.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cmd/cmd.go b/cmd/cmd.go index d77bb2c58..d08787bda 100644 --- a/cmd/cmd.go +++ b/cmd/cmd.go @@ -147,10 +147,7 @@ func CreateHandler(cmd *cobra.Command, args []string) error { return err } - // TODO: this is incorrect since the file might be in a subdirectory - // instead this should take the path relative to the model directory - // but the current implementation does not allow this - files.Store(filepath.Base(f), digest) + files.Store(f, digest) return nil }) } @@ -162,8 +159,7 @@ func CreateHandler(cmd *cobra.Command, args []string) error { return err } - // TODO: same here - adapters.Store(filepath.Base(f), digest) + adapters.Store(f, digest) return nil }) }