From 5aee34db9f529b0b81ab0ea86b49a4f60b9ef625 Mon Sep 17 00:00:00 2001
From: Eva Ho <hoyyeva@gmail.com>
Date: Wed, 19 Nov 2025 15:57:19 -0500
Subject: [PATCH] fix tests

---
 app/ui/app/src/utils/mergeModels.test.ts | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/app/ui/app/src/utils/mergeModels.test.ts b/app/ui/app/src/utils/mergeModels.test.ts
index 90092182a..990569115 100644
--- a/app/ui/app/src/utils/mergeModels.test.ts
+++ b/app/ui/app/src/utils/mergeModels.test.ts
@@ -14,8 +14,8 @@ describe("Model merging logic", () => {
     const merged = mergeModels(localModels);
 
     // First verify cloud models are first and in FEATURED_MODELS order
-    const cloudModels = FEATURED_MODELS.filter((m: string) =>
-      m.endsWith("cloud"),
+    const cloudModels = FEATURED_MODELS.filter(
+      (m: string) => m.endsWith("cloud") || m === "gemini-3-pro-preview",
     );
     for (let i = 0; i < cloudModels.length; i++) {
       expect(merged[i].model).toBe(cloudModels[i]);
@@ -24,7 +24,7 @@ describe("Model merging logic", () => {
 
     // Then verify non-cloud featured models are next and in FEATURED_MODELS order
     const nonCloudFeatured = FEATURED_MODELS.filter(
-      (m: string) => !m.endsWith("cloud"),
+      (m: string) => !m.endsWith("cloud") && m !== "gemini-3-pro-preview",
     );
     for (let i = 0; i < nonCloudFeatured.length; i++) {
       const model = merged[i + cloudModels.length];
@@ -54,9 +54,9 @@ describe("Model merging logic", () => {
     const cloudModels = merged.filter((m) => m.isCloud());
     expect(cloudModels.length).toBe(0);
 
-    // Should have non-cloud featured models
+    // Should have non-cloud featured models (excluding gemini-3-pro-preview which is treated as cloud)
     const nonCloudFeatured = FEATURED_MODELS.filter(
-      (m) => !m.endsWith("cloud"),
+      (m) => !m.endsWith("cloud") && m !== "gemini-3-pro-preview",
     );
     for (let i = 0; i < nonCloudFeatured.length; i++) {
       const model = merged[i];
@@ -74,7 +74,9 @@ describe("Model merging logic", () => {
     const merged = mergeModels([]);
 
     // First verify cloud models are first and in FEATURED_MODELS order
-    const cloudModels = FEATURED_MODELS.filter((m) => m.endsWith("cloud"));
+    const cloudModels = FEATURED_MODELS.filter(
+      (m) => m.endsWith("cloud") || m === "gemini-3-pro-preview",
+    );
     for (let i = 0; i < cloudModels.length; i++) {
       expect(merged[i].model).toBe(cloudModels[i]);
       expect(merged[i].isCloud()).toBe(true);
@@ -82,7 +84,7 @@ describe("Model merging logic", () => {
 
     // Then verify non-cloud featured models are next and in FEATURED_MODELS order
     const nonCloudFeatured = FEATURED_MODELS.filter(
-      (m) => !m.endsWith("cloud"),
+      (m) => !m.endsWith("cloud") && m !== "gemini-3-pro-preview",
     );
     for (let i = 0; i < nonCloudFeatured.length; i++) {
       const model = merged[i + cloudModels.length];
@@ -104,7 +106,9 @@ describe("Model merging logic", () => {
     const merged = mergeModels(localModels);
 
     // First verify cloud models are first and in FEATURED_MODELS order
-    const cloudModels = FEATURED_MODELS.filter((m) => m.endsWith("cloud"));
+    const cloudModels = FEATURED_MODELS.filter(
+      (m) => m.endsWith("cloud") || m === "gemini-3-pro-preview",
+    );
     for (let i = 0; i < cloudModels.length; i++) {
       expect(merged[i].model).toBe(cloudModels[i]);
       expect(merged[i].isCloud()).toBe(true);
@@ -112,7 +116,7 @@ describe("Model merging logic", () => {
 
     // Then verify non-cloud featured models are next and in FEATURED_MODELS order
     const nonCloudFeatured = FEATURED_MODELS.filter(
-      (m) => !m.endsWith("cloud"),
+      (m) => !m.endsWith("cloud") && m !== "gemini-3-pro-preview",
     );
     for (let i = 0; i < nonCloudFeatured.length; i++) {
       const model = merged[i + cloudModels.length];