From e81305222bd491907990bfa005a38d92c6ea052b Mon Sep 17 00:00:00 2001 From: Bryan Jenks Date: Sun, 10 May 2020 08:26:40 -0700 Subject: [PATCH 1/3] downloads tag doesnt function kill it --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 8323f48..95ee523 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,6 @@

- From 18c3e510f279538a8f4ac71b9eb4ac693c91befb Mon Sep 17 00:00:00 2001 From: jsnal Date: Thu, 14 May 2020 14:31:34 -0400 Subject: [PATCH 2/3] fix(setup): fix setup on macOS Fix the setup function on macOS by removing the `eval` in the `touch` statement. This fix worked for me on macOS 10.14.6, however, this hasn't been tested with other versions of macOS. I checked that the script still works in Linux as well. --- flash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flash b/flash index 9fe676c..e39854e 100755 --- a/flash +++ b/flash @@ -114,7 +114,7 @@ Programming:What is the best operating system?:Arch, because BTW i run Arch:999" # Define setup process in a function and create necessary files for user setup(){\ mkdir "$DIR" && \ - eval touch {"$EXAMPLE_DECK","$HIGH_SCORE","$REVIEW_LOG"} && \ + touch {"$EXAMPLE_DECK","$HIGH_SCORE","$REVIEW_LOG"} && \ echo "$DECK_TEMPLATE" >> "$EXAMPLE_DECK" && \ echo -e "$DIR_MADE_MSG" ;} From 73e4ea3f3e3099899a8e633f346502aae29c5f25 Mon Sep 17 00:00:00 2001 From: Bryan Jenks Date: Thu, 14 May 2020 11:43:34 -0700 Subject: [PATCH 3/3] update README after #11 resolution --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 95ee523..e793ee8 100644 --- a/README.md +++ b/README.md @@ -29,6 +29,7 @@ This script uses: - [fzf](https://github.com/junegunn/fzf) - [bat](https://github.com/sharkdp/bat) +- (if on macOS the GNU core utilities are a dependency (namely the `shuf` utility) Install these prior to running the script. @@ -40,7 +41,9 @@ Untested, not sure if this script and its dependencies will work with WSL or not ### Mac -Currently testing see [#11](https://github.com/tallguyjenks/fla.sh/issues/11) +Will need to have `brew` to install dependencies listed below and also `brew install coreutils` to get the GNU core utilities as `shuf` is not in macOS by default. + +Confirmed to work on macOS 10.14.6 more recent version welcome to test and file an issue/pull request to update README if other versions run the script as it should. ### Linux